On 11/30/2017 4:54 PM, Ferenc Wágner wrote:
"Fabio M. Di Nitto" fdinitto@redhat.com writes:
On 11/30/2017 3:26 PM, Ferenc Wágner wrote:
You made me curious. Let me try to implement it... OK, I rebased and squashed my branch somewhat. I'm pushing it as modules2, we had some very similar ideas and some different ones!
can you please rebase it on top of the latest modules branch? it´s missing / reverting the latest spec file changes.
Not easily, but I cherry-picked them, hope it helps.
Ack, not a problem. We might need to cherry pick a bit more (like the valgrind exception for BSD), but let see.
Also, I see you are #define KNET_MODULE for each module to handle the log_msg and you need to pass log_msg symbols around on each load.
I am not against that patch, but i think just passing the pointer around via knet_h is less invasive and needs less "magic" :-)
Fabio
PS I love the work on configure.ac, that´s definitely going in.