Commits August 2019

commits@lists.kronosnet.org

2 participants
109 discussions

knet-build-all-nonvoting - Build # 1201 - Failure!

by jenkins＠kronosnet.org

knet-build-all-nonvoting - Build # 1201 - Failure: Check console output at https://ci.kronosnet.org/job/knet-build-all-nonvoting/1201/ to view the results.

4 years, 8 months

pacemaker-build-all-nonvoting - Build # 826 - Failure!

by jenkins＠kronosnet.org

pacemaker-build-all-nonvoting - Build # 826 - Failure: Check console output at https://ci.kronosnet.org/job/pacemaker-build-all-nonvoting/826/ to view the results.

4 years, 8 months

pacemaker-build-all-voting - Build # 1546 - Failure!

by jenkins＠kronosnet.org

pacemaker-build-all-voting - Build # 1546 - Failure: Check console output at https://ci.kronosnet.org/job/pacemaker-build-all-voting/1546/ to view the results.

4 years, 8 months

pacemaker-build-all-voting - Build # 1530 - Failure!

by jenkins＠kronosnet.org

pacemaker-build-all-voting - Build # 1530 - Failure: Check console output at https://ci.kronosnet.org/job/pacemaker-build-all-voting/1530/ to view the results.

4 years, 8 months

libqb-build-covscan - Build # 1 - Failure!

by jenkins＠kronosnet.org

libqb-build-covscan - Build # 1 - Failure: Check console output at https://ci.kronosnet.org/job/libqb-build-covscan/1/ to view the results.

4 years, 8 months

pacemaker-build-all-voting - Build # 1523 - Failure!

by jenkins＠kronosnet.org

pacemaker-build-all-voting - Build # 1523 - Failure: Check console output at https://ci.kronosnet.org/job/pacemaker-build-all-voting/1523/ to view the results.

4 years, 8 months

qdevice-build-all-voting - Build # 80 - Failure!

by jenkins＠kronosnet.org

qdevice-build-all-voting - Build # 80 - Failure: Check console output at https://ci.kronosnet.org/job/qdevice-build-all-voting/80/ to view the results.

4 years, 8 months

[kronosnet/kronosnet] 434299: [PMTUd] add dynamic pong timeout when using crypto

by Fabio M. Di Nitto

Branch: refs/heads/coverity_scan Home: https://github.com/kronosnet/kronosnet Commit: 434299300a2f23acd96f2f287939549ab2944411 https://github.com/kronosnet/kronosnet/commit/434299300a2f23acd96f2f2879395… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-13 (Tue, 13 Aug 2019) Changed paths: M libknet/internals.h M libknet/links.c M libknet/links.h M libknet/threads_pmtud.c Log Message: ----------- [PMTUd] add dynamic pong timeout when using crypto problem originally reported by proxmox community, users observed that under pressure the MTU would flap back and forth between 2 values due to other node response timeout. implement a dynamic timeout multiplier when using crypto that should solve the problem in a more flexible fashion. When a timeout hits, those new logs will show: [knet]: [info] host: host: 1 (passive) best link: 0 (pri: 0) [knet]: [debug] pmtud: Starting PMTUD for host: 1 link: 0 [knet]: [debug] pmtud: Increasing PMTUd response timeout multiplier to (4) for host 1 link: 0 [knet]: [info] pmtud: PMTUD link change for host: 1 link: 0 from 469 to 65429 [knet]: [debug] pmtud: PMTUD completed for host: 1 link: 0 current link mtu: 65429 [knet]: [info] pmtud: Global data MTU changed to: 65429 [knet]: [debug] pmtud: Starting PMTUD for host: 1 link: 0 [knet]: [debug] pmtud: Increasing PMTUd response timeout multiplier to (8) for host 1 link: 0 [knet]: [debug] pmtud: Increasing PMTUd response timeout multiplier to (16) for host 1 link: 0 [knet]: [debug] pmtud: Increasing PMTUd response timeout multiplier to (32) for host 1 link: 0 [knet]: [debug] pmtud: Increasing PMTUd response timeout multiplier to (64) for host 1 link: 0 [knet]: [debug] pmtud: PMTUD completed for host: 1 link: 0 current link mtu: 65429 [knet]: [debug] pmtud: Starting PMTUD for host: 1 link: 0 [knet]: [debug] pmtud: Increasing PMTUd response timeout multiplier to (128) for host 1 link: 0 [knet]: [debug] pmtud: PMTUD completed for host: 1 link: 0 current link mtu: 65429 and when the latency reduces and it is safe to be more responsive again: [knet]: [debug] pmtud: Starting PMTUD for host: 1 link: 0 [knet]: [debug] pmtud: Decreasing PMTUd response timeout multiplier to (64) for host 1 link: 0 [knet]: [debug] pmtud: PMTUD completed for host: 1 link: 0 current link mtu: 65429 .... testing this patch on normal hosts is a bit challenging tho. Patch was tested by hardcoding a super low timeout here: diff --git a/libknet/threads_pmtud.c b/libknet/threads_pmtud.c index 4f0ba0f..5e2b89b 100644 --- a/libknet/threads_pmtud.c +++ b/libknet/threads_pmtud.c @@ -261,7 +271,8 @@ retry: /* * crypto, under pressure, is a royal PITA */ - pong_timeout_adj_tmp = dst_link->pong_timeout_adj * 2; + //pong_timeout_adj_tmp = dst_link->pong_timeout_adj * dst_link->pmtud_crypto_timeout_multiplier; + pong_timeout_adj_tmp = 30 * dst_link->pmtud_crypto_timeout_multiplier; } else { pong_timeout_adj_tmp = dst_link->pong_timeout_adj; } and using a long running version of api_knet_send_crypto_test with a short PMTUd setfreq (10 sec). Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>

4 years, 8 months

[kronosnet/kronosnet] 434299: [PMTUd] add dynamic pong timeout when using crypto

by Fabio M. Di Nitto

Branch: refs/heads/pmtud-fixes Home: https://github.com/kronosnet/kronosnet Commit: 434299300a2f23acd96f2f287939549ab2944411 https://github.com/kronosnet/kronosnet/commit/434299300a2f23acd96f2f2879395… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-13 (Tue, 13 Aug 2019) Changed paths: M libknet/internals.h M libknet/links.c M libknet/links.h M libknet/threads_pmtud.c Log Message: ----------- [PMTUd] add dynamic pong timeout when using crypto problem originally reported by proxmox community, users observed that under pressure the MTU would flap back and forth between 2 values due to other node response timeout. implement a dynamic timeout multiplier when using crypto that should solve the problem in a more flexible fashion. When a timeout hits, those new logs will show: [knet]: [info] host: host: 1 (passive) best link: 0 (pri: 0) [knet]: [debug] pmtud: Starting PMTUD for host: 1 link: 0 [knet]: [debug] pmtud: Increasing PMTUd response timeout multiplier to (4) for host 1 link: 0 [knet]: [info] pmtud: PMTUD link change for host: 1 link: 0 from 469 to 65429 [knet]: [debug] pmtud: PMTUD completed for host: 1 link: 0 current link mtu: 65429 [knet]: [info] pmtud: Global data MTU changed to: 65429 [knet]: [debug] pmtud: Starting PMTUD for host: 1 link: 0 [knet]: [debug] pmtud: Increasing PMTUd response timeout multiplier to (8) for host 1 link: 0 [knet]: [debug] pmtud: Increasing PMTUd response timeout multiplier to (16) for host 1 link: 0 [knet]: [debug] pmtud: Increasing PMTUd response timeout multiplier to (32) for host 1 link: 0 [knet]: [debug] pmtud: Increasing PMTUd response timeout multiplier to (64) for host 1 link: 0 [knet]: [debug] pmtud: PMTUD completed for host: 1 link: 0 current link mtu: 65429 [knet]: [debug] pmtud: Starting PMTUD for host: 1 link: 0 [knet]: [debug] pmtud: Increasing PMTUd response timeout multiplier to (128) for host 1 link: 0 [knet]: [debug] pmtud: PMTUD completed for host: 1 link: 0 current link mtu: 65429 and when the latency reduces and it is safe to be more responsive again: [knet]: [debug] pmtud: Starting PMTUD for host: 1 link: 0 [knet]: [debug] pmtud: Decreasing PMTUd response timeout multiplier to (64) for host 1 link: 0 [knet]: [debug] pmtud: PMTUD completed for host: 1 link: 0 current link mtu: 65429 .... testing this patch on normal hosts is a bit challenging tho. Patch was tested by hardcoding a super low timeout here: diff --git a/libknet/threads_pmtud.c b/libknet/threads_pmtud.c index 4f0ba0f..5e2b89b 100644 --- a/libknet/threads_pmtud.c +++ b/libknet/threads_pmtud.c @@ -261,7 +271,8 @@ retry: /* * crypto, under pressure, is a royal PITA */ - pong_timeout_adj_tmp = dst_link->pong_timeout_adj * 2; + //pong_timeout_adj_tmp = dst_link->pong_timeout_adj * dst_link->pmtud_crypto_timeout_multiplier; + pong_timeout_adj_tmp = 30 * dst_link->pmtud_crypto_timeout_multiplier; } else { pong_timeout_adj_tmp = dst_link->pong_timeout_adj; } and using a long running version of api_knet_send_crypto_test with a short PMTUd setfreq (10 sec). Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>

4 years, 8 months

[kronosnet/kronosnet]

by kronosnet CI bot

Branch: refs/heads/coverity_scan Home: https://github.com/kronosnet/kronosnet

4 years, 8 months

← Newer
1
2
3
4
5
6
7
8
9
10
11
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Commits August 2019