Commits August 2019

commits@lists.kronosnet.org

2 participants
109 discussions

sbd-build-all-voting - Build # 1 - Failure!
by jenkins＠kronosnet.org 22 Aug '19

22 Aug '19

sbd-build-all-voting - Build # 1 - Failure: Check console output at https://ci.kronosnet.org/job/sbd-build-all-voting/1/ to view the results.

1 0

pacemaker-build-all-voting - Build # 1564 - Failure!
by jenkins＠kronosnet.org 21 Aug '19

21 Aug '19

pacemaker-build-all-voting - Build # 1564 - Failure: Check console output at https://ci.kronosnet.org/job/pacemaker-build-all-voting/1564/ to view the results.

1 2

pacemaker-build-all-voting - Build # 1561 - Still Failing!
by jenkins＠kronosnet.org 21 Aug '19

21 Aug '19

pacemaker-build-all-voting - Build # 1561 - Still Failing: Check console output at https://ci.kronosnet.org/job/pacemaker-build-all-voting/1561/ to view the results.

1 1

[kronosnet/kronosnet] 4f9904: Merge pull request #232 from kronosnet/stable1-pro...
by Fabio M. Di Nitto 21 Aug '19

21 Aug '19

Branch: refs/heads/coverity_scan Home: https://github.com/kronosnet/kronosnet Commit: 4f9904c8ccb093f59cc352e7ac14fbad9027f07a https://github.com/kronosnet/kronosnet/commit/4f9904c8ccb093f59cc352e7ac14f… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M build-aux/knet_valgrind_memcheck.supp M libknet/Makefile.am M libknet/crypto.c M libknet/crypto_model.h M libknet/crypto_nss.c M libknet/crypto_openssl.c M libknet/handle.c M libknet/internals.h M libknet/libknet.h M libknet/links.c M libknet/links.h A libknet/onwire.c M libknet/onwire.h M libknet/tests/Makefile.am M libknet/tests/api-check.mk A libknet/tests/api_knet_handle_pmtud_set.c M libknet/tests/api_knet_send.c M libknet/tests/api_knet_send_compress.c M libknet/tests/api_knet_send_crypto.c M libknet/tests/api_knet_send_loopback.c M libknet/tests/api_knet_send_sync.c A libknet/tests/fun_pmtud_crypto.c M libknet/tests/test-common.c M libknet/threads_common.c M libknet/threads_common.h M libknet/threads_pmtud.c M libknet/threads_rx.c M libknet/threads_tx.c M libknet/transport_udp.c M man/Makefile.am Log Message: ----------- Merge pull request #232 from kronosnet/stable1-proposed stable1-proposed Commit: 62da86bf3434d2d14f287c8a66d5631ab354f787 https://github.com/kronosnet/kronosnet/commit/62da86bf3434d2d14f287c8a66d56… Author: yuan ren <yren(a)suse.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/compress.c M libknet/compress_bzip2.c M libknet/compress_lz4.c M libknet/compress_lz4hc.c M libknet/compress_lzma.c M libknet/compress_lzo2.c M libknet/compress_model.h M libknet/compress_zlib.c M libknet/compress_zstd.c M libknet/tests/api_knet_handle_compress.c Log Message: ----------- Default compress level use Discuss with Fabio, invalid compression level not the knet responsible for, so error logged. But if compress success but dstLen larger than srcLen, defualt compression level will be used, because the request level is not effective. Signed-off-by: yuan ren <yren(a)suse.com> Commit: 7e4103482fa81e47ee5e1d344b0f9972830a91b9 https://github.com/kronosnet/kronosnet/commit/7e4103482fa81e47ee5e1d344b0f9… Author: yuan ren <yren(a)suse.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/tests/api_knet_handle_compress.c Log Message: ----------- [compress]Default compression level use 1. add test casees for a module without default.Using default compression level. 2. Discuss with Fabio, invalid compression level not the knet responsible for, so error logged. But if compress success but dstLen larger than srcLen, defualt compression level will be used, because the request level is not effective. Signed-off-by: yuan ren <yren(a)suse.com> Commit: a3beb3c4f299af1f5c64f30195e41367c48d47db https://github.com/kronosnet/kronosnet/commit/a3beb3c4f299af1f5c64f30195e41… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/compress.c Log Message: ----------- [compress] fix a few minor space vs tab and code formatting Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 9952335aa1e8f108e11ecd3b01375788baf9eeb7 https://github.com/kronosnet/kronosnet/commit/9952335aa1e8f108e11ecd3b01375… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/tests/api_knet_handle_compress.c Log Message: ----------- [compress] fix #if def around BZIP2 testing Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: e773c94251302ac8f0c41dff2baec6a7d486ce13 https://github.com/kronosnet/kronosnet/commit/e773c94251302ac8f0c41dff2baec… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: A .travis.yml Log Message: ----------- [coverity] add .travis.yml to integrate CI with coverity scan Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 021e57d335b2061ff5f291d514109a7d344f0cf8 https://github.com/kronosnet/kronosnet/commit/021e57d335b2061ff5f291d514109… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/transport_sctp.c Log Message: ----------- [sctp] fix deference after null check Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 95c6335c9b92c15c6b83b158d54aa644f6ccbd5b https://github.com/kronosnet/kronosnet/commit/95c6335c9b92c15c6b83b158d54aa… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/transport_sctp.c Log Message: ----------- [sctp] free access list only if the socket is valid Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 054d97343ec7f10eeceab2863a9aaebe8e2ee5d0 https://github.com/kronosnet/kronosnet/commit/054d97343ec7f10eeceab2863a9aa… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/internals.h Log Message: ----------- [rx] align data types Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: cc630fee36f94998708c5cd42fd9311969b7567a https://github.com/kronosnet/kronosnet/commit/cc630fee36f94998708c5cd42fd93… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/handle.c Log Message: ----------- [handle] make sure that the pmtud buf contains at least knet header size Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 5dd7bbf83abb604928d9162cfd938d9afa8e52b6 https://github.com/kronosnet/kronosnet/commit/5dd7bbf83abb604928d9162cfd938… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/transport_sctp.c Log Message: ----------- [sctp] revalidate fd to make coverity scan happy Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: e6a050020602ac9e72d3b473451335f58c3ae549 https://github.com/kronosnet/kronosnet/commit/e6a050020602ac9e72d3b47345133… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/tests/knet_bench.c Log Message: ----------- [tests] fix knet_bench coverity errors Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 47e8638403bf5e73e8f4b8508c27a09031d0a1c1 https://github.com/kronosnet/kronosnet/commit/47e8638403bf5e73e8f4b8508c27a… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/common.c Log Message: ----------- [common] fix dlopen error handling Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: b67fbfdd4b29584a48130d50ffdae4f3bfba88ad https://github.com/kronosnet/kronosnet/commit/b67fbfdd4b29584a48130d50ffdae… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/threads_rx.c Log Message: ----------- [rx] better error report if we can't resolve hostname / port Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: c3af67df2a18309fef9b543ab6e20a8d091c01a9 https://github.com/kronosnet/kronosnet/commit/c3af67df2a18309fef9b543ab6e20… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/links_acl_ip.c Log Message: ----------- [acl] avoid forward null deferencing Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 5f7591ca6c8e9e3fa56a7d3dc07bfee00ecbe5f8 https://github.com/kronosnet/kronosnet/commit/5f7591ca6c8e9e3fa56a7d3dc07bf… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/transport_sctp.c Log Message: ----------- [sctp] cleanup bugs detected in error paths by coverity scan Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 6d06efc6cd0daeb9a39edd1144794c1609bee396 https://github.com/kronosnet/kronosnet/commit/6d06efc6cd0daeb9a39edd1144794… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libnozzle/libnozzle.c Log Message: ----------- [nozzle] fix negative return detected by coverity scan Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 7ab467bfaed7169ad46cf006280186a7c281d9d8 https://github.com/kronosnet/kronosnet/commit/7ab467bfaed7169ad46cf00628018… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libnozzle/libnozzle.c Log Message: ----------- [nozzle] don't leak memory on error Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 56f167b90ee2bf78653f2476ef52b53234a9ee82 https://github.com/kronosnet/kronosnet/commit/56f167b90ee2bf78653f2476ef52b… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/compress_zstd.c Log Message: ----------- [compress] don't leak memory in case of errors during zstd init Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 77e32532552e80181fe7c9fc58fa9fbe322c5662 https://github.com/kronosnet/kronosnet/commit/77e32532552e80181fe7c9fc58fa9… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/logging.c Log Message: ----------- [logging] make sure not to overrun buffers by pre-allocating them Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 10c992e885fbfd0368dde130b9e532a77d2cac16 https://github.com/kronosnet/kronosnet/commit/10c992e885fbfd0368dde130b9e53… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/compress.c Log Message: ----------- [compress] do not overrun allocated array for compress modules Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: b784ea4cb20d98b60aa5d0742376f0435c6770fd https://github.com/kronosnet/kronosnet/commit/b784ea4cb20d98b60aa5d0742376f… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M .gitignore M Makefile.am M build-aux/check.mk M configure.ac Log Message: ----------- [coverity] add test targets to run coverity automatically Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 3d0f0068f03c5ec5581dc0725c9076e27ce00716 https://github.com/kronosnet/kronosnet/commit/3d0f0068f03c5ec5581dc0725c907… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/threads_pmtud.c Log Message: ----------- [PMTUd] do not double unlock global read lock Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: d20212a47111e80b0c16c1f7866e9e5047a8dd70 https://github.com/kronosnet/kronosnet/commit/d20212a47111e80b0c16c1f7866e9… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libnozzle/internals.h M libnozzle/libnozzle.c Log Message: ----------- [nozzle] avoid tons of possible buffer overruns Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: c9ffbd7b872ba316bf2e9f82d71d049b547b3f96 https://github.com/kronosnet/kronosnet/commit/c9ffbd7b872ba316bf2e9f82d71d0… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/tests/test-common.c Log Message: ----------- [test] simplify flush log allocate on stack only once and make sure strings are null terminated drop useless read loop since log msg are always smaller than PAGE_SIZE and read are atomic at that level Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 329f20e40c47df4a645f69496d5b6bc14eac03a4 https://github.com/kronosnet/kronosnet/commit/329f20e40c47df4a645f69496d5b6… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/common.c Log Message: ----------- [common] make sure string is null terminated Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: a340c08e9059cf2afda3ad74ab524dc1857717d7 https://github.com/kronosnet/kronosnet/commit/a340c08e9059cf2afda3ad74ab524… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/threads_tx.c Log Message: ----------- [tx] drop unnecessary usleep when sending to localhost Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 9d230289cc646d45429e550b78116939ff670628 https://github.com/kronosnet/kronosnet/commit/9d230289cc646d45429e550b78116… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libnozzle/tests/api_nozzle_get_name_by_handle.c M libnozzle/tests/api_nozzle_set_mac.c Log Message: ----------- [nozzle] fix a few coverity errors in the test suite Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: c8e2e6af4fb458afdaa8848295045fbabcc07bc0 https://github.com/kronosnet/kronosnet/commit/c8e2e6af4fb458afdaa8848295045… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/internals.h M libknet/threads_tx.c Log Message: ----------- [tx] clean up channel management code for internal communications the code is still not in use but it's more clear and doesn't trigger memory overrun Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: c3ec183e0541d2eb50322ff783c76654b4f70098 https://github.com/kronosnet/kronosnet/commit/c3ec183e0541d2eb50322ff783c76… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/transport_sctp.c Log Message: ----------- [sctp] retry locking in case of failure Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Compare: https://github.com/kronosnet/kronosnet/compare/f6b11c05112c...c3ec183e0541

1 0

knet-build-all-voting - Build # 1401 - Failure!
by jenkins＠kronosnet.org 21 Aug '19

21 Aug '19

knet-build-all-voting - Build # 1401 - Failure: Check console output at https://ci.kronosnet.org/job/knet-build-all-voting/1401/ to view the results.

1 0

[kronosnet/kronosnet] 62da86: Default compress level use
by Fabio M. Di Nitto 21 Aug '19

21 Aug '19

Branch: refs/heads/stable1-proposed Home: https://github.com/kronosnet/kronosnet Commit: 62da86bf3434d2d14f287c8a66d5631ab354f787 https://github.com/kronosnet/kronosnet/commit/62da86bf3434d2d14f287c8a66d56… Author: yuan ren <yren(a)suse.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/compress.c M libknet/compress_bzip2.c M libknet/compress_lz4.c M libknet/compress_lz4hc.c M libknet/compress_lzma.c M libknet/compress_lzo2.c M libknet/compress_model.h M libknet/compress_zlib.c M libknet/compress_zstd.c M libknet/tests/api_knet_handle_compress.c Log Message: ----------- Default compress level use Discuss with Fabio, invalid compression level not the knet responsible for, so error logged. But if compress success but dstLen larger than srcLen, defualt compression level will be used, because the request level is not effective. Signed-off-by: yuan ren <yren(a)suse.com> Commit: 7e4103482fa81e47ee5e1d344b0f9972830a91b9 https://github.com/kronosnet/kronosnet/commit/7e4103482fa81e47ee5e1d344b0f9… Author: yuan ren <yren(a)suse.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/tests/api_knet_handle_compress.c Log Message: ----------- [compress]Default compression level use 1. add test casees for a module without default.Using default compression level. 2. Discuss with Fabio, invalid compression level not the knet responsible for, so error logged. But if compress success but dstLen larger than srcLen, defualt compression level will be used, because the request level is not effective. Signed-off-by: yuan ren <yren(a)suse.com> Commit: a3beb3c4f299af1f5c64f30195e41367c48d47db https://github.com/kronosnet/kronosnet/commit/a3beb3c4f299af1f5c64f30195e41… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/compress.c Log Message: ----------- [compress] fix a few minor space vs tab and code formatting Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 9952335aa1e8f108e11ecd3b01375788baf9eeb7 https://github.com/kronosnet/kronosnet/commit/9952335aa1e8f108e11ecd3b01375… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/tests/api_knet_handle_compress.c Log Message: ----------- [compress] fix #if def around BZIP2 testing Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: e773c94251302ac8f0c41dff2baec6a7d486ce13 https://github.com/kronosnet/kronosnet/commit/e773c94251302ac8f0c41dff2baec… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: A .travis.yml Log Message: ----------- [coverity] add .travis.yml to integrate CI with coverity scan Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 021e57d335b2061ff5f291d514109a7d344f0cf8 https://github.com/kronosnet/kronosnet/commit/021e57d335b2061ff5f291d514109… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/transport_sctp.c Log Message: ----------- [sctp] fix deference after null check Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 95c6335c9b92c15c6b83b158d54aa644f6ccbd5b https://github.com/kronosnet/kronosnet/commit/95c6335c9b92c15c6b83b158d54aa… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/transport_sctp.c Log Message: ----------- [sctp] free access list only if the socket is valid Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 054d97343ec7f10eeceab2863a9aaebe8e2ee5d0 https://github.com/kronosnet/kronosnet/commit/054d97343ec7f10eeceab2863a9aa… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/internals.h Log Message: ----------- [rx] align data types Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: cc630fee36f94998708c5cd42fd9311969b7567a https://github.com/kronosnet/kronosnet/commit/cc630fee36f94998708c5cd42fd93… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/handle.c Log Message: ----------- [handle] make sure that the pmtud buf contains at least knet header size Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 5dd7bbf83abb604928d9162cfd938d9afa8e52b6 https://github.com/kronosnet/kronosnet/commit/5dd7bbf83abb604928d9162cfd938… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/transport_sctp.c Log Message: ----------- [sctp] revalidate fd to make coverity scan happy Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: e6a050020602ac9e72d3b473451335f58c3ae549 https://github.com/kronosnet/kronosnet/commit/e6a050020602ac9e72d3b47345133… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/tests/knet_bench.c Log Message: ----------- [tests] fix knet_bench coverity errors Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 47e8638403bf5e73e8f4b8508c27a09031d0a1c1 https://github.com/kronosnet/kronosnet/commit/47e8638403bf5e73e8f4b8508c27a… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/common.c Log Message: ----------- [common] fix dlopen error handling Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: b67fbfdd4b29584a48130d50ffdae4f3bfba88ad https://github.com/kronosnet/kronosnet/commit/b67fbfdd4b29584a48130d50ffdae… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/threads_rx.c Log Message: ----------- [rx] better error report if we can't resolve hostname / port Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: c3af67df2a18309fef9b543ab6e20a8d091c01a9 https://github.com/kronosnet/kronosnet/commit/c3af67df2a18309fef9b543ab6e20… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/links_acl_ip.c Log Message: ----------- [acl] avoid forward null deferencing Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 5f7591ca6c8e9e3fa56a7d3dc07bfee00ecbe5f8 https://github.com/kronosnet/kronosnet/commit/5f7591ca6c8e9e3fa56a7d3dc07bf… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/transport_sctp.c Log Message: ----------- [sctp] cleanup bugs detected in error paths by coverity scan Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 6d06efc6cd0daeb9a39edd1144794c1609bee396 https://github.com/kronosnet/kronosnet/commit/6d06efc6cd0daeb9a39edd1144794… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libnozzle/libnozzle.c Log Message: ----------- [nozzle] fix negative return detected by coverity scan Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 7ab467bfaed7169ad46cf006280186a7c281d9d8 https://github.com/kronosnet/kronosnet/commit/7ab467bfaed7169ad46cf00628018… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libnozzle/libnozzle.c Log Message: ----------- [nozzle] don't leak memory on error Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 56f167b90ee2bf78653f2476ef52b53234a9ee82 https://github.com/kronosnet/kronosnet/commit/56f167b90ee2bf78653f2476ef52b… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/compress_zstd.c Log Message: ----------- [compress] don't leak memory in case of errors during zstd init Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 77e32532552e80181fe7c9fc58fa9fbe322c5662 https://github.com/kronosnet/kronosnet/commit/77e32532552e80181fe7c9fc58fa9… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/logging.c Log Message: ----------- [logging] make sure not to overrun buffers by pre-allocating them Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 10c992e885fbfd0368dde130b9e532a77d2cac16 https://github.com/kronosnet/kronosnet/commit/10c992e885fbfd0368dde130b9e53… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/compress.c Log Message: ----------- [compress] do not overrun allocated array for compress modules Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: b784ea4cb20d98b60aa5d0742376f0435c6770fd https://github.com/kronosnet/kronosnet/commit/b784ea4cb20d98b60aa5d0742376f… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M .gitignore M Makefile.am M build-aux/check.mk M configure.ac Log Message: ----------- [coverity] add test targets to run coverity automatically Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 3d0f0068f03c5ec5581dc0725c9076e27ce00716 https://github.com/kronosnet/kronosnet/commit/3d0f0068f03c5ec5581dc0725c907… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/threads_pmtud.c Log Message: ----------- [PMTUd] do not double unlock global read lock Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: d20212a47111e80b0c16c1f7866e9e5047a8dd70 https://github.com/kronosnet/kronosnet/commit/d20212a47111e80b0c16c1f7866e9… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libnozzle/internals.h M libnozzle/libnozzle.c Log Message: ----------- [nozzle] avoid tons of possible buffer overruns Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: c9ffbd7b872ba316bf2e9f82d71d049b547b3f96 https://github.com/kronosnet/kronosnet/commit/c9ffbd7b872ba316bf2e9f82d71d0… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/tests/test-common.c Log Message: ----------- [test] simplify flush log allocate on stack only once and make sure strings are null terminated drop useless read loop since log msg are always smaller than PAGE_SIZE and read are atomic at that level Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 329f20e40c47df4a645f69496d5b6bc14eac03a4 https://github.com/kronosnet/kronosnet/commit/329f20e40c47df4a645f69496d5b6… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/common.c Log Message: ----------- [common] make sure string is null terminated Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: a340c08e9059cf2afda3ad74ab524dc1857717d7 https://github.com/kronosnet/kronosnet/commit/a340c08e9059cf2afda3ad74ab524… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/threads_tx.c Log Message: ----------- [tx] drop unnecessary usleep when sending to localhost Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 9d230289cc646d45429e550b78116939ff670628 https://github.com/kronosnet/kronosnet/commit/9d230289cc646d45429e550b78116… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libnozzle/tests/api_nozzle_get_name_by_handle.c M libnozzle/tests/api_nozzle_set_mac.c Log Message: ----------- [nozzle] fix a few coverity errors in the test suite Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: c8e2e6af4fb458afdaa8848295045fbabcc07bc0 https://github.com/kronosnet/kronosnet/commit/c8e2e6af4fb458afdaa8848295045… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/internals.h M libknet/threads_tx.c Log Message: ----------- [tx] clean up channel management code for internal communications the code is still not in use but it's more clear and doesn't trigger memory overrun Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: c3ec183e0541d2eb50322ff783c76654b4f70098 https://github.com/kronosnet/kronosnet/commit/c3ec183e0541d2eb50322ff783c76… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/transport_sctp.c Log Message: ----------- [sctp] retry locking in case of failure Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Compare: https://github.com/kronosnet/kronosnet/compare/4f9904c8ccb0...c3ec183e0541

1 0

[kronosnet/kronosnet]
by Fabio M. Di Nitto 21 Aug '19

21 Aug '19

Branch: refs/tags/v1.11 Home: https://github.com/kronosnet/kronosnet

1 0

[kronosnet/kronosnet] 4f9904: Merge pull request #232 from kronosnet/stable1-pro...
by Fabio M. Di Nitto 21 Aug '19

21 Aug '19

Branch: refs/heads/stable1-proposed Home: https://github.com/kronosnet/kronosnet Commit: 4f9904c8ccb093f59cc352e7ac14fbad9027f07a https://github.com/kronosnet/kronosnet/commit/4f9904c8ccb093f59cc352e7ac14f… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M build-aux/knet_valgrind_memcheck.supp M libknet/Makefile.am M libknet/crypto.c M libknet/crypto_model.h M libknet/crypto_nss.c M libknet/crypto_openssl.c M libknet/handle.c M libknet/internals.h M libknet/libknet.h M libknet/links.c M libknet/links.h A libknet/onwire.c M libknet/onwire.h M libknet/tests/Makefile.am M libknet/tests/api-check.mk A libknet/tests/api_knet_handle_pmtud_set.c M libknet/tests/api_knet_send.c M libknet/tests/api_knet_send_compress.c M libknet/tests/api_knet_send_crypto.c M libknet/tests/api_knet_send_loopback.c M libknet/tests/api_knet_send_sync.c A libknet/tests/fun_pmtud_crypto.c M libknet/tests/test-common.c M libknet/threads_common.c M libknet/threads_common.h M libknet/threads_pmtud.c M libknet/threads_rx.c M libknet/threads_tx.c M libknet/transport_udp.c M man/Makefile.am Log Message: ----------- Merge pull request #232 from kronosnet/stable1-proposed stable1-proposed

1 0

[kronosnet/kronosnet] 124b1a: [tests] ignore libnss errors from OpenSuse 15
by Fabio M. Di Nitto 21 Aug '19

21 Aug '19

Branch: refs/heads/stable1 Home: https://github.com/kronosnet/kronosnet Commit: 124b1a76032b791775ac069afb7f553e9c61bc00 https://github.com/kronosnet/kronosnet/commit/124b1a76032b791775ac069afb7f5… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M build-aux/knet_valgrind_memcheck.supp Log Message: ----------- [tests] ignore libnss errors from OpenSuse 15 Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 711618053fdce2c137e9af702b2d692a21b9550b https://github.com/kronosnet/kronosnet/commit/711618053fdce2c137e9af702b2d6… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M build-aux/knet_valgrind_memcheck.supp Log Message: ----------- [tests] ignore libnss errors from OpenSuse Tumbleweed Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 4372e499ecd4c7506be5ccb75dc857872f900785 https://github.com/kronosnet/kronosnet/commit/4372e499ecd4c7506be5ccb75dc85… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/handle.c M libknet/internals.h M libknet/tests/api_knet_send.c M libknet/tests/api_knet_send_compress.c M libknet/tests/api_knet_send_crypto.c M libknet/tests/api_knet_send_loopback.c M libknet/tests/api_knet_send_sync.c M libknet/tests/test-common.c M libknet/threads_common.c M libknet/threads_common.h M libknet/threads_rx.c M libknet/threads_tx.c Log Message: ----------- [threads] allow knet_handle_setfwd to flush socket queues Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 731da3eee45a7f50d2ffff78299092a5131f8208 https://github.com/kronosnet/kronosnet/commit/731da3eee45a7f50d2ffff7829909… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/crypto.c Log Message: ----------- [crypto] fix log information Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 2e433d34e228c5e49cca6782f840ee91a4968bc5 https://github.com/kronosnet/kronosnet/commit/2e433d34e228c5e49cca6782f840e… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/transport_udp.c Log Message: ----------- [udp] log information about detected kernel MTU Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: b7d0f70c9f8008b59a2c3592714ae08efca04303 https://github.com/kronosnet/kronosnet/commit/b7d0f70c9f8008b59a2c3592714ae… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/threads_pmtud.c Log Message: ----------- [docs] add knet packet layout Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 496748b133b6c4e89fb5201d5bcb1ac62f2701ee https://github.com/kronosnet/kronosnet/commit/496748b133b6c4e89fb5201d5bcb1… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/threads_pmtud.c Log Message: ----------- [PMTUd] fix MTU calculation when using crypto and add docs Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 4aa4db652495b1778a3b23203c1dabad31f8e134 https://github.com/kronosnet/kronosnet/commit/4aa4db652495b1778a3b23203c1da… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/Makefile.am M libknet/crypto.c M libknet/crypto_model.h M libknet/crypto_nss.c M libknet/crypto_openssl.c M libknet/internals.h M libknet/links.c A libknet/onwire.c M libknet/onwire.h M libknet/tests/Makefile.am M libknet/tests/api_knet_send_crypto.c A libknet/tests/fun_pmtud_crypto.c M libknet/threads_common.c M libknet/threads_pmtud.c Log Message: ----------- [PMTUd] rework the whole math to calculate MTU internal changes: - drop the concept of sec_header_size that was completely wrong and unnecessary - bump crypto API to version 3 due to the above change - clarify the difference between link->proto_overhead and link->status->proto_overhead. We cannot rename the status one as it would also change ABI. - add onwire.c with documentation on the packet format and what various len(s) mean in context. - add 3 new functions to calculate MTUs back and forth and use them around, hopefully with enough clarification on why things are done in a given way. - heavily change thread_pmtud.c to use those new facilities. - fix major calculation issues when using crypto (non-crypto was not affected by the problem). - fix checks around to make sure they match the new math. - fix padding calculation. - add functional PMTUd crypto test this test can take several hours (12+) and should be executed on a controlled environment since it automatically changes loopback MTU to run tests. - fix way the lowest MTU is calculated during a PMTUd run to avoid spurious double notifications. - drop redundant checks. user visible changes: - Global MTU is now calculated properly when using crypto and values will be in general bigger than before due to incorrect padding calculation in the previous implementation. Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: dce34780e8ce259ca29bb26cceac896d16f32747 https://github.com/kronosnet/kronosnet/commit/dce34780e8ce259ca29bb26cceac8… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/internals.h M libknet/links.c M libknet/links.h M libknet/threads_pmtud.c Log Message: ----------- [PMTUd] add dynamic pong timeout when using crypto problem originally reported by proxmox community, users observed that under pressure the MTU would flap back and forth between 2 values due to other node response timeout. implement a dynamic timeout multiplier when using crypto that should solve the problem in a more flexible fashion. When a timeout hits, those new logs will show: [knet]: [info] host: host: 1 (passive) best link: 0 (pri: 0) [knet]: [debug] pmtud: Starting PMTUD for host: 1 link: 0 [knet]: [debug] pmtud: Increasing PMTUd response timeout multiplier to (4) for host 1 link: 0 [knet]: [info] pmtud: PMTUD link change for host: 1 link: 0 from 469 to 65429 [knet]: [debug] pmtud: PMTUD completed for host: 1 link: 0 current link mtu: 65429 [knet]: [info] pmtud: Global data MTU changed to: 65429 [knet]: [debug] pmtud: Starting PMTUD for host: 1 link: 0 [knet]: [debug] pmtud: Increasing PMTUd response timeout multiplier to (8) for host 1 link: 0 [knet]: [debug] pmtud: Increasing PMTUd response timeout multiplier to (16) for host 1 link: 0 [knet]: [debug] pmtud: Increasing PMTUd response timeout multiplier to (32) for host 1 link: 0 [knet]: [debug] pmtud: Increasing PMTUd response timeout multiplier to (64) for host 1 link: 0 [knet]: [debug] pmtud: PMTUD completed for host: 1 link: 0 current link mtu: 65429 [knet]: [debug] pmtud: Starting PMTUD for host: 1 link: 0 [knet]: [debug] pmtud: Increasing PMTUd response timeout multiplier to (128) for host 1 link: 0 [knet]: [debug] pmtud: PMTUD completed for host: 1 link: 0 current link mtu: 65429 and when the latency reduces and it is safe to be more responsive again: [knet]: [debug] pmtud: Starting PMTUD for host: 1 link: 0 [knet]: [debug] pmtud: Decreasing PMTUd response timeout multiplier to (64) for host 1 link: 0 [knet]: [debug] pmtud: PMTUD completed for host: 1 link: 0 current link mtu: 65429 .... testing this patch on normal hosts is a bit challenging tho. Patch was tested by hardcoding a super low timeout here: diff --git a/libknet/threads_pmtud.c b/libknet/threads_pmtud.c index 4f0ba0f..5e2b89b 100644 --- a/libknet/threads_pmtud.c +++ b/libknet/threads_pmtud.c @@ -261,7 +271,8 @@ retry: /* * crypto, under pressure, is a royal PITA */ - pong_timeout_adj_tmp = dst_link->pong_timeout_adj * 2; + //pong_timeout_adj_tmp = dst_link->pong_timeout_adj * dst_link->pmtud_crypto_timeout_multiplier; + pong_timeout_adj_tmp = 30 * dst_link->pmtud_crypto_timeout_multiplier; } else { pong_timeout_adj_tmp = dst_link->pong_timeout_adj; } and using a long running version of api_knet_send_crypto_test with a short PMTUd setfreq (10 sec). Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: c1b46b0a365fbcd3c6c594bb8fd31fbb487774fe https://github.com/kronosnet/kronosnet/commit/c1b46b0a365fbcd3c6c594bb8fd31… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/handle.c M libknet/internals.h M libknet/libknet.h M libknet/tests/api-check.mk A libknet/tests/api_knet_handle_pmtud_set.c M libknet/threads_pmtud.c M man/Makefile.am Log Message: ----------- [PMTUd] add ability to manually override MTU and disable PMTUd Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: f6b11c05112c520ccda3b28e7676acbc6b8a7938 https://github.com/kronosnet/kronosnet/commit/f6b11c05112c520ccda3b28e7676a… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M libknet/Makefile.am Log Message: ----------- [build] bump soname to indicate new API call Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 4f9904c8ccb093f59cc352e7ac14fbad9027f07a https://github.com/kronosnet/kronosnet/commit/4f9904c8ccb093f59cc352e7ac14f… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M build-aux/knet_valgrind_memcheck.supp M libknet/Makefile.am M libknet/crypto.c M libknet/crypto_model.h M libknet/crypto_nss.c M libknet/crypto_openssl.c M libknet/handle.c M libknet/internals.h M libknet/libknet.h M libknet/links.c M libknet/links.h A libknet/onwire.c M libknet/onwire.h M libknet/tests/Makefile.am M libknet/tests/api-check.mk A libknet/tests/api_knet_handle_pmtud_set.c M libknet/tests/api_knet_send.c M libknet/tests/api_knet_send_compress.c M libknet/tests/api_knet_send_crypto.c M libknet/tests/api_knet_send_loopback.c M libknet/tests/api_knet_send_sync.c A libknet/tests/fun_pmtud_crypto.c M libknet/tests/test-common.c M libknet/threads_common.c M libknet/threads_common.h M libknet/threads_pmtud.c M libknet/threads_rx.c M libknet/threads_tx.c M libknet/transport_udp.c M man/Makefile.am Log Message: ----------- Merge pull request #232 from kronosnet/stable1-proposed stable1-proposed Compare: https://github.com/kronosnet/kronosnet/compare/fce69571d656...4f9904c8ccb0

1 0

[kronosnet/kronosnet]
by kronosnet CI bot 21 Aug '19

21 Aug '19

Branch: refs/heads/coverity_scan Home: https://github.com/kronosnet/kronosnet

1 0

← Newer
1
2
3
4
5
6
7
...
11
Older →

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Commits August 2019