Branch: refs/heads/covfix Home: https://github.com/kronosnet/kronosnet Commit: ecdbebef14589579effc5d3206a8f2e0b0dfd50d https://github.com/kronosnet/kronosnet/commit/ecdbebef14589579effc5d3206a8f2... Author: Fabio M. Di Nitto fdinitto@redhat.com Date: 2026-04-21 (Tue, 21 Apr 2026)
Changed paths: M libknet/logging.c M libknet/threads_tx.c
Log Message: ----------- Suppress Coverity false positives for MISSING_LOCK and UNINIT
Fixed two Coverity false positive warnings:
1. MISSING_LOCK in threads_tx.c (_dispatch_to_local): - Access to knet_h->sockfd[channel].is_created flagged as unguarded - Lock is actually held by caller (_handle_send_to_links_thread) - Added local variable to read value once with suppression annotation
2. UNINIT in logging.c (log_msg): - va_list 'ap' flagged as uninitialized before va_start - va_start IS the initialization, but Coverity doesn't understand this - Restructured early returns and added suppression annotation
Both issues are false positives. The code is correct, but Coverity's dataflow analysis cannot detect the lock acquisition in the call chain or understand va_start semantics.
Coverity scan now reports 0 defects (down from 2).
Signed-off-by: Fabio M. Di Nitto fdinitto@redhat.com Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com
To unsubscribe from these emails, change your notification settings at https://github.com/kronosnet/kronosnet/settings/notifications