[kronosnet/kronosnet] b6f745: Merge pull request #240 from kronosnet/cov-scan - Commits

1 Aug 2019

  Branch: refs/heads/coverity_scan
  Home:   https://github.com/kronosnet/kronosnet
  Commit: b6f7454a98c9376b85d46dd44a2ea1f5dd663d67

https://github.com/kronosnet/kronosnet/commit/b6f7454a98c9376b85d46dd44a2ea…
  Author: Fabio M. Di Nitto &lt;fdinitto(a)redhat.com&gt;
  Date:   2019-07-26 (Fri, 26 Jul 2019)

  Changed paths:
    M .gitignore
    M Makefile.am
    M build-aux/check.mk
    M configure.ac
    M libknet/common.c
    M libknet/compress.c
    M libknet/compress_zstd.c
    M libknet/handle.c
    M libknet/internals.h
    M libknet/links_acl_ip.c
    M libknet/logging.c
    M libknet/tests/knet_bench.c
    M libknet/tests/test-common.c
    M libknet/threads_pmtud.c
    M libknet/threads_rx.c
    M libknet/threads_tx.c
    M libknet/transport_sctp.c
    M libnozzle/internals.h
    M libnozzle/libnozzle.c
    M libnozzle/tests/api_nozzle_get_name_by_handle.c
    M libnozzle/tests/api_nozzle_set_mac.c

  Log Message:
  -----------
  Merge pull request #240 from kronosnet/cov-scan

coverity scan fixes

  Commit: b54f80dcf14fc962fdf304d41be0b1001de716e7

https://github.com/kronosnet/kronosnet/commit/b54f80dcf14fc962fdf304d41be0b…
  Author: Fabio M. Di Nitto &lt;fdinitto(a)redhat.com&gt;
  Date:   2019-07-30 (Tue, 30 Jul 2019)

  Changed paths:
    M libknet/crypto.c

  Log Message:
  -----------
  [crypto] fix log information

Signed-off-by: Fabio M. Di Nitto &lt;fdinitto(a)redhat.com&gt;

  Commit: 84aed4bba304f40feb32a5c09885350756ab2d1d

https://github.com/kronosnet/kronosnet/commit/84aed4bba304f40feb32a5c098853…
  Author: Fabio M. Di Nitto &lt;fdinitto(a)redhat.com&gt;
  Date:   2019-07-31 (Wed, 31 Jul 2019)

  Changed paths:
    M libknet/transport_udp.c

  Log Message:
  -----------
  [udp] log information about detected kernel MTU

Signed-off-by: Fabio M. Di Nitto &lt;fdinitto(a)redhat.com&gt;

  Commit: 30b789d2d2b9985e2044b2a7caefb513e76c1027

https://github.com/kronosnet/kronosnet/commit/30b789d2d2b9985e2044b2a7caefb…
  Author: Fabio M. Di Nitto &lt;fdinitto(a)redhat.com&gt;
  Date:   2019-07-31 (Wed, 31 Jul 2019)

  Changed paths:
    M libknet/tests/api_knet_send_crypto.c
    M libknet/threads_pmtud.c

  Log Message:
  -----------
  [pmtud] break on loop when using crypto

under certain circumstances, when crypto is enabled, pMTUD will
continue sending a packet of the same size over and over just
at the MTU boundary.

In case we are sending the same packet twice (due to crypto alignment
and such), it means we cannot make any more progress and we need to take
that size as ultimate MTU.

Fixes: https://github.com/kronosnet/kronosnet/issues/241

Also change default test parameters to easily trigger the issue in case
of regression. Tested using ifconfig lo mtu 65520.

Signed-off-by: Fabio M. Di Nitto &lt;fdinitto(a)redhat.com&gt;

Compare: https://github.com/kronosnet/kronosnet/compare/90dcd0970e7c...30b789d2d2b9