Branch: refs/heads/stable1 Home: https://github.com/kronosnet/kronosnet Commit: 5dbd770cf3cdf6b7e5739112c743273d7b2d4c9e https://github.com/kronosnet/kronosnet/commit/5dbd770cf3cdf6b7e5739112c74327... Author: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: 2025-06-16 (Mon, 16 Jun 2025)
Changed paths: A STYLE_GUIDE.md
Log Message: ----------- Create and refine STYLE_GUIDE.md for project contributions
This commit introduces STYLE_GUIDE.md, a comprehensive document outlining coding standards and best practices for the Kronosnet project. This guide aims to ensure consistency and clarity in contributions.
The following key areas are covered:
1. **C Language Style**: * Minimum Dialect: C99. * Indentation: Tabs (not spaces). * Curly Braces: * Control flow (if, for, while): Opening brace on the same line. * Function definitions: Opening brace on the next line. * Always use braces, even for single-line blocks. * Variable Declaration: At the beginning of their scope. * Line Length: Preferred maximum of 120 characters, flexible for readability (e.g., nested structs).
2. **Naming Conventions**: * General: `snake_case` for internal variables and function names. * Public API Elements: * `knet_` or `nozzle_` prefix for functions, structs, typedefs (e.g., `knet_get_host_list`, `nozzle_device_config`). * `KNET_` or `NOZZLE_` prefix for enums and defines (macros), followed by uppercase `SNAKE_CASE` (e.g., `KNET_MAX_CLIENTS`, `NOZZLE_BUFFER_SIZE_DEFAULT`). * Internal Elements: * Names should be descriptive, indicating purpose and subsystem. * Functions shared across multiple threads: Prefix with `_` (e.g., `_shared_data_access`).
3. **Comments**: * `//` for single-line, `/* ... */` for multi-line. * Emphasizes clear and concise comments for non-obvious code.
4. **Best Practices**: * API Changes Require Tests: Any internal or external API modification must be accompanied by corresponding tests in the test suite.
5. **Copyright**: * A copyright notice specific to `STYLE_GUIDE.md` (Year 2025, Author: Jules <AI Agent>) has been included and formatted as plain Markdown text.
This initial version of the style guide addresses issue #22 and incorporates iterative feedback on formatting, content, and specificity. A trivial change (extra newline at EOF) was included in this commit to facilitate this comprehensive message.
Signed-off-by: Fabio M. Di Nitto fdinitto@redhat.com
Commit: e8fbc6077c61587f65161a5bbd46ea76f3dd351d https://github.com/kronosnet/kronosnet/commit/e8fbc6077c61587f65161a5bbd46ea... Author: Christine Caulfield ccaulfie@redhat.com Date: 2025-06-23 (Mon, 23 Jun 2025)
Changed paths: M libnozzle/libnozzle.c
Log Message: ----------- nozzle: Fix potential thread race in nozzle_close()
Commit: 0864900eb2581fe9a2b6878a44d2251004db9802 https://github.com/kronosnet/kronosnet/commit/0864900eb2581fe9a2b6878a44d225... Author: Fabio M. Di Nitto fdinitto@redhat.com Date: 2025-08-12 (Tue, 12 Aug 2025)
Changed paths: M libknet/threads_rx.c
Log Message: ----------- Fix wrong pointer in _handle_recv_from_links_thread()
Resolves: https://github.com/kronosnet/kronosnet/issues/449
Signed-off-by: Fabio M. Di Nitto fdinitto@redhat.com
Commit: fb2f2ac3c6363735366e6b8d77a99004acdd218d https://github.com/kronosnet/kronosnet/commit/fb2f2ac3c6363735366e6b8d77a990... Author: Dmitry Belyavskiy beldmit@gmail.com Date: 2025-08-25 (Mon, 25 Aug 2025)
Changed paths: M libknet/crypto_openssl.c
Log Message: ----------- Some error checking for OpenSSL functions
Commit: 8922b836718e9f0b5745f2abdbc7f157a1c7d26e https://github.com/kronosnet/kronosnet/commit/8922b836718e9f0b5745f2abdbc7f1... Author: Christine Caulfield ccaulfie@redhat.com Date: 2025-08-28 (Thu, 28 Aug 2025)
Changed paths: M libknet/tests/api_knet_handle_free.c M libknet/tests/api_knet_handle_set_transport_reconnect_interval.c
Log Message: ----------- Suppress some sudden coverity errors
Commit: 3cbd7320f1df4bea9a33fae0e912245fce95bfab https://github.com/kronosnet/kronosnet/commit/3cbd7320f1df4bea9a33fae0e91224... Author: David Hanisch hanisch@strato.de Date: 2025-08-29 (Fri, 29 Aug 2025)
Changed paths: M libknet/handle_api.c M libknet/internals.h M libknet/libknet.h M libknet/tests/api-check.mk A libknet/tests/api_knet_handle_setprio_dscp.c M libknet/transport_common.c M man/Makefile.am
Log Message: ----------- Allow to configure a dscp value for KNET_LINK_FLAG_TRAFFICHIPRIO
Currently IPTOS_LOWDELAY is used for IP_TOS. A setup may require to set a certain dscp value to prioritize the IP traffic.
Commit: 15383d787d0808e55d80282ddd609422e30d5fa3 https://github.com/kronosnet/kronosnet/commit/15383d787d0808e55d80282ddd6094... Author: Fabio M. Di Nitto fdinitto@redhat.com Date: 2025-08-29 (Fri, 29 Aug 2025)
Changed paths: M libknet/Makefile.am
Log Message: ----------- libknet: bump soname to reflect new symbol
Signed-off-by: Fabio M. Di Nitto fdinitto@redhat.com
Commit: 571baade645c746521d83f0182ad7ada0219578d https://github.com/kronosnet/kronosnet/commit/571baade645c746521d83f0182ad7a... Author: David Hanisch hanisch@strato.de Date: 2025-08-30 (Sat, 30 Aug 2025)
Changed paths: M libknet/tests/api_knet_handle_pmtud_setfreq.c
Log Message: ----------- fix wrong tests
Api calls fail due to NULL knet handle, but intention is to fail due to wrong arguments.
Commit: 87c33a3a5172b72a8b01d5822d94a74d030ae9d5 https://github.com/kronosnet/kronosnet/commit/87c33a3a5172b72a8b01d5822d94a7... Author: Chrissie Caulfield ccaulfie@redhat.com Date: 2025-09-04 (Thu, 04 Sep 2025)
Changed paths: M libnozzle/libnozzle.c
Log Message: ----------- libnozzle - Fix FreeBSD nozzle_down (#458)
For reasons I am unlikely ever to understand, it's necessary to call SIOCGIFFLAGS on a tap interface after SIOCIFDESTROY for the device to actually be removed.
...so do that
Commit: 1d55876008b62d0d86a8b0e74dc06b81f0967f12 https://github.com/kronosnet/kronosnet/commit/1d55876008b62d0d86a8b0e74dc06b... Author: Fabio M. Di Nitto fdinitto@redhat.com Date: 2025-09-06 (Sat, 06 Sep 2025)
Changed paths: M libnozzle/libnozzle.c M libnozzle/tests/test-common.c
Log Message: ----------- libnozzle - Fix FreeBSD nozzle_down (take 2)
also, FreeBSD 13+ now allow tap0 to be delete.. if only the kernel interface was stable....
Signed-off-by: Fabio M. Di Nitto fdinitto@redhat.com
Commit: 41912b5a7ffd4447173844f121d464045c34bd17 https://github.com/kronosnet/kronosnet/commit/41912b5a7ffd4447173844f121d464... Author: Christine Caulfield ccaulfie@redhat.com Date: 2025-09-23 (Tue, 23 Sep 2025)
Changed paths: M Makefile.am M README M configure.ac M libknet/Makefile.am M libknet/compress.c M libknet/compress.h M libknet/handle.c M libknet/libknet.h M libknet/libknet_exported_syms M libknet/netutils.h M libknet/onwire.h M libknet/tests/Makefile.am M libknet/tests/api-test-coverage M libknet/tests/api_knet_addrtostr.c M libknet/tests/api_knet_handle_new_limit.c M libknet/tests/api_knet_send.c M libknet/tests/api_knet_strtoaddr.c M libknet/tests/fun_pmtud_crypto.c M libknet/tests/knet_bench.c M libknet/tests/test-common.h M libknet/threads_tx.c M libknet/transport_common.c M libknet/transport_loopback.c M libknet/transport_udp.c M libnozzle/Makefile.am M libnozzle/internals.h M libnozzle/libnozzle.c M libnozzle/libnozzle_exported_syms M libnozzle/tests/api-test-coverage M libnozzle/tests/api_nozzle_add_ip.c M libnozzle/tests/api_nozzle_close.c M libnozzle/tests/api_nozzle_del_ip.c M libnozzle/tests/api_nozzle_get_mac.c M libnozzle/tests/api_nozzle_get_mtu.c M libnozzle/tests/api_nozzle_open.c M libnozzle/tests/api_nozzle_set_down.c M libnozzle/tests/api_nozzle_set_mac.c M libnozzle/tests/api_nozzle_set_mtu.c M libnozzle/tests/api_nozzle_set_up.c M libnozzle/tests/test-common.c
Log Message: ----------- Make knet work on OpenIndiana (Solaris)
author: various
Signed-off-by: Fabio M. Di Nitto fdinitto@redhat.com
Commit: 277978e2ba300b15cee686a14561c7fb40c1fa96 https://github.com/kronosnet/kronosnet/commit/277978e2ba300b15cee686a14561c7... Author: Christine Caulfield ccaulfie@redhat.com Date: 2025-09-23 (Tue, 23 Sep 2025)
Changed paths: M libknet/tests/api_knet_handle_pmtud_set.c M libnozzle/tests/test-common.c
Log Message: ----------- Several test suite fixes
Increase the sleep in pmtud tests Increase timeout in fun_onwire_upgrade Try and make sure IPv6 test addresses are always valid
Commit: bb0bbcbc9f222722da41280e33708086c7dbc271 https://github.com/kronosnet/kronosnet/commit/bb0bbcbc9f222722da41280e337080... Author: Christine Caulfield ccaulfie@redhat.com Date: 2025-09-23 (Tue, 23 Sep 2025)
Changed paths: M README
Log Message: ----------- Update README to explain libqb dependancy
Commit: 228a23831c448dd18814d8319b9f033ad7a2fb69 https://github.com/kronosnet/kronosnet/commit/228a23831c448dd18814d8319b9f03... Author: Fabio M. Di Nitto fdinitto@redhat.com Date: 2025-09-23 (Tue, 23 Sep 2025)
Changed paths: M man/doxyxml.c
Log Message: ----------- man: align doxyxml with libqb for solaris support
Signed-off-by: Fabio M. Di Nitto fdinitto@redhat.com
Commit: e3d8743dd5d3f675a5803a4c58259fed94e14469 https://github.com/kronosnet/kronosnet/commit/e3d8743dd5d3f675a5803a4c58259f... Author: Fabio M. Di Nitto fdinitto@redhat.com Date: 2025-09-24 (Wed, 24 Sep 2025)
Changed paths: M configure.ac
Log Message: ----------- libknet: deprecate SCTP support
Signed-off-by: Fabio M. Di Nitto fdinitto@redhat.com
Commit: c4142e39568a7510380d679c1fbe3cba94b7d422 https://github.com/kronosnet/kronosnet/commit/c4142e39568a7510380d679c1fbe3c... Author: Fabio M. Di Nitto fdinitto@redhat.com Date: 2025-09-25 (Thu, 25 Sep 2025)
Changed paths: M Makefile.am M README A STYLE_GUIDE.md M configure.ac M libknet/Makefile.am M libknet/compress.c M libknet/compress.h M libknet/crypto_openssl.c M libknet/handle.c M libknet/handle_api.c M libknet/internals.h M libknet/libknet.h M libknet/libknet_exported_syms M libknet/netutils.h M libknet/onwire.h M libknet/tests/Makefile.am M libknet/tests/api-check.mk M libknet/tests/api-test-coverage M libknet/tests/api_knet_addrtostr.c M libknet/tests/api_knet_handle_free.c M libknet/tests/api_knet_handle_new_limit.c M libknet/tests/api_knet_handle_pmtud_set.c M libknet/tests/api_knet_handle_pmtud_setfreq.c M libknet/tests/api_knet_handle_set_transport_reconnect_interval.c A libknet/tests/api_knet_handle_setprio_dscp.c M libknet/tests/api_knet_send.c M libknet/tests/api_knet_strtoaddr.c M libknet/tests/fun_pmtud_crypto.c M libknet/tests/knet_bench.c M libknet/tests/test-common.h M libknet/threads_rx.c M libknet/threads_tx.c M libknet/transport_common.c M libknet/transport_loopback.c M libknet/transport_udp.c M libnozzle/Makefile.am M libnozzle/internals.h M libnozzle/libnozzle.c M libnozzle/libnozzle_exported_syms M libnozzle/tests/api-test-coverage M libnozzle/tests/api_nozzle_add_ip.c M libnozzle/tests/api_nozzle_close.c M libnozzle/tests/api_nozzle_del_ip.c M libnozzle/tests/api_nozzle_get_mac.c M libnozzle/tests/api_nozzle_get_mtu.c M libnozzle/tests/api_nozzle_open.c M libnozzle/tests/api_nozzle_set_down.c M libnozzle/tests/api_nozzle_set_mac.c M libnozzle/tests/api_nozzle_set_mtu.c M libnozzle/tests/api_nozzle_set_up.c M libnozzle/tests/test-common.c M man/Makefile.am M man/doxyxml.c
Log Message: ----------- Merge pull request #446 from kronosnet/stable1-proposed
stable1-proposed
Compare: https://github.com/kronosnet/kronosnet/compare/da73f2a1e0ff...c4142e39568a
To unsubscribe from these emails, change your notification settings at https://github.com/kronosnet/kronosnet/settings/notifications
-
Fabio M. Di Nitto