[kronosnet/kronosnet] 28e004: tests: fix C99 compliance for mixed declarations a... - Commits

7 Jun 2026


      Branch: refs/heads/tests-cleanup
  Home:   https://github.com/kronosnet/kronosnet
  Commit: 28e00424393bed9619bd999f58ef9ac794f1eb12
      https://github.com/kronosnet/kronosnet/commit/28e00424393bed9619bd999f58ef9a...
  Author: Fabio M. Di Nitto fdinitto@redhat.com
  Date:   2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
    M libknet/tests/api_knet_handle_add_datafd.c
    M libknet/tests/api_knet_handle_clear_stats.c
    M libknet/tests/api_knet_handle_compress.c
    M libknet/tests/api_knet_handle_crypto_rx_clear_traffic.c
    M libknet/tests/api_knet_handle_crypto_set_config.c
    M libknet/tests/api_knet_handle_crypto_use_config.c
    M libknet/tests/api_knet_handle_enable_access_lists.c
    M libknet/tests/api_knet_handle_enable_filter.c
    M libknet/tests/api_knet_handle_enable_onwire_ver_notify.c
    M libknet/tests/api_knet_handle_enable_pmtud_notify.c
    M libknet/tests/api_knet_handle_enable_sock_notify.c
    M libknet/tests/api_knet_handle_free.c
    M libknet/tests/api_knet_handle_get_channel.c
    M libknet/tests/api_knet_handle_get_datafd.c
    M libknet/tests/api_knet_handle_get_host_defrag_bufs.c
    M libknet/tests/api_knet_handle_get_onwire_ver.c
    M libknet/tests/api_knet_handle_get_stats.c
    M libknet/tests/api_knet_handle_get_threads_timer_res.c
    M libknet/tests/api_knet_handle_get_transport_reconnect_interval.c
    M libknet/tests/api_knet_handle_new.c
    M libknet/tests/api_knet_handle_pmtud_get.c
    M libknet/tests/api_knet_handle_pmtud_getfreq.c
    M libknet/tests/api_knet_handle_pmtud_set.c
    M libknet/tests/api_knet_handle_pmtud_setfreq.c
    M libknet/tests/api_knet_handle_remove_datafd.c
    M libknet/tests/api_knet_handle_set_host_defrag_bufs.c
    M libknet/tests/api_knet_handle_set_onwire_ver.c
    M libknet/tests/api_knet_handle_set_threads_timer_res.c
    M libknet/tests/api_knet_handle_set_transport_reconnect_interval.c
    M libknet/tests/api_knet_handle_setfwd.c
    M libknet/tests/api_knet_handle_setprio_dscp.c
    M libknet/tests/api_knet_host_add.c
    M libknet/tests/api_knet_host_enable_status_change_notify.c
    M libknet/tests/api_knet_host_get_host_list.c
    M libknet/tests/api_knet_host_get_id_by_host_name.c
    M libknet/tests/api_knet_host_get_name_by_host_id.c
    M libknet/tests/api_knet_host_get_policy.c
    M libknet/tests/api_knet_host_get_status.c
    M libknet/tests/api_knet_host_remove.c
    M libknet/tests/api_knet_host_set_name.c
    M libknet/tests/api_knet_host_set_policy.c
    M libknet/tests/api_knet_link_add_acl.c
    M libknet/tests/api_knet_link_clear_acl.c
    M libknet/tests/api_knet_link_clear_config.c
    M libknet/tests/api_knet_link_enable_status_change_notify.c
    M libknet/tests/api_knet_link_get_config.c
    M libknet/tests/api_knet_link_get_enable.c
    M libknet/tests/api_knet_link_get_link_list.c
    M libknet/tests/api_knet_link_get_ping_timers.c
    M libknet/tests/api_knet_link_get_pong_count.c
    M libknet/tests/api_knet_link_get_priority.c
    M libknet/tests/api_knet_link_get_status.c
    M libknet/tests/api_knet_link_insert_acl.c
    M libknet/tests/api_knet_link_rm_acl.c
    M libknet/tests/api_knet_link_set_config.c
    M libknet/tests/api_knet_link_set_enable.c
    M libknet/tests/api_knet_link_set_ping_timers.c
    M libknet/tests/api_knet_link_set_pong_count.c
    M libknet/tests/api_knet_link_set_priority.c
    M libknet/tests/api_knet_log_get_loglevel.c
    M libknet/tests/api_knet_log_get_loglevel_id.c
    M libknet/tests/api_knet_log_get_subsystem_id.c
    M libknet/tests/api_knet_log_set_loglevel.c
    M libknet/tests/api_knet_recv.c
    M libknet/tests/api_knet_send.c
    M libknet/tests/api_knet_send_compress.c
    M libknet/tests/api_knet_send_crypto.c
    M libknet/tests/api_knet_send_loopback.c
    M libknet/tests/api_knet_send_sync.c
    M libknet/tests/fun_acl_check.c
    M libknet/tests/fun_config_crypto.c
    M libknet/tests/fun_onwire_upgrade.c
    M libknet/tests/test-common.c
Log Message:
  -----------
  tests: fix C99 compliance for mixed declarations and code
Move all variable declarations before executable statements.
Fixed 74 test files to comply with C99 standard.
Signed-off-by: Fabio M. Di Nitto fabbione@kronosnet.org
Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com
Commit: 1677b80cf61c2e713fd17f5b50eae24b55e628d5
      https://github.com/kronosnet/kronosnet/commit/1677b80cf61c2e713fd17f5b50eae2...
  Author: Fabio M. Di Nitto fdinitto@redhat.com
  Date:   2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
    M libknet/tests/api_knet_get_crypto_cipher_list.c
    M libknet/tests/api_knet_get_crypto_hash_list.c
    M libknet/tests/api_knet_handle_clear_stats.c
    M libknet/tests/api_knet_handle_new.c
    M libknet/tests/api_knet_handle_new_limit.c
    M libknet/tests/api_knet_send_compress.c
    M libknet/tests/api_knet_send_crypto.c
    M libknet/tests/api_knet_send_loopback.c
    M libknet/tests/fun_acl_check.c
    M libknet/tests/fun_config_crypto.c
    M libknet/tests/fun_config_crypto_ctr.c
    M libknet/tests/fun_onwire_upgrade.c
    M libknet/tests/fun_pmtud_crypto.c
Log Message:
  -----------
  tests: add zero-initialization to knet_h arrays
Initialize all knet_h arrays with = {0} for consistency.
Signed-off-by: Fabio M. Di Nitto fabbione@kronosnet.org
Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com
Commit: 6d1e5b8bb55189e11e5b46894988cda61201e9c7
      https://github.com/kronosnet/kronosnet/commit/6d1e5b8bb55189e11e5b46894988cd...
  Author: Fabio M. Di Nitto fdinitto@redhat.com
  Date:   2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
    M libknet/tests/api_knet_addrtostr.c
    M libknet/tests/api_knet_get_compress_list.c
    M libknet/tests/api_knet_get_crypto_cipher_list.c
    M libknet/tests/api_knet_get_crypto_hash_list.c
    M libknet/tests/api_knet_get_crypto_list.c
    M libknet/tests/api_knet_get_transport_list.c
    M libknet/tests/api_knet_handle_set_onwire_ver.c
    M libknet/tests/api_knet_handle_set_threads_timer_res.c
    M libknet/tests/api_knet_link_add_acl.c
    M libknet/tests/api_knet_link_insert_acl.c
    M libknet/tests/api_knet_link_rm_acl.c
    M libknet/tests/api_knet_link_set_config.c
    M libknet/tests/api_knet_link_set_enable.c
    M libknet/tests/api_knet_link_set_ping_timers.c
    M libknet/tests/api_knet_link_set_pong_count.c
    M libknet/tests/api_knet_link_set_priority.c
Log Message:
  -----------
  tests: extend usage of FAIL_ON_ERR* macros across test suite
Replace manual error checking patterns with FAIL_ON_ERR* macros from
test-common.h to improve consistency and reduce boilerplate.
Conversions include:
- FAIL_ON_ERR: for tests with knet_h arrays requiring cleanup
- FAIL_ON_ERR_NOCLEAN: for tests without knet_h arrays
- FAIL_ON_SUCCESS: for negative testing with expected errno
Signed-off-by: Fabio M. Di Nitto fabbione@kronosnet.org
Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com
Commit: 7aeeb0e785c0176d90acbd0508f2f80419d7602c
      https://github.com/kronosnet/kronosnet/commit/7aeeb0e785c0176d90acbd0508f2f8...
  Author: Fabio M. Di Nitto fdinitto@redhat.com
  Date:   2026-06-07 (Sun, 07 Jun 2026)
Changed paths:
    M libknet/tests/api_knet_host_set_name.c
Log Message:
  -----------
  tests: remove redundant knet_host_remove call in api_knet_host_set_name
The manual knet_host_remove(knet_h1, 2) call is unnecessary since
TEST_EXIT_CLEAN() will clean up all hosts via _ts_knet_handle_stop_everything().
Signed-off-by: Fabio M. Di Nitto fabbione@kronosnet.org
Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com
Compare: https://github.com/kronosnet/kronosnet/compare/28e00424393b%5E...7aeeb0e785c...
To unsubscribe from these emails, change your notification settings at https://github.com/kronosnet/kronosnet/settings/notifications