Branch: refs/heads/main Home: https://github.com/kronosnet/kronosnet Commit: ac6e34f91bba2d58a75796277b135f5d8b7ef755 https://github.com/kronosnet/kronosnet/commit/ac6e34f91bba2d58a75796277b135f... Author: Christine Caulfield ccaulfie@redhat.com Date: 2026-06-12 (Fri, 12 Jun 2026)
Changed paths: M libnozzle/libnozzle.c
Log Message: ----------- nozzle: Use portable type and macro for platform abstraction
Replace direct use of 'struct ifreq' with 'nozzle_ifreq' type and 'lib_cfg.ioctlfd' with 'NOZZLE_IOCTL_FD' macro. This improves portability across different BSD variants and Solaris where the ifreq structure may differ.
These macros are defined in libnozzle_bsd.c and other platform-specific files to abstract platform differences.
Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com
Commit: 63fd6847cfa0649464dd357d8586fd44539f449f https://github.com/kronosnet/kronosnet/commit/63fd6847cfa0649464dd357d8586fd... Author: Christine Caulfield ccaulfie@redhat.com Date: 2026-06-12 (Fri, 12 Jun 2026)
Changed paths: M libnozzle/libnozzle_bsd.c
Log Message: ----------- nozzle: Translate EEXIST to EBUSY on BSD for consistency
When creating a tap device on BSD, SIOCIFCREATE2 returns EEXIST if the device already exists. For consistency with Linux (which returns EBUSY in the same situation), translate EEXIST to EBUSY.
This allows tests and calling code to handle duplicate device creation uniformly across platforms.
Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com
Commit: b1e852127fa16df70f008cc479f635a9aba384b5 https://github.com/kronosnet/kronosnet/commit/b1e852127fa16df70f008cc479f635... Author: Christine Caulfield ccaulfie@redhat.com Date: 2026-06-12 (Fri, 12 Jun 2026)
Changed paths: M libnozzle/tests/api_nozzle_add_ip.c M libnozzle/tests/api_nozzle_close.c M libnozzle/tests/api_nozzle_del_ip.c M libnozzle/tests/api_nozzle_get_fd.c M libnozzle/tests/api_nozzle_get_handle_by_name.c M libnozzle/tests/api_nozzle_get_ips.c M libnozzle/tests/api_nozzle_get_mac.c M libnozzle/tests/api_nozzle_get_mtu.c M libnozzle/tests/api_nozzle_get_name_by_handle.c M libnozzle/tests/api_nozzle_open.c M libnozzle/tests/api_nozzle_run_updown.c M libnozzle/tests/api_nozzle_set_down.c M libnozzle/tests/api_nozzle_set_mac.c M libnozzle/tests/api_nozzle_set_mtu.c M libnozzle/tests/api_nozzle_set_up.c M libnozzle/tests/int_execute_bin_sh_command.c M libnozzle/tests/test-common.h
Log Message: ----------- nozzle: Introduce test macros similar to libknet
Add comprehensive test macros to test-common.h, similar to those used in libknet tests: - FAIL_ON_ERR: Fail if function returns error - FAIL_ON_SUCCESS: Negative test - expect failure with specific errno - FAIL_ON_NULL/FAIL_ON_NOT_NULL: For pointer-returning functions - FAIL_ON_NONZERO/FAIL_ON_ZERO: For comparisons - FAIL_ON_ERR_ONLY: For functions returning -1 on error - FAIL_ON_CMD: For execute_bin_sh_command and similar - FAIL_ON_CMD_SUCCESS: Negative test for commands
These macros: - Reduce code duplication and improve readability - Print descriptive failure messages with line numbers - Handle errno correctly for debugging - Automatically clean up via 'goto out_clean' pattern
All test files have been converted to use these macros, significantly reducing test code size (from 1280 to ~600 lines net) while improving clarity and error reporting.
Also fixed Solaris-specific test issues where interface state checks aren't possible - these now skip the check rather than fail.
Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com
Commit: e9d4e197ba239cbb1516b0412234f17175ce8fb9 https://github.com/kronosnet/kronosnet/commit/e9d4e197ba239cbb1516b0412234f1... Author: Fabio M. Di Nitto fdinitto@redhat.com Date: 2026-06-12 (Fri, 12 Jun 2026)
Changed paths: M libnozzle/libnozzle.c M libnozzle/libnozzle_bsd.c M libnozzle/tests/api_nozzle_add_ip.c M libnozzle/tests/api_nozzle_close.c M libnozzle/tests/api_nozzle_del_ip.c M libnozzle/tests/api_nozzle_get_fd.c M libnozzle/tests/api_nozzle_get_handle_by_name.c M libnozzle/tests/api_nozzle_get_ips.c M libnozzle/tests/api_nozzle_get_mac.c M libnozzle/tests/api_nozzle_get_mtu.c M libnozzle/tests/api_nozzle_get_name_by_handle.c M libnozzle/tests/api_nozzle_open.c M libnozzle/tests/api_nozzle_run_updown.c M libnozzle/tests/api_nozzle_set_down.c M libnozzle/tests/api_nozzle_set_mac.c M libnozzle/tests/api_nozzle_set_mtu.c M libnozzle/tests/api_nozzle_set_up.c M libnozzle/tests/int_execute_bin_sh_command.c M libnozzle/tests/test-common.h
Log Message: ----------- Merge pull request #491 from kronosnet/nozzle-tests-macros
Nozzle tests macros
Compare: https://github.com/kronosnet/kronosnet/compare/80de6e5c6ffb...e9d4e197ba23
To unsubscribe from these emails, change your notification settings at https://github.com/kronosnet/kronosnet/settings/notifications
-
Fabio M. Di Nitto