Branch: refs/heads/fix-acl Home: https://github.com/kronosnet/kronosnet Commit: 3761691f7158659d6a4608af211b05d5a8df43dc https://github.com/kronosnet/kronosnet/commit/3761691f7158659d6a4608af211b05... Author: Fabio M. Di Nitto fdinitto@redhat.com Date: 2021-07-23 (Fri, 23 Jul 2021)
Changed paths: M libknet/tests/api_knet_send_sync.c M libknet/transport_sctp.c
Log Message: ----------- [sctp] fix invalid memory access
and add more tests to the SCTP matrix
Signed-off-by: Fabio M. Di Nitto fdinitto@redhat.com
Commit: 4b3a66f60e3989d3ac0eb984c0a2e48c1565659b https://github.com/kronosnet/kronosnet/commit/4b3a66f60e3989d3ac0eb984c0a2e4... Author: Fabio M. Di Nitto fdinitto@redhat.com Date: 2021-07-23 (Fri, 23 Jul 2021)
Changed paths: M libknet/links.c
Log Message: ----------- [acl] make knet_link_add_acl a wrapper to knet_link_insert_acl
remove lots of duplicated code
Signed-off-by: Fabio M. Di Nitto fdinitto@redhat.com
Commit: 6e854a95615121ad128aa62d1c0f20345dff9f0d https://github.com/kronosnet/kronosnet/commit/6e854a95615121ad128aa62d1c0f20... Author: Fabio M. Di Nitto fdinitto@redhat.com Date: 2021-07-23 (Fri, 23 Jul 2021)
Changed paths: M libknet/internals.h M libknet/links.c M libknet/links_acl.c M libknet/links_acl.h M libknet/links_acl_ip.c M libknet/tests/Makefile.am M libknet/tests/api_knet_link_add_acl.c M libknet/tests/api_knet_link_clear_acl.c M libknet/tests/api_knet_link_insert_acl.c M libknet/tests/api_knet_link_rm_acl.c M libknet/tests/api_knet_link_set_config.c M libknet/tests/api_knet_send.c A libknet/tests/fun_acl_check.c M libknet/threads_rx.c M libknet/transport_sctp.c
Log Message: ----------- [acl] major internal rework
ACL internal management was somewhat broken and didn´t really do what was advertised for dynamic links.
- fix ACL to be truely per host/link as public API advertise - move ACL checking when host/link are known - add extensive tests - fix various minor bugs that went undetected for a bit - enable access list testings on more tests
Signed-off-by: Christine Caulfield ccaulfie@redhat.com Signed-off-by: Fabio M. Di Nitto fdinitto@redhat.com
Commit: 284425d0098fcf6b287238cd8086cc9bb049b94d https://github.com/kronosnet/kronosnet/commit/284425d0098fcf6b287238cd8086cc... Author: Christine Caulfield ccaulfie@redhat.com Date: 2021-07-23 (Fri, 23 Jul 2021)
Changed paths: M libknet/tests/fun_acl_check.c
Log Message: ----------- test: Add some waits after removing a blocking ACL
The ACL can make the link unstable and we can get down events even after calling knet_link_rm_acl(), so simply checking for all links up is not sufficient.
Commit: e7a739be2b1ea4a0bbaea55338b180d5a2e817e0 https://github.com/kronosnet/kronosnet/commit/e7a739be2b1ea4a0bbaea55338b180... Author: Christine Caulfield ccaulfie@redhat.com Date: 2021-07-23 (Fri, 23 Jul 2021)
Changed paths: M libknet/tests/fun_acl_check.c
Log Message: ----------- test: actually get rid of arbitrary sleeps
A better way is to wait for the link to go down BEFORE calling knet_link_rm_acl(), then wait for it to come back up AFTER knet_link_rm_ac(). That avoids all sleeps and makes it properly event-driven.
This patch also fixes an error reporting bug.
Commit: d9c796e708d5174a28964f4a429b37b86ea350ef https://github.com/kronosnet/kronosnet/commit/d9c796e708d5174a28964f4a429b37... Author: Fabio M. Di Nitto fdinitto@redhat.com Date: 2021-07-23 (Fri, 23 Jul 2021)
Changed paths: M libknet/tests/fun_acl_check.c M libknet/tests/test-common.c
Log Message: ----------- [tests] fix some error handling
Signed-off-by: Fabio M. Di Nitto fdinitto@redhat.com
Compare: https://github.com/kronosnet/kronosnet/compare/dcdef264c6f6...d9c796e708d5
-
Fabio M. Di Nitto