Branch: refs/heads/main Home: https://github.com/kronosnet/kronosnet Commit: 3d3f07b3f19317345020f8c770e02d07682aa76e https://github.com/kronosnet/kronosnet/commit/3d3f07b3f19317345020f8c770e02d... Author: Christine Caulfield ccaulfie@redhat.com Date: 2025-08-28 (Thu, 28 Aug 2025)
Changed paths: M libknet/transport_udp.c
Log Message: ----------- UDP: Don't keep retrying send if we get EINVAL
UDP can return EINVAL if the route is down or not configured, this can cause knet to 'spin' (well, ish, there is a usleep in there).
With this patch in place knet doesn't hog the CPU anywhere near so much (and it does recover if the link returns).
TBH I'm in 2 minds about this. When I first spotted corosync taking up 100% CPU because I had forgotten to ifup the link I screamed 'bug', but I'm not totally sure. It might need more sensitive handling. hence I'm posting it here as much for discussion as anything else
Signed-off-by: Christine Caulfield ccaulfie@redhat.com
Commit: 9287f87e748fe57abe6d3f3672a128ecf4546a46 https://github.com/kronosnet/kronosnet/commit/9287f87e748fe57abe6d3f3672a128... Author: Christine Caulfield ccaulfie@redhat.com Date: 2025-08-28 (Thu, 28 Aug 2025)
Changed paths: M libknet/transport_udp.c
Log Message: ----------- UDP: Don't keep retrying send if we get EINVAL
UDP can return EINVAL if the route is down or not configured, this can cause knet to 'spin' (well, ish, there is a usleep in there).
With this patch in place knet doesn't hog the CPU anywhere near so much (and it does recover if the link returns).
TBH I'm in 2 minds about this. When I first spotted corosync taking up 100% CPU because I had forgotten to ifup the link I screamed 'bug', but I'm not totally sure. It might need more sensitive handling. hence I'm posting it here as much for discussion as anything else
Signed-off-by: Christine Caulfield ccaulfie@redhat.com
Commit: 2e8539ac169d5f86e6c6251d3c65d3271af7e025 https://github.com/kronosnet/kronosnet/commit/2e8539ac169d5f86e6c6251d3c65d3... Author: Christine Caulfield ccaulfie@redhat.com Date: 2025-08-28 (Thu, 28 Aug 2025)
Changed paths: M libknet/tests/api_knet_handle_free.c M libknet/tests/api_knet_handle_set_transport_reconnect_interval.c M libknet/transport_udp.c
Log Message: ----------- Suppress some sudden coverity errors
Commit: f1bf72cf63d82228601abd6a41f81de25c09df67 https://github.com/kronosnet/kronosnet/commit/f1bf72cf63d82228601abd6a41f81d... Author: Fabio M. Di Nitto fdinitto@redhat.com Date: 2025-08-28 (Thu, 28 Aug 2025)
Changed paths: M libknet/tests/api_knet_handle_free.c M libknet/tests/api_knet_handle_set_transport_reconnect_interval.c
Log Message: ----------- Merge pull request #454 from chrissie-c/cov-suddenly
Suppress some sudden coverity errors in tests
Compare: https://github.com/kronosnet/kronosnet/compare/9900e5b73112...f1bf72cf63d8
To unsubscribe from these emails, change your notification settings at https://github.com/kronosnet/kronosnet/settings/notifications