Branch: refs/heads/flags Home: https://github.com/kronosnet/kronosnet Commit: 32c8bbfd5620147ec669a9ba8f2468c530b8c4c6 https://github.com/kronosnet/kronosnet/commit/32c8bbfd5620147ec669a9ba8f2468... Author: Ferenc Wágner wferi@debian.org Date: 2018-01-29 (Mon, 29 Jan 2018)
Changed paths: M configure.ac
Log Message: ----------- build: remove unused DEBUG Automake conditional
Signed-off-by: Ferenc Wágner wferi@debian.org
Commit: b3a1876810d0704e393960343bec0eff19e1df6e https://github.com/kronosnet/kronosnet/commit/b3a1876810d0704e393960343bec0e... Author: Ferenc Wágner wferi@debian.org Date: 2018-01-29 (Mon, 29 Jan 2018)
Changed paths: M poc-code/iov-hash/Makefile.am
Log Message: ----------- build: LIBS belong to LDADD for binaries
Signed-off-by: Ferenc Wágner wferi@debian.org
Commit: 2b49ed998fad137b0386399bdb149943badd7677 https://github.com/kronosnet/kronosnet/commit/2b49ed998fad137b0386399bdb1499... Author: Ferenc Wágner wferi@debian.org Date: 2018-01-29 (Mon, 29 Jan 2018)
Changed paths: M configure.ac M libknet/Makefile.am M libtap/Makefile.am
Log Message: ----------- build: sanitize LDFLAGS handling
The Automake manual states that according to the GNU Coding Standards the so-called "Variables reserved for the user" mustn't be changed by the build system, and they must override the default settings from the build system. The "Flag Variables Ordering" section provides the recipes on which we build here.
Using $lt_prog_compiler_pic directly shouldn't be necessary, let's try leaving it out.
Signed-off-by: Ferenc Wágner wferi@debian.org
Commit: b22fec803fe1ba43c2d1cd58dc34812a3f989370 https://github.com/kronosnet/kronosnet/commit/b22fec803fe1ba43c2d1cd58dc3481... Author: Ferenc Wágner wferi@debian.org Date: 2018-01-29 (Mon, 29 Jan 2018)
Changed paths: M configure.ac
Log Message: ----------- build: we preserve CPPFLAGS, just remove the tempting hooks
Signed-off-by: Ferenc Wágner wferi@debian.org
Commit: 79825a703a179ad2322943d803dbf2c7fa59cad1 https://github.com/kronosnet/kronosnet/commit/79825a703a179ad2322943d803dbf2... Author: Ferenc Wágner wferi@debian.org Date: 2018-01-29 (Mon, 29 Jan 2018)
Changed paths: M configure.ac M kronosnetd/Makefile.am M libknet/Makefile.am M libknet/tests/Makefile.am M libtap/Makefile.am M poc-code/iov-hash/Makefile.am
Log Message: ----------- build: sanitize CFLAGS handling
As for LDFLAGS previously: leave the CFLAGS "user variable" untouched to enable easy selective overriding of the flags used by the build system.
Using $lt_prog_compiler_pic shouldn't be necessary, let's drop it and see if anything breaks. WERROR_CFLAGS was undefined, so dropped as well.
Signed-off-by: Ferenc Wágner wferi@debian.org
Commit: 172b7832bcff2388b9d942cc923d742a0a80d866 https://github.com/kronosnet/kronosnet/commit/172b7832bcff2388b9d942cc923d74... Author: Ferenc Wágner wferi@debian.org Date: 2018-01-29 (Mon, 29 Jan 2018)
Changed paths: M configure.ac A m4/ax_check_link_flag.m4
Log Message: ----------- build: check for the --enable-new-dtags flag before using it
Signed-off-by: Ferenc Wágner wferi@debian.org
Commit: 1d6fe70d4810d45b8dd3ca983ffcf86408db5f62 https://github.com/kronosnet/kronosnet/commit/1d6fe70d4810d45b8dd3ca983ffcf8... Author: Ferenc Wágner wferi@debian.org Date: 2018-01-29 (Mon, 29 Jan 2018)
Changed paths: M configure.ac
Log Message: ----------- build: use --as-needed to avoid unnecessary dependency on libm
I removed --as-needed in 1b96703, but now I found a good reason to use it after all.
Signed-off-by: Ferenc Wágner wferi@debian.org
Commit: f55a13844d74b85a6f3fa80cf3739eb352f02fb8 https://github.com/kronosnet/kronosnet/commit/f55a13844d74b85a6f3fa80cf3739e... Author: Ferenc Wágner wferi@debian.org Date: 2018-01-29 (Mon, 29 Jan 2018)
Changed paths: M configure.ac
Log Message: ----------- build: linking with libm is unnecessary on some systems (like OS X)
Inlining of builtin functions can eliminate the libm dependency on other systems as well, but AC_SEARCH_LIBS can't detect this because it tests with a false prototype. Thus we use --as-needed linking already to trim such unnecessary dependencies.
Signed-off-by: Ferenc Wágner wferi@debian.org
Commit: f77b5f38b311935505a539b1b8d1eff7784b6a8c https://github.com/kronosnet/kronosnet/commit/f77b5f38b311935505a539b1b8d1ef... Author: Ferenc Wágner wferi@debian.org Date: 2018-01-29 (Mon, 29 Jan 2018)
Changed paths: M libknet/Makefile.am M libtap/Makefile.am
Log Message: ----------- build: --export-dynamic is needed for dlopened modules only
Not that it matters on ELF platforms the least. If Kronosnet is ever ported to Windows, however...
Signed-off-by: Ferenc Wágner wferi@debian.org
Commit: 3f8205260b50e87be5735ca6dfce05b6d976580e https://github.com/kronosnet/kronosnet/commit/3f8205260b50e87be5735ca6dfce05... Author: Ferenc Wágner wferi@debian.org Date: 2018-01-29 (Mon, 29 Jan 2018)
Changed paths: M libknet/Makefile.am R libknet/libknet_exported_syms M libtap/Makefile.am R libtap/libtap_exported_syms
Log Message: ----------- build: filter exported symbols by libtool regexes
This should be equivalent to the previous solution, just a little less verbose.
Signed-off-by: Ferenc Wágner wferi@debian.org
Compare: https://github.com/kronosnet/kronosnet/compare/32c8bbfd5620%5E...3f8205260b5...