[kronosnet/kronosnet] ed7573: man: Fix covscan reports in doxyxml.c

Branch: refs/heads/stable1 Home: https://github.com/kronosnet/kronosnet Commit: ed7573d17e7f8e71ab4874665d1de787a1ba16e4 https://github.com/kronosnet/kronosnet/commit/ed7573d17e7f8e71ab4874665d1de… Author: Christine Caulfield <ccaulfie(a)redhat.com> Date: 2020-02-21 (Fri, 21 Feb 2020) Changed paths: M man/doxyxml.c Log Message: ----------- man: Fix covscan reports in doxyxml.c This fixes most of the remaining covscan errors in doxyxml.c. The ones that remain are caused by malloced structures being stored in qb_hashtable_maps. These still cause unfreed memory, because the contents of the maps are never explictly freed, but as they are used until the very end of the program (when the OS will free everything) I'm dubious as to whether it's worth doing it in the code - or whether covscan will work out what's going on anyway. Commit: 3ba5ddfc329699928bd3ee1fae0926dc54678fe1 https://github.com/kronosnet/kronosnet/commit/3ba5ddfc329699928bd3ee1fae092… Author: Christine Caulfield <ccaulfie(a)redhat.com> Date: 2020-02-21 (Fri, 21 Feb 2020) Changed paths: M man/doxyxml.c Log Message: ----------- man: Change strcat to strncat Oddly, covscan doesn't compain about the use of strcat, but I'm going to pre-empt it, just in case it decides to. Commit: fcbeda8f2010be8f1addb0a8e135c26e5961b1e0 https://github.com/kronosnet/kronosnet/commit/fcbeda8f2010be8f1addb0a8e135c… Author: Jan Friesse <jfriesse(a)redhat.com> Date: 2020-02-26 (Wed, 26 Feb 2020) Changed paths: M libknet/libknet.h Log Message: ----------- [man] Enhance prio description of POLICY_PASSIVE Some users found description of POLICY_PASSIVE priority confusing (probably because "priority" word is too overloaded) so add some redundancy to make description unambiguous. Signed-off-by: Jan Friesse <jfriesse(a)redhat.com> Commit: e90cf369cd25ac0f3b199530dbbfb49d3a70a8e8 https://github.com/kronosnet/kronosnet/commit/e90cf369cd25ac0f3b199530dbbfb… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2020-02-28 (Fri, 28 Feb 2020) Changed paths: M libknet/transport_common.c M libknet/transport_sctp.c Log Message: ----------- [transports] use SO_REUSEADDR only for sctp Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: e61d0866cf5f60ff1fc06a3b2d00622ae501b65d https://github.com/kronosnet/kronosnet/commit/e61d0866cf5f60ff1fc06a3b2d006… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2020-02-28 (Fri, 28 Feb 2020) Changed paths: M libknet/tests/api_knet_handle_clear_stats.c M libknet/tests/api_knet_handle_pmtud_set.c M libknet/tests/api_knet_host_remove.c M libknet/tests/api_knet_link_add_acl.c M libknet/tests/api_knet_link_clear_acl.c M libknet/tests/api_knet_link_clear_config.c M libknet/tests/api_knet_link_get_config.c M libknet/tests/api_knet_link_get_enable.c M libknet/tests/api_knet_link_get_link_list.c M libknet/tests/api_knet_link_get_ping_timers.c M libknet/tests/api_knet_link_get_pong_count.c M libknet/tests/api_knet_link_get_priority.c M libknet/tests/api_knet_link_get_status.c M libknet/tests/api_knet_link_insert_acl.c M libknet/tests/api_knet_link_rm_acl.c M libknet/tests/api_knet_link_set_config.c M libknet/tests/api_knet_send.c M libknet/tests/api_knet_send_compress.c M libknet/tests/api_knet_send_crypto.c M libknet/tests/api_knet_send_loopback.c M libknet/tests/api_knet_send_sync.c M libknet/tests/fun_pmtud_crypto.c M libknet/tests/test-common.c M libknet/tests/test-common.h Log Message: ----------- [tests] rework test suite link port allocation Logic is to try to configure a link with port X and if it fails, try the next port. This avoids port collisions between services and knet test suite. Please note that the implementation in test-common.c is NOT super clean. There is still some redundant code in there that is left on purpose. There is another branch, not yet merged, that implements functional testing framework that does heavy use of those functions. We will clean test-common.c as we port the functional testing branch and make it ready for merging. For now, this is good enough to have a more stable test suite. Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 41f5a2ada4d3d315c17e666eaa9d296dd07be40a https://github.com/kronosnet/kronosnet/commit/41f5a2ada4d3d315c17e666eaa9d2… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2020-02-28 (Fri, 28 Feb 2020) Changed paths: M libknet/threads_rx.c Log Message: ----------- [rx] kill unused variable Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 86e0560371197501bbda0d83371c04f5933606f0 https://github.com/kronosnet/kronosnet/commit/86e0560371197501bbda0d83371c0… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2020-02-28 (Fri, 28 Feb 2020) Changed paths: M libknet/handle.c M libknet/internals.h M libknet/threads_heartbeat.c M libknet/threads_pmtud.c M libknet/threads_rx.c M libknet/threads_tx.c Log Message: ----------- [stats] allow knet_handle_get_stats to operate in a readlock context - add global stat mutex lock to protect stats updates - use global stat mutex lock across all the threads - fix up some minor bugs: - update RX crypto stats only when crypto is enabled - update compress and crypto stats in a consistent fashion Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: cd916c46da21af6561c920b7ec016a427f54ac30 https://github.com/kronosnet/kronosnet/commit/cd916c46da21af6561c920b7ec016… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2020-02-28 (Fri, 28 Feb 2020) Changed paths: M libknet/internals.h M libknet/links.c M libknet/links.h M libknet/threads_heartbeat.c M libknet/threads_pmtud.c M libknet/threads_rx.c M libknet/threads_tx.c Log Message: ----------- [stats] allow knet_link_get_status to operate in readlock context - add per link stats mutex - use per link stats mutex across the board note: some threads need to lock for a slightly longer period of time than strictly necessary to avoid reverse-order locking with other mutexes. Signed-off-by: Christine Caulfield <ccaulfie(a)redhat.com> Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 0ba5985c3ddec8429b989f0e7bd3324f53e0a9b0 https://github.com/kronosnet/kronosnet/commit/0ba5985c3ddec8429b989f0e7bd33… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2020-03-04 (Wed, 04 Mar 2020) Changed paths: M libknet/handle.c M libknet/internals.h M libknet/libknet.h M libknet/links.c M libknet/links.h M libknet/tests/api_knet_handle_clear_stats.c M libknet/tests/api_knet_handle_pmtud_set.c M libknet/tests/api_knet_host_remove.c M libknet/tests/api_knet_link_add_acl.c M libknet/tests/api_knet_link_clear_acl.c M libknet/tests/api_knet_link_clear_config.c M libknet/tests/api_knet_link_get_config.c M libknet/tests/api_knet_link_get_enable.c M libknet/tests/api_knet_link_get_link_list.c M libknet/tests/api_knet_link_get_ping_timers.c M libknet/tests/api_knet_link_get_pong_count.c M libknet/tests/api_knet_link_get_priority.c M libknet/tests/api_knet_link_get_status.c M libknet/tests/api_knet_link_insert_acl.c M libknet/tests/api_knet_link_rm_acl.c M libknet/tests/api_knet_link_set_config.c M libknet/tests/api_knet_send.c M libknet/tests/api_knet_send_compress.c M libknet/tests/api_knet_send_crypto.c M libknet/tests/api_knet_send_loopback.c M libknet/tests/api_knet_send_sync.c M libknet/tests/fun_pmtud_crypto.c M libknet/tests/test-common.c M libknet/tests/test-common.h M libknet/threads_heartbeat.c M libknet/threads_pmtud.c M libknet/threads_rx.c M libknet/threads_tx.c M libknet/transport_common.c M libknet/transport_sctp.c M man/doxyxml.c Log Message: ----------- Merge pull request #288 from kronosnet/stable1-proposed Stable1 proposed Compare: https://github.com/kronosnet/kronosnet/compare/b784b9658bc1...0ba5985c3dde