[kronosnet/kronosnet] 6df02b: [sctp] fix deference after null check

Branch: refs/heads/master Home: https://github.com/kronosnet/kronosnet Commit: 6df02b2402585da90fe93a0eddae5fa23c92efa4 https://github.com/kronosnet/kronosnet/commit/6df02b2402585da90fe93a0eddae5… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-07-23 (Tue, 23 Jul 2019) Changed paths: M libknet/transport_sctp.c Log Message: ----------- [sctp] fix deference after null check Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 5bc2d528d4c0e6de56e0b76caaa87d02a9fe3e91 https://github.com/kronosnet/kronosnet/commit/5bc2d528d4c0e6de56e0b76caaa87… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-07-23 (Tue, 23 Jul 2019) Changed paths: M libknet/transport_sctp.c Log Message: ----------- [sctp] free access list only if the socket is valid Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 5e91bbbad9d824ed8c58990e1a06f237ae801822 https://github.com/kronosnet/kronosnet/commit/5e91bbbad9d824ed8c58990e1a06f… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-07-23 (Tue, 23 Jul 2019) Changed paths: M libknet/internals.h Log Message: ----------- [rx] align data types Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 4ad5fbe5d4dba43d564b77268874cac2c067dfee https://github.com/kronosnet/kronosnet/commit/4ad5fbe5d4dba43d564b77268874c… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-07-23 (Tue, 23 Jul 2019) Changed paths: M libknet/handle.c Log Message: ----------- [handle] make sure that the pmtud buf contains at least knet header size Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: fdd9945783f75f2e2cbf7684440aed47cbe440d8 https://github.com/kronosnet/kronosnet/commit/fdd9945783f75f2e2cbf7684440ae… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-07-23 (Tue, 23 Jul 2019) Changed paths: M libknet/transport_sctp.c Log Message: ----------- [sctp] revalidate fd to make coverity scan happy Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 4f829f4cf6b4b9c969ffaabc41bb203842767947 https://github.com/kronosnet/kronosnet/commit/4f829f4cf6b4b9c969ffaabc41bb2… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-07-23 (Tue, 23 Jul 2019) Changed paths: M libknet/tests/knet_bench.c Log Message: ----------- [tests] fix knet_bench coverity errors Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: f38cb9ff4ce350ed3b173ceb3756d30ee8930f5d https://github.com/kronosnet/kronosnet/commit/f38cb9ff4ce350ed3b173ceb3756d… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-07-23 (Tue, 23 Jul 2019) Changed paths: M libknet/common.c Log Message: ----------- [common] fix dlopen error handling Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: a97b47a330ebd608578d3d5170c6fb13f79b0fe6 https://github.com/kronosnet/kronosnet/commit/a97b47a330ebd608578d3d5170c6f… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-07-23 (Tue, 23 Jul 2019) Changed paths: M libknet/threads_rx.c Log Message: ----------- [rx] better error report if we can't resolve hostname / port Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: d16146d0be641c3250cfef7835446389accdefef https://github.com/kronosnet/kronosnet/commit/d16146d0be641c3250cfef7835446… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-07-23 (Tue, 23 Jul 2019) Changed paths: M libknet/links_acl_ip.c Log Message: ----------- [acl] avoid forward null deferencing Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 566f44fcb2bf2d980fd83b10baffd6ae5f7c4cb9 https://github.com/kronosnet/kronosnet/commit/566f44fcb2bf2d980fd83b10baffd… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-07-23 (Tue, 23 Jul 2019) Changed paths: M libknet/transport_sctp.c Log Message: ----------- [sctp] cleanup bugs detected in error paths by coverity scan Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 1c841a1298fd33e9522a0ae02d3470df034b356c https://github.com/kronosnet/kronosnet/commit/1c841a1298fd33e9522a0ae02d347… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-07-23 (Tue, 23 Jul 2019) Changed paths: M libnozzle/libnozzle.c Log Message: ----------- [nozzle] fix negative return detected by coverity scan Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 4c642d6e17e9805bd48e1b8ed8b9e2c15dc48de7 https://github.com/kronosnet/kronosnet/commit/4c642d6e17e9805bd48e1b8ed8b9e… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-07-23 (Tue, 23 Jul 2019) Changed paths: M libnozzle/libnozzle.c Log Message: ----------- [nozzle] don't leak memory on error Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 68999f9652c3c301e3df7705e6fa6326f5dd38b8 https://github.com/kronosnet/kronosnet/commit/68999f9652c3c301e3df7705e6fa6… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-07-23 (Tue, 23 Jul 2019) Changed paths: M libknet/compress_zstd.c Log Message: ----------- [compress] don't leak memory in case of errors during zstd init Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 29414008d8fb8a95fafd7c4c5ad6615816b3af59 https://github.com/kronosnet/kronosnet/commit/29414008d8fb8a95fafd7c4c5ad66… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-07-23 (Tue, 23 Jul 2019) Changed paths: M libknet/logging.c Log Message: ----------- [logging] make sure not to overrun buffers by pre-allocating them Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: b91ae24b40e024b22a3c99ae3f1a8339dc4b62b0 https://github.com/kronosnet/kronosnet/commit/b91ae24b40e024b22a3c99ae3f1a8… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-07-23 (Tue, 23 Jul 2019) Changed paths: M libknet/compress.c Log Message: ----------- [compress] do not overrun allocated array for compress modules Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 38349d883d0b3139b472da21f06911b363c6d643 https://github.com/kronosnet/kronosnet/commit/38349d883d0b3139b472da21f0691… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-07-23 (Tue, 23 Jul 2019) Changed paths: M .gitignore M Makefile.am M build-aux/check.mk M configure.ac Log Message: ----------- [coverity] add test targets to run coverity automatically Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: c6cc24732396d059bdd07cbe4e45afdf4538a751 https://github.com/kronosnet/kronosnet/commit/c6cc24732396d059bdd07cbe4e45a… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: M libknet/threads_pmtud.c Log Message: ----------- [PMTUd] do not double unlock global read lock Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: a2a0dfc1881745a207a2ce8ff59dca52bfe5aa6b https://github.com/kronosnet/kronosnet/commit/a2a0dfc1881745a207a2ce8ff59dc… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: M libnozzle/internals.h M libnozzle/libnozzle.c Log Message: ----------- [nozzle] avoid tons of possible buffer overruns Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: bdac44c3a7adf2d9f24a6d09ce010bf26fc3f86a https://github.com/kronosnet/kronosnet/commit/bdac44c3a7adf2d9f24a6d09ce010… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: M libknet/tests/test-common.c Log Message: ----------- [test] simplify flush log allocate on stack only once and make sure strings are null terminated drop useless read loop since log msg are always smaller than PAGE_SIZE and read are atomic at that level Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 2a4a1af9a70a5a63b1f8255182383de9efe24a8e https://github.com/kronosnet/kronosnet/commit/2a4a1af9a70a5a63b1f8255182383… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: M libknet/common.c Log Message: ----------- [common] make sure string is null terminated Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: a7d775777aa3d7945c897559ee28ab7d98e5c5db https://github.com/kronosnet/kronosnet/commit/a7d775777aa3d7945c897559ee28a… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: M libknet/threads_tx.c Log Message: ----------- [tx] drop unnecessary usleep when sending to localhost Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: bca3b8a68087885b5ec50a88d873179a053ee92b https://github.com/kronosnet/kronosnet/commit/bca3b8a68087885b5ec50a88d8731… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: M libnozzle/tests/api_nozzle_get_name_by_handle.c M libnozzle/tests/api_nozzle_set_mac.c Log Message: ----------- [nozzle] fix a few coverity errors in the test suite Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 79729ab872f47d8f37ab303ce1ae19b1e7e1ef16 https://github.com/kronosnet/kronosnet/commit/79729ab872f47d8f37ab303ce1ae1… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-07-25 (Thu, 25 Jul 2019) Changed paths: M libknet/internals.h M libknet/threads_tx.c Log Message: ----------- [tx] clean up channel management code for internal communications the code is still not in use but it's more clear and doesn't trigger memory overrun Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 90dcd0970e7c030fb8996aaeeadb7a403043ac2d https://github.com/kronosnet/kronosnet/commit/90dcd0970e7c030fb8996aaeeadb7… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-07-26 (Fri, 26 Jul 2019) Changed paths: M libknet/transport_sctp.c Log Message: ----------- [sctp] retry locking in case of failure Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: b6f7454a98c9376b85d46dd44a2ea1f5dd663d67 https://github.com/kronosnet/kronosnet/commit/b6f7454a98c9376b85d46dd44a2ea… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-07-26 (Fri, 26 Jul 2019) Changed paths: M .gitignore M Makefile.am M build-aux/check.mk M configure.ac M libknet/common.c M libknet/compress.c M libknet/compress_zstd.c M libknet/handle.c M libknet/internals.h M libknet/links_acl_ip.c M libknet/logging.c M libknet/tests/knet_bench.c M libknet/tests/test-common.c M libknet/threads_pmtud.c M libknet/threads_rx.c M libknet/threads_tx.c M libknet/transport_sctp.c M libnozzle/internals.h M libnozzle/libnozzle.c M libnozzle/tests/api_nozzle_get_name_by_handle.c M libnozzle/tests/api_nozzle_set_mac.c Log Message: ----------- Merge pull request #240 from kronosnet/cov-scan coverity scan fixes Compare: https://github.com/kronosnet/kronosnet/compare/9208534014e7...b6f7454a98c9