Commits

commits@lists.kronosnet.org

1 participants
39425 discussions

[kronosnet/kronosnet] 6d1625: [build] workaround memory alignment bug in nss in ...
by GitHub 15 Nov '17

15 Nov '17

Branch: refs/heads/master Home: https://github.com/kronosnet/kronosnet Commit: 6d1625538adedb911d47e6b2047573ee85780b2c https://github.com/kronosnet/kronosnet/commit/6d1625538adedb911d47e6b204757… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2017-11-15 (Wed, 15 Nov 2017) Changed paths: M build-aux/check.mk Log Message: ----------- [build] workaround memory alignment bug in nss in combination with valgrind on Linux/i386 Over the past few weeks, we noticed CI failing on i386 when running make check-memcheck (test suite executed with valgring). Those failures were not consistent and sometime random. After some heavy debugging it turns out that those failures are a combination of libnss3 internal memory allocator bug and valgrind internal memory allocator. Current libnss3 memory allocator expects a 16 bytes memory aligned buffer and in the event the memory is not aligned, it would round it. The issue is that, in performing this rounding, nss does not track properly the original address of the memory, and the equivalent of subsequent free of this buffer would fail, leaking memory and potentially accessing memory not allocated or corrpting memory. The nss bug is already fixed upstream by commit: changeset: 13557:52e38f913220 Valgrind on Linux/i386 memory allocator can return memory that is not aligned to the 16 bytes, contrary to what malloc/glibc does. Valgrind was returning (somehow randomly) a non aligned buffer to nss triggering the nss bug and the leak. By forcing valgrind to use aligned memory, nss bug does not trigger and there is no memory leak during the execution of the test suite. The memory leak never triggered when running knet in normal conditions. Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: bc519d4a4a5f7c9a6cadae0453f15cc2ff432960 https://github.com/kronosnet/kronosnet/commit/bc519d4a4a5f7c9a6cadae0453f15… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2017-11-15 (Wed, 15 Nov 2017) Changed paths: M build-aux/check.mk Log Message: ----------- Merge pull request #88 from kronosnet/nss-workaround [build] workaround memory alignment bug in nss in combination with va… Compare: https://github.com/kronosnet/kronosnet/compare/8156886888aa...bc519d4a4a5f

1 0

knet-build-all-voting - Build # 131 - Failure!
by jenkins＠kronosnet.org 15 Nov '17

15 Nov '17

knet-build-all-voting - Build # 131 - Failure: Check console output at https://ci.kronosnet.org/job/knet-build-all-voting/131/ to view the results.

1 0

[kronosnet/kronosnet] 6d1625: [build] workaround memory alignment bug in nss in ...
by GitHub 15 Nov '17

15 Nov '17

Branch: refs/heads/nss-workaround Home: https://github.com/kronosnet/kronosnet Commit: 6d1625538adedb911d47e6b2047573ee85780b2c https://github.com/kronosnet/kronosnet/commit/6d1625538adedb911d47e6b204757… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2017-11-15 (Wed, 15 Nov 2017) Changed paths: M build-aux/check.mk Log Message: ----------- [build] workaround memory alignment bug in nss in combination with valgrind on Linux/i386 Over the past few weeks, we noticed CI failing on i386 when running make check-memcheck (test suite executed with valgring). Those failures were not consistent and sometime random. After some heavy debugging it turns out that those failures are a combination of libnss3 internal memory allocator bug and valgrind internal memory allocator. Current libnss3 memory allocator expects a 16 bytes memory aligned buffer and in the event the memory is not aligned, it would round it. The issue is that, in performing this rounding, nss does not track properly the original address of the memory, and the equivalent of subsequent free of this buffer would fail, leaking memory and potentially accessing memory not allocated or corrpting memory. The nss bug is already fixed upstream by commit: changeset: 13557:52e38f913220 Valgrind on Linux/i386 memory allocator can return memory that is not aligned to the 16 bytes, contrary to what malloc/glibc does. Valgrind was returning (somehow randomly) a non aligned buffer to nss triggering the nss bug and the leak. By forcing valgrind to use aligned memory, nss bug does not trigger and there is no memory leak during the execution of the test suite. The memory leak never triggered when running knet in normal conditions. Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>

1 0

[kronosnet/kronosnet]
by GitHub 15 Nov '17

15 Nov '17

Branch: refs/heads/test-nss-leak Home: https://github.com/kronosnet/kronosnet

1 0

[kronosnet/kronosnet]
by GitHub 15 Nov '17

15 Nov '17

Branch: refs/heads/nss-workaround Home: https://github.com/kronosnet/kronosnet

1 0

knet-build-all-nonvoting - Build # 26 - Still Failing!
by jenkins＠kronosnet.org 15 Nov '17

15 Nov '17

knet-build-all-nonvoting - Build # 26 - Still Failing: Check console output at https://ci.kronosnet.org/job/knet-build-all-nonvoting/26/ to view the results.

1 81

[kronosnet/kronosnet]
by GitHub 14 Nov '17

14 Nov '17

Branch: refs/heads/pthread Home: https://github.com/kronosnet/kronosnet

1 0

[kronosnet/kronosnet] 2b1072: build: adopt ax_pthread.m4 to provide all necessar...
by GitHub 14 Nov '17

14 Nov '17

Branch: refs/heads/master Home: https://github.com/kronosnet/kronosnet Commit: 2b1072db76d0dba1b03999467fd278fac09976b0 https://github.com/kronosnet/kronosnet/commit/2b1072db76d0dba1b03999467fd27… Author: Ferenc Wágner <wferi(a)debian.org> Date: 2017-11-14 (Tue, 14 Nov 2017) Changed paths: M .gitignore M Makefile.am M autogen.sh M configure.ac M libknet/Makefile.am M libknet/tests/Makefile.am M libtap/Makefile.am A m4/ax_pthread.m4 Log Message: ----------- build: adopt ax_pthread.m4 to provide all necessary flags Previously we only linked with -lpthread, but for example the -pthread GCC option provides a CPP define as well. Commit: 8156886888aa40e5d325e7bdd56a1697843cc78c https://github.com/kronosnet/kronosnet/commit/8156886888aa40e5d325e7bdd56a1… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2017-11-14 (Tue, 14 Nov 2017) Changed paths: M .gitignore M Makefile.am M autogen.sh M configure.ac M libknet/Makefile.am M libknet/tests/Makefile.am M libtap/Makefile.am A m4/ax_pthread.m4 Log Message: ----------- Merge pull request #86 from kronosnet/pthread build: adopt ax_pthread.m4 to provide all necessary flags Compare: https://github.com/kronosnet/kronosnet/compare/0b4bfc6f1dca...8156886888aa

1 0

knet-build-all-voting - Build # 125 - Failure!
by jenkins＠kronosnet.org 14 Nov '17

14 Nov '17

knet-build-all-voting - Build # 125 - Failure: Check console output at https://ci.kronosnet.org/job/knet-build-all-voting/125/ to view the results.

1 0

[kronosnet/kronosnet] 2b1072: build: adopt ax_pthread.m4 to provide all necessar...
by GitHub 14 Nov '17

14 Nov '17

Branch: refs/heads/pthread Home: https://github.com/kronosnet/kronosnet Commit: 2b1072db76d0dba1b03999467fd278fac09976b0 https://github.com/kronosnet/kronosnet/commit/2b1072db76d0dba1b03999467fd27… Author: Ferenc Wágner <wferi(a)debian.org> Date: 2017-11-14 (Tue, 14 Nov 2017) Changed paths: M .gitignore M Makefile.am M autogen.sh M configure.ac M libknet/Makefile.am M libknet/tests/Makefile.am M libtap/Makefile.am A m4/ax_pthread.m4 Log Message: ----------- build: adopt ax_pthread.m4 to provide all necessary flags Previously we only linked with -lpthread, but for example the -pthread GCC option provides a CPP define as well.

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Commits