Commits

commits@lists.kronosnet.org

2 participants
33708 discussions

[kronosnet/kronosnet] 49ef95: [crypto] Try crypt and decrypt on crypto_init
by Jan Friesse 14 Aug '23

14 Aug '23

Branch: refs/heads/stable1-proposed Home: https://github.com/kronosnet/kronosnet Commit: 49ef95aea3bb5a223ec12c2e33e855c8948c0204 https://github.com/kronosnet/kronosnet/commit/49ef95aea3bb5a223ec12c2e33e85… Author: Jan Friesse <jfriesse(a)redhat.com> Date: 2023-08-14 (Mon, 14 Aug 2023) Changed paths: M libknet/crypto.c Log Message: ----------- [crypto] Try crypt and decrypt on crypto_init Crypt (or decrypt) operation might fail in some cases even when initialization succeeded. This problem is known to happen when FIPS mode is enabled and combination of openssl/aes192 and md5 is used. This was not caught during crypto_init so knet user (corosync) was not aware of non-working crypto so it couldn't handle it - and couldn't send/receive any packets. Solution is to try crypt, decrypt and compare of result buffer right after new crypto_instance is created. If any of these operation fails, whole crypto_init fails, crypto_instance is freed and knet user is notified by receiving non-zero return code. Signed-off-by: Jan Friesse <jfriesse(a)redhat.com>

1 0

[kronosnet/kronosnet] ec10e5: [crypto] Try crypt and decrypt on crypto_init
by Fabio M. Di Nitto 14 Aug '23

14 Aug '23

Branch: refs/heads/main Home: https://github.com/kronosnet/kronosnet Commit: ec10e550a09cfd30ce5e94ecde041a31f871e204 https://github.com/kronosnet/kronosnet/commit/ec10e550a09cfd30ce5e94ecde041… Author: Jan Friesse <jfriesse(a)redhat.com> Date: 2023-08-14 (Mon, 14 Aug 2023) Changed paths: M libknet/crypto.c Log Message: ----------- [crypto] Try crypt and decrypt on crypto_init Crypt (or decrypt) operation might fail in some cases even when initialization succeeded. This problem is known to happen when FIPS mode is enabled and combination of openssl/aes192 and md5 is used. This was not caught during crypto_init so knet user (corosync) was not aware of non-working crypto so it couldn't handle it - and couldn't send/receive any packets. Solution is to try crypt, decrypt and compare of result buffer right after new crypto_instance is created. If any of these operation fails, whole crypto_init fails, crypto_instance is freed and knet user is notified by receiving non-zero return code. Signed-off-by: Jan Friesse <jfriesse(a)redhat.com> Commit: 31cec7382f20b5bdd7fa22c0cc9eaa0f4526de4f https://github.com/kronosnet/kronosnet/commit/31cec7382f20b5bdd7fa22c0cc9ea… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2023-08-14 (Mon, 14 Aug 2023) Changed paths: M libknet/crypto.c Log Message: ----------- Merge pull request #412 from jfriesse/try_encrypt_on_crypto_init [crypto] Try crypt and decrypt on crypto_init Compare: https://github.com/kronosnet/kronosnet/compare/683d10883622...31cec7382f20

1 0

[jenkins] kronosnet PR-412 (build 1) completed with state: failure
by jenkins＠kronosnet.org 14 Aug '23

14 Aug '23

0 Non-voting fails total runtime = 1 hr 18 min See https://ci.kronosnet.org/job/kronosnet/job/kronosnet-pipeline/job/PR-412/1/…

1 2

[jenkins] libqb PR-491 (build 24) succeeded
by jenkins＠kronosnet.org 14 Aug '23

14 Aug '23

total runtime: 37 min Split logs: https://ci.kronosnet.org/job/libqb/job/libqb-pipeline/job/PR-491/24/artifac… Full log: https://ci.kronosnet.org/job/libqb/job/libqb-pipeline/job/PR-491/24/console…

1 0

[jenkins][cidev] ci-test PR-42 (build 7) succeeded but with 1/1 non-voting fail
by jenkins＠kronosnet.org 14 Aug '23

14 Aug '23

failed job: built-in(nonvoting-clang: org.jenkinsci.plugins.workflow.steps.FlowInterruptedException) debian12-ci-test-x86-64(nonvoting) built-in(nonvoting: java.lang.IllegalStateException: Can't send a remote FilePath to a different remote channel (current=hudson.remoting.Channel@53506543:debian12-ci-test-x86-64, target=hudson.remoting.Channel@30058ad6:debian12-ci-test-x86-64)) total runtime: 10 min Split logs: https://ci.kronosnet.org/job/ci-test-github/job/ci-test-pipeline/job/PR-42/… Full log: https://ci.kronosnet.org/job/ci-test-github/job/ci-test-pipeline/job/PR-42/…

1 0

[jenkins][cidev] ci-test PR-42 (build 6) succeeded
by jenkins＠kronosnet.org 14 Aug '23

14 Aug '23

total runtime: 20 sec Split logs: https://ci.kronosnet.org/job/ci-test-github/job/ci-test-pipeline/job/PR-42/… Full log: https://ci.kronosnet.org/job/ci-test-github/job/ci-test-pipeline/job/PR-42/…

1 0

[jenkins] pcs-functional-testing osp rhel9 zstream: no upstream: next-stable tests: all (build 13) completed with state: completed
by jenkins＠kronosnet.org 14 Aug '23

14 Aug '23

0/0 Non-voting fails null 0/0 Voting fails null total runtime: 1 min 55 sec Split logs: https://ci.kronosnet.org/job/pcs/job/pcs-functional-testing/13/artifact/ Full log: https://ci.kronosnet.org/job/pcs/job/pcs-functional-testing/13/consoleText/

1 0

[jenkins][cidev] ci-test PR-42 (build 5) succeeded
by jenkins＠kronosnet.org 14 Aug '23

14 Aug '23

total runtime: 19 sec Split logs: https://ci.kronosnet.org/job/ci-test-github/job/ci-test-pipeline/job/PR-42/… Full log: https://ci.kronosnet.org/job/ci-test-github/job/ci-test-pipeline/job/PR-42/…

1 0

[jenkins][cidev] ci-test PR-42 (build 4) succeeded
by jenkins＠kronosnet.org 14 Aug '23

14 Aug '23

1 0

[jenkins][cidev] ci-test PR-42 (build 3) succeeded
by jenkins＠kronosnet.org 14 Aug '23

14 Aug '23

total runtime: 19 sec parallel error caught: {groovy.lang.MissingPropertyException: No such property: locals for class: runStage} Split logs: https://ci.kronosnet.org/job/ci-test-github/job/ci-test-pipeline/job/PR-42/… Full log: https://ci.kronosnet.org/job/ci-test-github/job/ci-test-pipeline/job/PR-42/…

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Commits