Commits

commits@lists.kronosnet.org

2 participants
43304 discussions

[kronosnet/kronosnet] 5d3947: libknet: improve OpenSSL error logging to print en...
by Fabio M. Di Nitto 24 Apr '26

24 Apr '26

Branch: refs/heads/improve-openssl-error-logging Home: https://github.com/kronosnet/kronosnet Commit: 5d394724324ab9dd59d4ad408d12c73ee77876c2 https://github.com/kronosnet/kronosnet/commit/5d394724324ab9dd59d4ad408d12c… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2026-04-24 (Fri, 24 Apr 2026) Changed paths: M libknet/crypto_openssl.c Log Message: ----------- libknet: improve OpenSSL error logging to print entire error stack Fixes #456 The OpenSSL crypto module previously used ERR_error_string_n(ERR_get_error()) which only retrieved and logged the first error from OpenSSL's error queue. When multiple errors occur, they are all pushed onto the error stack, and only logging the first error can make debugging difficult. This patch introduces a new helper function log_openssl_errors() that: - Iterates through the entire OpenSSL error stack using ERR_get_error() in a loop until it returns 0 - Formats each error using ERR_error_string_n() - Logs each error at the appropriate level (ERR or DEBUG) - Marks subsequent errors with "additional error:" prefix for clarity - Automatically clears the error stack after logging All error reporting call sites have been updated to use this helper, eliminating local sslerr buffers that are no longer needed. Benefits: - Complete error context: All errors in the stack are now visible - Better debugging: Easier to diagnose complex OpenSSL failures - Cleaner code: Removes repetitive error handling boilerplate Reported-by: Dmitry Belyavskiy <beldmit(a)gmail.com> Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org> Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/kronosnet/kronosnet/settings/notifications

1 0

[jenkins] pcs main (build 453) success
by jenkins＠kronosnet.org 24 Apr '26

24 Apr '26

Run reason: Started by upstream project "global/all-weekly" build number 41 Total runtime: 7 hr 24 min Split logs: https://ci.kronosnet.org/job/pcs/job/pcs-pipeline/job/main/453/artifact/ Full log: https://ci.kronosnet.org/job/pcs/job/pcs-pipeline/job/main/453/consoleText

1 0

[jenkins] fence-agents main (build 250) success
by jenkins＠kronosnet.org 24 Apr '26

24 Apr '26

Run reason: Started by upstream project "global/all-weekly" build number 41 Total runtime: 6 hr 57 min Split logs: https://ci.kronosnet.org/job/fence-agents/job/fence-agents-pipeline/job/mai… Full log: https://ci.kronosnet.org/job/fence-agents/job/fence-agents-pipeline/job/mai…

1 0

[jenkins] dlm main (build 239) success
by jenkins＠kronosnet.org 24 Apr '26

24 Apr '26

Run reason: Started by upstream project "global/all-weekly" build number 41 Total runtime: 6 hr 38 min Split logs: https://ci.kronosnet.org/job/dlm/job/dlm-pipeline/239/artifact/ Full log: https://ci.kronosnet.org/job/dlm/job/dlm-pipeline/239/consoleText

1 0

[jenkins] libqb main (build 259) completed with state: failure
by jenkins＠kronosnet.org 24 Apr '26

24 Apr '26

2/43 Non-voting fails: openindiana-x86-64(nonvoting: Setup source) openindiana-x86-64(nonvoting-clang: Setup source) 2/45 Voting fails: freebsd-15-x86-64(voting: Run tests) centos-9-s390x(voting: Run tests) Run reason: Started by upstream project "global/all-weekly" build number 41 Total runtime: 5 hr 30 min Split logs: https://ci.kronosnet.org/job/libqb/job/libqb-pipeline/job/main/259/artifact/ Full log: https://ci.kronosnet.org/job/libqb/job/libqb-pipeline/job/main/259/consoleT… Failed logs: https://ci.kronosnet.org/job/libqb/job/libqb-pipeline/job/main/259/artifact… https://ci.kronosnet.org/job/libqb/job/libqb-pipeline/job/main/259/artifact… https://ci.kronosnet.org/job/libqb/job/libqb-pipeline/job/main/259/artifact… https://ci.kronosnet.org/job/libqb/job/libqb-pipeline/job/main/259/artifact…

1 0

[jenkins] gfs2-utils main (build 250) succeeded but with 2/36 non-voting fails
by jenkins＠kronosnet.org 24 Apr '26

24 Apr '26

Failed jobs: alpine-x86-64(nonvoting: Build source) alpine-x86-64(nonvoting-clang: Build source) Run reason: Started by upstream project "global/all-weekly" build number 41 Total runtime: 5 hr 23 min Split logs: https://ci.kronosnet.org/job/gfs2-utils/job/gfs2-utils-pipeline/250/artifac… Full log: https://ci.kronosnet.org/job/gfs2-utils/job/gfs2-utils-pipeline/250/console… Failed logs: https://ci.kronosnet.org/job/gfs2-utils/job/gfs2-utils-pipeline/250/artifac… https://ci.kronosnet.org/job/gfs2-utils/job/gfs2-utils-pipeline/250/artifac…

1 0

[jenkins] resource-agents main (build 385) success
by jenkins＠kronosnet.org 24 Apr '26

24 Apr '26

Run reason: Started by upstream project "global/all-weekly" build number 41 Total runtime: 5 hr 23 min Split logs: https://ci.kronosnet.org/job/resource-agents/job/resource-agents-pipeline/j… Full log: https://ci.kronosnet.org/job/resource-agents/job/resource-agents-pipeline/j…

1 0

[jenkins] pcs pcs-0.11 (build 226) succeeded but with 1/7 non-voting fail
by jenkins＠kronosnet.org 24 Apr '26

24 Apr '26

Failed job: alpine-x86-64(nonvoting: Setup source) Run reason: Started by upstream project "global/all-weekly" build number 41 Total runtime: 4 hr 25 min Split logs: https://ci.kronosnet.org/job/pcs/job/pcs-pipeline/job/pcs-0.11/226/artifact/ Full log: https://ci.kronosnet.org/job/pcs/job/pcs-pipeline/job/pcs-0.11/226/consoleT… Failed logs: https://ci.kronosnet.org/job/pcs/job/pcs-pipeline/job/pcs-0.11/226/artifact…

1 0

[jenkins] corosync-qdevice main (build 192) success
by jenkins＠kronosnet.org 24 Apr '26

24 Apr '26

Run reason: Started by upstream project "global/all-weekly" build number 41 Total runtime: 3 hr 34 min Split logs: https://ci.kronosnet.org/job/corosync-qdevice/job/corosync-qdevice-pipeline… Full log: https://ci.kronosnet.org/job/corosync-qdevice/job/corosync-qdevice-pipeline…

1 0

[jenkins] pcs pcs-0.10 (build 189) success
by jenkins＠kronosnet.org 24 Apr '26

24 Apr '26

Run reason: Started by upstream project "global/all-weekly" build number 41 Total runtime: 1 hr 16 min Split logs: https://ci.kronosnet.org/job/pcs/job/pcs-pipeline/job/pcs-0.10/189/artifact/ Full log: https://ci.kronosnet.org/job/pcs/job/pcs-pipeline/job/pcs-0.10/189/consoleT…

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Commits