Branch: refs/heads/stable1-proposed
Home: https://github.com/kronosnet/kronosnet
Commit: 8ca310a7964cde3972a1be92d504081a5d1cc299
https://github.com/kronosnet/kronosnet/commit/8ca310a7964cde3972a1be92d5040…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2026-04-25 (Sat, 25 Apr 2026)
Changed paths:
M libknet/crypto_openssl.c
Log Message:
-----------
libknet: improve OpenSSL error logging to print entire error stack
Fixes #456
The OpenSSL crypto module previously used ERR_error_string_n(ERR_get_error())
which only retrieved and logged the first error from OpenSSL's error queue.
When multiple errors occur, they are all pushed onto the error stack, and
only logging the first error can make debugging difficult.
This patch introduces a new helper function log_openssl_errors() that:
- Iterates through the entire OpenSSL error stack using ERR_get_error()
in a loop until it returns 0
- Formats each error using ERR_error_string_n()
- Logs each error at the appropriate level (ERR or DEBUG)
- Marks subsequent errors with "additional error:" prefix for clarity
- Automatically clears the error stack after logging
All error reporting call sites have been updated to use this helper,
eliminating local sslerr buffers that are no longer needed.
Benefits:
- Complete error context: All errors in the stack are now visible
- Better debugging: Easier to diagnose complex OpenSSL failures
- Cleaner code: Removes repetitive error handling boilerplate
Reported-by: Dmitry Belyavskiy <beldmit(a)gmail.com>
Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org>
Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com>
To unsubscribe from these emails, change your notification settings at https://github.com/kronosnet/kronosnet/settings/notifications
Branch: refs/heads/main
Home: https://github.com/kronosnet/kronosnet
Commit: 5d394724324ab9dd59d4ad408d12c73ee77876c2
https://github.com/kronosnet/kronosnet/commit/5d394724324ab9dd59d4ad408d12c…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2026-04-24 (Fri, 24 Apr 2026)
Changed paths:
M libknet/crypto_openssl.c
Log Message:
-----------
libknet: improve OpenSSL error logging to print entire error stack
Fixes #456
The OpenSSL crypto module previously used ERR_error_string_n(ERR_get_error())
which only retrieved and logged the first error from OpenSSL's error queue.
When multiple errors occur, they are all pushed onto the error stack, and
only logging the first error can make debugging difficult.
This patch introduces a new helper function log_openssl_errors() that:
- Iterates through the entire OpenSSL error stack using ERR_get_error()
in a loop until it returns 0
- Formats each error using ERR_error_string_n()
- Logs each error at the appropriate level (ERR or DEBUG)
- Marks subsequent errors with "additional error:" prefix for clarity
- Automatically clears the error stack after logging
All error reporting call sites have been updated to use this helper,
eliminating local sslerr buffers that are no longer needed.
Benefits:
- Complete error context: All errors in the stack are now visible
- Better debugging: Easier to diagnose complex OpenSSL failures
- Cleaner code: Removes repetitive error handling boilerplate
Reported-by: Dmitry Belyavskiy <beldmit(a)gmail.com>
Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org>
Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com>
Commit: 602320f4c32a94dc83b7b1f2cd701d398c9de7ce
https://github.com/kronosnet/kronosnet/commit/602320f4c32a94dc83b7b1f2cd701…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2026-04-25 (Sat, 25 Apr 2026)
Changed paths:
M libknet/crypto_openssl.c
Log Message:
-----------
Merge pull request #475 from kronosnet/improve-openssl-error-logging
libknet: improve OpenSSL error logging to print entire error stack
Compare: https://github.com/kronosnet/kronosnet/compare/fae0a1c5b65d...602320f4c32a
To unsubscribe from these emails, change your notification settings at https://github.com/kronosnet/kronosnet/settings/notifications
34/43 Non-voting fails: openindiana-x86-64(nonvoting: Setup source) openindiana-x86-64(nonvoting-clang: Setup source) rhel-8-power9-ppc64le(nonvoting-clang: Build source) rhel-8-x86-64(nonvoting-clang: Build source) rhel-8-s390x(nonvoting-clang: Build source) fedora-43-s390x(nonvoting-clang: Run tests) centos-10-s390x(nonvoting-clang: Run tests) ubuntu-22-04-lts-x86-64(nonvoting-clang: Run tests) debian-12-x86-64(nonvoting-clang: Run tests) rhel-9-s390x(nonvoting-clang: Run tests) rhel-10-s390x(nonvoting-clang: Run tests) fedora-rawhide-s390x(nonvoting-clang: Run tests) rhel-10-power9-ppc64le(nonvoting-clang: Run tests) rhel-9-x86-64(nonvoting-clang: Run tests) centos-9-x86-64(nonvoting-clang: Run tests) centos-9-s390x(nonvoting-clang: Run tests) ubuntu-24-04-lts-x86-64(nonvoting-clang: Run tests) debian-13-x86-64(nonvoting-clang: Run tests) debian-testing-x86-64(nonvoting-clang: Run tests) debian-unstable-x86-64(nonvoting-clang: Run tests) centos-10-x86-64(nonvoting-clang: Run tests) ubuntu-25-10-x86-64(nonvoting-clang: Run tests) rhel-10-x86-64(nonvoting-clang: Run tests) ubuntu-devel-x86-64(nonvoting-clang: Run tests) alpine-x86-64(nonvoting-clang: Run tests) freebsd-15-x86-64(nonvoting-clang: Run tests) freebsd-14-x86-64(nonvoting-clang: Run tests) freebsd-devel-x86-64(nonvoting-clang: Run tests) freebsd-13-x86-64(nonvoting-clang: Run tests) fedora-rawhide-x86-64(nonvoting-clang: Run tests) fedora-43-x86-64(nonvoting-clang: Run tests) fedora-42-x86-64(nonvoting-clang: Run tests) fedora-rawhide-power9-ppc64le(nonvoting-clang: Run tests) fedora-43-power9-ppc64le(nonvoting-clang: Run tests)
6/45 Voting fails: rhel-8-x86-64(voting: Build source) rhel-8-power9-ppc64le(voting: Build source) rhel-8-s390x(voting: Build source) rhel-8-s390x(buildrpms: Build source) rhel-8-power9-ppc64le(buildrpms: Build source) rhel-8-x86-64(buildrpms: Build source)
Run reason: Pull request #513 opened
Total runtime: 4 hr 5 min
Split logs: https://ci.kronosnet.org/job/libqb/job/libqb-pipeline/job/PR-513/1/artifact/
Full log: https://ci.kronosnet.org/job/libqb/job/libqb-pipeline/job/PR-513/1/consoleT…