Commits

commits@lists.kronosnet.org

1 participants
19590 discussions

[kronosnet/kronosnet] eb2e84: [PMTUd] rework the whole math to calculate MTU

by Fabio M. Di Nitto

Branch: refs/heads/pmtud-fixes Home: https://github.com/kronosnet/kronosnet Commit: eb2e847ca2361fb9bb52b9859be0eca4f3683860 https://github.com/kronosnet/kronosnet/commit/eb2e847ca2361fb9bb52b9859be0e… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-12 (Mon, 12 Aug 2019) Changed paths: M libknet/Makefile.am M libknet/crypto.c M libknet/crypto_model.h M libknet/crypto_nss.c M libknet/crypto_openssl.c M libknet/internals.h M libknet/links.c A libknet/onwire.c M libknet/onwire.h M libknet/tests/Makefile.am A libknet/tests/fun_pmtud_crypto.c M libknet/threads_common.c M libknet/threads_pmtud.c Log Message: ----------- [PMTUd] rework the whole math to calculate MTU internal changes: - drop the concept of sec_header_size that was completely wrong and unnecessary - bump crypto API to version 3 due to the above change - clarify the difference between link->proto_overhead and link->status->proto_overhead. We cannot rename the status one as it would also change ABI. - add onwire.c with documentation on the packet format and what various len(s) mean in context. - add 3 new functions to calculate MTUs back and forth and use them around, hopefully with enough clarification on why things are done in a given way. - heavily change thread_pmtud.c to use those new facilities. - fix major calculation issues when using crypto (non-crypto was not affected by the problem). - fix checks around to make sure they match the new math. - fix padding calculation. - add functional PMTUd crypto test this test can take several hours (12+) and should be executed on a controlled environment since it automatically changes loopback MTU to run tests. - fix way the lowest MTU is calculated during a PMTUd run to avoid spurious double notifications. user visible changes: - Global MTU is now calculated properly when using crypto and values will be in general bigger than before due to incorrect padding calculation in the previous implementation. Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>

5 years, 1 month

knet-build-all-nonvoting - Build # 1195 - Failure!

by jenkins＠kronosnet.org

knet-build-all-nonvoting - Build # 1195 - Failure: Check console output at https://ci.kronosnet.org/job/knet-build-all-nonvoting/1195/ to view the results.

5 years, 1 month

[kronosnet/kronosnet]

by kronosnet CI bot

Branch: refs/heads/coverity_scan Home: https://github.com/kronosnet/kronosnet

5 years, 1 month

[kronosnet/kronosnet] 77aa52: [PMTUd] rework the whole math to calculate MTU

by Fabio M. Di Nitto

Branch: refs/heads/pmtud-fixes Home: https://github.com/kronosnet/kronosnet Commit: 77aa525da66c13d61fcf7c2a35df584c50d546ba https://github.com/kronosnet/kronosnet/commit/77aa525da66c13d61fcf7c2a35df5… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-12 (Mon, 12 Aug 2019) Changed paths: M libknet/Makefile.am M libknet/crypto.c M libknet/crypto_model.h M libknet/crypto_nss.c M libknet/crypto_openssl.c M libknet/internals.h M libknet/links.c A libknet/onwire.c M libknet/onwire.h M libknet/tests/Makefile.am A libknet/tests/fun_pmtud_crypto.c M libknet/threads_common.c M libknet/threads_pmtud.c Log Message: ----------- [PMTUd] rework the whole math to calculate MTU internal changes: - drop the concept of sec_header_size that was completely wrong and unnecessary - bump crypto API to version 3 due to the above change - clarify the difference between link->proto_overhead and link->status->proto_overhead. We cannot rename the status one as it would also change ABI. - add onwire.c with documentation on the packet format and what various len(s) mean in context. - add 3 new functions to calculate MTUs back and forth and use them around, hopefully with enough clarification on why things are done in a given way. - heavily change thread_pmtud.c to use those new facilities. - fix major calculation issues when using crypto (non-crypto was not affected by the problem). - fix checks around to make sure they match the new math. - fix padding calculation. - add functional PMTUd crypto test this test can take several hours (12+) and should be executed on a controlled environment since it automatically changes loopback MTU to run tests. user visible changes: - Global MTU is now calculated properly when using crypto and values will be in general bigger than before due to incorrect padding calculation in the previous implementation. Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>

5 years, 1 month

knet-build-all-voting - Build # 1384 - Failure!

by jenkins＠kronosnet.org

knet-build-all-voting - Build # 1384 - Failure: Check console output at https://ci.kronosnet.org/job/knet-build-all-voting/1384/ to view the results.

5 years, 1 month

knet-build-all-nonvoting - Build # 1193 - Failure!

by jenkins＠kronosnet.org

knet-build-all-nonvoting - Build # 1193 - Failure: Check console output at https://ci.kronosnet.org/job/knet-build-all-nonvoting/1193/ to view the results.

5 years, 1 month

knet-build-covscan - Build # 28 - Failure!

by jenkins＠kronosnet.org

knet-build-covscan - Build # 28 - Failure: Check console output at https://ci.kronosnet.org/job/knet-build-covscan/28/ to view the results.

5 years, 1 month

[kronosnet/kronosnet]

by kronosnet CI bot

Branch: refs/heads/coverity_scan Home: https://github.com/kronosnet/kronosnet

5 years, 1 month

[kronosnet/kronosnet] db9d25: [tests] add functional PMTUd crypto test

by Fabio M. Di Nitto

Branch: refs/heads/pmtud-fixes Home: https://github.com/kronosnet/kronosnet Commit: db9d2562d8c753159ae72f4b850974969767a53a https://github.com/kronosnet/kronosnet/commit/db9d2562d8c753159ae72f4b85097… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-08-10 (Sat, 10 Aug 2019) Changed paths: M libknet/tests/Makefile.am A libknet/tests/fun_pmtud_crypto.c Log Message: ----------- [tests] add functional PMTUd crypto test this test can take several hours and should be executed on a controlled environment since it automatically changes loopback MTU to run tests. Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>

5 years, 1 month

knet-build-all-voting - Build # 1382 - Failure!

by jenkins＠kronosnet.org

knet-build-all-voting - Build # 1382 - Failure: Check console output at https://ci.kronosnet.org/job/knet-build-all-voting/1382/ to view the results.

5 years, 1 month

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Commits