Branch: refs/heads/copyright-updates-incomplete
Home: https://github.com/kronosnet/kronosnet
Commit: 0374dcd237b628caabd2590fdaad7fb10b2b6f9f
https://github.com/kronosnet/kronosnet/commit/0374dcd237b628caabd2590fdaad7…
Author: google-labs-jules[bot] <161369871+google-labs-jules[bot](a)users.noreply.github.com>
Date: 2025-06-05 (Thu, 05 Jun 2025)
Changed paths:
M configure.ac
M libknet/bindings/Makefile.am
A libknet/bindings/python/Makefile.am
A libknet/bindings/python/_knet.c
A libknet/bindings/python/tests/__init__.py
A libknet/bindings/python/tests/test_knet.py
M libnozzle/bindings/Makefile.am
A libnozzle/bindings/python/Makefile.am
A libnozzle/bindings/python/_nozzle.c
A libnozzle/bindings/python/tests/__init__.py
A libnozzle/bindings/python/tests/test_nozzle.py
Log Message:
-----------
Add copyright headers to Python binding files (partial)
This commit adds or updates copyright headers for several files
related to the new Python bindings. The year is set to 2025,
and "Jules <jules(a)google.com> (Google AI Agent)" is added as an
author. The license is GPL-2.0+.
Files updated so far:
- configure.ac (author added, year confirmed)
- libnozzle/bindings/python/Makefile.am (year updated, author added)
- libnozzle/bindings/python/_nozzle.c (new header added)
- libnozzle/bindings/python/tests/__init__.py (new one-line header)
- libnozzle/bindings/python/tests/test_nozzle.py (new header, corrected position after shebang)
- libknet/bindings/python/Makefile.am (year updated, author added)
- libknet/bindings/python/_knet.c (new header added)
- libknet/bindings/python/tests/__init__.py (new one-line header)
I was interrupted before completing updates for all planned files.
Specifically, `libknet/bindings/python/tests/test_knet.py` still
needs its copyright header added.
Throughout this task, I've been unable to run any build commands
(autogen.sh, configure, make) due to persistent internal errors.
This has prevented any compilation or testing of the bindings
and their integration into the build system. The changes made
are based on static analysis of the codebase and adherence to
existing patterns.
To unsubscribe from these emails, change your notification settings at https://github.com/kronosnet/kronosnet/settings/notifications
Branch: refs/heads/reformat-style-guide-copyright
Home: https://github.com/kronosnet/kronosnet
Commit: 37490792ac81877bda2c5b0c8bab6e554a3a2f31
https://github.com/kronosnet/kronosnet/commit/37490792ac81877bda2c5b0c8bab6…
Author: google-labs-jules[bot] <161369871+google-labs-jules[bot](a)users.noreply.github.com>
Date: 2025-06-04 (Wed, 04 Jun 2025)
Changed paths:
A STYLE_GUIDE.md
Log Message:
-----------
Create and refine STYLE_GUIDE.md for project contributions
This commit introduces STYLE_GUIDE.md, a comprehensive document
outlining coding standards and best practices for the Kronosnet project.
This guide aims to ensure consistency and clarity in contributions.
The following key areas are covered:
1. **C Language Style**:
* Minimum Dialect: C99.
* Indentation: Tabs (not spaces).
* Curly Braces:
* Control flow (if, for, while): Opening brace on the same line.
* Function definitions: Opening brace on the next line.
* Always use braces, even for single-line blocks.
* Variable Declaration: At the beginning of their scope.
* Line Length: Preferred maximum of 120 characters, flexible for
readability (e.g., nested structs).
2. **Naming Conventions**:
* General: `snake_case` for internal variables and function names.
* Public API Elements:
* `knet_` or `nozzle_` prefix for functions, structs, typedefs
(e.g., `knet_get_host_list`, `nozzle_device_config`).
* `KNET_` or `NOZZLE_` prefix for enums and defines (macros),
followed by uppercase `SNAKE_CASE` (e.g., `KNET_MAX_CLIENTS`,
`NOZZLE_BUFFER_SIZE_DEFAULT`).
* Internal Elements:
* Names should be descriptive, indicating purpose and subsystem.
* Functions shared across multiple threads: Prefix with `_`
(e.g., `_shared_data_access`).
3. **Comments**:
* `//` for single-line, `/* ... */` for multi-line.
* Emphasizes clear and concise comments for non-obvious code.
4. **Best Practices**:
* API Changes Require Tests: Any internal or external API
modification must be accompanied by corresponding tests in the
test suite.
5. **Copyright**:
* A copyright notice specific to `STYLE_GUIDE.md` (Year 2025,
Author: Jules <AI Agent>) has been included and formatted as
plain Markdown text.
This initial version of the style guide addresses issue #22 and incorporates
iterative feedback on formatting, content, and specificity. A trivial
change (extra newline at EOF) was included in this commit to facilitate
this comprehensive message.
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
To unsubscribe from these emails, change your notification settings at https://github.com/kronosnet/kronosnet/settings/notifications