Branch: refs/heads/pmtud-fixes
Home: https://github.com/kronosnet/kronosnet
Commit: 9ddec90a1205e8fb3fe845fd9542c7b93cd1da1b
https://github.com/kronosnet/kronosnet/commit/9ddec90a1205e8fb3fe845fd9542c…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2019-08-10 (Sat, 10 Aug 2019)
Changed paths:
M libknet/Makefile.am
M libknet/crypto.c
M libknet/crypto_model.h
M libknet/crypto_nss.c
M libknet/crypto_openssl.c
M libknet/internals.h
M libknet/links.c
A libknet/onwire.c
M libknet/onwire.h
M libknet/threads_common.c
M libknet/threads_pmtud.c
Log Message:
-----------
[PMTUd] rework the whole math to calculate MTU
internal changes:
- drop the concept of sec_header_size that was completely wrong
and unnecessary
- bump crypto API to version 3 due to the above change
- clarify the difference between link->proto_overhead and
link->status->proto_overhead. We cannot rename the status
one as it would also change ABI.
- add onwire.c with documentation on the packet format
and what various len(s) mean in context.
- add 3 new functions to calculate MTUs back and forth
and use them around, hopefully with enough clarification
on why things are done in a given way.
- heavily change thread_pmtud.c to use those new facilities.
- fix major calculation issues when using crypto (non-crypto
was not affected by the problem).
- fix checks around to make sure they match the new math.
- fix padding calculation.
user visible changes:
- Global MTU is now calculated properly when using crypto
and values will be in general bigger than before due
to incorrect padding calculation in the previous implementation.
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Branch: refs/heads/doxycov
Home: https://github.com/kronosnet/kronosnet
Commit: f973f098a23566209c2bbc4a0b44822b02e27980
https://github.com/kronosnet/kronosnet/commit/f973f098a23566209c2bbc4a0b448…
Author: Christine Caulfield <ccaulfie(a)redhat.com>
Date: 2019-08-08 (Thu, 08 Aug 2019)
Changed paths:
M man/doxyxml.c
Log Message:
-----------
man: Change strcat to strncat
Oddly, covscan doesn't compain about the use of strcat, but
I'm going to pre-empt it, just in case it decides to.
Branch: refs/heads/doxycov
Home: https://github.com/kronosnet/kronosnet
Commit: 7e452f8648ec08757f24aecefd107e405f35e46a
https://github.com/kronosnet/kronosnet/commit/7e452f8648ec08757f24aecefd107…
Author: Christine Caulfield <ccaulfie(a)redhat.com>
Date: 2019-08-08 (Thu, 08 Aug 2019)
Changed paths:
M man/doxyxml.c
Log Message:
-----------
man: Change strcat to strncat
Oddly, covscan doesn't compain about the use of strcat, but
I'm going to pre-empt it, just in case it decides to.
Branch: refs/heads/fn-testing
Home: https://github.com/kronosnet/kronosnet
Commit: edc0215a8d690bc16dc8e2041c3b23b46ae9b757
https://github.com/kronosnet/kronosnet/commit/edc0215a8d690bc16dc8e2041c3b2…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2019-08-06 (Tue, 06 Aug 2019)
Changed paths:
M libknet/tests/test-common.c
Log Message:
-----------
[tests] remove unnecessary shutdown locking
the test should be in charge not to shutdown too much at once
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 8fa3f62adac86d760dbe122c61c445b7b9fbbae3
https://github.com/kronosnet/kronosnet/commit/8fa3f62adac86d760dbe122c61c44…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2019-08-06 (Tue, 06 Aug 2019)
Changed paths:
M libknet/tests/test-common.c
Log Message:
-----------
[tests] print information about which knet_handle is performing operations
this is necessary when a test creates multiple handles for functional testing
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: fa60cf030d93b4f725a87fced203686332de6e27
https://github.com/kronosnet/kronosnet/commit/fa60cf030d93b4f725a87fced2036…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2019-08-06 (Tue, 06 Aug 2019)
Changed paths:
M libknet/tests/test-common.c
Log Message:
-----------
[tests] use link_get_enable instead of get_status
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 55d470f7866c796eaedc7b866a07e83e6a83cf24
https://github.com/kronosnet/kronosnet/commit/55d470f7866c796eaedc7b866a07e…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2019-08-06 (Tue, 06 Aug 2019)
Changed paths:
M libknet/tests/test-common.c
M libknet/tests/test-common.h
Log Message:
-----------
[tests] add basic framework to create, join and stop many nodes
all nodes will be using loopback interface (lo) at different
port offset.
currently limited to ipv4 for basic development.
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 4b33d4d00e652ba13d822c7bb950d6e5c17e4dd0
https://github.com/kronosnet/kronosnet/commit/4b33d4d00e652ba13d822c7bb950d…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2019-08-06 (Tue, 06 Aug 2019)
Changed paths:
M libknet/tests/test-common.c
M libknet/tests/test-common.h
Log Message:
-----------
[tests] allow IPv6 to be used for functional testing
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Compare: https://github.com/kronosnet/kronosnet/compare/edc0215a8d69%5E...4b33d4d00e…
Branch: refs/heads/doxycov
Home: https://github.com/kronosnet/kronosnet
Commit: b43a5030e85c393ea825607f8010a7ee18b9953f
https://github.com/kronosnet/kronosnet/commit/b43a5030e85c393ea825607f8010a…
Author: Christine Caulfield <ccaulfie(a)redhat.com>
Date: 2019-08-05 (Mon, 05 Aug 2019)
Changed paths:
M man/doxyxml.c
Log Message:
-----------
man: Fix covscan reports in doxyxml.c
This fixes most of the remaining covscan errors in doxyxml.c.
The ones that remain are caused by malloced structures being
stored in qb_hashtable_maps.
These still cause unfreed memory, because the contents of the maps
are never explictly freed, but as they are used until the very end of
the program (when the OS will free everything) I'm dubious as to
whether it's worth doing it in the code - or whether covscan will
work out what's going on anyway.