Commits

commits@lists.kronosnet.org

2 participants
33190 discussions

[kronosnet/kronosnet] 3629f3: Don't require root privileges unless necessary
by GitHub 27 Nov '17

27 Nov '17

Branch: refs/heads/master Home: https://github.com/kronosnet/kronosnet Commit: 3629f34f6ad1d56c641566d00a6cfcc96c853bf7 https://github.com/kronosnet/kronosnet/commit/3629f34f6ad1d56c641566d00a6cf… Author: Ferenc Wágner <wferi(a)debian.org> Date: 2017-11-25 (Sat, 25 Nov 2017) Changed paths: M libknet/tests/test-common.c M libknet/transport_common.c Log Message: ----------- Don't require root privileges unless necessary On Linux, if /proc/sys/net/core/[rw]mem_max are set to at least 8388608 (KNET_RING_RCVBUFF), setting the socket buffer sizes doesn't require root privileges. FreeBSD uses the kern.ipc.maxsockbuf sysctl MIB variable for capping user buffer requests. Linux doubles the requested amount for administrative overhead, but FreeBSD does not, so we can't be too strict when checking the results. Commit: f1c6182f0d1eba2bb59d54811abf17315bd7148e https://github.com/kronosnet/kronosnet/commit/f1c6182f0d1eba2bb59d54811abf1… Author: Ferenc Wágner <wferi(a)debian.org> Date: 2017-11-26 (Sun, 26 Nov 2017) Changed paths: M libknet/tests/api_knet_get_compress_list.c M libknet/tests/api_knet_get_crypto_list.c M libknet/tests/api_knet_get_transport_id_by_name.c M libknet/tests/api_knet_get_transport_list.c M libknet/tests/api_knet_get_transport_name_by_id.c M libknet/tests/api_knet_handle_add_datafd.c M libknet/tests/api_knet_handle_clear_stats.c M libknet/tests/api_knet_handle_compress.c M libknet/tests/api_knet_handle_crypto.c M libknet/tests/api_knet_handle_enable_filter.c M libknet/tests/api_knet_handle_enable_pmtud_notify.c M libknet/tests/api_knet_handle_enable_sock_notify.c M libknet/tests/api_knet_handle_free.c M libknet/tests/api_knet_handle_get_channel.c M libknet/tests/api_knet_handle_get_datafd.c M libknet/tests/api_knet_handle_get_stats.c M libknet/tests/api_knet_handle_get_transport_reconnect_interval.c M libknet/tests/api_knet_handle_new.c M libknet/tests/api_knet_handle_new_limit.c M libknet/tests/api_knet_handle_pmtud_get.c M libknet/tests/api_knet_handle_pmtud_getfreq.c M libknet/tests/api_knet_handle_pmtud_setfreq.c M libknet/tests/api_knet_handle_remove_datafd.c M libknet/tests/api_knet_handle_set_transport_reconnect_interval.c M libknet/tests/api_knet_handle_setfwd.c M libknet/tests/api_knet_host_add.c M libknet/tests/api_knet_host_enable_status_change_notify.c M libknet/tests/api_knet_host_get_host_list.c M libknet/tests/api_knet_host_get_id_by_host_name.c M libknet/tests/api_knet_host_get_name_by_host_id.c M libknet/tests/api_knet_host_get_policy.c M libknet/tests/api_knet_host_get_status.c M libknet/tests/api_knet_host_remove.c M libknet/tests/api_knet_host_set_name.c M libknet/tests/api_knet_host_set_policy.c M libknet/tests/api_knet_link_clear_config.c M libknet/tests/api_knet_link_get_config.c M libknet/tests/api_knet_link_get_enable.c M libknet/tests/api_knet_link_get_link_list.c M libknet/tests/api_knet_link_get_ping_timers.c M libknet/tests/api_knet_link_get_pong_count.c M libknet/tests/api_knet_link_get_priority.c M libknet/tests/api_knet_link_get_status.c M libknet/tests/api_knet_link_set_config.c M libknet/tests/api_knet_link_set_enable.c M libknet/tests/api_knet_link_set_ping_timers.c M libknet/tests/api_knet_link_set_pong_count.c M libknet/tests/api_knet_link_set_priority.c M libknet/tests/api_knet_log_get_loglevel.c M libknet/tests/api_knet_log_set_loglevel.c M libknet/tests/api_knet_recv.c M libknet/tests/api_knet_send.c M libknet/tests/api_knet_send_compress.c M libknet/tests/api_knet_send_crypto.c M libknet/tests/api_knet_send_loopback.c M libknet/tests/api_knet_send_sync.c M libknet/tests/crypto_bench.c M libknet/tests/int_crypto.c M libknet/tests/knet_bench.c M libknet/tests/test-common.c M libknet/tests/test-common.h Log Message: ----------- Remove the need_root() function The point is not having root privileges, but having high enough socket buffer caps. Very few of the test can run without it. Commit: 3b1b2a9987b4fd355697bc29ef076f120f096574 https://github.com/kronosnet/kronosnet/commit/3b1b2a9987b4fd355697bc29ef076… Author: Ferenc Wágner <wferi(a)debian.org> Date: 2017-11-27 (Mon, 27 Nov 2017) Changed paths: M libknet/transport_common.c Log Message: ----------- Detailed error reporting about socket buffer sizes Commit: 0f7bf3fce06b887a71675b05befc01815d4867d6 https://github.com/kronosnet/kronosnet/commit/0f7bf3fce06b887a71675b05befc0… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2017-11-27 (Mon, 27 Nov 2017) Changed paths: M libknet/tests/api_knet_get_compress_list.c M libknet/tests/api_knet_get_crypto_list.c M libknet/tests/api_knet_get_transport_id_by_name.c M libknet/tests/api_knet_get_transport_list.c M libknet/tests/api_knet_get_transport_name_by_id.c M libknet/tests/api_knet_handle_add_datafd.c M libknet/tests/api_knet_handle_clear_stats.c M libknet/tests/api_knet_handle_compress.c M libknet/tests/api_knet_handle_crypto.c M libknet/tests/api_knet_handle_enable_filter.c M libknet/tests/api_knet_handle_enable_pmtud_notify.c M libknet/tests/api_knet_handle_enable_sock_notify.c M libknet/tests/api_knet_handle_free.c M libknet/tests/api_knet_handle_get_channel.c M libknet/tests/api_knet_handle_get_datafd.c M libknet/tests/api_knet_handle_get_stats.c M libknet/tests/api_knet_handle_get_transport_reconnect_interval.c M libknet/tests/api_knet_handle_new.c M libknet/tests/api_knet_handle_new_limit.c M libknet/tests/api_knet_handle_pmtud_get.c M libknet/tests/api_knet_handle_pmtud_getfreq.c M libknet/tests/api_knet_handle_pmtud_setfreq.c M libknet/tests/api_knet_handle_remove_datafd.c M libknet/tests/api_knet_handle_set_transport_reconnect_interval.c M libknet/tests/api_knet_handle_setfwd.c M libknet/tests/api_knet_host_add.c M libknet/tests/api_knet_host_enable_status_change_notify.c M libknet/tests/api_knet_host_get_host_list.c M libknet/tests/api_knet_host_get_id_by_host_name.c M libknet/tests/api_knet_host_get_name_by_host_id.c M libknet/tests/api_knet_host_get_policy.c M libknet/tests/api_knet_host_get_status.c M libknet/tests/api_knet_host_remove.c M libknet/tests/api_knet_host_set_name.c M libknet/tests/api_knet_host_set_policy.c M libknet/tests/api_knet_link_clear_config.c M libknet/tests/api_knet_link_get_config.c M libknet/tests/api_knet_link_get_enable.c M libknet/tests/api_knet_link_get_link_list.c M libknet/tests/api_knet_link_get_ping_timers.c M libknet/tests/api_knet_link_get_pong_count.c M libknet/tests/api_knet_link_get_priority.c M libknet/tests/api_knet_link_get_status.c M libknet/tests/api_knet_link_set_config.c M libknet/tests/api_knet_link_set_enable.c M libknet/tests/api_knet_link_set_ping_timers.c M libknet/tests/api_knet_link_set_pong_count.c M libknet/tests/api_knet_link_set_priority.c M libknet/tests/api_knet_log_get_loglevel.c M libknet/tests/api_knet_log_set_loglevel.c M libknet/tests/api_knet_recv.c M libknet/tests/api_knet_send.c M libknet/tests/api_knet_send_compress.c M libknet/tests/api_knet_send_crypto.c M libknet/tests/api_knet_send_loopback.c M libknet/tests/api_knet_send_sync.c M libknet/tests/crypto_bench.c M libknet/tests/int_crypto.c M libknet/tests/knet_bench.c M libknet/tests/test-common.c M libknet/tests/test-common.h M libknet/transport_common.c Log Message: ----------- Merge pull request #91 from kronosnet/no-root Enable testing without root privileges Compare: https://github.com/kronosnet/kronosnet/compare/cc2209872ec0...0f7bf3fce06b

1 0

[kronosnet/kronosnet] f1c618: Remove the need_root() function
by GitHub 27 Nov '17

27 Nov '17

Branch: refs/heads/no-root Home: https://github.com/kronosnet/kronosnet Commit: f1c6182f0d1eba2bb59d54811abf17315bd7148e https://github.com/kronosnet/kronosnet/commit/f1c6182f0d1eba2bb59d54811abf1… Author: Ferenc Wágner <wferi(a)debian.org> Date: 2017-11-26 (Sun, 26 Nov 2017) Changed paths: M libknet/tests/api_knet_get_compress_list.c M libknet/tests/api_knet_get_crypto_list.c M libknet/tests/api_knet_get_transport_id_by_name.c M libknet/tests/api_knet_get_transport_list.c M libknet/tests/api_knet_get_transport_name_by_id.c M libknet/tests/api_knet_handle_add_datafd.c M libknet/tests/api_knet_handle_clear_stats.c M libknet/tests/api_knet_handle_compress.c M libknet/tests/api_knet_handle_crypto.c M libknet/tests/api_knet_handle_enable_filter.c M libknet/tests/api_knet_handle_enable_pmtud_notify.c M libknet/tests/api_knet_handle_enable_sock_notify.c M libknet/tests/api_knet_handle_free.c M libknet/tests/api_knet_handle_get_channel.c M libknet/tests/api_knet_handle_get_datafd.c M libknet/tests/api_knet_handle_get_stats.c M libknet/tests/api_knet_handle_get_transport_reconnect_interval.c M libknet/tests/api_knet_handle_new.c M libknet/tests/api_knet_handle_new_limit.c M libknet/tests/api_knet_handle_pmtud_get.c M libknet/tests/api_knet_handle_pmtud_getfreq.c M libknet/tests/api_knet_handle_pmtud_setfreq.c M libknet/tests/api_knet_handle_remove_datafd.c M libknet/tests/api_knet_handle_set_transport_reconnect_interval.c M libknet/tests/api_knet_handle_setfwd.c M libknet/tests/api_knet_host_add.c M libknet/tests/api_knet_host_enable_status_change_notify.c M libknet/tests/api_knet_host_get_host_list.c M libknet/tests/api_knet_host_get_id_by_host_name.c M libknet/tests/api_knet_host_get_name_by_host_id.c M libknet/tests/api_knet_host_get_policy.c M libknet/tests/api_knet_host_get_status.c M libknet/tests/api_knet_host_remove.c M libknet/tests/api_knet_host_set_name.c M libknet/tests/api_knet_host_set_policy.c M libknet/tests/api_knet_link_clear_config.c M libknet/tests/api_knet_link_get_config.c M libknet/tests/api_knet_link_get_enable.c M libknet/tests/api_knet_link_get_link_list.c M libknet/tests/api_knet_link_get_ping_timers.c M libknet/tests/api_knet_link_get_pong_count.c M libknet/tests/api_knet_link_get_priority.c M libknet/tests/api_knet_link_get_status.c M libknet/tests/api_knet_link_set_config.c M libknet/tests/api_knet_link_set_enable.c M libknet/tests/api_knet_link_set_ping_timers.c M libknet/tests/api_knet_link_set_pong_count.c M libknet/tests/api_knet_link_set_priority.c M libknet/tests/api_knet_log_get_loglevel.c M libknet/tests/api_knet_log_set_loglevel.c M libknet/tests/api_knet_recv.c M libknet/tests/api_knet_send.c M libknet/tests/api_knet_send_compress.c M libknet/tests/api_knet_send_crypto.c M libknet/tests/api_knet_send_loopback.c M libknet/tests/api_knet_send_sync.c M libknet/tests/crypto_bench.c M libknet/tests/int_crypto.c M libknet/tests/knet_bench.c M libknet/tests/test-common.c M libknet/tests/test-common.h Log Message: ----------- Remove the need_root() function The point is not having root privileges, but having high enough socket buffer caps. Very few of the test can run without it. Commit: 3b1b2a9987b4fd355697bc29ef076f120f096574 https://github.com/kronosnet/kronosnet/commit/3b1b2a9987b4fd355697bc29ef076… Author: Ferenc Wágner <wferi(a)debian.org> Date: 2017-11-27 (Mon, 27 Nov 2017) Changed paths: M libknet/transport_common.c Log Message: ----------- Detailed error reporting about socket buffer sizes Compare: https://github.com/kronosnet/kronosnet/compare/3629f34f6ad1...3b1b2a9987b4

1 0

[kronosnet/kronosnet] 5e5ab0: [pmtud] don't burst packets but spread them around
by GitHub 27 Nov '17

27 Nov '17

Branch: refs/heads/pmtu-fixes Home: https://github.com/kronosnet/kronosnet Commit: 5e5ab0747866d5b7d7291878e5182e2332d473e5 https://github.com/kronosnet/kronosnet/commit/5e5ab0747866d5b7d7291878e5182… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2017-11-27 (Mon, 27 Nov 2017) Changed paths: M libknet/threads_pmtud.c Log Message: ----------- [pmtud] don't burst packets but spread them around Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>

1 0

[kronosnet/kronosnet] db0041: [pmtud] fix PMTU detection when link is first up (...
by GitHub 26 Nov '17

26 Nov '17

Branch: refs/heads/pmtu-fixes Home: https://github.com/kronosnet/kronosnet Commit: db004181c5bde3ab484da4361f4f79bc817ef014 https://github.com/kronosnet/kronosnet/commit/db004181c5bde3ab484da4361f4f7… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2017-11-26 (Sun, 26 Nov 2017) Changed paths: M libknet/threads_heartbeat.c Log Message: ----------- [pmtud] fix PMTU detection when link is first up (part 2) Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>

1 0

[kronosnet/kronosnet] 2b1cd7: [pmtud] fix PMTU detection when link is first up
by GitHub 26 Nov '17

26 Nov '17

Branch: refs/heads/pmtu-fixes Home: https://github.com/kronosnet/kronosnet Commit: 2b1cd7120428690d8181afae7949f5be2dcac92c https://github.com/kronosnet/kronosnet/commit/2b1cd7120428690d8181afae7949f… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2017-11-26 (Sun, 26 Nov 2017) Changed paths: M libknet/internals.h M libknet/links.c M libknet/threads_pmtud.c Log Message: ----------- [pmtud] fix PMTU detection when link is first up we noticed, during testing, that from time to time the kernel would return EMSGSIZE also on known valid packet specially during first time link intialization. after re-reading carefully man 7 ip, it turns out that we did not account for: "While MTU discovery is in progress, initial packets from datagram sockets may be dropped. Applications using UDP should be aware of this and not take it into account for their packet retransmit strategy." as solution, we use the first PMTUd run to send a series of packets that will give time to the kernel to perform its own PMTU detection before we start operating. This can probably lay the base for sending packets, and then use getsockopt to determine the link MTU vs rely on other nodes reply. Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>

1 0

[kronosnet/kronosnet] e25cd3: [pmtud] fix handling of errno and savederrno
by GitHub 26 Nov '17

26 Nov '17

Branch: refs/heads/pmtu-fixes Home: https://github.com/kronosnet/kronosnet Commit: e25cd37fd438507b10b54af55271f6e115d9ecbe https://github.com/kronosnet/kronosnet/commit/e25cd37fd438507b10b54af55271f… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2017-11-26 (Sun, 26 Nov 2017) Changed paths: M libknet/host.c M libknet/threads_heartbeat.c M libknet/threads_pmtud.c M libknet/threads_rx.c M libknet/transport_sctp.c Log Message: ----------- [pmtud] fix handling of errno and savederrno also, during debugging it turned out that sendto does not reset errno on successful run, returning the status from the previous error. While that's hardly a problem, it makes debugging more interesting, so let's reset errno before each call to sendto. Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>

1 0

[kronosnet/kronosnet]
by GitHub 26 Nov '17

26 Nov '17

Branch: refs/heads/pmtu-fixes Home: https://github.com/kronosnet/kronosnet

1 0

[kronosnet/kronosnet] 3629f3: Don't require root privileges unless necessary
by GitHub 25 Nov '17

25 Nov '17

Branch: refs/heads/no-root Home: https://github.com/kronosnet/kronosnet Commit: 3629f34f6ad1d56c641566d00a6cfcc96c853bf7 https://github.com/kronosnet/kronosnet/commit/3629f34f6ad1d56c641566d00a6cf… Author: Ferenc Wágner <wferi(a)debian.org> Date: 2017-11-25 (Sat, 25 Nov 2017) Changed paths: M libknet/tests/test-common.c M libknet/transport_common.c Log Message: ----------- Don't require root privileges unless necessary On Linux, if /proc/sys/net/core/[rw]mem_max are set to at least 8388608 (KNET_RING_RCVBUFF), setting the socket buffer sizes doesn't require root privileges. FreeBSD uses the kern.ipc.maxsockbuf sysctl MIB variable for capping user buffer requests. Linux doubles the requested amount for administrative overhead, but FreeBSD does not, so we can't be too strict when checking the results.

1 0

knet-build-all-voting - Build # 178 - Failure!
by jenkins＠kronosnet.org 25 Nov '17

25 Nov '17

knet-build-all-voting - Build # 178 - Failure: Check console output at https://ci.kronosnet.org/job/knet-build-all-voting/178/ to view the results.

1 0

[kronosnet/kronosnet] f57aef: Don't require root privileges unless necessary
by GitHub 25 Nov '17

25 Nov '17

Branch: refs/heads/no-root Home: https://github.com/kronosnet/kronosnet Commit: f57aef9e1c20962f61fb168c070212c88690832c https://github.com/kronosnet/kronosnet/commit/f57aef9e1c20962f61fb168c07021… Author: Ferenc Wágner <wferi(a)debian.org> Date: 2017-11-25 (Sat, 25 Nov 2017) Changed paths: M libknet/tests/test-common.c M libknet/transport_common.c Log Message: ----------- Don't require root privileges unless necessary On Linux, if /proc/sys/net/core/[rw]mem_max are set to at least 8388608 (KNET_RING_RCVBUFF), setting the socket buffer sizes doesn't require root privileges. FreeBSD uses the kern.ipc.maxsockbuf sysctl MIB variable for capping user buffer requests. Linux doubles the requested amount for administrative overhead, but FreeBSD does not, so we can't be too strict when checking the results.

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Commits