Commits

commits@lists.kronosnet.org

2 participants
33093 discussions

[kronosnet/kronosnet] aaea6c: [test] add packet verification option to knet_bench
by Fabio M. Di Nitto 16 Oct '19

16 Oct '19

Branch: refs/heads/netload-fixes Home: https://github.com/kronosnet/kronosnet Commit: aaea6cbe4b1d2dfc1eba266ec94fd785d6aa28bd https://github.com/kronosnet/kronosnet/commit/aaea6cbe4b1d2dfc1eba266ec94fd… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-16 (Wed, 16 Oct 2019) Changed paths: M libknet/tests/knet_bench.c Log Message: ----------- [test] add packet verification option to knet_bench Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>

1 0

pacemaker1-build-all-voting - Build # 237 - Failure!
by jenkins＠kronosnet.org 15 Oct '19

15 Oct '19

pacemaker1-build-all-voting - Build # 237 - Failure: Check console output at https://ci.kronosnet.org/job/pacemaker1-build-all-voting/237/ to view the results.

1 0

[kronosnet/kronosnet]
by kronosnet CI bot 15 Oct '19

15 Oct '19

Branch: refs/heads/coverity_scan Home: https://github.com/kronosnet/kronosnet

1 0

[kronosnet/kronosnet] 7923e1: [host] rename variables to make it easier to read ...
by Fabio M. Di Nitto 15 Oct '19

15 Oct '19

Branch: refs/heads/stable1-proposed Home: https://github.com/kronosnet/kronosnet Commit: 7923e1864f6c35ca4cdcd0f0991eafe1c9d43713 https://github.com/kronosnet/kronosnet/commit/7923e1864f6c35ca4cdcd0f0991ea… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-15 (Tue, 15 Oct 2019) Changed paths: M libknet/host.c Log Message: ----------- [host] rename variables to make it easier to read the code Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 764a8d67a90f54a4a39d9c890c6196cd6683bbc9 https://github.com/kronosnet/kronosnet/commit/764a8d67a90f54a4a39d9c890c619… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-15 (Tue, 15 Oct 2019) Changed paths: M libknet/host.c Log Message: ----------- [host] fix defrag buffers reclaim logic The problem: - let's assume a 2 nodes (A and B) cluster setup - node A sends fragmented packets to node B and there is packet loss on the network. - node B receives all those fragments and attempts to reassemble them. - node A sends packet seq_num X in Y fragments. - node B receives only part of the fragments and stores them in a defrag buf. - packet loss stops. - node A continues to send packets and a seq_num roll-over takes place. - node A sends a new packet seq_num X in Y fragments. - node B gets confused here because the parts of the old packet seq_num X are still stored and the buffer has not been reclaimed. - node B continues to rebuild packet seq_num X with old stale data and new data from after the roll-over. - node B completes reassembling the packet and delivers junk to the application. The solution: Add a much stronger buffer reclaim logic that will apply on each received packet and not only when defrag buffers are needed, as there might be a mix of fragmented and not fragmented packets in-flight. The new logic creates a window of N packets that can be handled at the same time (based on the number of buffers) and clear everything else. Fixes https://github.com/kronosnet/kronosnet/issues/261 Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 281979eed8985aa0a87b34714d97cdfa1bc073df https://github.com/kronosnet/kronosnet/commit/281979eed8985aa0a87b34714d97c… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-15 (Tue, 15 Oct 2019) Changed paths: M libknet/threads_rx.c Log Message: ----------- [rx] copy data into the defrag buffer only if we know the size of the frame Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: dbd6dc8e845c53d126072f13c76bb72fa424bb5f https://github.com/kronosnet/kronosnet/commit/dbd6dc8e845c53d126072f13c76bb… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-15 (Tue, 15 Oct 2019) Changed paths: M libknet/tests/knet_bench.c Log Message: ----------- [test] add ability to knet_bench to specify a fixed packet size for perf test Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: e004fbb0ba4c18c773d0ecdc3ee1cac0f2817171 https://github.com/kronosnet/kronosnet/commit/e004fbb0ba4c18c773d0ecdc3ee1c… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-15 (Tue, 15 Oct 2019) Changed paths: M libknet/threads_pmtud.c Log Message: ----------- [PMTUd] invalidate MTU for a link if the value is lower than minimum Under heavy network load and packet loss, calculated MTU can be too small. In that case we need to invalidate the link mtu, that would remove the link from the rotation (and traffic) and would give PMTUd time to get the right MTU in the next round. Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Compare: https://github.com/kronosnet/kronosnet/compare/0714234d5ada...e004fbb0ba4c

1 0

[kronosnet/kronosnet] a081ff: [host] rename variables to make it easier to read ...
by Fabio M. Di Nitto 15 Oct '19

15 Oct '19

Branch: refs/heads/master Home: https://github.com/kronosnet/kronosnet Commit: a081ff7fab6bb98f9ff2a88b1593776b0c27b6f1 https://github.com/kronosnet/kronosnet/commit/a081ff7fab6bb98f9ff2a88b15937… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-15 (Tue, 15 Oct 2019) Changed paths: M libknet/host.c Log Message: ----------- [host] rename variables to make it easier to read the code Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 3fb0166ebd14e37a2fb9fe7aeae53d09e0e66b74 https://github.com/kronosnet/kronosnet/commit/3fb0166ebd14e37a2fb9fe7aeae53… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-15 (Tue, 15 Oct 2019) Changed paths: M libknet/host.c Log Message: ----------- [host] fix defrag buffers reclaim logic The problem: - let's assume a 2 nodes (A and B) cluster setup - node A sends fragmented packets to node B and there is packet loss on the network. - node B receives all those fragments and attempts to reassemble them. - node A sends packet seq_num X in Y fragments. - node B receives only part of the fragments and stores them in a defrag buf. - packet loss stops. - node A continues to send packets and a seq_num roll-over takes place. - node A sends a new packet seq_num X in Y fragments. - node B gets confused here because the parts of the old packet seq_num X are still stored and the buffer has not been reclaimed. - node B continues to rebuild packet seq_num X with old stale data and new data from after the roll-over. - node B completes reassembling the packet and delivers junk to the application. The solution: Add a much stronger buffer reclaim logic that will apply on each received packet and not only when defrag buffers are needed, as there might be a mix of fragmented and not fragmented packets in-flight. The new logic creates a window of N packets that can be handled at the same time (based on the number of buffers) and clear everything else. Fixes https://github.com/kronosnet/kronosnet/issues/261 Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 8b2863b392d275ea50fa19e8e8bebe40a6134707 https://github.com/kronosnet/kronosnet/commit/8b2863b392d275ea50fa19e8e8beb… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-15 (Tue, 15 Oct 2019) Changed paths: M libknet/threads_rx.c Log Message: ----------- [rx] copy data into the defrag buffer only if we know the size of the frame Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: d39c189900ef1a5647c7264e799f793ab9fd93e2 https://github.com/kronosnet/kronosnet/commit/d39c189900ef1a5647c7264e799f7… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-15 (Tue, 15 Oct 2019) Changed paths: M libknet/tests/knet_bench.c Log Message: ----------- [test] add ability to knet_bench to specify a fixed packet size for perf test Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 34c08ae7e7903d79f06569b4f506a00c15af0238 https://github.com/kronosnet/kronosnet/commit/34c08ae7e7903d79f06569b4f506a… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-15 (Tue, 15 Oct 2019) Changed paths: M libknet/threads_pmtud.c Log Message: ----------- [PMTUd] invalidate MTU for a link if the value is lower than minimum Under heavy network load and packet loss, calculated MTU can be too small. In that case we need to invalidate the link mtu, that would remove the link from the rotation (and traffic) and would give PMTUd time to get the right MTU in the next round. Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 292b2e06380d75001f8991648eebf9764c102d24 https://github.com/kronosnet/kronosnet/commit/292b2e06380d75001f8991648eebf… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-15 (Tue, 15 Oct 2019) Changed paths: M libknet/host.c M libknet/tests/knet_bench.c M libknet/threads_pmtud.c M libknet/threads_rx.c Log Message: ----------- Merge pull request #264 from kronosnet/netload-fixes Netload fixes Compare: https://github.com/kronosnet/kronosnet/compare/7c470fe6fe90...292b2e06380d

1 0

[kronosnet/kronosnet]
by kronosnet CI bot 15 Oct '19

15 Oct '19

Branch: refs/heads/coverity_scan Home: https://github.com/kronosnet/kronosnet

1 0

[kronosnet/kronosnet] 3fb016: [host] fix defrag buffers reclaim logic
by Fabio M. Di Nitto 15 Oct '19

15 Oct '19

Branch: refs/heads/netload-fixes Home: https://github.com/kronosnet/kronosnet Commit: 3fb0166ebd14e37a2fb9fe7aeae53d09e0e66b74 https://github.com/kronosnet/kronosnet/commit/3fb0166ebd14e37a2fb9fe7aeae53… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-15 (Tue, 15 Oct 2019) Changed paths: M libknet/host.c Log Message: ----------- [host] fix defrag buffers reclaim logic The problem: - let's assume a 2 nodes (A and B) cluster setup - node A sends fragmented packets to node B and there is packet loss on the network. - node B receives all those fragments and attempts to reassemble them. - node A sends packet seq_num X in Y fragments. - node B receives only part of the fragments and stores them in a defrag buf. - packet loss stops. - node A continues to send packets and a seq_num roll-over takes place. - node A sends a new packet seq_num X in Y fragments. - node B gets confused here because the parts of the old packet seq_num X are still stored and the buffer has not been reclaimed. - node B continues to rebuild packet seq_num X with old stale data and new data from after the roll-over. - node B completes reassembling the packet and delivers junk to the application. The solution: Add a much stronger buffer reclaim logic that will apply on each received packet and not only when defrag buffers are needed, as there might be a mix of fragmented and not fragmented packets in-flight. The new logic creates a window of N packets that can be handled at the same time (based on the number of buffers) and clear everything else. Fixes https://github.com/kronosnet/kronosnet/issues/261 Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 8b2863b392d275ea50fa19e8e8bebe40a6134707 https://github.com/kronosnet/kronosnet/commit/8b2863b392d275ea50fa19e8e8beb… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-15 (Tue, 15 Oct 2019) Changed paths: M libknet/threads_rx.c Log Message: ----------- [rx] copy data into the defrag buffer only if we know the size of the frame Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: d39c189900ef1a5647c7264e799f793ab9fd93e2 https://github.com/kronosnet/kronosnet/commit/d39c189900ef1a5647c7264e799f7… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-15 (Tue, 15 Oct 2019) Changed paths: M libknet/tests/knet_bench.c Log Message: ----------- [test] add ability to knet_bench to specify a fixed packet size for perf test Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 34c08ae7e7903d79f06569b4f506a00c15af0238 https://github.com/kronosnet/kronosnet/commit/34c08ae7e7903d79f06569b4f506a… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-15 (Tue, 15 Oct 2019) Changed paths: M libknet/threads_pmtud.c Log Message: ----------- [PMTUd] invalidate MTU for a link if the value is lower than minimum Under heavy network load and packet loss, calculated MTU can be too small. In that case we need to invalidate the link mtu, that would remove the link from the rotation (and traffic) and would give PMTUd time to get the right MTU in the next round. Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Compare: https://github.com/kronosnet/kronosnet/compare/e2af2fce11a7...34c08ae7e790

1 0

[kronosnet/kronosnet] e2af2f: [PMTUd] invalidate MTU for a link if the value is ...
by Fabio M. Di Nitto 15 Oct '19

15 Oct '19

Branch: refs/heads/netload-fixes Home: https://github.com/kronosnet/kronosnet Commit: e2af2fce11a72b6ff5bf530554d839276e6d4b05 https://github.com/kronosnet/kronosnet/commit/e2af2fce11a72b6ff5bf530554d83… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-15 (Tue, 15 Oct 2019) Changed paths: M libknet/threads_pmtud.c Log Message: ----------- [PMTUd] invalidate MTU for a link if the value is lower than minimum Under heavy network load and packet loss, calculated MTU can be too small. In that case we need to invalidate the link mtu, that would remove the link from the rotation (and traffic) and would give PMTUd time to get the right MTU in the next round. Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>

1 0

[kronosnet/kronosnet] d16e1f: [DEBUG] DO NOT MERGE: don't accept crappy MTU values
by Fabio M. Di Nitto 15 Oct '19

15 Oct '19

Branch: refs/heads/memory-corrupt-debug Home: https://github.com/kronosnet/kronosnet Commit: d16e1fd6f06ebf988341be116657a3037f7fc70f https://github.com/kronosnet/kronosnet/commit/d16e1fd6f06ebf988341be116657a… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-15 (Tue, 15 Oct 2019) Changed paths: M libknet/threads_pmtud.c Log Message: ----------- [DEBUG] DO NOT MERGE: don't accept crappy MTU values Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>

1 0

[kronosnet/kronosnet] 7c470f: Merge pull request #263 from kronosnet/runtime-debug
by Fabio M. Di Nitto 15 Oct '19

15 Oct '19

Branch: refs/heads/coverity_scan Home: https://github.com/kronosnet/kronosnet Commit: 7c470fe6fe90d7a523ca0bfc238ed89e0948f940 https://github.com/kronosnet/kronosnet/commit/7c470fe6fe90d7a523ca0bfc238ed… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-09 (Wed, 09 Oct 2019) Changed paths: M configure.ac M man/Makefile.am Log Message: ----------- Merge pull request #263 from kronosnet/runtime-debug [build] add --with-sanitizers= option for sanitizer builds Commit: a081ff7fab6bb98f9ff2a88b1593776b0c27b6f1 https://github.com/kronosnet/kronosnet/commit/a081ff7fab6bb98f9ff2a88b15937… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-15 (Tue, 15 Oct 2019) Changed paths: M libknet/host.c Log Message: ----------- [host] rename variables to make it easier to read the code Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 1338058fa634b08eee7099c0614e8076267501ff https://github.com/kronosnet/kronosnet/commit/1338058fa634b08eee7099c0614e8… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-15 (Tue, 15 Oct 2019) Changed paths: M libknet/host.c Log Message: ----------- [host] fix defrag buffers reclaim logic The problem: - let's assume a 2 nodes (A and B) cluster setup - node A sends fragmented packets to node B and there is packet loss on the network. - node B receives all those fragments and attempts to reassemble them. - node A sends packet seq_num X in Y fragments. - node B receives only part of the fragments and stores them in a defrag buf. - packet loss stops. - node A continues to send packets and a seq_num roll-over takes place. - node A sends a new packet seq_num X in Y fragments. - node B gets confused here because the parts of the old packet seq_num X are still stored and the buffer has not been reclaimed. - node B continues to rebuild packet seq_num X with old stale data and new data from after the roll-over. - node B completes reassembling the packet and delivers junk to the application. The solution: Add a much stronger buffer reclaim logic that will apply on each received packet and not only when defrag buffers are needed, as there might be a mix of fragmented and not fragmented packets in-flight. The new logic creates a window of N packets that can be handled at the same time (based on the number of buffers) and clear everything else. Fixes https://github.com/kronosnet/kronosnet/issues/261 Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: aeaffc89bb71a2ab4e5b1f5cce49a20e3c0872e3 https://github.com/kronosnet/kronosnet/commit/aeaffc89bb71a2ab4e5b1f5cce49a… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-15 (Tue, 15 Oct 2019) Changed paths: M libknet/threads_rx.c Log Message: ----------- [rx] copy data into the defrag buffer only if we know the size of the frame Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 3ed7293c027cc0c5940dabd19f859bf22f00efae https://github.com/kronosnet/kronosnet/commit/3ed7293c027cc0c5940dabd19f859… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-15 (Tue, 15 Oct 2019) Changed paths: M libknet/tests/knet_bench.c Log Message: ----------- [test] add ability to knet_bench to specify a fixed packet size for perf test Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Compare: https://github.com/kronosnet/kronosnet/compare/38e40998ec6b...3ed7293c027c

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Commits