Commits

commits@lists.kronosnet.org

1 participants
28391 discussions

[kronosnet/kronosnet] c7a382: [nozzle] add Doxygen header
by GitHub 16 Nov '17

16 Nov '17

Branch: refs/heads/libtap-fixes Home: https://github.com/kronosnet/kronosnet Commit: c7a382ed5503fa31d29db81dc1c19aa27fee9744 https://github.com/kronosnet/kronosnet/commit/c7a382ed5503fa31d29db81dc1c19… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2017-11-16 (Thu, 16 Nov 2017) Changed paths: M libnozzle/libnozzle.h Log Message: ----------- [nozzle] add Doxygen header Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>

1 0

[kronosnet/kronosnet] 68fa70: [libnozzle] rename libtap to libnozzle (part 1)
by GitHub 16 Nov '17

16 Nov '17

Branch: refs/heads/libtap-fixes Home: https://github.com/kronosnet/kronosnet Commit: 68fa70f0675bfe63916d055b059141c76ba2bfb7 https://github.com/kronosnet/kronosnet/commit/68fa70f0675bfe63916d055b05914… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2017-11-16 (Thu, 16 Nov 2017) Changed paths: M Makefile.am M NOTES_TO_PACKAGE_MAINTAINERS M README M configure.ac M kronosnet.spec.in M kronosnetd/Makefile.am M kronosnetd/cfg.c M kronosnetd/cfg.h M kronosnetd/vty_cli_cmds.c A libnozzle/Makefile.am A libnozzle/api-test-coverage A libnozzle/libnozzle.c A libnozzle/libnozzle.h A libnozzle/libnozzle.pc.in A libnozzle/libnozzle_exported_syms A libnozzle/tap_updown_bad/down.d/kronostest A libnozzle/tap_updown_bad/post-down.d/kronostest A libnozzle/tap_updown_bad/pre-up.d/kronostest A libnozzle/tap_updown_bad/up.d/kronostest A libnozzle/tap_updown_good/down.d/kronostest A libnozzle/tap_updown_good/post-down.d/kronostest A libnozzle/tap_updown_good/pre-up.d/kronostest A libnozzle/tap_updown_good/up.d/kronostest R libtap/Makefile.am R libtap/api-test-coverage R libtap/libtap.c R libtap/libtap.h R libtap/libtap.pc.in R libtap/libtap_exported_syms R libtap/tap_updown_bad/down.d/kronostest R libtap/tap_updown_bad/post-down.d/kronostest R libtap/tap_updown_bad/pre-up.d/kronostest R libtap/tap_updown_bad/up.d/kronostest R libtap/tap_updown_good/down.d/kronostest R libtap/tap_updown_good/post-down.d/kronostest R libtap/tap_updown_good/pre-up.d/kronostest R libtap/tap_updown_good/up.d/kronostest Log Message: ----------- [libnozzle] rename libtap to libnozzle (part 1) Our fearless Debian maintainer wferi made us aware that TAP is an overloaded term already and it would be very confusing to add yet another one. nozzle is a good pick from http://www.thesaurus.com/browse/tap I am sure lib*cock* would have cause havoc :-) This commit only rename files and allow builds. The API needs to be renamed too, but that will come over time with major code cleanup as documented here: https://trello.com/c/pyEKd4UH/396-libnozzle-make-it-production-ga-ready Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>

1 0

[kronosnet/kronosnet] 700bb0: [libtap] BSD: switch to ioctl to destroy tap devic...
by GitHub 16 Nov '17

16 Nov '17

Branch: refs/heads/libtap-fixes Home: https://github.com/kronosnet/kronosnet Commit: 700bb0621279b8837ffa36383a0458eeb7a8b605 https://github.com/kronosnet/kronosnet/commit/700bb0621279b8837ffa36383a045… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2017-11-16 (Thu, 16 Nov 2017) Changed paths: M libtap/libtap.c Log Message: ----------- [libtap] BSD: switch to ioctl to destroy tap devices Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>

1 0

knet-build-all-voting - Build # 134 - Failure!
by jenkins＠kronosnet.org 16 Nov '17

16 Nov '17

knet-build-all-voting - Build # 134 - Failure: Check console output at https://ci.kronosnet.org/job/knet-build-all-voting/134/ to view the results.

1 0

[kronosnet/kronosnet] d07381: [libtap] tests: allow random localhost IPs for tes...
by GitHub 16 Nov '17

16 Nov '17

Branch: refs/heads/libtap-fixes Home: https://github.com/kronosnet/kronosnet Commit: d07381604a5edfa94f8ba4fb4c5845a47faddefa https://github.com/kronosnet/kronosnet/commit/d07381604a5edfa94f8ba4fb4c584… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2017-11-16 (Thu, 16 Nov 2017) Changed paths: M libtap/libtap.c Log Message: ----------- [libtap] tests: allow random localhost IPs for testing - avoids clashing with machine routing - allows parallel testing Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 1e05d5c01910f0aaf5b36c1546fcd4ad1885dc11 https://github.com/kronosnet/kronosnet/commit/1e05d5c01910f0aaf5b36c1546fcd… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2017-11-16 (Thu, 16 Nov 2017) Changed paths: M libtap/libtap.c Log Message: ----------- [libtap] tests: add better IPv6 private address space randomization Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: d978e5a38c34aa9a721803e1226823cd98e6c773 https://github.com/kronosnet/kronosnet/commit/d978e5a38c34aa9a721803e122682… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2017-11-16 (Thu, 16 Nov 2017) Changed paths: M configure.ac M libtap/libtap.c Log Message: ----------- [libtap] port to freebsd and fix a bunch of small bugs - tap_open: do mutex lock only after malloc to avoid deadlock - fix test suite to increase randomness when testing named tap devices - remove hardcoded paths to /bin/true /bin/false and /bin/grep Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: eab4930606f60160ce68da8e0bdd7687382ff5ce https://github.com/kronosnet/kronosnet/commit/eab4930606f60160ce68da8e0bdd7… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2017-11-16 (Thu, 16 Nov 2017) Changed paths: M README Log Message: ----------- [libtap] update README for BSD Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 9114d279d7314f4eecaaa1b237287fe2076d026e https://github.com/kronosnet/kronosnet/commit/9114d279d7314f4eecaaa1b237287… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2017-11-16 (Thu, 16 Nov 2017) Changed paths: M libtap/libtap.h Log Message: ----------- [libtap] define IFNAMSIZ for applications that don't need/want to include net/if.h Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Compare: https://github.com/kronosnet/kronosnet/compare/dc7e39042646...9114d279d731

1 0

[kronosnet/kronosnet] 19a2b9: test commit
by GitHub 16 Nov '17

16 Nov '17

Branch: refs/heads/ci-test Home: https://github.com/kronosnet/kronosnet Commit: 19a2b9856fcaf3c1fc1476bb6c7d913be5b094c9 https://github.com/kronosnet/kronosnet/commit/19a2b9856fcaf3c1fc1476bb6c7d9… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2017-11-16 (Thu, 16 Nov 2017) Changed paths: M NOTES_TO_PACKAGE_MAINTAINERS Log Message: ----------- test commit Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 3308e499488091c45027a534a7bb4d78f2190211 https://github.com/kronosnet/kronosnet/commit/3308e499488091c45027a534a7bb4… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2017-11-16 (Thu, 16 Nov 2017) Changed paths: M NOTES_TO_PACKAGE_MAINTAINERS Log Message: ----------- test commit 2 Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: fe1baf38ce58086d5cfcfb3e9a5cce594c876517 https://github.com/kronosnet/kronosnet/commit/fe1baf38ce58086d5cfcfb3e9a5cc… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2017-11-16 (Thu, 16 Nov 2017) Changed paths: M NOTES_TO_PACKAGE_MAINTAINERS Log Message: ----------- test commmit 3 Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Compare: https://github.com/kronosnet/kronosnet/compare/6e18c372d2e0...fe1baf38ce58

1 0

[kronosnet/kronosnet] 6d1625: [build] workaround memory alignment bug in nss in ...
by GitHub 15 Nov '17

15 Nov '17

Branch: refs/heads/master Home: https://github.com/kronosnet/kronosnet Commit: 6d1625538adedb911d47e6b2047573ee85780b2c https://github.com/kronosnet/kronosnet/commit/6d1625538adedb911d47e6b204757… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2017-11-15 (Wed, 15 Nov 2017) Changed paths: M build-aux/check.mk Log Message: ----------- [build] workaround memory alignment bug in nss in combination with valgrind on Linux/i386 Over the past few weeks, we noticed CI failing on i386 when running make check-memcheck (test suite executed with valgring). Those failures were not consistent and sometime random. After some heavy debugging it turns out that those failures are a combination of libnss3 internal memory allocator bug and valgrind internal memory allocator. Current libnss3 memory allocator expects a 16 bytes memory aligned buffer and in the event the memory is not aligned, it would round it. The issue is that, in performing this rounding, nss does not track properly the original address of the memory, and the equivalent of subsequent free of this buffer would fail, leaking memory and potentially accessing memory not allocated or corrpting memory. The nss bug is already fixed upstream by commit: changeset: 13557:52e38f913220 Valgrind on Linux/i386 memory allocator can return memory that is not aligned to the 16 bytes, contrary to what malloc/glibc does. Valgrind was returning (somehow randomly) a non aligned buffer to nss triggering the nss bug and the leak. By forcing valgrind to use aligned memory, nss bug does not trigger and there is no memory leak during the execution of the test suite. The memory leak never triggered when running knet in normal conditions. Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: bc519d4a4a5f7c9a6cadae0453f15cc2ff432960 https://github.com/kronosnet/kronosnet/commit/bc519d4a4a5f7c9a6cadae0453f15… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2017-11-15 (Wed, 15 Nov 2017) Changed paths: M build-aux/check.mk Log Message: ----------- Merge pull request #88 from kronosnet/nss-workaround [build] workaround memory alignment bug in nss in combination with va… Compare: https://github.com/kronosnet/kronosnet/compare/8156886888aa...bc519d4a4a5f

1 0

knet-build-all-voting - Build # 131 - Failure!
by jenkins＠kronosnet.org 15 Nov '17

15 Nov '17

knet-build-all-voting - Build # 131 - Failure: Check console output at https://ci.kronosnet.org/job/knet-build-all-voting/131/ to view the results.

1 0

[kronosnet/kronosnet] 6d1625: [build] workaround memory alignment bug in nss in ...
by GitHub 15 Nov '17

15 Nov '17

Branch: refs/heads/nss-workaround Home: https://github.com/kronosnet/kronosnet Commit: 6d1625538adedb911d47e6b2047573ee85780b2c https://github.com/kronosnet/kronosnet/commit/6d1625538adedb911d47e6b204757… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2017-11-15 (Wed, 15 Nov 2017) Changed paths: M build-aux/check.mk Log Message: ----------- [build] workaround memory alignment bug in nss in combination with valgrind on Linux/i386 Over the past few weeks, we noticed CI failing on i386 when running make check-memcheck (test suite executed with valgring). Those failures were not consistent and sometime random. After some heavy debugging it turns out that those failures are a combination of libnss3 internal memory allocator bug and valgrind internal memory allocator. Current libnss3 memory allocator expects a 16 bytes memory aligned buffer and in the event the memory is not aligned, it would round it. The issue is that, in performing this rounding, nss does not track properly the original address of the memory, and the equivalent of subsequent free of this buffer would fail, leaking memory and potentially accessing memory not allocated or corrpting memory. The nss bug is already fixed upstream by commit: changeset: 13557:52e38f913220 Valgrind on Linux/i386 memory allocator can return memory that is not aligned to the 16 bytes, contrary to what malloc/glibc does. Valgrind was returning (somehow randomly) a non aligned buffer to nss triggering the nss bug and the leak. By forcing valgrind to use aligned memory, nss bug does not trigger and there is no memory leak during the execution of the test suite. The memory leak never triggered when running knet in normal conditions. Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>

1 0

[kronosnet/kronosnet]
by GitHub 15 Nov '17

15 Nov '17

Branch: refs/heads/test-nss-leak Home: https://github.com/kronosnet/kronosnet

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Commits