Branch: refs/heads/update-gitignore
Home: https://github.com/kronosnet/kronosnet
Commit: e3effd0a2250ab7e608537df0bcbffa073d246fd
https://github.com/kronosnet/kronosnet/commit/e3effd0a2250ab7e608537df0bcbf…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2026-05-15 (Fri, 15 May 2026)
Changed paths:
M .gitignore
Log Message:
-----------
build: add .claude to .gitignore
Prevent accidental commit of Claude Code session data and configuration.
The .claude directory contains user-specific settings, conversation history,
and temporary files that should not be tracked in version control.
Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org>
Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com>
To unsubscribe from these emails, change your notification settings at https://github.com/kronosnet/kronosnet/settings/notifications
Branch: refs/heads/main
Home: https://github.com/kronosnet/kronosnet
Commit: 03e654af806751ac3718b2b3c04a20f8bc6955ad
https://github.com/kronosnet/kronosnet/commit/03e654af806751ac3718b2b3c04a2…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2026-05-09 (Sat, 09 May 2026)
Changed paths:
M libnozzle/libnozzle.c
Log Message:
-----------
libnozzle: use IFF_TUN_EXCL for exclusive TAP device creation
Add IFF_TUN_EXCL flag when creating named TAP devices to prevent race
conditions where another process creates the same device name between
check and creation. Available since Linux 3.4 with graceful fallback.
Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org>
Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com>
Commit: b67725ad290ff8d7e00365a8a282d4d6d3734566
https://github.com/kronosnet/kronosnet/commit/b67725ad290ff8d7e00365a8a282d…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2026-05-09 (Sat, 09 May 2026)
Changed paths:
M libnozzle/libnozzle.c
Log Message:
-----------
libnozzle: improve libnl error code translation
Replace generic errno values with proper error code translation from
libnl. Add nlerr_to_errno() helper that maps NLE_* codes to standard
errno values for better diagnostics when netlink operations fail.
Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org>
Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com>
Commit: a6798b0b51b24f6f78cf93c31c724655d3bf7c11
https://github.com/kronosnet/kronosnet/commit/a6798b0b51b24f6f78cf93c31c724…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2026-05-09 (Sat, 09 May 2026)
Changed paths:
M libnozzle/internals.h
M libnozzle/libnozzle.c
Log Message:
-----------
libnozzle: implement FreeBSD native ioctl for IP address management
Replace shell command execution with native ioctl calls using struct in_aliasreq (IPv4) and struct in6_aliasreq (IPv6).
Use separate AF_INET and AF_INET6 sockets for proper address family handling.
Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org>
Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com>
Commit: 051cd040da5215b7647ed5124ba0c6129db04487
https://github.com/kronosnet/kronosnet/commit/051cd040da5215b7647ed5124ba0c…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2026-05-09 (Sat, 09 May 2026)
Changed paths:
M libnozzle/libnozzle.c
Log Message:
-----------
libnozzle: implement Solaris native ioctl for IP address management
Replace shell command execution with native ioctl calls using struct lifreq.
Use per-interface AF_INET and AF_INET6 sockets for IPv4/IPv6 operations.
Set secondary=1 for IPv6 address deletion to match Solaris logical interface semantics.
Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org>
Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com>
Commit: 8c1dc621fb2c5ac334de0a32c4a66d9949d1edc6
https://github.com/kronosnet/kronosnet/commit/8c1dc621fb2c5ac334de0a32c4a66…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2026-05-14 (Thu, 14 May 2026)
Changed paths:
M libnozzle/Makefile.am
M libnozzle/internals.h
M libnozzle/libnozzle.c
A libnozzle/libnozzle_bsd.c
A libnozzle/libnozzle_linux.c
A libnozzle/libnozzle_solaris.c
Log Message:
-----------
libnozzle: refactor platform-specific code into dedicated files
Split platform-specific implementation from libnozzle.c into dedicated
files: libnozzle_linux.c, libnozzle_bsd.c, libnozzle_solaris.c.
Introduce platform abstraction layer with typedefs and macros in internals.h:
- nozzle_ifreq: Platform-specific ifreq structure type
- NOZZLE_SOCKET_DOMAIN: Socket domain for ioctl fd (AF_LOCAL on BSD)
- NOZZLE_IOCTL_FD: File descriptor for ioctl operations
- NOZZLE_SET_MTU: Platform-specific MTU ioctl command
- NOZZLE_IPV6_IS_SECONDARY(domain): IPv6 secondary interface check
This eliminates all platform-specific #ifdef blocks from libnozzle.c,
improving code organization and readability. Platform differences are
now documented in a single location (internals.h and platform-specific
files) rather than scattered throughout the main code.
Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org>
Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com>
Commit: 2ce260930cd76874cc4edb2dd1fa549c6cb4808e
https://github.com/kronosnet/kronosnet/commit/2ce260930cd76874cc4edb2dd1fa5…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2026-05-14 (Thu, 14 May 2026)
Changed paths:
M libnozzle/internals.c
M libnozzle/internals.h
M libnozzle/libnozzle_bsd.c
M libnozzle/libnozzle_linux.c
M libnozzle/libnozzle_solaris.c
Log Message:
-----------
libnozzle: refactor IP address helpers to reduce code duplication
Extract common IP address calculation logic from platform-specific functions
into shared helpers. Add _determine_family(), _validate_prefix(),
_ipv4_prefix_to_netmask(), and _ipv6_prefix_to_mask() to internals.c/h.
Include netinet/in.h in both files for struct in6_addr definition.
Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org>
Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com>
Commit: 13b31f2261e6352264b30b125d4c60489885132f
https://github.com/kronosnet/kronosnet/commit/13b31f2261e6352264b30b125d4c6…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2026-05-14 (Thu, 14 May 2026)
Changed paths:
M libnozzle/libnozzle_bsd.c
M libnozzle/libnozzle_linux.c
M libnozzle/libnozzle_solaris.c
Log Message:
-----------
libnozzle: consolidate platform-specific add_ip/del_ip implementations
Consolidate duplicate add/delete logic into platform-specific helpers:
Linux uses _netlink_modify_addr() for netlink operations, BSD uses
_bsd_modify_ipv4/6() for ioctl operations, Solaris uses _solaris_modify_ipv4/6()
with secondary interface support. Eliminates ~80 lines of duplication.
Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org>
Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com>
Commit: 2bb35f5e71dbf21263b49c941c9c2c32c6b2c1aa
https://github.com/kronosnet/kronosnet/commit/2bb35f5e71dbf21263b49c941c9c2…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2026-05-15 (Fri, 15 May 2026)
Changed paths:
M libnozzle/Makefile.am
M libnozzle/internals.c
M libnozzle/internals.h
M libnozzle/libnozzle.c
A libnozzle/libnozzle_bsd.c
A libnozzle/libnozzle_linux.c
A libnozzle/libnozzle_solaris.c
Log Message:
-----------
Merge pull request #480 from kronosnet/libnozzle-fixes
libnozzle: platform-specific refactoring and improvements
Compare: https://github.com/kronosnet/kronosnet/compare/f227fc63efd3...2bb35f5e71db
To unsubscribe from these emails, change your notification settings at https://github.com/kronosnet/kronosnet/settings/notifications
Branch: refs/heads/fix-testsuite
Home: https://github.com/kronosnet/kronosnet
Commit: 1894d3cab64614931e6b19d26e68721ebec3625d
https://github.com/kronosnet/kronosnet/commit/1894d3cab64614931e6b19d26e687…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2026-05-15 (Fri, 15 May 2026)
Changed paths:
M libknet/tests/test-common.c
M libknet/tests/test-common.h
Log Message:
-----------
tests: remove unused execute_shell and set_scheduler functions
Remove execute_shell() and its helper _read_pipe() from test-common.c/h.
Remove set_scheduler() function and its declaration.
Both functions were defined but never used anywhere in the test suite.
Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org>
Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com>
Commit: fcf1a30e3ceb41cf88134e4eb5afb2b420d3d534
https://github.com/kronosnet/kronosnet/commit/fcf1a30e3ceb41cf88134e4eb5afb…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2026-05-15 (Fri, 15 May 2026)
Changed paths:
M libknet/tests/test-common.c
M libknet/tests/test-common.h
Log Message:
-----------
tests: add log_test macro for test suite logging
Add log_test() macro to test-common.h that writes directly to the knet
logging infrastructure. Messages are sent with NULL handle and displayed
with [testsuite]: prefix.
Modify flush_logs() to handle NULL knet_h gracefully instead of aborting.
This allows test code to use the logging infrastructure without needing
a knet handle, making it easier to log test progress and debug information.
Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org>
Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com>
Commit: a6a03d040ca3e32c85813a80e1bc99161719ac94
https://github.com/kronosnet/kronosnet/commit/a6a03d040ca3e32c85813a80e1bc9…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2026-05-15 (Fri, 15 May 2026)
Changed paths:
M libknet/tests/test-common.c
M libknet/tests/test-common.h
Log Message:
-----------
tests: add timestamps to test suite log output
Add elapsed time timestamps to all log messages in format [seconds.milliseconds].
Time is measured from when setup_logpipes() is first called (test start).
This makes it easier to:
- Debug timing-sensitive test failures
- Identify performance bottlenecks in tests
- Correlate log messages with test events
Modified log_test() macro to take logfd as first parameter for consistency
with other logging patterns in the test suite.
Example output:
[ 0.000] [testsuite]: Test start
[ 1.000] [testsuite]: After 1 second
[ 3.000] [testsuite]: After 3 seconds total
Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org>
Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com>
Commit: 0d80473566ce1bb26dfadfd392d399fb08c78dd5
https://github.com/kronosnet/kronosnet/commit/0d80473566ce1bb26dfadfd392d39…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2026-05-15 (Fri, 15 May 2026)
Changed paths:
M libknet/tests/Makefile.am
M libknet/tests/api-check.mk
M libknet/tests/test-common.c
M libknet/tests/test-common.h
Log Message:
-----------
tests: add new test infrastructure for start_logging/stop_logging pattern
Make stop_logging() public with full state reset to enable mid-execution restart.
Add clean_exit_new(), knet_handle_start_new(), knet_handle_start_nodes_new() and _NEW
macro variants (CLEAN_EXIT_NEW, FAIL_ON_ERR_NEW, FAIL_ON_SUCCESS_NEW, etc.) for tests
using the new logging pattern. Update Makefile.am and api-check.mk to link test-common.c.
Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org>
Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com>
Commit: 2665bf8b2122767eee2b718c1a3378ea6424a4a0
https://github.com/kronosnet/kronosnet/commit/2665bf8b2122767eee2b718c1a337…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2026-05-15 (Fri, 15 May 2026)
Changed paths:
M libknet/tests/api_knet_addrtostr.c
M libknet/tests/api_knet_get_compress_list.c
M libknet/tests/api_knet_get_crypto_list.c
M libknet/tests/api_knet_get_transport_id_by_name.c
M libknet/tests/api_knet_get_transport_list.c
M libknet/tests/api_knet_get_transport_name_by_id.c
M libknet/tests/api_knet_handle_add_datafd.c
M libknet/tests/api_knet_handle_clear_stats.c
M libknet/tests/api_knet_handle_compress.c
M libknet/tests/api_knet_handle_crypto_rx_clear_traffic.c
M libknet/tests/api_knet_handle_crypto_set_config.c
M libknet/tests/api_knet_handle_crypto_use_config.c
M libknet/tests/api_knet_handle_enable_access_lists.c
M libknet/tests/api_knet_handle_enable_filter.c
M libknet/tests/api_knet_handle_enable_onwire_ver_notify.c
M libknet/tests/api_knet_handle_enable_pmtud_notify.c
M libknet/tests/api_knet_handle_enable_sock_notify.c
M libknet/tests/api_knet_handle_free.c
M libknet/tests/api_knet_handle_get_channel.c
M libknet/tests/api_knet_handle_get_datafd.c
M libknet/tests/api_knet_handle_get_host_defrag_bufs.c
M libknet/tests/api_knet_handle_get_onwire_ver.c
M libknet/tests/api_knet_handle_get_stats.c
M libknet/tests/api_knet_handle_get_threads_timer_res.c
M libknet/tests/api_knet_handle_get_transport_reconnect_interval.c
M libknet/tests/api_knet_handle_new.c
M libknet/tests/api_knet_handle_new_limit.c
M libknet/tests/api_knet_handle_pmtud_get.c
M libknet/tests/api_knet_handle_pmtud_getfreq.c
M libknet/tests/api_knet_handle_pmtud_set.c
M libknet/tests/api_knet_handle_pmtud_setfreq.c
M libknet/tests/api_knet_handle_remove_datafd.c
M libknet/tests/api_knet_handle_set_host_defrag_bufs.c
M libknet/tests/api_knet_handle_set_onwire_ver.c
M libknet/tests/api_knet_handle_set_threads_timer_res.c
M libknet/tests/api_knet_handle_set_transport_reconnect_interval.c
M libknet/tests/api_knet_handle_setfwd.c
M libknet/tests/api_knet_handle_setprio_dscp.c
M libknet/tests/api_knet_host_add.c
M libknet/tests/api_knet_host_enable_status_change_notify.c
M libknet/tests/api_knet_host_get_host_list.c
M libknet/tests/api_knet_host_get_id_by_host_name.c
M libknet/tests/api_knet_host_get_name_by_host_id.c
M libknet/tests/api_knet_host_get_policy.c
M libknet/tests/api_knet_host_get_status.c
M libknet/tests/api_knet_host_remove.c
M libknet/tests/api_knet_host_set_name.c
M libknet/tests/api_knet_host_set_policy.c
M libknet/tests/api_knet_link_add_acl.c
M libknet/tests/api_knet_link_clear_acl.c
M libknet/tests/api_knet_link_clear_config.c
M libknet/tests/api_knet_link_enable_status_change_notify.c
M libknet/tests/api_knet_link_get_config.c
M libknet/tests/api_knet_link_get_enable.c
M libknet/tests/api_knet_link_get_link_list.c
M libknet/tests/api_knet_link_get_ping_timers.c
M libknet/tests/api_knet_link_get_pong_count.c
M libknet/tests/api_knet_link_get_priority.c
M libknet/tests/api_knet_link_get_status.c
M libknet/tests/api_knet_link_insert_acl.c
M libknet/tests/api_knet_link_rm_acl.c
M libknet/tests/api_knet_link_set_config.c
M libknet/tests/api_knet_link_set_enable.c
M libknet/tests/api_knet_link_set_ping_timers.c
M libknet/tests/api_knet_link_set_pong_count.c
M libknet/tests/api_knet_link_set_priority.c
M libknet/tests/api_knet_log_get_loglevel.c
M libknet/tests/api_knet_log_get_loglevel_id.c
M libknet/tests/api_knet_log_get_loglevel_name.c
M libknet/tests/api_knet_log_get_subsystem_id.c
M libknet/tests/api_knet_log_get_subsystem_name.c
M libknet/tests/api_knet_log_set_loglevel.c
M libknet/tests/api_knet_recv.c
M libknet/tests/api_knet_send.c
M libknet/tests/api_knet_send_compress.c
M libknet/tests/api_knet_send_crypto.c
M libknet/tests/api_knet_send_loopback.c
M libknet/tests/api_knet_send_sync.c
M libknet/tests/api_knet_strtoaddr.c
M libknet/tests/fun_acl_check.c
M libknet/tests/fun_config_crypto.c
M libknet/tests/fun_config_crypto_ctr_test.c
M libknet/tests/fun_onwire_upgrade.c
M libknet/tests/fun_pmtud_crypto.c
M libknet/tests/int_links_acl_ip.c
M libknet/tests/int_timediff.c
Log Message:
-----------
tests: convert test suite to start_logging/stop_logging pattern
Convert all test files (79 api_*, 2 int_*, 5 fun_*) from old setup_logpipes
pattern to new start_logging/stop_logging pattern with log_test() macro.
Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org>
Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com>
Commit: 02cb2f5c92611272297c1868338dc33d5d4d1251
https://github.com/kronosnet/kronosnet/commit/02cb2f5c92611272297c1868338dc…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2026-05-15 (Fri, 15 May 2026)
Changed paths:
M libknet/tests/test-common.c
M libknet/tests/test-common.h
Log Message:
-----------
tests: remove old logging infrastructure and macros
Remove obsolete functions and macros after full test suite conversion:
- FAIL_ON_ERR, FAIL_ON_SUCCESS, FAIL_ON_ERR_ONLY, CLEAN_EXIT macros
- clean_exit(), knet_handle_start(), knet_handle_start_nodes() functions
- Obsolete WARNING comment about not using start_logging for api_/int_ tests
All tests now use _NEW variants with start_logging/stop_logging pattern.
Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org>
Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com>
Commit: f1b6afc15e10f249490401081c14138112b1b74a
https://github.com/kronosnet/kronosnet/commit/f1b6afc15e10f249490401081c141…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2026-05-15 (Fri, 15 May 2026)
Changed paths:
M libknet/tests/api_knet_handle_add_datafd.c
M libknet/tests/api_knet_handle_clear_stats.c
M libknet/tests/api_knet_handle_compress.c
M libknet/tests/api_knet_handle_crypto_rx_clear_traffic.c
M libknet/tests/api_knet_handle_crypto_set_config.c
M libknet/tests/api_knet_handle_crypto_use_config.c
M libknet/tests/api_knet_handle_enable_access_lists.c
M libknet/tests/api_knet_handle_enable_filter.c
M libknet/tests/api_knet_handle_enable_onwire_ver_notify.c
M libknet/tests/api_knet_handle_enable_pmtud_notify.c
M libknet/tests/api_knet_handle_enable_sock_notify.c
M libknet/tests/api_knet_handle_free.c
M libknet/tests/api_knet_handle_get_channel.c
M libknet/tests/api_knet_handle_get_datafd.c
M libknet/tests/api_knet_handle_get_host_defrag_bufs.c
M libknet/tests/api_knet_handle_get_onwire_ver.c
M libknet/tests/api_knet_handle_get_stats.c
M libknet/tests/api_knet_handle_get_threads_timer_res.c
M libknet/tests/api_knet_handle_get_transport_reconnect_interval.c
M libknet/tests/api_knet_handle_new.c
M libknet/tests/api_knet_handle_pmtud_get.c
M libknet/tests/api_knet_handle_pmtud_getfreq.c
M libknet/tests/api_knet_handle_pmtud_set.c
M libknet/tests/api_knet_handle_pmtud_setfreq.c
M libknet/tests/api_knet_handle_remove_datafd.c
M libknet/tests/api_knet_handle_set_host_defrag_bufs.c
M libknet/tests/api_knet_handle_set_onwire_ver.c
M libknet/tests/api_knet_handle_set_threads_timer_res.c
M libknet/tests/api_knet_handle_set_transport_reconnect_interval.c
M libknet/tests/api_knet_handle_setfwd.c
M libknet/tests/api_knet_handle_setprio_dscp.c
M libknet/tests/api_knet_host_add.c
M libknet/tests/api_knet_host_enable_status_change_notify.c
M libknet/tests/api_knet_host_get_host_list.c
M libknet/tests/api_knet_host_get_id_by_host_name.c
M libknet/tests/api_knet_host_get_name_by_host_id.c
M libknet/tests/api_knet_host_get_policy.c
M libknet/tests/api_knet_host_get_status.c
M libknet/tests/api_knet_host_remove.c
M libknet/tests/api_knet_host_set_name.c
M libknet/tests/api_knet_host_set_policy.c
M libknet/tests/api_knet_link_add_acl.c
M libknet/tests/api_knet_link_clear_acl.c
M libknet/tests/api_knet_link_clear_config.c
M libknet/tests/api_knet_link_enable_status_change_notify.c
M libknet/tests/api_knet_link_get_config.c
M libknet/tests/api_knet_link_get_enable.c
M libknet/tests/api_knet_link_get_link_list.c
M libknet/tests/api_knet_link_get_ping_timers.c
M libknet/tests/api_knet_link_get_pong_count.c
M libknet/tests/api_knet_link_get_priority.c
M libknet/tests/api_knet_link_get_status.c
M libknet/tests/api_knet_link_insert_acl.c
M libknet/tests/api_knet_link_rm_acl.c
M libknet/tests/api_knet_link_set_config.c
M libknet/tests/api_knet_link_set_enable.c
M libknet/tests/api_knet_link_set_ping_timers.c
M libknet/tests/api_knet_link_set_pong_count.c
M libknet/tests/api_knet_link_set_priority.c
M libknet/tests/api_knet_log_get_loglevel.c
M libknet/tests/api_knet_log_set_loglevel.c
M libknet/tests/api_knet_recv.c
M libknet/tests/api_knet_send.c
M libknet/tests/api_knet_send_compress.c
M libknet/tests/api_knet_send_crypto.c
M libknet/tests/api_knet_send_loopback.c
M libknet/tests/api_knet_send_sync.c
M libknet/tests/fun_acl_check.c
M libknet/tests/fun_config_crypto.c
M libknet/tests/fun_config_crypto_ctr_test.c
M libknet/tests/fun_onwire_upgrade.c
M libknet/tests/fun_pmtud_crypto.c
M libknet/tests/test-common.c
M libknet/tests/test-common.h
Log Message:
-----------
tests: rename _NEW macros and _new functions to standard names
Remove _NEW/_new suffixes from all macros and functions:
- FAIL_ON_ERR_NEW -> FAIL_ON_ERR
- FAIL_ON_SUCCESS_NEW -> FAIL_ON_SUCCESS
- FAIL_ON_ERR_ONLY_NEW -> FAIL_ON_ERR_ONLY
- FAIL_ON_ERR_THR_NEW -> FAIL_ON_ERR_THR
- CLEAN_EXIT_NEW -> CLEAN_EXIT
- clean_exit_new -> clean_exit
- knet_handle_start_new -> knet_handle_start
- knet_handle_start_nodes_new -> knet_handle_start_nodes
These are now the standard versions using start_logging/stop_logging pattern.
Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org>
Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com>
Commit: 3352183a8b574fa5c63bcf0a59da28635fdb1686
https://github.com/kronosnet/kronosnet/commit/3352183a8b574fa5c63bcf0a59da2…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2026-05-15 (Fri, 15 May 2026)
Changed paths:
M libknet/tests/api_knet_handle_clear_stats.c
M libknet/tests/api_knet_handle_pmtud_set.c
M libknet/tests/api_knet_handle_set_threads_timer_res.c
M libknet/tests/api_knet_host_remove.c
M libknet/tests/api_knet_link_add_acl.c
M libknet/tests/api_knet_link_clear_acl.c
M libknet/tests/api_knet_link_clear_config.c
M libknet/tests/api_knet_link_get_config.c
M libknet/tests/api_knet_link_get_enable.c
M libknet/tests/api_knet_link_get_link_list.c
M libknet/tests/api_knet_link_get_ping_timers.c
M libknet/tests/api_knet_link_get_pong_count.c
M libknet/tests/api_knet_link_get_priority.c
M libknet/tests/api_knet_link_get_status.c
M libknet/tests/api_knet_link_insert_acl.c
M libknet/tests/api_knet_link_rm_acl.c
M libknet/tests/api_knet_link_set_config.c
M libknet/tests/api_knet_link_set_enable.c
M libknet/tests/api_knet_link_set_ping_timers.c
M libknet/tests/api_knet_link_set_pong_count.c
M libknet/tests/api_knet_link_set_priority.c
M libknet/tests/api_knet_recv.c
M libknet/tests/api_knet_send.c
M libknet/tests/api_knet_send_compress.c
M libknet/tests/api_knet_send_crypto.c
M libknet/tests/api_knet_send_loopback.c
M libknet/tests/api_knet_send_sync.c
M libknet/tests/fun_acl_check.c
M libknet/tests/fun_config_crypto.c
M libknet/tests/fun_config_crypto_ctr_test.c
M libknet/tests/fun_onwire_upgrade.c
M libknet/tests/fun_pmtud_crypto.c
M libknet/tests/knet_bench.c
M libknet/tests/test-common.c
M libknet/tests/test-common.h
Log Message:
-----------
tests: convert to start_logging/stop_logging infrastructure
Migrate test suite from manual setup_logpipes() to unified start_logging()
and stop_logging() infrastructure with log_test() for test messages.
Changes:
- Convert all printf() calls in test functions to log_test()
- Add logfd parameter to helper functions that need logging
- Update knet_handle_stop_everything() and clean_exit() to use log_test()
instead of fprintf(stderr) and perror()
- Use static variables for logfd in callbacks
- Make internal helper functions static
This provides:
- Unified logging with timestamps
- Test messages appear as [testsuite]: in logs
- Clean separation of test progress from knet library logs
Note: knet_bench.c partially converted (uses start_logging but retains
printf for user-facing output). Full conversion will be done separately.
Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org>
Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com>
Commit: 65cbd17de38e3b18b47462d3e9c10d22ab34a1c3
https://github.com/kronosnet/kronosnet/commit/65cbd17de38e3b18b47462d3e9c10…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2026-05-15 (Fri, 15 May 2026)
Changed paths:
M libknet/tests/api_knet_addrtostr.c
M libknet/tests/api_knet_get_compress_list.c
M libknet/tests/api_knet_get_crypto_list.c
M libknet/tests/api_knet_get_transport_id_by_name.c
M libknet/tests/api_knet_get_transport_list.c
M libknet/tests/api_knet_get_transport_name_by_id.c
M libknet/tests/api_knet_handle_add_datafd.c
M libknet/tests/api_knet_handle_clear_stats.c
M libknet/tests/api_knet_handle_compress.c
M libknet/tests/api_knet_handle_crypto_rx_clear_traffic.c
M libknet/tests/api_knet_handle_crypto_set_config.c
M libknet/tests/api_knet_handle_crypto_use_config.c
M libknet/tests/api_knet_handle_enable_access_lists.c
M libknet/tests/api_knet_handle_enable_filter.c
M libknet/tests/api_knet_handle_enable_onwire_ver_notify.c
M libknet/tests/api_knet_handle_enable_pmtud_notify.c
M libknet/tests/api_knet_handle_enable_sock_notify.c
M libknet/tests/api_knet_handle_free.c
M libknet/tests/api_knet_handle_get_channel.c
M libknet/tests/api_knet_handle_get_datafd.c
M libknet/tests/api_knet_handle_get_host_defrag_bufs.c
M libknet/tests/api_knet_handle_get_onwire_ver.c
M libknet/tests/api_knet_handle_get_stats.c
M libknet/tests/api_knet_handle_get_threads_timer_res.c
M libknet/tests/api_knet_handle_get_transport_reconnect_interval.c
M libknet/tests/api_knet_handle_new.c
M libknet/tests/api_knet_handle_new_limit.c
M libknet/tests/api_knet_handle_pmtud_get.c
M libknet/tests/api_knet_handle_pmtud_getfreq.c
M libknet/tests/api_knet_handle_pmtud_set.c
M libknet/tests/api_knet_handle_pmtud_setfreq.c
M libknet/tests/api_knet_handle_remove_datafd.c
M libknet/tests/api_knet_handle_set_host_defrag_bufs.c
M libknet/tests/api_knet_handle_set_onwire_ver.c
M libknet/tests/api_knet_handle_set_threads_timer_res.c
M libknet/tests/api_knet_handle_set_transport_reconnect_interval.c
M libknet/tests/api_knet_handle_setfwd.c
M libknet/tests/api_knet_handle_setprio_dscp.c
M libknet/tests/api_knet_host_add.c
M libknet/tests/api_knet_host_enable_status_change_notify.c
M libknet/tests/api_knet_host_get_host_list.c
M libknet/tests/api_knet_host_get_id_by_host_name.c
M libknet/tests/api_knet_host_get_name_by_host_id.c
M libknet/tests/api_knet_host_get_policy.c
M libknet/tests/api_knet_host_get_status.c
M libknet/tests/api_knet_host_remove.c
M libknet/tests/api_knet_host_set_name.c
M libknet/tests/api_knet_host_set_policy.c
M libknet/tests/api_knet_link_add_acl.c
M libknet/tests/api_knet_link_clear_acl.c
M libknet/tests/api_knet_link_clear_config.c
M libknet/tests/api_knet_link_enable_status_change_notify.c
M libknet/tests/api_knet_link_get_config.c
M libknet/tests/api_knet_link_get_enable.c
M libknet/tests/api_knet_link_get_link_list.c
M libknet/tests/api_knet_link_get_ping_timers.c
M libknet/tests/api_knet_link_get_pong_count.c
M libknet/tests/api_knet_link_get_priority.c
M libknet/tests/api_knet_link_get_status.c
M libknet/tests/api_knet_link_insert_acl.c
M libknet/tests/api_knet_link_rm_acl.c
M libknet/tests/api_knet_link_set_config.c
M libknet/tests/api_knet_link_set_enable.c
M libknet/tests/api_knet_link_set_ping_timers.c
M libknet/tests/api_knet_link_set_pong_count.c
M libknet/tests/api_knet_link_set_priority.c
M libknet/tests/api_knet_log_get_loglevel.c
M libknet/tests/api_knet_log_get_loglevel_id.c
M libknet/tests/api_knet_log_get_loglevel_name.c
M libknet/tests/api_knet_log_get_subsystem_id.c
M libknet/tests/api_knet_log_get_subsystem_name.c
M libknet/tests/api_knet_log_set_loglevel.c
M libknet/tests/api_knet_recv.c
M libknet/tests/api_knet_send.c
M libknet/tests/api_knet_send_compress.c
M libknet/tests/api_knet_send_crypto.c
M libknet/tests/api_knet_send_loopback.c
M libknet/tests/api_knet_send_sync.c
M libknet/tests/api_knet_strtoaddr.c
M libknet/tests/fun_acl_check.c
M libknet/tests/fun_config_crypto.c
M libknet/tests/fun_config_crypto_ctr_test.c
M libknet/tests/fun_onwire_upgrade.c
M libknet/tests/fun_pmtud_crypto.c
M libknet/tests/int_links_acl_ip.c
M libknet/tests/int_timediff.c
M libknet/tests/test-common.c
M libknet/tests/test-common.h
Log Message:
-----------
tests: standardize test result output and exit handling
Add TEST_EXIT() macro to print consistent [PASS]/[FAIL]/[SKIP]/[ERROR] markers
and exit with proper code. Convert all exit() and return statements in test
suite to use TEST_EXIT(). Update CLEAN_EXIT() to call TEST_EXIT() instead of
duplicating exit logic. Remove unused exit_local() helper. Fix capitalization
in test descriptions (Knet → knet).
Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org>
Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com>
Commit: c49d1b6d9b848497b43c7fba47e975f60564062d
https://github.com/kronosnet/kronosnet/commit/c49d1b6d9b848497b43c7fba47e97…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2026-05-15 (Fri, 15 May 2026)
Changed paths:
M libknet/tests/api_knet_addrtostr.c
M libknet/tests/api_knet_get_compress_list.c
M libknet/tests/api_knet_get_crypto_list.c
M libknet/tests/api_knet_get_transport_id_by_name.c
M libknet/tests/api_knet_get_transport_list.c
M libknet/tests/api_knet_get_transport_name_by_id.c
M libknet/tests/api_knet_handle_add_datafd.c
M libknet/tests/api_knet_handle_clear_stats.c
M libknet/tests/api_knet_handle_compress.c
M libknet/tests/api_knet_handle_crypto_rx_clear_traffic.c
M libknet/tests/api_knet_handle_crypto_set_config.c
M libknet/tests/api_knet_handle_crypto_use_config.c
M libknet/tests/api_knet_handle_enable_access_lists.c
M libknet/tests/api_knet_handle_enable_filter.c
M libknet/tests/api_knet_handle_enable_onwire_ver_notify.c
M libknet/tests/api_knet_handle_enable_pmtud_notify.c
M libknet/tests/api_knet_handle_enable_sock_notify.c
M libknet/tests/api_knet_handle_free.c
M libknet/tests/api_knet_handle_get_channel.c
M libknet/tests/api_knet_handle_get_datafd.c
M libknet/tests/api_knet_handle_get_host_defrag_bufs.c
M libknet/tests/api_knet_handle_get_onwire_ver.c
M libknet/tests/api_knet_handle_get_stats.c
M libknet/tests/api_knet_handle_get_threads_timer_res.c
M libknet/tests/api_knet_handle_get_transport_reconnect_interval.c
M libknet/tests/api_knet_handle_new.c
M libknet/tests/api_knet_handle_new_limit.c
M libknet/tests/api_knet_handle_pmtud_get.c
M libknet/tests/api_knet_handle_pmtud_getfreq.c
M libknet/tests/api_knet_handle_pmtud_set.c
M libknet/tests/api_knet_handle_pmtud_setfreq.c
M libknet/tests/api_knet_handle_remove_datafd.c
M libknet/tests/api_knet_handle_set_host_defrag_bufs.c
M libknet/tests/api_knet_handle_set_onwire_ver.c
M libknet/tests/api_knet_handle_set_threads_timer_res.c
M libknet/tests/api_knet_handle_set_transport_reconnect_interval.c
M libknet/tests/api_knet_handle_setfwd.c
M libknet/tests/api_knet_handle_setprio_dscp.c
M libknet/tests/api_knet_host_add.c
M libknet/tests/api_knet_host_enable_status_change_notify.c
M libknet/tests/api_knet_host_get_host_list.c
M libknet/tests/api_knet_host_get_id_by_host_name.c
M libknet/tests/api_knet_host_get_name_by_host_id.c
M libknet/tests/api_knet_host_get_policy.c
M libknet/tests/api_knet_host_get_status.c
M libknet/tests/api_knet_host_remove.c
M libknet/tests/api_knet_host_set_name.c
M libknet/tests/api_knet_host_set_policy.c
M libknet/tests/api_knet_link_add_acl.c
M libknet/tests/api_knet_link_clear_acl.c
M libknet/tests/api_knet_link_clear_config.c
M libknet/tests/api_knet_link_enable_status_change_notify.c
M libknet/tests/api_knet_link_get_config.c
M libknet/tests/api_knet_link_get_enable.c
M libknet/tests/api_knet_link_get_link_list.c
M libknet/tests/api_knet_link_get_ping_timers.c
M libknet/tests/api_knet_link_get_pong_count.c
M libknet/tests/api_knet_link_get_priority.c
M libknet/tests/api_knet_link_get_status.c
M libknet/tests/api_knet_link_insert_acl.c
M libknet/tests/api_knet_link_rm_acl.c
M libknet/tests/api_knet_link_set_config.c
M libknet/tests/api_knet_link_set_enable.c
M libknet/tests/api_knet_link_set_ping_timers.c
M libknet/tests/api_knet_link_set_pong_count.c
M libknet/tests/api_knet_link_set_priority.c
M libknet/tests/api_knet_log_get_loglevel.c
M libknet/tests/api_knet_log_get_loglevel_id.c
M libknet/tests/api_knet_log_get_loglevel_name.c
M libknet/tests/api_knet_log_get_subsystem_id.c
M libknet/tests/api_knet_log_get_subsystem_name.c
M libknet/tests/api_knet_log_set_loglevel.c
M libknet/tests/api_knet_recv.c
M libknet/tests/api_knet_send.c
M libknet/tests/api_knet_send_compress.c
M libknet/tests/api_knet_send_crypto.c
M libknet/tests/api_knet_send_loopback.c
M libknet/tests/api_knet_send_sync.c
M libknet/tests/api_knet_strtoaddr.c
M libknet/tests/fun_acl_check.c
M libknet/tests/fun_config_crypto.c
M libknet/tests/fun_config_crypto_ctr_test.c
M libknet/tests/fun_onwire_upgrade.c
M libknet/tests/fun_pmtud_crypto.c
M libknet/tests/int_links_acl_ip.c
M libknet/tests/int_timediff.c
M libknet/tests/test-common.c
M libknet/tests/test-common.h
Log Message:
-----------
tests: refactor exit macros - rename CLEAN_EXIT to TEST_EXIT_CLEAN
Rename CLEAN_EXIT to TEST_EXIT_CLEAN for clearer semantics.
Remove clean_exit function and inline logic into TEST_EXIT_CLEAN macro.
Add stop_logging() to TEST_EXIT macro to ensure cleanup.
Remove redundant stop_logging() calls immediately before TEST_EXIT/TEST_EXIT_CLEAN.
Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org>
Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com>
Commit: f5fd3aa34b797b0398ea952e8b1045fae1f0bb46
https://github.com/kronosnet/kronosnet/commit/f5fd3aa34b797b0398ea952e8b104…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2026-05-15 (Fri, 15 May 2026)
Changed paths:
M libknet/tests/api_knet_handle_add_datafd.c
M libknet/tests/api_knet_handle_clear_stats.c
M libknet/tests/api_knet_handle_compress.c
M libknet/tests/api_knet_handle_crypto_rx_clear_traffic.c
M libknet/tests/api_knet_handle_crypto_set_config.c
M libknet/tests/api_knet_handle_crypto_use_config.c
M libknet/tests/api_knet_handle_enable_access_lists.c
M libknet/tests/api_knet_handle_enable_filter.c
M libknet/tests/api_knet_handle_enable_onwire_ver_notify.c
M libknet/tests/api_knet_handle_enable_pmtud_notify.c
M libknet/tests/api_knet_handle_enable_sock_notify.c
M libknet/tests/api_knet_handle_free.c
M libknet/tests/api_knet_handle_get_channel.c
M libknet/tests/api_knet_handle_get_datafd.c
M libknet/tests/api_knet_handle_get_host_defrag_bufs.c
M libknet/tests/api_knet_handle_get_onwire_ver.c
M libknet/tests/api_knet_handle_get_stats.c
M libknet/tests/api_knet_handle_get_threads_timer_res.c
M libknet/tests/api_knet_handle_get_transport_reconnect_interval.c
M libknet/tests/api_knet_handle_new.c
M libknet/tests/api_knet_handle_pmtud_get.c
M libknet/tests/api_knet_handle_pmtud_getfreq.c
M libknet/tests/api_knet_handle_pmtud_set.c
M libknet/tests/api_knet_handle_pmtud_setfreq.c
M libknet/tests/api_knet_handle_remove_datafd.c
M libknet/tests/api_knet_handle_set_host_defrag_bufs.c
M libknet/tests/api_knet_handle_set_onwire_ver.c
M libknet/tests/api_knet_handle_set_threads_timer_res.c
M libknet/tests/api_knet_handle_set_transport_reconnect_interval.c
M libknet/tests/api_knet_handle_setfwd.c
M libknet/tests/api_knet_handle_setprio_dscp.c
M libknet/tests/api_knet_host_add.c
M libknet/tests/api_knet_host_enable_status_change_notify.c
M libknet/tests/api_knet_host_get_host_list.c
M libknet/tests/api_knet_host_get_id_by_host_name.c
M libknet/tests/api_knet_host_get_name_by_host_id.c
M libknet/tests/api_knet_host_get_policy.c
M libknet/tests/api_knet_host_get_status.c
M libknet/tests/api_knet_host_remove.c
M libknet/tests/api_knet_host_set_name.c
M libknet/tests/api_knet_host_set_policy.c
M libknet/tests/api_knet_link_add_acl.c
M libknet/tests/api_knet_link_clear_acl.c
M libknet/tests/api_knet_link_clear_config.c
M libknet/tests/api_knet_link_enable_status_change_notify.c
M libknet/tests/api_knet_link_get_config.c
M libknet/tests/api_knet_link_get_enable.c
M libknet/tests/api_knet_link_get_link_list.c
M libknet/tests/api_knet_link_get_ping_timers.c
M libknet/tests/api_knet_link_get_pong_count.c
M libknet/tests/api_knet_link_get_priority.c
M libknet/tests/api_knet_link_get_status.c
M libknet/tests/api_knet_link_insert_acl.c
M libknet/tests/api_knet_link_rm_acl.c
M libknet/tests/api_knet_link_set_config.c
M libknet/tests/api_knet_link_set_enable.c
M libknet/tests/api_knet_link_set_ping_timers.c
M libknet/tests/api_knet_link_set_pong_count.c
M libknet/tests/api_knet_link_set_priority.c
M libknet/tests/api_knet_log_get_loglevel.c
M libknet/tests/api_knet_log_set_loglevel.c
M libknet/tests/api_knet_recv.c
M libknet/tests/api_knet_send.c
M libknet/tests/api_knet_send_compress.c
M libknet/tests/api_knet_send_crypto.c
M libknet/tests/api_knet_send_loopback.c
M libknet/tests/api_knet_send_sync.c
M libknet/tests/fun_acl_check.c
M libknet/tests/fun_config_crypto.c
M libknet/tests/fun_config_crypto_ctr_test.c
M libknet/tests/fun_onwire_upgrade.c
M libknet/tests/fun_pmtud_crypto.c
M libknet/tests/knet_bench.c
M libknet/tests/test-common.c
M libknet/tests/test-common.h
Log Message:
-----------
tests: rename knet_* test helpers to _ts_knet_* to avoid namespace collision
Rename test suite helpers that wrap libknet API to use _ts_ prefix (test suite)
to clearly distinguish them from the public libknet API functions:
- knet_handle_start → _ts_knet_handle_start
- knet_handle_stop_everything → _ts_knet_handle_stop_everything
- knet_handle_start_nodes → _ts_knet_handle_start_nodes
- knet_handle_join_nodes → _ts_knet_handle_join_nodes
- knet_handle_disconnect_links → _ts_knet_handle_disconnect_links
- knet_handle_reconnect_links → _ts_knet_handle_reconnect_links
- _knet_link_set_config → _ts_knet_link_set_config
This prevents confusion between test infrastructure and library API.
Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org>
Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com>
Commit: 9706e99e45db09e4a23e6e10078fe441823d7544
https://github.com/kronosnet/kronosnet/commit/9706e99e45db09e4a23e6e10078fe…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2026-05-15 (Fri, 15 May 2026)
Changed paths:
M libknet/tests/api_knet_handle_pmtud_set.c
M libknet/tests/api_knet_recv.c
M libknet/tests/fun_config_crypto.c
M libknet/tests/fun_onwire_upgrade.c
M libknet/tests/test-common.c
M libknet/tests/test-common.h
Log Message:
-----------
tests: improve test_sleep() function
Standardize test_sleep() signature and add logging for better diagnostics.
Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org>
Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com>
Commit: 123bb3aee4aaf6c305ef66dedb2158086095968b
https://github.com/kronosnet/kronosnet/commit/123bb3aee4aaf6c305ef66dedb215…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2026-05-15 (Fri, 15 May 2026)
Changed paths:
M libknet/tests/knet_bench.c
Log Message:
-----------
tests: improve knet_bench infrastructure
Make logfd static and use TEST_EXIT macros throughout for consistency
with test suite standards.
Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org>
Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com>
Commit: 25a34fd02fda387bbdd5b8e9955caa8efdee0583
https://github.com/kronosnet/kronosnet/commit/25a34fd02fda387bbdd5b8e9955ca…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2026-05-15 (Fri, 15 May 2026)
Changed paths:
M libknet/tests/Makefile.am
A libknet/tests/fun_config_crypto_ctr.c
R libknet/tests/fun_config_crypto_ctr_test.c
Log Message:
-----------
tests: rename fun_config_crypto_ctr_test.c to match naming standard
Rename fun_config_crypto_ctr_test.c to fun_config_crypto_ctr.c to match
the naming convention used by other test files.
Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org>
Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com>
Commit: b27426e9827a94ca3ddcf2b7cc0dd25bc98ec4f6
https://github.com/kronosnet/kronosnet/commit/b27426e9827a94ca3ddcf2b7cc0dd…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2026-05-15 (Fri, 15 May 2026)
Changed paths:
M libknet/tests/api_knet_handle_free.c
M libknet/tests/fun_pmtud_crypto.c
Log Message:
-----------
tests: remove redundant TESTNODES definitions
Remove redundant TESTNODES=1 definitions from api_knet_handle_free.c and
fun_pmtud_crypto.c since test-common.h already defines TESTNODES=1 as the
default value.
Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org>
Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com>
Commit: 7fd22122a876c44a22009758d1d9357633a21697
https://github.com/kronosnet/kronosnet/commit/7fd22122a876c44a22009758d1d93…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2026-05-15 (Fri, 15 May 2026)
Changed paths:
M libknet/tests/fun_acl_check.c
M libknet/tests/fun_config_crypto.c
M libknet/tests/fun_onwire_upgrade.c
M libknet/tests/test-common.c
M libknet/tests/test-common.h
Log Message:
-----------
tests: consolidate timeout and wait_for_reply handling
Centralize valgrind timeout adjustment and wait_for_reply() function:
- Add adjust_timeout_for_valgrind() helper in test-common.c
- Move timeout adjustment to wait_for_reply() (used by wait_for_host and wait_for_nodes_state)
- Make wait_for_reply() shared, remove duplicate from fun_acl_check.c
- Update test_sleep() and wait_for_packet() to use helper
- Remove duplicate valgrind checks from fun_config_crypto.c, fun_acl_check.c, fun_onwire_upgrade.c
Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org>
Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com>
Commit: 862ec86e41e89fc0f1234187422ecfc05a222f9b
https://github.com/kronosnet/kronosnet/commit/862ec86e41e89fc0f1234187422ec…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2026-05-15 (Fri, 15 May 2026)
Changed paths:
M libknet/tests/api_knet_handle_add_datafd.c
M libknet/tests/api_knet_handle_compress.c
M libknet/tests/api_knet_handle_crypto_rx_clear_traffic.c
M libknet/tests/api_knet_handle_crypto_set_config.c
M libknet/tests/api_knet_handle_crypto_use_config.c
M libknet/tests/api_knet_handle_enable_access_lists.c
M libknet/tests/api_knet_handle_enable_filter.c
M libknet/tests/api_knet_handle_enable_onwire_ver_notify.c
M libknet/tests/api_knet_handle_enable_pmtud_notify.c
M libknet/tests/api_knet_handle_enable_sock_notify.c
M libknet/tests/api_knet_handle_free.c
M libknet/tests/api_knet_handle_get_channel.c
M libknet/tests/api_knet_handle_get_datafd.c
M libknet/tests/api_knet_handle_get_host_defrag_bufs.c
M libknet/tests/api_knet_handle_get_onwire_ver.c
M libknet/tests/api_knet_handle_get_stats.c
M libknet/tests/api_knet_handle_get_threads_timer_res.c
M libknet/tests/api_knet_handle_get_transport_reconnect_interval.c
M libknet/tests/api_knet_handle_pmtud_get.c
M libknet/tests/api_knet_handle_pmtud_getfreq.c
M libknet/tests/api_knet_handle_pmtud_set.c
M libknet/tests/api_knet_handle_pmtud_setfreq.c
M libknet/tests/api_knet_handle_remove_datafd.c
M libknet/tests/api_knet_handle_set_host_defrag_bufs.c
M libknet/tests/api_knet_handle_set_onwire_ver.c
M libknet/tests/api_knet_handle_set_threads_timer_res.c
M libknet/tests/api_knet_handle_set_transport_reconnect_interval.c
M libknet/tests/api_knet_handle_setfwd.c
M libknet/tests/api_knet_handle_setprio_dscp.c
M libknet/tests/api_knet_host_add.c
M libknet/tests/api_knet_host_enable_status_change_notify.c
M libknet/tests/api_knet_host_get_host_list.c
M libknet/tests/api_knet_host_get_id_by_host_name.c
M libknet/tests/api_knet_host_get_name_by_host_id.c
M libknet/tests/api_knet_host_get_policy.c
M libknet/tests/api_knet_host_get_status.c
M libknet/tests/api_knet_host_remove.c
M libknet/tests/api_knet_host_set_name.c
M libknet/tests/api_knet_host_set_policy.c
M libknet/tests/api_knet_link_add_acl.c
M libknet/tests/api_knet_link_clear_acl.c
M libknet/tests/api_knet_link_clear_config.c
M libknet/tests/api_knet_link_enable_status_change_notify.c
M libknet/tests/api_knet_link_get_config.c
M libknet/tests/api_knet_link_get_enable.c
M libknet/tests/api_knet_link_get_link_list.c
M libknet/tests/api_knet_link_get_ping_timers.c
M libknet/tests/api_knet_link_get_pong_count.c
M libknet/tests/api_knet_link_get_priority.c
M libknet/tests/api_knet_link_get_status.c
M libknet/tests/api_knet_link_insert_acl.c
M libknet/tests/api_knet_link_rm_acl.c
M libknet/tests/api_knet_link_set_config.c
M libknet/tests/api_knet_link_set_enable.c
M libknet/tests/api_knet_link_set_ping_timers.c
M libknet/tests/api_knet_link_set_pong_count.c
M libknet/tests/api_knet_link_set_priority.c
M libknet/tests/api_knet_log_get_loglevel.c
M libknet/tests/api_knet_log_set_loglevel.c
M libknet/tests/api_knet_recv.c
M libknet/tests/api_knet_send.c
M libknet/tests/api_knet_send_sync.c
M libknet/tests/test-common.c
Log Message:
-----------
tests: improve error handling consistency in API tests
Replace verbose error checks with FAIL_ON_SUCCESS macro in 61 API tests.
Initialize knet_h arrays to prevent coverity UNINIT warnings.
Add NULL check in _ts_knet_handle_stop_everything() for safe cleanup.
Fixes 53 coverity defects, reduces test code by 184 lines.
Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org>
Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com>
Commit: bd0e8c4ac3a8a398c6c42c88fdc12ccbd150e367
https://github.com/kronosnet/kronosnet/commit/bd0e8c4ac3a8a398c6c42c88fdc12…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2026-05-15 (Fri, 15 May 2026)
Changed paths:
M libknet/tests/api_knet_handle_clear_stats.c
M libknet/tests/api_knet_handle_pmtud_set.c
M libknet/tests/api_knet_recv.c
M libknet/tests/api_knet_send.c
M libknet/tests/api_knet_send_compress.c
M libknet/tests/api_knet_send_crypto.c
M libknet/tests/api_knet_send_loopback.c
M libknet/tests/api_knet_send_sync.c
M libknet/tests/fun_config_crypto.c
M libknet/tests/fun_config_crypto_ctr.c
M libknet/tests/fun_pmtud_crypto.c
M libknet/tests/test-common.c
M libknet/tests/test-common.h
Log Message:
-----------
tests: replace magic numbers with named constants
Add timeout constants (TEST_TIMEOUT_LONG/SHORT/QUICK) and port range
constants (TEST_PORT_*) to test-common.h. Replace all hardcoded values
throughout test suite for better readability and maintainability.
Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org>
Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com>
Commit: ed742b958ab5622fd7d36b1996fd6e64ac47a21f
https://github.com/kronosnet/kronosnet/commit/ed742b958ab5622fd7d36b1996fd6…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2026-05-15 (Fri, 15 May 2026)
Changed paths:
M libknet/tests/api_knet_addrtostr.c
M libknet/tests/api_knet_get_compress_list.c
M libknet/tests/api_knet_get_crypto_list.c
M libknet/tests/api_knet_get_transport_list.c
M libknet/tests/api_knet_strtoaddr.c
M libknet/tests/test-common.h
Log Message:
-----------
tests: add NOCLEAN macro variants for tests without knet handles
Add FAIL_ON_ERR_NOCLEAN and FAIL_ON_SUCCESS_NOCLEAN macros for tests
that don't create knet handles and don't need cleanup infrastructure.
Convert 5 API tests to use new macros (11 error checks total):
- api_knet_addrtostr.c (4 checks)
- api_knet_strtoaddr.c (4 checks)
- api_knet_get_compress_list.c (1 check)
- api_knet_get_crypto_list.c (1 check)
- api_knet_get_transport_list.c (1 check)
Reduces test code by 37 lines and improves consistency with other tests.
Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org>
Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com>
Commit: 4390256708585f566837861f40729c65ba3c4e4e
https://github.com/kronosnet/kronosnet/commit/4390256708585f566837861f40729…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2026-05-15 (Fri, 15 May 2026)
Changed paths:
M libknet/tests/api_knet_recv.c
Log Message:
-----------
tests: remove commented-out dead code from api_knet_recv test
The commented-out writev() call was replaced by knet_send() during the
test infrastructure migration and is no longer needed.
Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org>
Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com>
Commit: 54aeac27007c8c6cd84c9a4c708598041bb093aa
https://github.com/kronosnet/kronosnet/commit/54aeac27007c8c6cd84c9a4c70859…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2026-05-15 (Fri, 15 May 2026)
Changed paths:
M libknet/tests/api_knet_handle_clear_stats.c
M libknet/tests/api_knet_handle_pmtud_set.c
M libknet/tests/api_knet_recv.c
M libknet/tests/api_knet_send.c
M libknet/tests/api_knet_send_compress.c
M libknet/tests/api_knet_send_crypto.c
M libknet/tests/api_knet_send_loopback.c
M libknet/tests/api_knet_send_sync.c
M libknet/tests/fun_acl_check.c
M libknet/tests/fun_config_crypto.c
M libknet/tests/fun_config_crypto_ctr.c
M libknet/tests/fun_onwire_upgrade.c
M libknet/tests/fun_pmtud_crypto.c
M libknet/tests/test-common.c
M libknet/tests/test-common.h
Log Message:
-----------
tests: remove flush_logs() and unused FILE *std parameter
The log thread continuously drains the log pipe, so manual flush_logs()
calls are unnecessary. Remove them and the now-unused FILE *std parameter
from wait_for_packet(), wait_for_host(), and wait_for_nodes_state().
Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org>
Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com>
Commit: 5b91abf4462f9df4fbb06c9efda0fc3b2b908352
https://github.com/kronosnet/kronosnet/commit/5b91abf4462f9df4fbb06c9efda0f…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2026-05-15 (Fri, 15 May 2026)
Changed paths:
M libknet/tests/test-common.h
Log Message:
-----------
tests: add comprehensive documentation to test-common.h
Add detailed documentation for all test infrastructure macros and helper
functions. Each macro and function now has a description, parameter
documentation, return value documentation, and usage notes where
applicable.
Documentation covers:
- Test result codes (PASS, FAIL, SKIP, ERROR, CONTINUE)
- Timeout and port constants
- Test macros (TEST_EXIT_CLEAN, FAIL_ON_ERR, FAIL_ON_SUCCESS, etc.)
- NOCLEAN variants for tests without knet handles
- Runtime environment detection (is_memcheck, is_helgrind)
- Handle management (_ts_knet_handle_start, _ts_knet_link_set_config)
- Multi-node helpers (_ts_knet_handle_join_nodes, etc.)
- Logging infrastructure (start_logging, stop_logging)
- Address helpers (make_local_sockaddr, make_local_sockaddr6)
- Wait and timing helpers (wait_for_host, wait_for_packet, etc.)
Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org>
Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com>
Compare: https://github.com/kronosnet/kronosnet/compare/1894d3cab646%5E...5b91abf446…
To unsubscribe from these emails, change your notification settings at https://github.com/kronosnet/kronosnet/settings/notifications
4/82 Non-voting fails: fedora-43-power9-ppc64le(nonvoting-clang: Build source) alpine-x86-64(nonvoting-clang: Build source) alpine-x86-64(nonvoting-clang_debug: Build source) fedora-43-power9-ppc64le(nonvoting-clang_debug: Build source)
3/75 Voting fails: fedora-43-power9-ppc64le(voting: Build source) fedora-43-power9-ppc64le(voting_debug: Build source) fedora-43-power9-ppc64le(buildrpms: Setup RPMs)
Run reason: Pull request #482 opened
Total runtime: 2 hr 1 min
Split logs: https://ci.kronosnet.org/job/kronosnet/job/kronosnet-pipeline/job/PR-482/1/…
Full log: https://ci.kronosnet.org/job/kronosnet/job/kronosnet-pipeline/job/PR-482/1/…
Full Coverity results:
http://ci.kronosnet.org/coverity/kronosnet/rhel-8-coverity-x86-64/pr482//1http://ci.kronosnet.org/coverity/kronosnet/rhel-10-coverity-x86-64/pr482//1http://ci.kronosnet.org/coverity/kronosnet/rhel-9-coverity-x86-64/pr482//1
Please report the following errors to your friendly local Jenkins admin (though they have probably already seen them and are already panicking).
Exception caught on freebsd-devel-x86-64 during nonvoting: org.jenkinsci.plugins.workflow.steps.FlowInterruptedException:
Exception caught on freebsd-devel-x86-64 during nonvoting_debug: org.jenkinsci.plugins.workflow.steps.FlowInterruptedException:
Exception caught on freebsd-devel-x86-64 during nonvoting-clang: org.jenkinsci.plugins.workflow.steps.FlowInterruptedException:
Exception caught on freebsd-devel-x86-64 during nonvoting-clang_debug: org.jenkinsci.plugins.workflow.steps.FlowInterruptedException:
Exception caught on fedora-42-x86-64 during buildrpms: org.jenkinsci.plugins.workflow.steps.FlowInterruptedException:
Exception caught on fedora-43-x86-64 during buildrpms: org.jenkinsci.plugins.workflow.steps.FlowInterruptedException:
Exception caught on fedora-rawhide-power9-ppc64le during buildrpms: org.jenkinsci.plugins.workflow.steps.FlowInterruptedException:
Exception caught on fedora-rawhide-x86-64 during buildrpms: org.jenkinsci.plugins.workflow.steps.FlowInterruptedException: