Commits July 2021

commits@lists.kronosnet.org

2 participants
80 discussions

[kronosnet/kronosnet] cc5097: [acl] make knet_link_add_acl a wrapper to knet_lin...
by Fabio M. Di Nitto 27 Jul '21

27 Jul '21

Branch: refs/heads/fix-acl Home: https://github.com/kronosnet/kronosnet Commit: cc5097ef95f3c084e532ecb483dedd712940de82 https://github.com/kronosnet/kronosnet/commit/cc5097ef95f3c084e532ecb483ded… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2021-07-27 (Tue, 27 Jul 2021) Changed paths: M libknet/links.c Log Message: ----------- [acl] make knet_link_add_acl a wrapper to knet_link_insert_acl remove lots of duplicated code Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: bf5d852231f5b5662d18188135b24a831506b6be https://github.com/kronosnet/kronosnet/commit/bf5d852231f5b5662d18188135b24… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2021-07-27 (Tue, 27 Jul 2021) Changed paths: M libknet/internals.h M libknet/links.c M libknet/links_acl.c M libknet/links_acl.h M libknet/links_acl_ip.c M libknet/tests/Makefile.am M libknet/tests/api_knet_link_add_acl.c M libknet/tests/api_knet_link_clear_acl.c M libknet/tests/api_knet_link_insert_acl.c M libknet/tests/api_knet_link_rm_acl.c M libknet/tests/api_knet_link_set_config.c M libknet/tests/api_knet_send.c A libknet/tests/fun_acl_check.c M libknet/tests/test-common.c M libknet/threads_rx.c M libknet/transport_sctp.c Log Message: ----------- [acl] major internal rework ACL internal management was somewhat broken and didn´t really do what was advertised for dynamic links. - fix ACL to be truely per host/link as public API advertise - move ACL checking when host/link are known - add extensive tests - fix various minor bugs that went undetected for a bit - enable access list testings on more tests Signed-off-by: Christine Caulfield <ccaulfie(a)redhat.com> Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: c75a249970eaf641fe59da4b1a94dcd74f55226d https://github.com/kronosnet/kronosnet/commit/c75a249970eaf641fe59da4b1a94d… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2021-07-27 (Tue, 27 Jul 2021) Changed paths: M libknet/internals.h M libknet/transport_loopback.c M libknet/transport_loopback.h M libknet/transport_sctp.c M libknet/transport_sctp.h M libknet/transport_udp.c M libknet/transport_udp.h M libknet/transports.c M libknet/transports.h Log Message: ----------- [transports] remove unused internal ACL API with the new ACL code, this internal API is no longer used Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 313691bca43b5509c50ef34cfe31b226be1a22fe https://github.com/kronosnet/kronosnet/commit/313691bca43b5509c50ef34cfe31b… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2021-07-27 (Tue, 27 Jul 2021) Changed paths: M configure.ac M libknet/tests/Makefile.am Log Message: ----------- [tests] make execution of functional testing optionals Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Compare: https://github.com/kronosnet/kronosnet/compare/68c1b93f9c37...313691bca43b

1 0

pacemaker-build-covscan - Build # 1703 - Failure!
by jenkins＠kronosnet.org 26 Jul '21

26 Jul '21

pacemaker-build-covscan - Build # 1703 - Failure: Check console output at https://ci.kronosnet.org/job/pacemaker-build-covscan/1703/ to view the results.

1 0

knet-build-all-voting - Build # 2417 - Failure!
by jenkins＠kronosnet.org 26 Jul '21

26 Jul '21

knet-build-all-voting - Build # 2417 - Failure: Check console output at https://ci.kronosnet.org/job/knet-build-all-voting/2417/ to view the results.

1 2

[kronosnet/kronosnet] d6bdae: [sctp] fix invalid memory access
by Fabio M. Di Nitto 26 Jul '21

26 Jul '21

Branch: refs/heads/fix-acl Home: https://github.com/kronosnet/kronosnet Commit: d6bdae84195f79bbeb44ec7fb552bff8db68ec3b https://github.com/kronosnet/kronosnet/commit/d6bdae84195f79bbeb44ec7fb552b… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2021-07-26 (Mon, 26 Jul 2021) Changed paths: M libknet/tests/api_knet_send_sync.c M libknet/transport_sctp.c Log Message: ----------- [sctp] fix invalid memory access and add more tests to the SCTP matrix Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: f9caec37a3d0888d71e4f7ce33ad59ed7dfcbe28 https://github.com/kronosnet/kronosnet/commit/f9caec37a3d0888d71e4f7ce33ad5… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2021-07-26 (Mon, 26 Jul 2021) Changed paths: M libknet/transport_sctp.c Log Message: ----------- [sctp] remove sockets from epoll earlier on some slow machines, where scheduling of some threads can be blocked for some time, keeping a FD on error on the epoll can cause even more load and reduce chances of the error handling thread to be scheduled. Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: b7c33081344e7eae3533b7a8e9f25d6de011b4d3 https://github.com/kronosnet/kronosnet/commit/b7c33081344e7eae3533b7a8e9f25… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2021-07-26 (Mon, 26 Jul 2021) Changed paths: M libknet/links.c Log Message: ----------- [acl] make knet_link_add_acl a wrapper to knet_link_insert_acl remove lots of duplicated code Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 4e9ff4b7ea944c051defb4d7e935989dbad9316a https://github.com/kronosnet/kronosnet/commit/4e9ff4b7ea944c051defb4d7e9359… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2021-07-26 (Mon, 26 Jul 2021) Changed paths: M libknet/internals.h M libknet/links.c M libknet/links_acl.c M libknet/links_acl.h M libknet/links_acl_ip.c M libknet/tests/Makefile.am M libknet/tests/api_knet_link_add_acl.c M libknet/tests/api_knet_link_clear_acl.c M libknet/tests/api_knet_link_insert_acl.c M libknet/tests/api_knet_link_rm_acl.c M libknet/tests/api_knet_link_set_config.c M libknet/tests/api_knet_send.c A libknet/tests/fun_acl_check.c M libknet/tests/test-common.c M libknet/threads_rx.c M libknet/transport_sctp.c Log Message: ----------- [acl] major internal rework ACL internal management was somewhat broken and didn´t really do what was advertised for dynamic links. - fix ACL to be truely per host/link as public API advertise - move ACL checking when host/link are known - add extensive tests - fix various minor bugs that went undetected for a bit - enable access list testings on more tests Signed-off-by: Christine Caulfield <ccaulfie(a)redhat.com> Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 75c3cd9a975aefdc0f98adbd786dd242e0182f68 https://github.com/kronosnet/kronosnet/commit/75c3cd9a975aefdc0f98adbd786dd… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2021-07-26 (Mon, 26 Jul 2021) Changed paths: M libknet/internals.h M libknet/transport_loopback.c M libknet/transport_loopback.h M libknet/transport_sctp.c M libknet/transport_sctp.h M libknet/transport_udp.c M libknet/transport_udp.h M libknet/transports.c M libknet/transports.h Log Message: ----------- [transports] remove unused internal ACL API with the new ACL code, this internal API is no longer used Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 68c1b93f9c379c272ef70abc62d647e10ce4260f https://github.com/kronosnet/kronosnet/commit/68c1b93f9c379c272ef70abc62d64… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2021-07-26 (Mon, 26 Jul 2021) Changed paths: M configure.ac M libknet/tests/Makefile.am Log Message: ----------- [tests] make execution of functional testing optionals Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Compare: https://github.com/kronosnet/kronosnet/compare/594ec61b8619...68c1b93f9c37

1 0

[kronosnet/kronosnet] 594ec6: test: Check for errors in pthread_cond_timedwait()
by Chrissie Caulfield 26 Jul '21

26 Jul '21

Branch: refs/heads/fix-acl Home: https://github.com/kronosnet/kronosnet Commit: 594ec61b8619ee44e08b19cad0be916870585fe9 https://github.com/kronosnet/kronosnet/commit/594ec61b8619ee44e08b19cad0be9… Author: Christine Caulfield <ccaulfie(a)redhat.com> Date: 2021-07-26 (Mon, 26 Jul 2021) Changed paths: M libknet/tests/fun_acl_check.c Log Message: ----------- test: Check for errors in pthread_cond_timedwait()

1 0

anvil-build-all-voting-functional-testing - Build # 572 - Failure!
by jenkins＠kronosnet.org 25 Jul '21

25 Jul '21

anvil-build-all-voting-functional-testing - Build # 572 - Failure: Check console output at https://ci.kronosnet.org/job/anvil-build-all-voting-functional-testing/572/ to view the results.

1 0

knet-build-all-nonvoting - Build # 1975 - Failure!
by jenkins＠kronosnet.org 25 Jul '21

25 Jul '21

knet-build-all-nonvoting - Build # 1975 - Failure: Check console output at https://ci.kronosnet.org/job/knet-build-all-nonvoting/1975/ to view the results.

1 0

knet-build-all-voting - Build # 2412 - Failure!
by jenkins＠kronosnet.org 25 Jul '21

25 Jul '21

knet-build-all-voting - Build # 2412 - Failure: Check console output at https://ci.kronosnet.org/job/knet-build-all-voting/2412/ to view the results.

1 1

[kronosnet/kronosnet] b7c3d0: [sctp] remove sockets from epoll earlier
by Fabio M. Di Nitto 25 Jul '21

25 Jul '21

Branch: refs/heads/fix-acl Home: https://github.com/kronosnet/kronosnet Commit: b7c3d065842f8780253ef2c32ede4bec4b956a0e https://github.com/kronosnet/kronosnet/commit/b7c3d065842f8780253ef2c32ede4… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2021-07-25 (Sun, 25 Jul 2021) Changed paths: M libknet/transport_sctp.c Log Message: ----------- [sctp] remove sockets from epoll earlier on some slow machines, where scheduling of some threads can be blocked for some time, keeping a FD on error on the epoll can cause even more load and reduce chances of the error handling thread to be scheduled. Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 306db442e3eee728fdb3e5223abbb9d06866300a https://github.com/kronosnet/kronosnet/commit/306db442e3eee728fdb3e5223abbb… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2021-07-25 (Sun, 25 Jul 2021) Changed paths: M libknet/tests/fun_acl_check.c Log Message: ----------- [test] add more info on what we are testing Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Compare: https://github.com/kronosnet/kronosnet/compare/d9c796e708d5...306db442e3ee

1 0

[kronosnet/kronosnet] 376169: [sctp] fix invalid memory access
by Fabio M. Di Nitto 23 Jul '21

23 Jul '21

Branch: refs/heads/fix-acl Home: https://github.com/kronosnet/kronosnet Commit: 3761691f7158659d6a4608af211b05d5a8df43dc https://github.com/kronosnet/kronosnet/commit/3761691f7158659d6a4608af211b0… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2021-07-23 (Fri, 23 Jul 2021) Changed paths: M libknet/tests/api_knet_send_sync.c M libknet/transport_sctp.c Log Message: ----------- [sctp] fix invalid memory access and add more tests to the SCTP matrix Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 4b3a66f60e3989d3ac0eb984c0a2e48c1565659b https://github.com/kronosnet/kronosnet/commit/4b3a66f60e3989d3ac0eb984c0a2e… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2021-07-23 (Fri, 23 Jul 2021) Changed paths: M libknet/links.c Log Message: ----------- [acl] make knet_link_add_acl a wrapper to knet_link_insert_acl remove lots of duplicated code Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 6e854a95615121ad128aa62d1c0f20345dff9f0d https://github.com/kronosnet/kronosnet/commit/6e854a95615121ad128aa62d1c0f2… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2021-07-23 (Fri, 23 Jul 2021) Changed paths: M libknet/internals.h M libknet/links.c M libknet/links_acl.c M libknet/links_acl.h M libknet/links_acl_ip.c M libknet/tests/Makefile.am M libknet/tests/api_knet_link_add_acl.c M libknet/tests/api_knet_link_clear_acl.c M libknet/tests/api_knet_link_insert_acl.c M libknet/tests/api_knet_link_rm_acl.c M libknet/tests/api_knet_link_set_config.c M libknet/tests/api_knet_send.c A libknet/tests/fun_acl_check.c M libknet/threads_rx.c M libknet/transport_sctp.c Log Message: ----------- [acl] major internal rework ACL internal management was somewhat broken and didn´t really do what was advertised for dynamic links. - fix ACL to be truely per host/link as public API advertise - move ACL checking when host/link are known - add extensive tests - fix various minor bugs that went undetected for a bit - enable access list testings on more tests Signed-off-by: Christine Caulfield <ccaulfie(a)redhat.com> Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 284425d0098fcf6b287238cd8086cc9bb049b94d https://github.com/kronosnet/kronosnet/commit/284425d0098fcf6b287238cd8086c… Author: Christine Caulfield <ccaulfie(a)redhat.com> Date: 2021-07-23 (Fri, 23 Jul 2021) Changed paths: M libknet/tests/fun_acl_check.c Log Message: ----------- test: Add some waits after removing a blocking ACL The ACL can make the link unstable and we can get down events even after calling knet_link_rm_acl(), so simply checking for all links up is not sufficient. Commit: e7a739be2b1ea4a0bbaea55338b180d5a2e817e0 https://github.com/kronosnet/kronosnet/commit/e7a739be2b1ea4a0bbaea55338b18… Author: Christine Caulfield <ccaulfie(a)redhat.com> Date: 2021-07-23 (Fri, 23 Jul 2021) Changed paths: M libknet/tests/fun_acl_check.c Log Message: ----------- test: actually get rid of arbitrary sleeps A better way is to wait for the link to go down BEFORE calling knet_link_rm_acl(), then wait for it to come back up AFTER knet_link_rm_ac(). That avoids all sleeps and makes it properly event-driven. This patch also fixes an error reporting bug. Commit: d9c796e708d5174a28964f4a429b37b86ea350ef https://github.com/kronosnet/kronosnet/commit/d9c796e708d5174a28964f4a429b3… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2021-07-23 (Fri, 23 Jul 2021) Changed paths: M libknet/tests/fun_acl_check.c M libknet/tests/test-common.c Log Message: ----------- [tests] fix some error handling Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Compare: https://github.com/kronosnet/kronosnet/compare/dcdef264c6f6...d9c796e708d5

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Commits July 2021