Commits January 2018

commits@lists.kronosnet.org

2 participants
177 discussions

[kronosnet/kronosnet] a0408a: fix missing space
by GitHub 04 Jan '18

04 Jan '18

Branch: refs/heads/scale Home: https://github.com/kronosnet/kronosnet Commit: a0408a4e103fca9a6303696d32511833bfbb69df https://github.com/kronosnet/kronosnet/commit/a0408a4e103fca9a6303696d32511… Author: Christine Caulfield <ccaulfie(a)redhat.com> Date: 2018-01-04 (Thu, 04 Jan 2018) Changed paths: M libknet/transport_udp.c Log Message: ----------- fix missing space

1 0

[kronosnet/knet-ansible-ci] 6cd259: yum: recover transactions if they are interrupted ...
by GitHub 04 Jan '18

04 Jan '18

Branch: refs/heads/master Home: https://github.com/kronosnet/knet-ansible-ci Commit: 6cd259a83face80b5d8c7bc245a3c6e58ad15637 https://github.com/kronosnet/knet-ansible-ci/commit/6cd259a83face80b5d8c7bc… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2018-01-04 (Thu, 04 Jan 2018) Changed paths: M roles/hostsetup/tasks/hostupdate.yml Log Message: ----------- yum: recover transactions if they are interrupted during an update/install Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>

1 0

[kronosnet/knet-ansible-ci] a09fe5: reduce forks to avoid DNS resolve timeout. This sh...
by GitHub 04 Jan '18

04 Jan '18

Branch: refs/heads/master Home: https://github.com/kronosnet/knet-ansible-ci Commit: a09fe50b65fd6ebd559e1cf939ca49d753eafa91 https://github.com/kronosnet/knet-ansible-ci/commit/a09fe50b65fd6ebd559e1cf… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2018-01-04 (Thu, 04 Jan 2018) Changed paths: M run-tests Log Message: ----------- reduce forks to avoid DNS resolve timeout. This should be calculated better based on ansible-inventory entries Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>

1 0

[kronosnet/kronosnet] 34672b: Add some missing error propagation
by GitHub 03 Jan '18

03 Jan '18

Branch: refs/heads/error_propagation Home: https://github.com/kronosnet/kronosnet Commit: 34672bf7ac0df624b91a61f807fc0d23a9073270 https://github.com/kronosnet/kronosnet/commit/34672bf7ac0df624b91a61f807fc0… Author: Ferenc Wágner <wferi(a)debian.org> Date: 2018-01-03 (Wed, 03 Jan 2018) Changed paths: M libknet/crypto.c M libknet/handle.c Log Message: ----------- Add some missing error propagation

1 0

[kronosnet/knet-ansible-ci] 4ffe5d: Update to use new -P option and -a for machine par...
by GitHub 03 Jan '18

03 Jan '18

Branch: refs/heads/master Home: https://github.com/kronosnet/knet-ansible-ci Commit: 4ffe5d10d84ea61c5706ff04fc145b6d6393a94a https://github.com/kronosnet/knet-ansible-ci/commit/4ffe5d10d84ea61c5706ff0… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2018-01-03 (Wed, 03 Jan 2018) Changed paths: M roles/kronosnet-tests/templates/knet_bench_wrapper.j2 Log Message: ----------- Update to use new -P option and -a for machine parsable data output Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>

1 0

knet-build-all-nonvoting - Build # 234 - Still Failing!
by jenkins＠kronosnet.org 03 Jan '18

03 Jan '18

knet-build-all-nonvoting - Build # 234 - Still Failing: Check console output at https://ci.kronosnet.org/job/knet-build-all-nonvoting/234/ to view the results.

1 22

[kronosnet/kronosnet] fc915b: [stats] report correct MTU for loopback links
by GitHub 03 Jan '18

03 Jan '18

Branch: refs/heads/scale Home: https://github.com/kronosnet/kronosnet Commit: fc915b6744d3b37864c6fe0e9bc585fb79ec9c6f https://github.com/kronosnet/kronosnet/commit/fc915b6744d3b37864c6fe0e9bc58… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2018-01-03 (Wed, 03 Jan 2018) Changed paths: M libknet/links.c Log Message: ----------- [stats] report correct MTU for loopback links Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 6cd9f82f33b07f0548bef9e4c5e59250d81d843c https://github.com/kronosnet/kronosnet/commit/6cd9f82f33b07f0548bef9e4c5e59… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2018-01-03 (Wed, 03 Jan 2018) Changed paths: M libknet/handle.c M libknet/internals.h M libknet/threads_pmtud.c M libknet/transport_udp.c Log Message: ----------- [PMTUd] Use kernel MTU information to determine next packet size during discovery Using this information we can, for good links (*), determine and verify the link MTU with 2 packets. * good links means: node X has MTU Y configured on a given interface. Any network object between node X and destination is capable of handling MTU >= Y. In no case the kernel will allow us to send packets > Y. Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: c7c7124a6d14afb94f9a979817b5db4168b52f5b https://github.com/kronosnet/kronosnet/commit/c7c7124a6d14afb94f9a979817b5d… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2018-01-03 (Wed, 03 Jan 2018) Changed paths: M libknet/links.c Log Message: ----------- [PTMUd] by using a safe PMTU to init a link, we can shave down corosync membership creation by 25% tested on a 9 node cluster with 2 links each node, going down from 4 seconds to 3 seconds Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 912be6b2bb4658dbc2c0dc1f4eeef8f531164d2f https://github.com/kronosnet/kronosnet/commit/912be6b2bb4658dbc2c0dc1f4eeef… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2018-01-03 (Wed, 03 Jan 2018) Changed paths: M libknet/internals.h M libknet/threads_common.c M libknet/threads_pmtud.c Log Message: ----------- [PMTUd] rename pmtud_running to pmtud_waiting Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 089d0e14e5c81ac9e462831c70d82870997c487c https://github.com/kronosnet/kronosnet/commit/089d0e14e5c81ac9e462831c70d82… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2018-01-03 (Wed, 03 Jan 2018) Changed paths: M libknet/internals.h M libknet/threads_pmtud.c M libknet/transport_udp.c Log Message: ----------- [PTMUd] if any threads receives a EMSGSIZE outside of a PMTUD run, force PTMUd to run Scenario: node X has MTU Y on the interface and application is sending packets with size >= Y. The interface MTU is suddenly reduced to < Y Before this change, the kernel would be dropping packets till the next PMTUd run. After this change, the PMTUd will be informed that it has to rerun (overriding the pmtud_interval), reducing the packet drop to a minimum. How to test: force knet_bench to send 1500 size packets with ping_data (requires code change) and start it. reduce MTU on the interface from 1500 to 1300 (for example) Notice an immediate trigger of PMTUd run in debug mode Note: going up, from 1300 to 1500 will wait for the next PMTUd re-run as there is no immediate way to detect this change unless we start listening to kernel netlink sockets with libnl3 (investigation in progress but not critical enough atm). Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 7d0d68ceb7d153bd5fd58cb5dccdfc8f7765f51c https://github.com/kronosnet/kronosnet/commit/7d0d68ceb7d153bd5fd58cb5dccdf… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2018-01-03 (Wed, 03 Jan 2018) Changed paths: M libknet/transport_udp.c Log Message: ----------- [PMTUd] make PMTUd force_run notification more quiet Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 3780ba8433ea458a52e01ba92108eb0cabafb035 https://github.com/kronosnet/kronosnet/commit/3780ba8433ea458a52e01ba92108e… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2018-01-03 (Wed, 03 Jan 2018) Changed paths: M libknet/threads_common.c Log Message: ----------- [PMTUd] if PMTUd is rescheduled, then enforce a new run the usleep between each PMTUd run will give time to the other threads to grab the wrlock Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: f7d49f4a3deb3e4d2db5b4a3d48df92e02be27d6 https://github.com/kronosnet/kronosnet/commit/f7d49f4a3deb3e4d2db5b4a3d48df… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2018-01-03 (Wed, 03 Jan 2018) Changed paths: M libknet/threads_pmtud.c Log Message: ----------- [PMTUd] generate warning when there is a timeout receiving a response Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: fafed5941d2b4754edb33fd4c3640ac50940968a https://github.com/kronosnet/kronosnet/commit/fafed5941d2b4754edb33fd4c3640… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2018-01-03 (Wed, 03 Jan 2018) Changed paths: M libknet/threads_pmtud.c Log Message: ----------- [PMTUd] amend warning message Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Compare: https://github.com/kronosnet/kronosnet/compare/e51aad809d89...fafed5941d2b

1 0

[kronosnet/kronosnet]
by GitHub 03 Jan '18

03 Jan '18

Branch: refs/heads/minor-fixes Home: https://github.com/kronosnet/kronosnet

1 0

[kronosnet/kronosnet] 30b5d2: [openssl] drop unnecessary reference counter
by GitHub 03 Jan '18

03 Jan '18

Branch: refs/heads/master Home: https://github.com/kronosnet/kronosnet Commit: 30b5d21b53794531a236984aeea7dd1fd1b0978f https://github.com/kronosnet/kronosnet/commit/30b5d21b53794531a236984aeea7d… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2018-01-03 (Wed, 03 Jan 2018) Changed paths: M libknet/crypto_openssl.c Log Message: ----------- [openssl] drop unnecessary reference counter Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 0f9f2f15bbca384936df3c24a6fd655bc3124cb5 https://github.com/kronosnet/kronosnet/commit/0f9f2f15bbca384936df3c24a6fd6… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2018-01-03 (Wed, 03 Jan 2018) Changed paths: M libknet/tests/knet_bench.c Log Message: ----------- [tests] fix regression in knet_bench introduced accidentaly by 2052faab4376107fe99e8a3f955bbcbfa426f648 Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 78b944a7298da30dfeb593a8a535de19f12bfbc8 https://github.com/kronosnet/kronosnet/commit/78b944a7298da30dfeb593a8a535d… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2018-01-03 (Wed, 03 Jan 2018) Changed paths: M libknet/tests/knet_bench.c Log Message: ----------- [tests] knet_bench allow to configure PMTUd interval from CLI Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 152d95f9c00fbfa02b4a55dc6fdda32c3b151c35 https://github.com/kronosnet/kronosnet/commit/152d95f9c00fbfa02b4a55dc6fdda… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2018-01-03 (Wed, 03 Jan 2018) Changed paths: M libknet/tests/knet_bench.c M libknet/tests/test-common.c Log Message: ----------- [tests] knet_bench: add machine parsable output this is done by adding prefixes to different messages to make it easier to grep/awk and changing format of [perf] to reflect cpghum syntax. Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 13c79608555725f3558b5ac6ce0ea785108b8775 https://github.com/kronosnet/kronosnet/commit/13c79608555725f3558b5ac6ce0ea… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2018-01-03 (Wed, 03 Jan 2018) Changed paths: M libknet/tests/knet_bench.c Log Message: ----------- [tests] knet_bench: allow to specify protocol (UDP/SCTP) per link Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: bb6094e97a59ff4600883e16984ed2a702e3fc11 https://github.com/kronosnet/kronosnet/commit/bb6094e97a59ff4600883e16984ed… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2018-01-03 (Wed, 03 Jan 2018) Changed paths: M libknet/tests/knet_bench.c Log Message: ----------- [tests] add missing break (detected by newer gcc) Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 8dd8029a2a1653e215212b82c6efeb3530e340b0 https://github.com/kronosnet/kronosnet/commit/8dd8029a2a1653e215212b82c6efe… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2018-01-03 (Wed, 03 Jan 2018) Changed paths: M libknet/crypto_openssl.c M libknet/tests/knet_bench.c M libknet/tests/test-common.c Log Message: ----------- Merge pull request #108 from kronosnet/minor-fixes Minor fixes Compare: https://github.com/kronosnet/kronosnet/compare/8713bf5a3d0e...8dd8029a2a16

1 0

[kronosnet/kronosnet] af84b6: [stats] report correct MTU for loopback links
by GitHub 03 Jan '18

03 Jan '18

Branch: refs/heads/scale Home: https://github.com/kronosnet/kronosnet Commit: af84b6a87494a1f2067e89a0e298981e740fa3e0 https://github.com/kronosnet/kronosnet/commit/af84b6a87494a1f2067e89a0e2989… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2018-01-03 (Wed, 03 Jan 2018) Changed paths: M libknet/links.c Log Message: ----------- [stats] report correct MTU for loopback links Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: d0014fe1827589cca815bb9a38a3dd84f0243a52 https://github.com/kronosnet/kronosnet/commit/d0014fe1827589cca815bb9a38a3d… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2018-01-03 (Wed, 03 Jan 2018) Changed paths: M libknet/handle.c M libknet/internals.h M libknet/threads_pmtud.c M libknet/transport_udp.c Log Message: ----------- [PMTUd] Use kernel MTU information to determine next packet size during discovery Using this information we can, for good links (*), determine and verify the link MTU with 2 packets. * good links means: node X has MTU Y configured on a given interface. Any network object between node X and destination is capable of handling MTU >= Y. In no case the kernel will allow us to send packets > Y. Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 25f58ef99800143145e2144ba325b9c8aeba2bbd https://github.com/kronosnet/kronosnet/commit/25f58ef99800143145e2144ba325b… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2018-01-03 (Wed, 03 Jan 2018) Changed paths: M libknet/links.c Log Message: ----------- [PTMUd] by using a safe PMTU to init a link, we can shave down corosync membership creation by 25% tested on a 9 node cluster with 2 links each node, going down from 4 seconds to 3 seconds Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: e679629f2fbb9cac4a8b953bee0e603ff2163de2 https://github.com/kronosnet/kronosnet/commit/e679629f2fbb9cac4a8b953bee0e6… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2018-01-03 (Wed, 03 Jan 2018) Changed paths: M libknet/internals.h M libknet/threads_common.c M libknet/threads_pmtud.c Log Message: ----------- [PMTUd] rename pmtud_running to pmtud_waiting Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: ec57f2c5ba10950c837dcffff2c15f097911c973 https://github.com/kronosnet/kronosnet/commit/ec57f2c5ba10950c837dcffff2c15… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2018-01-03 (Wed, 03 Jan 2018) Changed paths: M libknet/internals.h M libknet/tests/knet_bench.c M libknet/threads_pmtud.c M libknet/transport_udp.c Log Message: ----------- [PTMUd] if any threads receives a EMSGSIZE outside of a PMTUD run, force PTMUd to run Scenario: node X has MTU Y on the interface and application is sending packets with size >= Y. The interface MTU is suddenly reduced to < Y Before this change, the kernel would be dropping packets till the next PMTUd run. After this change, the PMTUd will be informed that it has to rerun (overriding the pmtud_interval), reducing the packet drop to a minimum. How to test: force knet_bench to send 1500 size packets with ping_data (requires code change) and start it. reduce MTU on the interface from 1500 to 1300 (for example) Notice an immediate trigger of PMTUd run in debug mode Note: going up, from 1300 to 1500 will wait for the next PMTUd re-run as there is no immediate way to detect this change unless we start listening to kernel netlink sockets with libnl3 (investigation in progress but not critical enough atm). Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 5b89b3173c0ce3157c5d38e9e1ace92bdc504bf9 https://github.com/kronosnet/kronosnet/commit/5b89b3173c0ce3157c5d38e9e1ace… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2018-01-03 (Wed, 03 Jan 2018) Changed paths: M libknet/transport_udp.c Log Message: ----------- [PMTUd] make PMTUd force_run notification more quiet Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 063dcdf74daa1bc4525a2b1ac86cc37b0514404b https://github.com/kronosnet/kronosnet/commit/063dcdf74daa1bc4525a2b1ac86cc… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2018-01-03 (Wed, 03 Jan 2018) Changed paths: M libknet/threads_common.c Log Message: ----------- [PMTUd] if PMTUd is rescheduled, then enforce a new run the usleep between each PMTUd run will give time to the other threads to grab the wrlock Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 28b4140b2395af863a16a75fb7d551c3feabbf31 https://github.com/kronosnet/kronosnet/commit/28b4140b2395af863a16a75fb7d55… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2018-01-03 (Wed, 03 Jan 2018) Changed paths: M libknet/threads_pmtud.c Log Message: ----------- [PMTUd] generate warning when there is a timeout receiving a response Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: e51aad809d896b46ee6850e24055eb993c25383c https://github.com/kronosnet/kronosnet/commit/e51aad809d896b46ee6850e24055e… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2018-01-03 (Wed, 03 Jan 2018) Changed paths: M libknet/threads_pmtud.c Log Message: ----------- [PMTUd] amend warning message Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Compare: https://github.com/kronosnet/kronosnet/compare/e1e86bf65213...e51aad809d89

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Commits January 2018