Commits November 2017

commits@lists.kronosnet.org

2 participants
231 discussions

[kronosnet/kronosnet] 6d1625: [build] workaround memory alignment bug in nss in ...
by GitHub 15 Nov '17

15 Nov '17

Branch: refs/heads/nss-workaround Home: https://github.com/kronosnet/kronosnet Commit: 6d1625538adedb911d47e6b2047573ee85780b2c https://github.com/kronosnet/kronosnet/commit/6d1625538adedb911d47e6b204757… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2017-11-15 (Wed, 15 Nov 2017) Changed paths: M build-aux/check.mk Log Message: ----------- [build] workaround memory alignment bug in nss in combination with valgrind on Linux/i386 Over the past few weeks, we noticed CI failing on i386 when running make check-memcheck (test suite executed with valgring). Those failures were not consistent and sometime random. After some heavy debugging it turns out that those failures are a combination of libnss3 internal memory allocator bug and valgrind internal memory allocator. Current libnss3 memory allocator expects a 16 bytes memory aligned buffer and in the event the memory is not aligned, it would round it. The issue is that, in performing this rounding, nss does not track properly the original address of the memory, and the equivalent of subsequent free of this buffer would fail, leaking memory and potentially accessing memory not allocated or corrpting memory. The nss bug is already fixed upstream by commit: changeset: 13557:52e38f913220 Valgrind on Linux/i386 memory allocator can return memory that is not aligned to the 16 bytes, contrary to what malloc/glibc does. Valgrind was returning (somehow randomly) a non aligned buffer to nss triggering the nss bug and the leak. By forcing valgrind to use aligned memory, nss bug does not trigger and there is no memory leak during the execution of the test suite. The memory leak never triggered when running knet in normal conditions. Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>

1 0

[kronosnet/kronosnet]
by GitHub 15 Nov '17

15 Nov '17

Branch: refs/heads/test-nss-leak Home: https://github.com/kronosnet/kronosnet

1 0

[kronosnet/kronosnet]
by GitHub 15 Nov '17

15 Nov '17

Branch: refs/heads/nss-workaround Home: https://github.com/kronosnet/kronosnet

1 0

knet-build-all-nonvoting - Build # 26 - Still Failing!
by jenkins＠kronosnet.org 15 Nov '17

15 Nov '17

knet-build-all-nonvoting - Build # 26 - Still Failing: Check console output at https://ci.kronosnet.org/job/knet-build-all-nonvoting/26/ to view the results.

1 81

[kronosnet/kronosnet]
by GitHub 14 Nov '17

14 Nov '17

Branch: refs/heads/pthread Home: https://github.com/kronosnet/kronosnet

1 0

[kronosnet/kronosnet] 2b1072: build: adopt ax_pthread.m4 to provide all necessar...
by GitHub 14 Nov '17

14 Nov '17

Branch: refs/heads/master Home: https://github.com/kronosnet/kronosnet Commit: 2b1072db76d0dba1b03999467fd278fac09976b0 https://github.com/kronosnet/kronosnet/commit/2b1072db76d0dba1b03999467fd27… Author: Ferenc Wágner <wferi(a)debian.org> Date: 2017-11-14 (Tue, 14 Nov 2017) Changed paths: M .gitignore M Makefile.am M autogen.sh M configure.ac M libknet/Makefile.am M libknet/tests/Makefile.am M libtap/Makefile.am A m4/ax_pthread.m4 Log Message: ----------- build: adopt ax_pthread.m4 to provide all necessary flags Previously we only linked with -lpthread, but for example the -pthread GCC option provides a CPP define as well. Commit: 8156886888aa40e5d325e7bdd56a1697843cc78c https://github.com/kronosnet/kronosnet/commit/8156886888aa40e5d325e7bdd56a1… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2017-11-14 (Tue, 14 Nov 2017) Changed paths: M .gitignore M Makefile.am M autogen.sh M configure.ac M libknet/Makefile.am M libknet/tests/Makefile.am M libtap/Makefile.am A m4/ax_pthread.m4 Log Message: ----------- Merge pull request #86 from kronosnet/pthread build: adopt ax_pthread.m4 to provide all necessary flags Compare: https://github.com/kronosnet/kronosnet/compare/0b4bfc6f1dca...8156886888aa

1 0

knet-build-all-voting - Build # 125 - Failure!
by jenkins＠kronosnet.org 14 Nov '17

14 Nov '17

knet-build-all-voting - Build # 125 - Failure: Check console output at https://ci.kronosnet.org/job/knet-build-all-voting/125/ to view the results.

1 0

[kronosnet/kronosnet] 2b1072: build: adopt ax_pthread.m4 to provide all necessar...
by GitHub 14 Nov '17

14 Nov '17

Branch: refs/heads/pthread Home: https://github.com/kronosnet/kronosnet Commit: 2b1072db76d0dba1b03999467fd278fac09976b0 https://github.com/kronosnet/kronosnet/commit/2b1072db76d0dba1b03999467fd27… Author: Ferenc Wágner <wferi(a)debian.org> Date: 2017-11-14 (Tue, 14 Nov 2017) Changed paths: M .gitignore M Makefile.am M autogen.sh M configure.ac M libknet/Makefile.am M libknet/tests/Makefile.am M libtap/Makefile.am A m4/ax_pthread.m4 Log Message: ----------- build: adopt ax_pthread.m4 to provide all necessary flags Previously we only linked with -lpthread, but for example the -pthread GCC option provides a CPP define as well.

1 0

[kronosnet/kronosnet] 7e0b69: build: adopt ax_pthread.m4 to provide all necessar...
by GitHub 14 Nov '17

14 Nov '17

Branch: refs/heads/pthread Home: https://github.com/kronosnet/kronosnet Commit: 7e0b69af680193cb5ddab5cbebc12c3c5e242803 https://github.com/kronosnet/kronosnet/commit/7e0b69af680193cb5ddab5cbebc12… Author: Ferenc Wágner <wferi(a)debian.org> Date: 2017-11-14 (Tue, 14 Nov 2017) Changed paths: M .gitignore M Makefile.am M autogen.sh M configure.ac M libknet/Makefile.am M libknet/tests/Makefile.am M libtap/Makefile.am A m4/ax_pthread.m4 Log Message: ----------- build: adopt ax_pthread.m4 to provide all necessary flags Previously we only linked with -lpthread, but for example the -pthread GCC option provides a CPP define as well.

1 0

[kronosnet/kronosnet] d523b4: build: we only use the crypto part of OpenSSL
by GitHub 14 Nov '17

14 Nov '17

Branch: refs/heads/master Home: https://github.com/kronosnet/kronosnet Commit: d523b40054a4851e0089d27a8af3a83adc194cc3 https://github.com/kronosnet/kronosnet/commit/d523b40054a4851e0089d27a8af3a… Author: Ferenc Wágner <wferi(a)debian.org> Date: 2017-11-13 (Mon, 13 Nov 2017) Changed paths: M configure.ac Log Message: ----------- build: we only use the crypto part of OpenSSL Commit: c1effb8a4bb38393d0d77acec8ad843a712554fe https://github.com/kronosnet/kronosnet/commit/c1effb8a4bb38393d0d77acec8ad8… Author: Ferenc Wágner <wferi(a)debian.org> Date: 2017-11-13 (Mon, 13 Nov 2017) Changed paths: M configure.ac Log Message: ----------- build: clock_gettime does not require the rt library for glibc 2.17+ So stop overlinking with -lrt on modern systems. Commit: 3cc6b18042ab6c30404b615e7188ad45c49d7c48 https://github.com/kronosnet/kronosnet/commit/3cc6b18042ab6c30404b615e7188a… Author: Ferenc Wágner <wferi(a)debian.org> Date: 2017-11-14 (Tue, 14 Nov 2017) Changed paths: M configure.ac Log Message: ----------- build: don't add the dl library to LIBS, keep it in dl_LIBS only This leaves us with an empty LIBS in the most common cases. Commit: bcb6cbb4ad8d03c148e767ba34b6fc7dd56e0576 https://github.com/kronosnet/kronosnet/commit/bcb6cbb4ad8d03c148e767ba34b6f… Author: Ferenc Wágner <wferi(a)debian.org> Date: 2017-11-14 (Tue, 14 Nov 2017) Changed paths: M configure.ac Log Message: ----------- build: the check_lib_no_libs function was unused The optional arguments of AC_CHECK_LIB work good enough. Commit: 4f002d0c996abb3362214030ea4ad55cad3976f2 https://github.com/kronosnet/kronosnet/commit/4f002d0c996abb3362214030ea4ad… Author: Ferenc Wágner <wferi(a)debian.org> Date: 2017-11-14 (Tue, 14 Nov 2017) Changed paths: M configure.ac Log Message: ----------- build: remove unused function checks These have no corresponding HAVE_X checks in the code. Commit: 26fe18aa1c70f0ed494a824b4659de315e6991d1 https://github.com/kronosnet/kronosnet/commit/26fe18aa1c70f0ed494a824b4659d… Author: Ferenc Wágner <wferi(a)debian.org> Date: 2017-11-14 (Tue, 14 Nov 2017) Changed paths: M configure.ac M kronosnetd/Makefile.am M libknet/tests/Makefile.am Log Message: ----------- build: only kronosnetd needs PAM, so keep the linker options separate Commit: 1b96703bb988796fa3b6cea8d24849445842131d https://github.com/kronosnet/kronosnet/commit/1b96703bb988796fa3b6cea8d2484… Author: Ferenc Wágner <wferi(a)debian.org> Date: 2017-11-14 (Tue, 14 Nov 2017) Changed paths: M configure.ac Log Message: ----------- Revert "build: link as needed" This reverts commit e3c019fde32f78bf2e3a9bcf6c2fff93245708a0. Once LIBS is kept empty and OpenSSL isn't linked to in full, overlinking shouldn't be a problem anymore. Commit: 0b4bfc6f1dcad169da8a710b38ed610998cc8517 https://github.com/kronosnet/kronosnet/commit/0b4bfc6f1dcad169da8a710b38ed6… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2017-11-14 (Tue, 14 Nov 2017) Changed paths: M configure.ac M kronosnetd/Makefile.am M libknet/tests/Makefile.am Log Message: ----------- Merge pull request #85 from wferi/libcrypto We only use the crypto part of OpenSSL Compare: https://github.com/kronosnet/kronosnet/compare/bb7eeb7a8323...0b4bfc6f1dca

1 0

← Newer
1
...
10
11
12
13
14
15
16
...
24
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Commits November 2017