Branch: refs/heads/master Home: https://github.com/kronosnet/kronosnet Commit: c0ea7408058466500faba9034aafa21d04e86336 https://github.com/kronosnet/kronosnet/commit/c0ea7408058466500faba9034aafa2... Author: Fabio M. Di Nitto fdinitto@redhat.com Date: 2017-10-19 (Thu, 19 Oct 2017)
Changed paths: M libknet/transport_udp.c
Log Message: ----------- [udp] fix incorrect return code
UDP TX is tricky and racy and in theory TX never fails, as UDP is allowed to drop packets internally anyway.
In some race condition situations, we can endup in a situation where: - thread X attempts to send a packet - socket receives an ICMP back (for whatever reasons) generated by some other random thread/packet combo - thread X detects an error in TX and decode the error (correct)
pre patch: - thread X would treat that as error and drop the packet post patch: - thread X should simply resend the packet
simply also the ordering of parsing socket error code to make it easier to read
Signed-off-by: Fabio M. Di Nitto fdinitto@redhat.com
Commit: 5b34c040b92425008646202765799942d1c5cb8a https://github.com/kronosnet/kronosnet/commit/5b34c040b924250086462027657999... Author: Fabio M. Di Nitto fdinitto@redhat.com Date: 2017-10-19 (Thu, 19 Oct 2017)
Changed paths: M libknet/transport_udp.c
Log Message: ----------- Merge pull request #57 from kronosnet/fabbione-udp-fixes
[udp] fix incorrect return code
Compare: https://github.com/kronosnet/kronosnet/compare/702d8f5ada83...5b34c040b924