Commits

commits@lists.kronosnet.org

1 participants
45234 discussions

[kronosnet/kronosnet]
by Fabio M. Di Nitto 18 May '26

18 May '26

Branch: refs/heads/fix-thread-pmtud-race Home: https://github.com/kronosnet/kronosnet To unsubscribe from these emails, change your notification settings at https://github.com/kronosnet/kronosnet/settings/notifications

1 0

[kronosnet/kronosnet] 30865b: libknet: force PMTUD rerun after reschedule interr...
by Fabio M. Di Nitto 18 May '26

18 May '26

Branch: refs/heads/main Home: https://github.com/kronosnet/kronosnet Commit: 30865b9921cab7657fd74df65d22d96add7b3e26 https://github.com/kronosnet/kronosnet/commit/30865b9921cab7657fd74df65d22d… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2026-05-16 (Sat, 16 May 2026) Changed paths: M libknet/threads_pmtud.c Log Message: ----------- libknet: force PMTUD rerun after reschedule interruption When PMTUD is interrupted by a reschedule request (returns EDEADLK), some links may have been checked while others were skipped. The next iteration uses the interval timer to decide which links to check, which means recently-checked links are skipped even if they need a new PMTUD run (e.g., after reconnection following onwire protocol upgrade). Fix by setting pmtud_forcerun=1 when the PMTUD thread detects it was interrupted (errno == EDEADLK). This ensures the next iteration force-runs PMTUD on all links regardless of the interval timer, completing discovery on interrupted and skipped links. This approach respects the 2018 commit d2a6344f design by setting forcerun in the PMTUD thread itself (after the interrupted iteration completes) rather than in _pmtud_reschedule() or its callers, avoiding the lock fighting and scheduling issues that commit addressed. Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org> Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com> Commit: 1a92d58e85668e6ffc5c9a4b5c9c4a087429a0b0 https://github.com/kronosnet/kronosnet/commit/1a92d58e85668e6ffc5c9a4b5c9c4… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2026-05-16 (Sat, 16 May 2026) Changed paths: M libknet/tests/fun_onwire_upgrade.c Log Message: ----------- tests: fix race condition in fun_onwire_upgrade test Add proper locking in upgrade_onwire_max_ver() to prevent race between test modifications of onwire_min_ver/onwire_max_ver and RX threads reading these values. RX threads hold global_rwlock during packet processing and check version fields without explicit synchronization, causing flaky test failures on FreeBSD when RX threads see stale values. Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org> Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com> Commit: 234af5bab227c7d8b1378a17f6d1da5ed371c9f1 https://github.com/kronosnet/kronosnet/commit/234af5bab227c7d8b1378a17f6d1d… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2026-05-18 (Mon, 18 May 2026) Changed paths: M libknet/tests/fun_onwire_upgrade.c M libknet/threads_pmtud.c Log Message: ----------- Merge pull request #481 from kronosnet/fix-thread-pmtud-race libknet: fix PMTUD reschedule race condition Compare: https://github.com/kronosnet/kronosnet/compare/1216e98fa4aa...234af5bab227 To unsubscribe from these emails, change your notification settings at https://github.com/kronosnet/kronosnet/settings/notifications

1 0

[jenkins] update-all-ci-tools (build 509) completed with 0 failures
by jenkins＠kronosnet.org 18 May '26

18 May '26

Run reason: Branch indexing Total runtime: 10 min Split logs: https://ci.kronosnet.org/job/global/job/update-all-ci-tools/job/main/509/ar… Full log: https://ci.kronosnet.org/job/global/job/update-all-ci-tools/job/main/509/co…

1 0

[jenkins] update-all-ci-tools (build 508) completed with 0 failures
by jenkins＠kronosnet.org 18 May '26

18 May '26

Total runtime: 1 min 19 sec Split logs: https://ci.kronosnet.org/job/global/job/update-all-ci-tools/job/main/508/ar… Full log: https://ci.kronosnet.org/job/global/job/update-all-ci-tools/job/main/508/co…

1 0

[jenkins] update-all-ci-tools (build 507) completed with 0 failures
by jenkins＠kronosnet.org 18 May '26

18 May '26

Total runtime: 2 min 4 sec Split logs: https://ci.kronosnet.org/job/global/job/update-all-ci-tools/job/main/507/ar… Full log: https://ci.kronosnet.org/job/global/job/update-all-ci-tools/job/main/507/co…

1 0

[kronosnet/kronosnet] 9e9b0b: tests: remove unused execute_shell and set_schedul...
by Fabio M. Di Nitto 18 May '26

18 May '26

Branch: refs/heads/fix-testsuite Home: https://github.com/kronosnet/kronosnet Commit: 9e9b0b2f856dc66eddee763a8078059eafb77edf https://github.com/kronosnet/kronosnet/commit/9e9b0b2f856dc66eddee763a80780… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2026-05-18 (Mon, 18 May 2026) Changed paths: M libknet/tests/test-common.c M libknet/tests/test-common.h Log Message: ----------- tests: remove unused execute_shell and set_scheduler functions Remove execute_shell() and its helper _read_pipe() from test-common.c/h. Remove set_scheduler() function and its declaration. Both functions were defined but never used anywhere in the test suite. Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org> Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com> Commit: 8d09337bc1aa2c908c4dfc5ef702161542479f44 https://github.com/kronosnet/kronosnet/commit/8d09337bc1aa2c908c4dfc5ef7021… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2026-05-18 (Mon, 18 May 2026) Changed paths: M libknet/tests/test-common.c M libknet/tests/test-common.h Log Message: ----------- tests: add log_test macro for test suite logging Add log_test() macro to test-common.h that writes directly to the knet logging infrastructure. Messages are sent with NULL handle and displayed with [testsuite]: prefix. Modify flush_logs() to handle NULL knet_h gracefully instead of aborting. This allows test code to use the logging infrastructure without needing a knet handle, making it easier to log test progress and debug information. Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org> Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com> Commit: 1aa4c559803cb479cc60cd7b160ea7cceaee74a6 https://github.com/kronosnet/kronosnet/commit/1aa4c559803cb479cc60cd7b160ea… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2026-05-18 (Mon, 18 May 2026) Changed paths: M libknet/tests/test-common.c M libknet/tests/test-common.h Log Message: ----------- tests: add timestamps to test suite log output Add elapsed time timestamps to all log messages in format [seconds.milliseconds]. Time is measured from when setup_logpipes() is first called (test start). This makes it easier to: - Debug timing-sensitive test failures - Identify performance bottlenecks in tests - Correlate log messages with test events Modified log_test() macro to take logfd as first parameter for consistency with other logging patterns in the test suite. Example output: [ 0.000] [testsuite]: Test start [ 1.000] [testsuite]: After 1 second [ 3.000] [testsuite]: After 3 seconds total Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org> Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com> Commit: 4fc45c3c572f99db6f67f39d57225bed1e864d2f https://github.com/kronosnet/kronosnet/commit/4fc45c3c572f99db6f67f39d57225… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2026-05-18 (Mon, 18 May 2026) Changed paths: M libknet/tests/Makefile.am M libknet/tests/api-check.mk M libknet/tests/test-common.c M libknet/tests/test-common.h Log Message: ----------- tests: add new test infrastructure for start_logging/stop_logging pattern Make stop_logging() public with full state reset to enable mid-execution restart. Add clean_exit_new(), knet_handle_start_new(), knet_handle_start_nodes_new() and _NEW macro variants (CLEAN_EXIT_NEW, FAIL_ON_ERR_NEW, FAIL_ON_SUCCESS_NEW, etc.) for tests using the new logging pattern. Update Makefile.am and api-check.mk to link test-common.c. Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org> Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com> Commit: f8b2965b8855dbcae574ba56ddb9ae1a5201d016 https://github.com/kronosnet/kronosnet/commit/f8b2965b8855dbcae574ba56ddb9a… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2026-05-18 (Mon, 18 May 2026) Changed paths: M libknet/tests/api_knet_addrtostr.c M libknet/tests/api_knet_get_compress_list.c M libknet/tests/api_knet_get_crypto_list.c M libknet/tests/api_knet_get_transport_id_by_name.c M libknet/tests/api_knet_get_transport_list.c M libknet/tests/api_knet_get_transport_name_by_id.c M libknet/tests/api_knet_handle_add_datafd.c M libknet/tests/api_knet_handle_clear_stats.c M libknet/tests/api_knet_handle_compress.c M libknet/tests/api_knet_handle_crypto_rx_clear_traffic.c M libknet/tests/api_knet_handle_crypto_set_config.c M libknet/tests/api_knet_handle_crypto_use_config.c M libknet/tests/api_knet_handle_enable_access_lists.c M libknet/tests/api_knet_handle_enable_filter.c M libknet/tests/api_knet_handle_enable_onwire_ver_notify.c M libknet/tests/api_knet_handle_enable_pmtud_notify.c M libknet/tests/api_knet_handle_enable_sock_notify.c M libknet/tests/api_knet_handle_free.c M libknet/tests/api_knet_handle_get_channel.c M libknet/tests/api_knet_handle_get_datafd.c M libknet/tests/api_knet_handle_get_host_defrag_bufs.c M libknet/tests/api_knet_handle_get_onwire_ver.c M libknet/tests/api_knet_handle_get_stats.c M libknet/tests/api_knet_handle_get_threads_timer_res.c M libknet/tests/api_knet_handle_get_transport_reconnect_interval.c M libknet/tests/api_knet_handle_new.c M libknet/tests/api_knet_handle_new_limit.c M libknet/tests/api_knet_handle_pmtud_get.c M libknet/tests/api_knet_handle_pmtud_getfreq.c M libknet/tests/api_knet_handle_pmtud_set.c M libknet/tests/api_knet_handle_pmtud_setfreq.c M libknet/tests/api_knet_handle_remove_datafd.c M libknet/tests/api_knet_handle_set_host_defrag_bufs.c M libknet/tests/api_knet_handle_set_onwire_ver.c M libknet/tests/api_knet_handle_set_threads_timer_res.c M libknet/tests/api_knet_handle_set_transport_reconnect_interval.c M libknet/tests/api_knet_handle_setfwd.c M libknet/tests/api_knet_handle_setprio_dscp.c M libknet/tests/api_knet_host_add.c M libknet/tests/api_knet_host_enable_status_change_notify.c M libknet/tests/api_knet_host_get_host_list.c M libknet/tests/api_knet_host_get_id_by_host_name.c M libknet/tests/api_knet_host_get_name_by_host_id.c M libknet/tests/api_knet_host_get_policy.c M libknet/tests/api_knet_host_get_status.c M libknet/tests/api_knet_host_remove.c M libknet/tests/api_knet_host_set_name.c M libknet/tests/api_knet_host_set_policy.c M libknet/tests/api_knet_link_add_acl.c M libknet/tests/api_knet_link_clear_acl.c M libknet/tests/api_knet_link_clear_config.c M libknet/tests/api_knet_link_enable_status_change_notify.c M libknet/tests/api_knet_link_get_config.c M libknet/tests/api_knet_link_get_enable.c M libknet/tests/api_knet_link_get_link_list.c M libknet/tests/api_knet_link_get_ping_timers.c M libknet/tests/api_knet_link_get_pong_count.c M libknet/tests/api_knet_link_get_priority.c M libknet/tests/api_knet_link_get_status.c M libknet/tests/api_knet_link_insert_acl.c M libknet/tests/api_knet_link_rm_acl.c M libknet/tests/api_knet_link_set_config.c M libknet/tests/api_knet_link_set_enable.c M libknet/tests/api_knet_link_set_ping_timers.c M libknet/tests/api_knet_link_set_pong_count.c M libknet/tests/api_knet_link_set_priority.c M libknet/tests/api_knet_log_get_loglevel.c M libknet/tests/api_knet_log_get_loglevel_id.c M libknet/tests/api_knet_log_get_loglevel_name.c M libknet/tests/api_knet_log_get_subsystem_id.c M libknet/tests/api_knet_log_get_subsystem_name.c M libknet/tests/api_knet_log_set_loglevel.c M libknet/tests/api_knet_recv.c M libknet/tests/api_knet_send.c M libknet/tests/api_knet_send_compress.c M libknet/tests/api_knet_send_crypto.c M libknet/tests/api_knet_send_loopback.c M libknet/tests/api_knet_send_sync.c M libknet/tests/api_knet_strtoaddr.c M libknet/tests/fun_acl_check.c M libknet/tests/fun_config_crypto.c M libknet/tests/fun_config_crypto_ctr_test.c M libknet/tests/fun_onwire_upgrade.c M libknet/tests/fun_pmtud_crypto.c M libknet/tests/int_links_acl_ip.c M libknet/tests/int_timediff.c Log Message: ----------- tests: convert test suite to start_logging/stop_logging pattern Convert all test files (79 api_*, 2 int_*, 5 fun_*) from old setup_logpipes pattern to new start_logging/stop_logging pattern with log_test() macro. Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org> Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com> Commit: a209033337ba15118e606bdb9825d34366ef98cc https://github.com/kronosnet/kronosnet/commit/a209033337ba15118e606bdb9825d… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2026-05-18 (Mon, 18 May 2026) Changed paths: M libknet/tests/test-common.c M libknet/tests/test-common.h Log Message: ----------- tests: remove old logging infrastructure and macros Remove obsolete functions and macros after full test suite conversion: - FAIL_ON_ERR, FAIL_ON_SUCCESS, FAIL_ON_ERR_ONLY, CLEAN_EXIT macros - clean_exit(), knet_handle_start(), knet_handle_start_nodes() functions - Obsolete WARNING comment about not using start_logging for api_/int_ tests All tests now use _NEW variants with start_logging/stop_logging pattern. Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org> Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com> Commit: 11af5dc9b2ae260710b592cc140376beba36460e https://github.com/kronosnet/kronosnet/commit/11af5dc9b2ae260710b592cc14037… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2026-05-18 (Mon, 18 May 2026) Changed paths: M libknet/tests/api_knet_handle_add_datafd.c M libknet/tests/api_knet_handle_clear_stats.c M libknet/tests/api_knet_handle_compress.c M libknet/tests/api_knet_handle_crypto_rx_clear_traffic.c M libknet/tests/api_knet_handle_crypto_set_config.c M libknet/tests/api_knet_handle_crypto_use_config.c M libknet/tests/api_knet_handle_enable_access_lists.c M libknet/tests/api_knet_handle_enable_filter.c M libknet/tests/api_knet_handle_enable_onwire_ver_notify.c M libknet/tests/api_knet_handle_enable_pmtud_notify.c M libknet/tests/api_knet_handle_enable_sock_notify.c M libknet/tests/api_knet_handle_free.c M libknet/tests/api_knet_handle_get_channel.c M libknet/tests/api_knet_handle_get_datafd.c M libknet/tests/api_knet_handle_get_host_defrag_bufs.c M libknet/tests/api_knet_handle_get_onwire_ver.c M libknet/tests/api_knet_handle_get_stats.c M libknet/tests/api_knet_handle_get_threads_timer_res.c M libknet/tests/api_knet_handle_get_transport_reconnect_interval.c M libknet/tests/api_knet_handle_new.c M libknet/tests/api_knet_handle_pmtud_get.c M libknet/tests/api_knet_handle_pmtud_getfreq.c M libknet/tests/api_knet_handle_pmtud_set.c M libknet/tests/api_knet_handle_pmtud_setfreq.c M libknet/tests/api_knet_handle_remove_datafd.c M libknet/tests/api_knet_handle_set_host_defrag_bufs.c M libknet/tests/api_knet_handle_set_onwire_ver.c M libknet/tests/api_knet_handle_set_threads_timer_res.c M libknet/tests/api_knet_handle_set_transport_reconnect_interval.c M libknet/tests/api_knet_handle_setfwd.c M libknet/tests/api_knet_handle_setprio_dscp.c M libknet/tests/api_knet_host_add.c M libknet/tests/api_knet_host_enable_status_change_notify.c M libknet/tests/api_knet_host_get_host_list.c M libknet/tests/api_knet_host_get_id_by_host_name.c M libknet/tests/api_knet_host_get_name_by_host_id.c M libknet/tests/api_knet_host_get_policy.c M libknet/tests/api_knet_host_get_status.c M libknet/tests/api_knet_host_remove.c M libknet/tests/api_knet_host_set_name.c M libknet/tests/api_knet_host_set_policy.c M libknet/tests/api_knet_link_add_acl.c M libknet/tests/api_knet_link_clear_acl.c M libknet/tests/api_knet_link_clear_config.c M libknet/tests/api_knet_link_enable_status_change_notify.c M libknet/tests/api_knet_link_get_config.c M libknet/tests/api_knet_link_get_enable.c M libknet/tests/api_knet_link_get_link_list.c M libknet/tests/api_knet_link_get_ping_timers.c M libknet/tests/api_knet_link_get_pong_count.c M libknet/tests/api_knet_link_get_priority.c M libknet/tests/api_knet_link_get_status.c M libknet/tests/api_knet_link_insert_acl.c M libknet/tests/api_knet_link_rm_acl.c M libknet/tests/api_knet_link_set_config.c M libknet/tests/api_knet_link_set_enable.c M libknet/tests/api_knet_link_set_ping_timers.c M libknet/tests/api_knet_link_set_pong_count.c M libknet/tests/api_knet_link_set_priority.c M libknet/tests/api_knet_log_get_loglevel.c M libknet/tests/api_knet_log_set_loglevel.c M libknet/tests/api_knet_recv.c M libknet/tests/api_knet_send.c M libknet/tests/api_knet_send_compress.c M libknet/tests/api_knet_send_crypto.c M libknet/tests/api_knet_send_loopback.c M libknet/tests/api_knet_send_sync.c M libknet/tests/fun_acl_check.c M libknet/tests/fun_config_crypto.c M libknet/tests/fun_config_crypto_ctr_test.c M libknet/tests/fun_onwire_upgrade.c M libknet/tests/fun_pmtud_crypto.c M libknet/tests/test-common.c M libknet/tests/test-common.h Log Message: ----------- tests: rename _NEW macros and _new functions to standard names Remove _NEW/_new suffixes from all macros and functions: - FAIL_ON_ERR_NEW -> FAIL_ON_ERR - FAIL_ON_SUCCESS_NEW -> FAIL_ON_SUCCESS - FAIL_ON_ERR_ONLY_NEW -> FAIL_ON_ERR_ONLY - FAIL_ON_ERR_THR_NEW -> FAIL_ON_ERR_THR - CLEAN_EXIT_NEW -> CLEAN_EXIT - clean_exit_new -> clean_exit - knet_handle_start_new -> knet_handle_start - knet_handle_start_nodes_new -> knet_handle_start_nodes These are now the standard versions using start_logging/stop_logging pattern. Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org> Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com> Commit: 5167bdf3e9c53791df53b311bae1f4621952101f https://github.com/kronosnet/kronosnet/commit/5167bdf3e9c53791df53b311bae1f… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2026-05-18 (Mon, 18 May 2026) Changed paths: M libknet/tests/api_knet_handle_clear_stats.c M libknet/tests/api_knet_handle_pmtud_set.c M libknet/tests/api_knet_handle_set_threads_timer_res.c M libknet/tests/api_knet_host_remove.c M libknet/tests/api_knet_link_add_acl.c M libknet/tests/api_knet_link_clear_acl.c M libknet/tests/api_knet_link_clear_config.c M libknet/tests/api_knet_link_get_config.c M libknet/tests/api_knet_link_get_enable.c M libknet/tests/api_knet_link_get_link_list.c M libknet/tests/api_knet_link_get_ping_timers.c M libknet/tests/api_knet_link_get_pong_count.c M libknet/tests/api_knet_link_get_priority.c M libknet/tests/api_knet_link_get_status.c M libknet/tests/api_knet_link_insert_acl.c M libknet/tests/api_knet_link_rm_acl.c M libknet/tests/api_knet_link_set_config.c M libknet/tests/api_knet_link_set_enable.c M libknet/tests/api_knet_link_set_ping_timers.c M libknet/tests/api_knet_link_set_pong_count.c M libknet/tests/api_knet_link_set_priority.c M libknet/tests/api_knet_recv.c M libknet/tests/api_knet_send.c M libknet/tests/api_knet_send_compress.c M libknet/tests/api_knet_send_crypto.c M libknet/tests/api_knet_send_loopback.c M libknet/tests/api_knet_send_sync.c M libknet/tests/fun_acl_check.c M libknet/tests/fun_config_crypto.c M libknet/tests/fun_config_crypto_ctr_test.c M libknet/tests/fun_onwire_upgrade.c M libknet/tests/fun_pmtud_crypto.c M libknet/tests/knet_bench.c M libknet/tests/test-common.c M libknet/tests/test-common.h Log Message: ----------- tests: convert to start_logging/stop_logging infrastructure Migrate test suite from manual setup_logpipes() to unified start_logging() and stop_logging() infrastructure with log_test() for test messages. Changes: - Convert all printf() calls in test functions to log_test() - Add logfd parameter to helper functions that need logging - Update knet_handle_stop_everything() and clean_exit() to use log_test() instead of fprintf(stderr) and perror() - Use static variables for logfd in callbacks - Make internal helper functions static This provides: - Unified logging with timestamps - Test messages appear as [testsuite]: in logs - Clean separation of test progress from knet library logs Note: knet_bench.c partially converted (uses start_logging but retains printf for user-facing output). Full conversion will be done separately. Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org> Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com> Commit: d64a8681af57b413475c06d223eb61ffaf2e9e22 https://github.com/kronosnet/kronosnet/commit/d64a8681af57b413475c06d223eb6… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2026-05-18 (Mon, 18 May 2026) Changed paths: M libknet/tests/api_knet_addrtostr.c M libknet/tests/api_knet_get_compress_list.c M libknet/tests/api_knet_get_crypto_list.c M libknet/tests/api_knet_get_transport_id_by_name.c M libknet/tests/api_knet_get_transport_list.c M libknet/tests/api_knet_get_transport_name_by_id.c M libknet/tests/api_knet_handle_add_datafd.c M libknet/tests/api_knet_handle_clear_stats.c M libknet/tests/api_knet_handle_compress.c M libknet/tests/api_knet_handle_crypto_rx_clear_traffic.c M libknet/tests/api_knet_handle_crypto_set_config.c M libknet/tests/api_knet_handle_crypto_use_config.c M libknet/tests/api_knet_handle_enable_access_lists.c M libknet/tests/api_knet_handle_enable_filter.c M libknet/tests/api_knet_handle_enable_onwire_ver_notify.c M libknet/tests/api_knet_handle_enable_pmtud_notify.c M libknet/tests/api_knet_handle_enable_sock_notify.c M libknet/tests/api_knet_handle_free.c M libknet/tests/api_knet_handle_get_channel.c M libknet/tests/api_knet_handle_get_datafd.c M libknet/tests/api_knet_handle_get_host_defrag_bufs.c M libknet/tests/api_knet_handle_get_onwire_ver.c M libknet/tests/api_knet_handle_get_stats.c M libknet/tests/api_knet_handle_get_threads_timer_res.c M libknet/tests/api_knet_handle_get_transport_reconnect_interval.c M libknet/tests/api_knet_handle_new.c M libknet/tests/api_knet_handle_new_limit.c M libknet/tests/api_knet_handle_pmtud_get.c M libknet/tests/api_knet_handle_pmtud_getfreq.c M libknet/tests/api_knet_handle_pmtud_set.c M libknet/tests/api_knet_handle_pmtud_setfreq.c M libknet/tests/api_knet_handle_remove_datafd.c M libknet/tests/api_knet_handle_set_host_defrag_bufs.c M libknet/tests/api_knet_handle_set_onwire_ver.c M libknet/tests/api_knet_handle_set_threads_timer_res.c M libknet/tests/api_knet_handle_set_transport_reconnect_interval.c M libknet/tests/api_knet_handle_setfwd.c M libknet/tests/api_knet_handle_setprio_dscp.c M libknet/tests/api_knet_host_add.c M libknet/tests/api_knet_host_enable_status_change_notify.c M libknet/tests/api_knet_host_get_host_list.c M libknet/tests/api_knet_host_get_id_by_host_name.c M libknet/tests/api_knet_host_get_name_by_host_id.c M libknet/tests/api_knet_host_get_policy.c M libknet/tests/api_knet_host_get_status.c M libknet/tests/api_knet_host_remove.c M libknet/tests/api_knet_host_set_name.c M libknet/tests/api_knet_host_set_policy.c M libknet/tests/api_knet_link_add_acl.c M libknet/tests/api_knet_link_clear_acl.c M libknet/tests/api_knet_link_clear_config.c M libknet/tests/api_knet_link_enable_status_change_notify.c M libknet/tests/api_knet_link_get_config.c M libknet/tests/api_knet_link_get_enable.c M libknet/tests/api_knet_link_get_link_list.c M libknet/tests/api_knet_link_get_ping_timers.c M libknet/tests/api_knet_link_get_pong_count.c M libknet/tests/api_knet_link_get_priority.c M libknet/tests/api_knet_link_get_status.c M libknet/tests/api_knet_link_insert_acl.c M libknet/tests/api_knet_link_rm_acl.c M libknet/tests/api_knet_link_set_config.c M libknet/tests/api_knet_link_set_enable.c M libknet/tests/api_knet_link_set_ping_timers.c M libknet/tests/api_knet_link_set_pong_count.c M libknet/tests/api_knet_link_set_priority.c M libknet/tests/api_knet_log_get_loglevel.c M libknet/tests/api_knet_log_get_loglevel_id.c M libknet/tests/api_knet_log_get_loglevel_name.c M libknet/tests/api_knet_log_get_subsystem_id.c M libknet/tests/api_knet_log_get_subsystem_name.c M libknet/tests/api_knet_log_set_loglevel.c M libknet/tests/api_knet_recv.c M libknet/tests/api_knet_send.c M libknet/tests/api_knet_send_compress.c M libknet/tests/api_knet_send_crypto.c M libknet/tests/api_knet_send_loopback.c M libknet/tests/api_knet_send_sync.c M libknet/tests/api_knet_strtoaddr.c M libknet/tests/fun_acl_check.c M libknet/tests/fun_config_crypto.c M libknet/tests/fun_config_crypto_ctr_test.c M libknet/tests/fun_onwire_upgrade.c M libknet/tests/fun_pmtud_crypto.c M libknet/tests/int_links_acl_ip.c M libknet/tests/int_timediff.c M libknet/tests/test-common.c M libknet/tests/test-common.h Log Message: ----------- tests: standardize test result output and exit handling Add TEST_EXIT() macro to print consistent [PASS]/[FAIL]/[SKIP]/[ERROR] markers and exit with proper code. Convert all exit() and return statements in test suite to use TEST_EXIT(). Update CLEAN_EXIT() to call TEST_EXIT() instead of duplicating exit logic. Remove unused exit_local() helper. Fix capitalization in test descriptions (Knet → knet). Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org> Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com> Commit: 03a7cf04afc725a56cb98f74abeca25db03fb4a7 https://github.com/kronosnet/kronosnet/commit/03a7cf04afc725a56cb98f74abeca… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2026-05-18 (Mon, 18 May 2026) Changed paths: M libknet/tests/api_knet_addrtostr.c M libknet/tests/api_knet_get_compress_list.c M libknet/tests/api_knet_get_crypto_list.c M libknet/tests/api_knet_get_transport_id_by_name.c M libknet/tests/api_knet_get_transport_list.c M libknet/tests/api_knet_get_transport_name_by_id.c M libknet/tests/api_knet_handle_add_datafd.c M libknet/tests/api_knet_handle_clear_stats.c M libknet/tests/api_knet_handle_compress.c M libknet/tests/api_knet_handle_crypto_rx_clear_traffic.c M libknet/tests/api_knet_handle_crypto_set_config.c M libknet/tests/api_knet_handle_crypto_use_config.c M libknet/tests/api_knet_handle_enable_access_lists.c M libknet/tests/api_knet_handle_enable_filter.c M libknet/tests/api_knet_handle_enable_onwire_ver_notify.c M libknet/tests/api_knet_handle_enable_pmtud_notify.c M libknet/tests/api_knet_handle_enable_sock_notify.c M libknet/tests/api_knet_handle_free.c M libknet/tests/api_knet_handle_get_channel.c M libknet/tests/api_knet_handle_get_datafd.c M libknet/tests/api_knet_handle_get_host_defrag_bufs.c M libknet/tests/api_knet_handle_get_onwire_ver.c M libknet/tests/api_knet_handle_get_stats.c M libknet/tests/api_knet_handle_get_threads_timer_res.c M libknet/tests/api_knet_handle_get_transport_reconnect_interval.c M libknet/tests/api_knet_handle_new.c M libknet/tests/api_knet_handle_new_limit.c M libknet/tests/api_knet_handle_pmtud_get.c M libknet/tests/api_knet_handle_pmtud_getfreq.c M libknet/tests/api_knet_handle_pmtud_set.c M libknet/tests/api_knet_handle_pmtud_setfreq.c M libknet/tests/api_knet_handle_remove_datafd.c M libknet/tests/api_knet_handle_set_host_defrag_bufs.c M libknet/tests/api_knet_handle_set_onwire_ver.c M libknet/tests/api_knet_handle_set_threads_timer_res.c M libknet/tests/api_knet_handle_set_transport_reconnect_interval.c M libknet/tests/api_knet_handle_setfwd.c M libknet/tests/api_knet_handle_setprio_dscp.c M libknet/tests/api_knet_host_add.c M libknet/tests/api_knet_host_enable_status_change_notify.c M libknet/tests/api_knet_host_get_host_list.c M libknet/tests/api_knet_host_get_id_by_host_name.c M libknet/tests/api_knet_host_get_name_by_host_id.c M libknet/tests/api_knet_host_get_policy.c M libknet/tests/api_knet_host_get_status.c M libknet/tests/api_knet_host_remove.c M libknet/tests/api_knet_host_set_name.c M libknet/tests/api_knet_host_set_policy.c M libknet/tests/api_knet_link_add_acl.c M libknet/tests/api_knet_link_clear_acl.c M libknet/tests/api_knet_link_clear_config.c M libknet/tests/api_knet_link_enable_status_change_notify.c M libknet/tests/api_knet_link_get_config.c M libknet/tests/api_knet_link_get_enable.c M libknet/tests/api_knet_link_get_link_list.c M libknet/tests/api_knet_link_get_ping_timers.c M libknet/tests/api_knet_link_get_pong_count.c M libknet/tests/api_knet_link_get_priority.c M libknet/tests/api_knet_link_get_status.c M libknet/tests/api_knet_link_insert_acl.c M libknet/tests/api_knet_link_rm_acl.c M libknet/tests/api_knet_link_set_config.c M libknet/tests/api_knet_link_set_enable.c M libknet/tests/api_knet_link_set_ping_timers.c M libknet/tests/api_knet_link_set_pong_count.c M libknet/tests/api_knet_link_set_priority.c M libknet/tests/api_knet_log_get_loglevel.c M libknet/tests/api_knet_log_get_loglevel_id.c M libknet/tests/api_knet_log_get_loglevel_name.c M libknet/tests/api_knet_log_get_subsystem_id.c M libknet/tests/api_knet_log_get_subsystem_name.c M libknet/tests/api_knet_log_set_loglevel.c M libknet/tests/api_knet_recv.c M libknet/tests/api_knet_send.c M libknet/tests/api_knet_send_compress.c M libknet/tests/api_knet_send_crypto.c M libknet/tests/api_knet_send_loopback.c M libknet/tests/api_knet_send_sync.c M libknet/tests/api_knet_strtoaddr.c M libknet/tests/fun_acl_check.c M libknet/tests/fun_config_crypto.c M libknet/tests/fun_config_crypto_ctr_test.c M libknet/tests/fun_onwire_upgrade.c M libknet/tests/fun_pmtud_crypto.c M libknet/tests/int_links_acl_ip.c M libknet/tests/int_timediff.c M libknet/tests/test-common.c M libknet/tests/test-common.h Log Message: ----------- tests: refactor exit macros - rename CLEAN_EXIT to TEST_EXIT_CLEAN Rename CLEAN_EXIT to TEST_EXIT_CLEAN for clearer semantics. Remove clean_exit function and inline logic into TEST_EXIT_CLEAN macro. Add stop_logging() to TEST_EXIT macro to ensure cleanup. Remove redundant stop_logging() calls immediately before TEST_EXIT/TEST_EXIT_CLEAN. Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org> Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com> Commit: 8444375433489d1563e13001f27678391e1af3f3 https://github.com/kronosnet/kronosnet/commit/8444375433489d1563e13001f2767… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2026-05-18 (Mon, 18 May 2026) Changed paths: M libknet/tests/api_knet_handle_add_datafd.c M libknet/tests/api_knet_handle_clear_stats.c M libknet/tests/api_knet_handle_compress.c M libknet/tests/api_knet_handle_crypto_rx_clear_traffic.c M libknet/tests/api_knet_handle_crypto_set_config.c M libknet/tests/api_knet_handle_crypto_use_config.c M libknet/tests/api_knet_handle_enable_access_lists.c M libknet/tests/api_knet_handle_enable_filter.c M libknet/tests/api_knet_handle_enable_onwire_ver_notify.c M libknet/tests/api_knet_handle_enable_pmtud_notify.c M libknet/tests/api_knet_handle_enable_sock_notify.c M libknet/tests/api_knet_handle_free.c M libknet/tests/api_knet_handle_get_channel.c M libknet/tests/api_knet_handle_get_datafd.c M libknet/tests/api_knet_handle_get_host_defrag_bufs.c M libknet/tests/api_knet_handle_get_onwire_ver.c M libknet/tests/api_knet_handle_get_stats.c M libknet/tests/api_knet_handle_get_threads_timer_res.c M libknet/tests/api_knet_handle_get_transport_reconnect_interval.c M libknet/tests/api_knet_handle_new.c M libknet/tests/api_knet_handle_pmtud_get.c M libknet/tests/api_knet_handle_pmtud_getfreq.c M libknet/tests/api_knet_handle_pmtud_set.c M libknet/tests/api_knet_handle_pmtud_setfreq.c M libknet/tests/api_knet_handle_remove_datafd.c M libknet/tests/api_knet_handle_set_host_defrag_bufs.c M libknet/tests/api_knet_handle_set_onwire_ver.c M libknet/tests/api_knet_handle_set_threads_timer_res.c M libknet/tests/api_knet_handle_set_transport_reconnect_interval.c M libknet/tests/api_knet_handle_setfwd.c M libknet/tests/api_knet_handle_setprio_dscp.c M libknet/tests/api_knet_host_add.c M libknet/tests/api_knet_host_enable_status_change_notify.c M libknet/tests/api_knet_host_get_host_list.c M libknet/tests/api_knet_host_get_id_by_host_name.c M libknet/tests/api_knet_host_get_name_by_host_id.c M libknet/tests/api_knet_host_get_policy.c M libknet/tests/api_knet_host_get_status.c M libknet/tests/api_knet_host_remove.c M libknet/tests/api_knet_host_set_name.c M libknet/tests/api_knet_host_set_policy.c M libknet/tests/api_knet_link_add_acl.c M libknet/tests/api_knet_link_clear_acl.c M libknet/tests/api_knet_link_clear_config.c M libknet/tests/api_knet_link_enable_status_change_notify.c M libknet/tests/api_knet_link_get_config.c M libknet/tests/api_knet_link_get_enable.c M libknet/tests/api_knet_link_get_link_list.c M libknet/tests/api_knet_link_get_ping_timers.c M libknet/tests/api_knet_link_get_pong_count.c M libknet/tests/api_knet_link_get_priority.c M libknet/tests/api_knet_link_get_status.c M libknet/tests/api_knet_link_insert_acl.c M libknet/tests/api_knet_link_rm_acl.c M libknet/tests/api_knet_link_set_config.c M libknet/tests/api_knet_link_set_enable.c M libknet/tests/api_knet_link_set_ping_timers.c M libknet/tests/api_knet_link_set_pong_count.c M libknet/tests/api_knet_link_set_priority.c M libknet/tests/api_knet_log_get_loglevel.c M libknet/tests/api_knet_log_set_loglevel.c M libknet/tests/api_knet_recv.c M libknet/tests/api_knet_send.c M libknet/tests/api_knet_send_compress.c M libknet/tests/api_knet_send_crypto.c M libknet/tests/api_knet_send_loopback.c M libknet/tests/api_knet_send_sync.c M libknet/tests/fun_acl_check.c M libknet/tests/fun_config_crypto.c M libknet/tests/fun_config_crypto_ctr_test.c M libknet/tests/fun_onwire_upgrade.c M libknet/tests/fun_pmtud_crypto.c M libknet/tests/knet_bench.c M libknet/tests/test-common.c M libknet/tests/test-common.h Log Message: ----------- tests: rename knet_* test helpers to _ts_knet_* to avoid namespace collision Rename test suite helpers that wrap libknet API to use _ts_ prefix (test suite) to clearly distinguish them from the public libknet API functions: - knet_handle_start → _ts_knet_handle_start - knet_handle_stop_everything → _ts_knet_handle_stop_everything - knet_handle_start_nodes → _ts_knet_handle_start_nodes - knet_handle_join_nodes → _ts_knet_handle_join_nodes - knet_handle_disconnect_links → _ts_knet_handle_disconnect_links - knet_handle_reconnect_links → _ts_knet_handle_reconnect_links - _knet_link_set_config → _ts_knet_link_set_config This prevents confusion between test infrastructure and library API. Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org> Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com> Commit: 8152c3c352f56772caaf5033b515a5104073a9fc https://github.com/kronosnet/kronosnet/commit/8152c3c352f56772caaf5033b515a… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2026-05-18 (Mon, 18 May 2026) Changed paths: M libknet/tests/api_knet_handle_pmtud_set.c M libknet/tests/api_knet_recv.c M libknet/tests/fun_config_crypto.c M libknet/tests/fun_onwire_upgrade.c M libknet/tests/test-common.c M libknet/tests/test-common.h Log Message: ----------- tests: improve test_sleep() function Standardize test_sleep() signature and add logging for better diagnostics. Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org> Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com> Commit: 24a40b5649f1b8c5b5f6a32dee4aa7483417b1b1 https://github.com/kronosnet/kronosnet/commit/24a40b5649f1b8c5b5f6a32dee4aa… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2026-05-18 (Mon, 18 May 2026) Changed paths: M libknet/tests/knet_bench.c Log Message: ----------- tests: improve knet_bench infrastructure Make logfd static and use TEST_EXIT macros throughout for consistency with test suite standards. Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org> Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com> Commit: 95bb1d7f50762ab7983aa30d78c151e2015a707e https://github.com/kronosnet/kronosnet/commit/95bb1d7f50762ab7983aa30d78c15… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2026-05-18 (Mon, 18 May 2026) Changed paths: M libknet/tests/Makefile.am A libknet/tests/fun_config_crypto_ctr.c R libknet/tests/fun_config_crypto_ctr_test.c Log Message: ----------- tests: rename fun_config_crypto_ctr_test.c to match naming standard Rename fun_config_crypto_ctr_test.c to fun_config_crypto_ctr.c to match the naming convention used by other test files. Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org> Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com> Commit: ea787a4992974eeba6f31eed53843f2895da43c7 https://github.com/kronosnet/kronosnet/commit/ea787a4992974eeba6f31eed53843… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2026-05-18 (Mon, 18 May 2026) Changed paths: M libknet/tests/api_knet_handle_free.c M libknet/tests/fun_pmtud_crypto.c Log Message: ----------- tests: remove redundant TESTNODES definitions Remove redundant TESTNODES=1 definitions from api_knet_handle_free.c and fun_pmtud_crypto.c since test-common.h already defines TESTNODES=1 as the default value. Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org> Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com> Commit: 191075f564baac7219eeb8dfa78b2024e5bbab8c https://github.com/kronosnet/kronosnet/commit/191075f564baac7219eeb8dfa78b2… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2026-05-18 (Mon, 18 May 2026) Changed paths: M libknet/tests/fun_acl_check.c M libknet/tests/fun_config_crypto.c M libknet/tests/fun_onwire_upgrade.c M libknet/tests/test-common.c M libknet/tests/test-common.h Log Message: ----------- tests: consolidate timeout and wait_for_reply handling Centralize valgrind timeout adjustment and wait_for_reply() function: - Add adjust_timeout_for_valgrind() helper in test-common.c - Move timeout adjustment to wait_for_reply() (used by wait_for_host and wait_for_nodes_state) - Make wait_for_reply() shared, remove duplicate from fun_acl_check.c - Update test_sleep() and wait_for_packet() to use helper - Remove duplicate valgrind checks from fun_config_crypto.c, fun_acl_check.c, fun_onwire_upgrade.c Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org> Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com> Commit: 61016f5d537163c97ea80cd5723f83d8b32d7ed1 https://github.com/kronosnet/kronosnet/commit/61016f5d537163c97ea80cd5723f8… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2026-05-18 (Mon, 18 May 2026) Changed paths: M libknet/tests/api_knet_handle_add_datafd.c M libknet/tests/api_knet_handle_compress.c M libknet/tests/api_knet_handle_crypto_rx_clear_traffic.c M libknet/tests/api_knet_handle_crypto_set_config.c M libknet/tests/api_knet_handle_crypto_use_config.c M libknet/tests/api_knet_handle_enable_access_lists.c M libknet/tests/api_knet_handle_enable_filter.c M libknet/tests/api_knet_handle_enable_onwire_ver_notify.c M libknet/tests/api_knet_handle_enable_pmtud_notify.c M libknet/tests/api_knet_handle_enable_sock_notify.c M libknet/tests/api_knet_handle_free.c M libknet/tests/api_knet_handle_get_channel.c M libknet/tests/api_knet_handle_get_datafd.c M libknet/tests/api_knet_handle_get_host_defrag_bufs.c M libknet/tests/api_knet_handle_get_onwire_ver.c M libknet/tests/api_knet_handle_get_stats.c M libknet/tests/api_knet_handle_get_threads_timer_res.c M libknet/tests/api_knet_handle_get_transport_reconnect_interval.c M libknet/tests/api_knet_handle_pmtud_get.c M libknet/tests/api_knet_handle_pmtud_getfreq.c M libknet/tests/api_knet_handle_pmtud_set.c M libknet/tests/api_knet_handle_pmtud_setfreq.c M libknet/tests/api_knet_handle_remove_datafd.c M libknet/tests/api_knet_handle_set_host_defrag_bufs.c M libknet/tests/api_knet_handle_set_onwire_ver.c M libknet/tests/api_knet_handle_set_threads_timer_res.c M libknet/tests/api_knet_handle_set_transport_reconnect_interval.c M libknet/tests/api_knet_handle_setfwd.c M libknet/tests/api_knet_handle_setprio_dscp.c M libknet/tests/api_knet_host_add.c M libknet/tests/api_knet_host_enable_status_change_notify.c M libknet/tests/api_knet_host_get_host_list.c M libknet/tests/api_knet_host_get_id_by_host_name.c M libknet/tests/api_knet_host_get_name_by_host_id.c M libknet/tests/api_knet_host_get_policy.c M libknet/tests/api_knet_host_get_status.c M libknet/tests/api_knet_host_remove.c M libknet/tests/api_knet_host_set_name.c M libknet/tests/api_knet_host_set_policy.c M libknet/tests/api_knet_link_add_acl.c M libknet/tests/api_knet_link_clear_acl.c M libknet/tests/api_knet_link_clear_config.c M libknet/tests/api_knet_link_enable_status_change_notify.c M libknet/tests/api_knet_link_get_config.c M libknet/tests/api_knet_link_get_enable.c M libknet/tests/api_knet_link_get_link_list.c M libknet/tests/api_knet_link_get_ping_timers.c M libknet/tests/api_knet_link_get_pong_count.c M libknet/tests/api_knet_link_get_priority.c M libknet/tests/api_knet_link_get_status.c M libknet/tests/api_knet_link_insert_acl.c M libknet/tests/api_knet_link_rm_acl.c M libknet/tests/api_knet_link_set_config.c M libknet/tests/api_knet_link_set_enable.c M libknet/tests/api_knet_link_set_ping_timers.c M libknet/tests/api_knet_link_set_pong_count.c M libknet/tests/api_knet_link_set_priority.c M libknet/tests/api_knet_log_get_loglevel.c M libknet/tests/api_knet_log_set_loglevel.c M libknet/tests/api_knet_recv.c M libknet/tests/api_knet_send.c M libknet/tests/api_knet_send_sync.c M libknet/tests/test-common.c Log Message: ----------- tests: improve error handling consistency in API tests Replace verbose error checks with FAIL_ON_SUCCESS macro in 61 API tests. Initialize knet_h arrays to prevent coverity UNINIT warnings. Add NULL check in _ts_knet_handle_stop_everything() for safe cleanup. Fixes 53 coverity defects, reduces test code by 184 lines. Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org> Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com> Commit: db24ecf9cf678f3c08cf551676a610db3a85f8aa https://github.com/kronosnet/kronosnet/commit/db24ecf9cf678f3c08cf551676a61… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2026-05-18 (Mon, 18 May 2026) Changed paths: M libknet/tests/api_knet_handle_clear_stats.c M libknet/tests/api_knet_handle_pmtud_set.c M libknet/tests/api_knet_recv.c M libknet/tests/api_knet_send.c M libknet/tests/api_knet_send_compress.c M libknet/tests/api_knet_send_crypto.c M libknet/tests/api_knet_send_loopback.c M libknet/tests/api_knet_send_sync.c M libknet/tests/fun_config_crypto.c M libknet/tests/fun_config_crypto_ctr.c M libknet/tests/fun_pmtud_crypto.c M libknet/tests/test-common.c M libknet/tests/test-common.h Log Message: ----------- tests: replace magic numbers with named constants Add timeout constants (TEST_TIMEOUT_LONG/SHORT/QUICK) and port range constants (TEST_PORT_*) to test-common.h. Replace all hardcoded values throughout test suite for better readability and maintainability. Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org> Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com> Commit: 1529c5d46093a6a47c69cf97b5756d55a843aeef https://github.com/kronosnet/kronosnet/commit/1529c5d46093a6a47c69cf97b5756… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2026-05-18 (Mon, 18 May 2026) Changed paths: M libknet/tests/api_knet_addrtostr.c M libknet/tests/api_knet_get_compress_list.c M libknet/tests/api_knet_get_crypto_list.c M libknet/tests/api_knet_get_transport_list.c M libknet/tests/api_knet_strtoaddr.c M libknet/tests/test-common.h Log Message: ----------- tests: add NOCLEAN macro variants for tests without knet handles Add FAIL_ON_ERR_NOCLEAN and FAIL_ON_SUCCESS_NOCLEAN macros for tests that don't create knet handles and don't need cleanup infrastructure. Convert 5 API tests to use new macros (11 error checks total): - api_knet_addrtostr.c (4 checks) - api_knet_strtoaddr.c (4 checks) - api_knet_get_compress_list.c (1 check) - api_knet_get_crypto_list.c (1 check) - api_knet_get_transport_list.c (1 check) Reduces test code by 37 lines and improves consistency with other tests. Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org> Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com> Commit: 1d9a99e1ab722f5297723f9ad740120fd3ca7f7a https://github.com/kronosnet/kronosnet/commit/1d9a99e1ab722f5297723f9ad7401… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2026-05-18 (Mon, 18 May 2026) Changed paths: M libknet/tests/api_knet_recv.c Log Message: ----------- tests: remove commented-out dead code from api_knet_recv test The commented-out writev() call was replaced by knet_send() during the test infrastructure migration and is no longer needed. Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org> Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com> Commit: 3e9de1216019fc64f74bcd9df42e2849aeb80fdb https://github.com/kronosnet/kronosnet/commit/3e9de1216019fc64f74bcd9df42e2… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2026-05-18 (Mon, 18 May 2026) Changed paths: M libknet/tests/api_knet_handle_clear_stats.c M libknet/tests/api_knet_handle_pmtud_set.c M libknet/tests/api_knet_recv.c M libknet/tests/api_knet_send.c M libknet/tests/api_knet_send_compress.c M libknet/tests/api_knet_send_crypto.c M libknet/tests/api_knet_send_loopback.c M libknet/tests/api_knet_send_sync.c M libknet/tests/fun_acl_check.c M libknet/tests/fun_config_crypto.c M libknet/tests/fun_config_crypto_ctr.c M libknet/tests/fun_onwire_upgrade.c M libknet/tests/fun_pmtud_crypto.c M libknet/tests/test-common.c M libknet/tests/test-common.h Log Message: ----------- tests: remove flush_logs() and unused FILE *std parameter The log thread continuously drains the log pipe, so manual flush_logs() calls are unnecessary. Remove them and the now-unused FILE *std parameter from wait_for_packet(), wait_for_host(), and wait_for_nodes_state(). Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org> Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com> Commit: 246b534832b5a62aab4ffd172559474b58b3ddf0 https://github.com/kronosnet/kronosnet/commit/246b534832b5a62aab4ffd1725594… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2026-05-18 (Mon, 18 May 2026) Changed paths: M libknet/tests/test-common.h Log Message: ----------- tests: add comprehensive documentation to test-common.h Add detailed documentation for all test infrastructure macros and helper functions. Each macro and function now has a description, parameter documentation, return value documentation, and usage notes where applicable. Documentation covers: - Test result codes (PASS, FAIL, SKIP, ERROR, CONTINUE) - Timeout and port constants - Test macros (TEST_EXIT_CLEAN, FAIL_ON_ERR, FAIL_ON_SUCCESS, etc.) - NOCLEAN variants for tests without knet handles - Runtime environment detection (is_memcheck, is_helgrind) - Handle management (_ts_knet_handle_start, _ts_knet_link_set_config) - Multi-node helpers (_ts_knet_handle_join_nodes, etc.) - Logging infrastructure (start_logging, stop_logging) - Address helpers (make_local_sockaddr, make_local_sockaddr6) - Wait and timing helpers (wait_for_host, wait_for_packet, etc.) Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org> Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com> Commit: 9bbdf8fdf0ce3354d69edc4c56d5ea01a5aaafb8 https://github.com/kronosnet/kronosnet/commit/9bbdf8fdf0ce3354d69edc4c56d5e… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2026-05-18 (Mon, 18 May 2026) Changed paths: M libknet/tests/api_knet_get_crypto_cipher_list.c M libknet/tests/api_knet_get_crypto_hash_list.c Log Message: ----------- tests: port crypto enumeration API tests to new infrastructure Port api_knet_get_crypto_cipher_list.c and api_knet_get_crypto_hash_list.c to use start_logging/stop_logging pattern, _ts_knet_handle_start(), log_test(), TEST_EXIT(), and FAIL_ON_SUCCESS_NOCLEAN macro. Signed-off-by: Fabio M. Di Nitto <fabbione(a)kronosnet.org> Co-Authored-By: Claude Sonnet 4.5 <noreply(a)anthropic.com> Compare: https://github.com/kronosnet/kronosnet/compare/5b91abf4462f...9bbdf8fdf0ce To unsubscribe from these emails, change your notification settings at https://github.com/kronosnet/kronosnet/settings/notifications

1 0

[jenkins] update-all-ci-tools (build 506) completed with 0 failures
by jenkins＠kronosnet.org 18 May '26

18 May '26

Total runtime: 1 min 13 sec Split logs: https://ci.kronosnet.org/job/global/job/update-all-ci-tools/job/main/506/ar… Full log: https://ci.kronosnet.org/job/global/job/update-all-ci-tools/job/main/506/co…

1 0

[jenkins] kronosnet PR-471 (build 5) succeeded but with 2/86 non-voting fails
by jenkins＠kronosnet.org 17 May '26

17 May '26

Failed jobs: alpine-x86-64(nonvoting-clang: Build source) alpine-x86-64(nonvoting-clang_debug: Build source) Run reason: Pull request #471 updated Total runtime: 9 hr 23 min Split logs: https://ci.kronosnet.org/job/kronosnet/job/kronosnet-pipeline/job/PR-471/5/… Full log: https://ci.kronosnet.org/job/kronosnet/job/kronosnet-pipeline/job/PR-471/5/… Failed logs: https://ci.kronosnet.org/job/kronosnet/job/kronosnet-pipeline/job/PR-471/5/… https://ci.kronosnet.org/job/kronosnet/job/kronosnet-pipeline/job/PR-471/5/… Full Coverity results: http://ci.kronosnet.org/coverity/kronosnet/rhel-8-coverity-x86-64/pr471//5 http://ci.kronosnet.org/coverity/kronosnet/rhel-10-coverity-x86-64/pr471//5 http://ci.kronosnet.org/coverity/kronosnet/rhel-9-coverity-x86-64/pr471//5 Duplicate job killed: kronosnet/kronosnet-pipeline/PR-471 (4)

1 0

[jenkins] kronosnet stable1-proposed (build 233) succeeded but with 2/86 non-voting fails
by jenkins＠kronosnet.org 17 May '26

17 May '26

1 0

[jenkins] all-weekly (build 45) error
by jenkins＠kronosnet.org 17 May '26

17 May '26

Run reason: Started by timer Total runtime: 14 hr Full log: https://ci.kronosnet.org/job/global/job/all-weekly/45/consoleText

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Commits