Branch: refs/heads/libtap-fixes
Home: https://github.com/kronosnet/kronosnet
Commit: 743062f3b7ce38527867bdb1028c1876d208d33e
https://github.com/kronosnet/kronosnet/commit/743062f3b7ce38527867bdb1028c1…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libtap/libtap.c
Log Message:
-----------
[libtap] tests: allow random localhost IPs for testing
- avoids clashing with machine routing
- allows parallel testing
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 4980865a4fc5ae6687b7d345efed57b28795e824
https://github.com/kronosnet/kronosnet/commit/4980865a4fc5ae6687b7d345efed5…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libtap/libtap.c
Log Message:
-----------
[libtap] tests: add better IPv6 private address space randomization
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 9097f413ba3b5ed2cb713e348b19645e8a9d2832
https://github.com/kronosnet/kronosnet/commit/9097f413ba3b5ed2cb713e348b196…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M configure.ac
M libtap/libtap.c
Log Message:
-----------
[libtap] port to freebsd and fix a bunch of small bugs
- tap_open: do mutex lock only after malloc to avoid deadlock
- fix test suite to increase randomness when testing named tap devices
- remove hardcoded paths to /bin/true /bin/false and /bin/grep
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 58b51ee4dd599d9f5cdd373036415be8c54765ea
https://github.com/kronosnet/kronosnet/commit/58b51ee4dd599d9f5cdd373036415…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M README
Log Message:
-----------
[libtap] update README for BSD
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 19fbf074cfd2c59b1150bad29f2722549053050c
https://github.com/kronosnet/kronosnet/commit/19fbf074cfd2c59b1150bad29f272…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libtap/libtap.h
Log Message:
-----------
[libtap] define IFNAMSIZ for applications that don't need/want to include net/if.h
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 0eb6871a7d42722d7dd1c358f184dc2cffdce51d
https://github.com/kronosnet/kronosnet/commit/0eb6871a7d42722d7dd1c358f184d…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libtap/libtap.c
Log Message:
-----------
[libtap] BSD: switch to ioctl to destroy tap devices
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 71cd914104e3d76b23d63e8098226f37666b1c18
https://github.com/kronosnet/kronosnet/commit/71cd914104e3d76b23d63e8098226…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M Makefile.am
M NOTES_TO_PACKAGE_MAINTAINERS
M README
M configure.ac
M kronosnet.spec.in
M kronosnetd/Makefile.am
M kronosnetd/cfg.c
M kronosnetd/cfg.h
M kronosnetd/vty_cli_cmds.c
A libnozzle/Makefile.am
A libnozzle/api-test-coverage
A libnozzle/libnozzle.c
A libnozzle/libnozzle.h
A libnozzle/libnozzle.pc.in
A libnozzle/libnozzle_exported_syms
A libnozzle/tap_updown_bad/down.d/kronostest
A libnozzle/tap_updown_bad/post-down.d/kronostest
A libnozzle/tap_updown_bad/pre-up.d/kronostest
A libnozzle/tap_updown_bad/up.d/kronostest
A libnozzle/tap_updown_good/down.d/kronostest
A libnozzle/tap_updown_good/post-down.d/kronostest
A libnozzle/tap_updown_good/pre-up.d/kronostest
A libnozzle/tap_updown_good/up.d/kronostest
R libtap/Makefile.am
R libtap/api-test-coverage
R libtap/libtap.c
R libtap/libtap.h
R libtap/libtap.pc.in
R libtap/libtap_exported_syms
R libtap/tap_updown_bad/down.d/kronostest
R libtap/tap_updown_bad/post-down.d/kronostest
R libtap/tap_updown_bad/pre-up.d/kronostest
R libtap/tap_updown_bad/up.d/kronostest
R libtap/tap_updown_good/down.d/kronostest
R libtap/tap_updown_good/post-down.d/kronostest
R libtap/tap_updown_good/pre-up.d/kronostest
R libtap/tap_updown_good/up.d/kronostest
Log Message:
-----------
[libnozzle] rename libtap to libnozzle (part 1)
Our fearless Debian maintainer wferi made us aware that TAP is an overloaded
term already and it would be very confusing to add yet another one.
nozzle is a good pick from http://www.thesaurus.com/browse/tap
I am sure lib*cock* would have cause havoc :-)
This commit only rename files and allow builds. The API needs to be renamed too,
but that will come over time with major code cleanup as documented here:
https://trello.com/c/pyEKd4UH/396-libnozzle-make-it-production-ga-ready
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 23008b78879a7e60fc379af332249bb1bc7d2b5b
https://github.com/kronosnet/kronosnet/commit/23008b78879a7e60fc379af332249…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] add Doxygen header
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 44c6b8f8bd6086a1fb2d15cddc930dfdefc80863
https://github.com/kronosnet/kronosnet/commit/44c6b8f8bd6086a1fb2d15cddc930…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] include net/if.h to define IFNAMSIZ instead of redefine
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: ffe72bf255e688cbf3d2aaca36d651fbabe44189
https://github.com/kronosnet/kronosnet/commit/ffe72bf255e688cbf3d2aaca36d65…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] rename tap_t to nozzle_t
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 4638b27f1e38cd9eb554158d8fd1b1fa440d5033
https://github.com/kronosnet/kronosnet/commit/4638b27f1e38cd9eb554158d8fd1b…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] rename struct _iface to nozzle_iface (looks better on public headers)
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: f1f1f681c9316a1dd507154e20cbbe5d53eaf7b9
https://github.com/kronosnet/kronosnet/commit/f1f1f681c9316a1dd507154e20cbb…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libnozzle/libnozzle.pc.in
Log Message:
-----------
[nozzle] fix pkg-config to point to nozzle
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 52e4281281f81d96552ae6b3b1ec38886b587d48
https://github.com/kronosnet/kronosnet/commit/52e4281281f81d96552ae6b3b1ec3…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libnozzle/api-test-coverage
M libnozzle/libnozzle.c
M libnozzle/libnozzle.h
M libnozzle/libnozzle_exported_syms
Log Message:
-----------
[nozzle] rename API from tap_ to nozzle_
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: c81581950f261275c6228f0c237d43205d30e5ba
https://github.com/kronosnet/kronosnet/commit/c81581950f261275c6228f0c237d4…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] rename last tap bits to nozzle
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 5f781da80091dfc6603b0e40b0cde8b7be5131d1
https://github.com/kronosnet/kronosnet/commit/5f781da80091dfc6603b0e40b0cde…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] cleanup nozzle_open coding style and return codes
also update the header file for Doxygen man pages
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: f06a3e81d45144a9be47105015d8f76f2441c7dc
https://github.com/kronosnet/kronosnet/commit/f06a3e81d45144a9be47105015d8f…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] start to cleanup nozzle_close to be more informative and effective
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: a79fc15cd72f337c383dd952e5ff808f9a8f35da
https://github.com/kronosnet/kronosnet/commit/a79fc15cd72f337c383dd952e5ff8…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] cleanup and document nozzle_set_up
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: f675d81ae40397941204fc596fe5ea59506cb2cc
https://github.com/kronosnet/kronosnet/commit/f675d81ae40397941204fc596fe5e…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] cleanup and document nozzle_set_down
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 05705ee76605c4ec102b381772f35ec4f8e1b8da
https://github.com/kronosnet/kronosnet/commit/05705ee76605c4ec102b381772f35…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] re-order functions in order of importance
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 1c8526cf0560bd779a35b58c4a979f32395a6ac7
https://github.com/kronosnet/kronosnet/commit/1c8526cf0560bd779a35b58c4a979…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] cleanup and document nozzle_add_ip
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 2015b1ab6eeb36a1e906157463067a14c36acc4b
https://github.com/kronosnet/kronosnet/commit/2015b1ab6eeb36a1e906157463067…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] cleanup and document nozzle_del_ip
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 01b4c0a9f131de90c27678fa2bd79effd1575efd
https://github.com/kronosnet/kronosnet/commit/01b4c0a9f131de90c27678fa2bd79…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] cleanup and document nozzle_get_ips (part 1)
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 1a73ef36a9ef2520de9b91c9e29fa50241606b51
https://github.com/kronosnet/kronosnet/commit/1a73ef36a9ef2520de9b91c9e29fa…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
Log Message:
-----------
[nozzle] fix test on BSD
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 58e7eeedd61b74796bea3c663c6aa34c1cd17780
https://github.com/kronosnet/kronosnet/commit/58e7eeedd61b74796bea3c663c6aa…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] cleanup and document nozzle_get_mtu
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 6697d87df07da3d33d653926e687ed8583fd2ae9
https://github.com/kronosnet/kronosnet/commit/6697d87df07da3d33d653926e687e…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] cleanup and document nozzle_set_mtu and nozzle_reset_mtu
couldn't split those 2 because they are stricly related
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 4cb206826c678dd976bc1ba3735d506c77a848cb
https://github.com/kronosnet/kronosnet/commit/4cb206826c678dd976bc1ba3735d5…
Author: Christine Caulfield <ccaulfie(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libnozzle/libnozzle.h
Log Message:
-----------
Tidy some English
Commit: 3bc0705d5b7b4b413fcff4a58439f5843ea4e901
https://github.com/kronosnet/kronosnet/commit/3bc0705d5b7b4b413fcff4a58439f…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] cleanup and document nozzle_get_mac
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: f3b441dfdaebb7dc2ef4fd6224180830bfbec437
https://github.com/kronosnet/kronosnet/commit/f3b441dfdaebb7dc2ef4fd6224180…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] cleanup and document nozzle_(re)set_mac
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 56911b847f7ba5938cf326ed46e140a7fbabe015
https://github.com/kronosnet/kronosnet/commit/56911b847f7ba5938cf326ed46e14…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] cleanup and document nozzle_get_handle_by_name
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 1cd51434716a0a524c336ebc673fccde8f477b5a
https://github.com/kronosnet/kronosnet/commit/1cd51434716a0a524c336ebc673fc…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] cleanup and document nozzle_get_name_by_handle
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: f4f911d2632218bd4b5788c85e83c56a9c04fd14
https://github.com/kronosnet/kronosnet/commit/f4f911d2632218bd4b5788c85e83c…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] cleanup and document nozzle_get_fd
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 9f86e8e82caf6e72158fc774d8de42c6c724c576
https://github.com/kronosnet/kronosnet/commit/9f86e8e82caf6e72158fc774d8de4…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libknet/Makefile.am
Log Message:
-----------
[man] drop redundant update-man-page code
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 7605c5ce271c118508815c4dd4463dc8b9d060d5
https://github.com/kronosnet/kronosnet/commit/7605c5ce271c118508815c4dd4463…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libnozzle/Makefile.am
A libnozzle/internals.h
M libnozzle/libnozzle.c
Log Message:
-----------
[cleanup] start splitting the code across multiple files
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 90aa93b9a64cbfbddef6df3e5e944e18b98c4bef
https://github.com/kronosnet/kronosnet/commit/90aa93b9a64cbfbddef6df3e5e944…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libnozzle/internals.h
M libnozzle/libnozzle.c
Log Message:
-----------
[nozzle] rename _config to nozzle_lib_config
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 2b4689dfd36f90c5aa25f727895a166e97209aad
https://github.com/kronosnet/kronosnet/commit/2b4689dfd36f90c5aa25f727895a1…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libnozzle/internals.h
M libnozzle/libnozzle.c
Log Message:
-----------
[cleanup] rename struct _ip to struct nozzle_ip and cleanup related defines
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: f3a75fa4ef0fdbb8119d64c507711b3e87683281
https://github.com/kronosnet/kronosnet/commit/f3a75fa4ef0fdbb8119d64c507711…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libnozzle/internals.h
M libnozzle/libnozzle.c
Log Message:
-----------
[cleanup] rename sockfd to ioctlfd
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 53fba6441d515a3004445eadbd49cbf2ffc5066d
https://github.com/kronosnet/kronosnet/commit/53fba6441d515a3004445eadbd49c…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libnozzle/internals.h
M libnozzle/libnozzle.c
M libnozzle/libnozzle.h
Log Message:
-----------
[cleanup] rename ip_addr to ipaddr
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: b8b1671f18197d600218255e2d8b400261938e38
https://github.com/kronosnet/kronosnet/commit/b8b1671f18197d600218255e2d8b4…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libnozzle/internals.h
M libnozzle/libnozzle.c
Log Message:
-----------
[cleanup] document nozzle_iface struct, drop unnecessary ifr struct and cleanup names
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: a3ce35614da78a5ee2a8e192d067d3d220437884
https://github.com/kronosnet/kronosnet/commit/a3ce35614da78a5ee2a8e192d067d…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
Log Message:
-----------
[build] fix build on BSD
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: a23ab2b8c4e00db897546bdc6227407aed2f14b6
https://github.com/kronosnet/kronosnet/commit/a23ab2b8c4e00db897546bdc62274…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
Log Message:
-----------
[nozzle] rename lib_mutex to config_mutex
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: d3abb2bc93f2384547649fed349f970e82a2cab2
https://github.com/kronosnet/kronosnet/commit/d3abb2bc93f2384547649fed349f9…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M configure.ac
M libnozzle/Makefile.am
R libnozzle/api-test-coverage
A libnozzle/man/Doxyfile.in
A libnozzle/man/Makefile.am
R libnozzle/tap_updown_bad/down.d/kronostest
R libnozzle/tap_updown_bad/post-down.d/kronostest
R libnozzle/tap_updown_bad/pre-up.d/kronostest
R libnozzle/tap_updown_bad/up.d/kronostest
R libnozzle/tap_updown_good/down.d/kronostest
R libnozzle/tap_updown_good/post-down.d/kronostest
R libnozzle/tap_updown_good/pre-up.d/kronostest
R libnozzle/tap_updown_good/up.d/kronostest
A libnozzle/tests/Makefile.am
A libnozzle/tests/api-test-coverage
A libnozzle/tests/tap_updown_bad/down.d/kronostest
A libnozzle/tests/tap_updown_bad/post-down.d/kronostest
A libnozzle/tests/tap_updown_bad/pre-up.d/kronostest
A libnozzle/tests/tap_updown_bad/up.d/kronostest
A libnozzle/tests/tap_updown_good/down.d/kronostest
A libnozzle/tests/tap_updown_good/post-down.d/kronostest
A libnozzle/tests/tap_updown_good/pre-up.d/kronostest
A libnozzle/tests/tap_updown_good/up.d/kronostest
Log Message:
-----------
[build] split tests, man pages and build dirs
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 74830462332a245af9c31a73f8c3924eadaa3865
https://github.com/kronosnet/kronosnet/commit/74830462332a245af9c31a73f8c39…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libnozzle/Makefile.am
A libnozzle/internals.c
M libnozzle/internals.h
M libnozzle/libnozzle.c
M libnozzle/tests/Makefile.am
A libnozzle/tests/nozzle_test.c
Log Message:
-----------
[nozzle] split code around to separate libnozzle and testsuite
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 890246767b30e337f41c11fe85a8cbbb7c2b1a0b
https://github.com/kronosnet/kronosnet/commit/890246767b30e337f41c11fe85a8c…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libnozzle/internals.c
M libnozzle/internals.h
M libnozzle/libnozzle.c
M libnozzle/tests/nozzle_test.c
Log Message:
-----------
[nozzle] start cleaning internal function names
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Compare: https://github.com/kronosnet/kronosnet/compare/cd30cb14a92e...890246767b30
Branch: refs/heads/master
Home: https://github.com/kronosnet/kronosnet
Commit: 1dfc8220a3f090e5ca6f8b922c63ae64e09260d1
https://github.com/kronosnet/kronosnet/commit/1dfc8220a3f090e5ca6f8b922c63a…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libknet/handle.c
M libknet/host.c
M libknet/internals.h
M libknet/links.c
M libknet/logging.c
M libknet/tests/Makefile.am
M libknet/threads_common.c
M libknet/threads_common.h
M libknet/threads_dsthandler.c
M libknet/threads_pmtud.c
M libknet/transport_sctp.c
M libknet/transports.c
Log Message:
-----------
[PMTUd] fix external API and PMTUd interaction
The problem:
PMTUd can take a long time to release the global read lock, mostly due
to the pthread_cond_timedwait required to ack/nack packets from the
other hosts. This delay could block any wrlock operation for several seconds
if not more.
The solution:
each call to the global pthread_rwlock_wrlock has been changed to a wrapper
that will notify the PMTUd to interrupt its operations (and restart) first,
then get a global write lock that is queued as soon as PMTUd is going out.
This solution also improves a lot shutdown speed.
How to test:
This is not super simple to test and verify. I used 2 VMs with known MTU of
1500. Start knet_bench on both (normal ping_data -C is more than enough).
Once they have established data exchange, change the MTU on one of the nodes
to 1600 (or higher). This should guarantee that the PMTUd process will take
a very long time to complete.
First verify that the PMTUd process takes several seconds.
Once the next PMTUd run starts, hit ctrl+c on the node that is executing
the PMTUd and the process should exit much faster than before this patch.
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: f8465e758969e2d4d9b5ed4a486890499419fb09
https://github.com/kronosnet/kronosnet/commit/f8465e758969e2d4d9b5ed4a48689…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libknet/handle.c
M libknet/host.c
M libknet/internals.h
M libknet/links.c
M libknet/logging.c
M libknet/tests/Makefile.am
M libknet/threads_common.c
M libknet/threads_common.h
M libknet/threads_dsthandler.c
M libknet/threads_pmtud.c
M libknet/transport_sctp.c
M libknet/transports.c
Log Message:
-----------
Merge pull request #103 from kronosnet/mtu-lock
[PMTUd] fix external API and PMTUd interaction
Compare: https://github.com/kronosnet/kronosnet/compare/0915310bc3da...f8465e758969
Branch: refs/heads/libtap-fixes
Home: https://github.com/kronosnet/kronosnet
Commit: cd30cb14a92e679d35eb3e94f1882a0098b22b0f
https://github.com/kronosnet/kronosnet/commit/cd30cb14a92e679d35eb3e94f1882…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M libnozzle/internals.c
M libnozzle/internals.h
M libnozzle/libnozzle.c
M libnozzle/tests/nozzle_test.c
Log Message:
-----------
[nozzle] start cleaning internal function names
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Branch: refs/heads/skip
Home: https://github.com/kronosnet/kronosnet
Commit: 603f18d092ff0b957f85cb14a39d93667193ba20
https://github.com/kronosnet/kronosnet/commit/603f18d092ff0b957f85cb14a39d9…
Author: Ferenc Wágner <wferi(a)debian.org>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libknet/transport_common.c
Log Message:
-----------
Report ENAMETOOLONG if socket buffers are too small
Signed-off-by: Ferenc Wágner <wferi(a)debian.org>
Commit: 4c56ccb327e94adf7fdceff51a78ada4b3278bb5
https://github.com/kronosnet/kronosnet/commit/4c56ccb327e94adf7fdceff51a78a…
Author: Ferenc Wágner <wferi(a)debian.org>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libknet/tests/test-common.c
M libknet/tests/test-common.h
Log Message:
-----------
tests: introduce knet_handle_start helper
Signed-off-by: Ferenc Wágner <wferi(a)debian.org>
Commit: 0509c442c950da9550fdf14714cb8d518101c1ed
https://github.com/kronosnet/kronosnet/commit/0509c442c950da9550fdf14714cb8…
Author: Ferenc Wágner <wferi(a)debian.org>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libknet/tests/api_knet_handle_add_datafd.c
M libknet/tests/api_knet_handle_clear_stats.c
M libknet/tests/api_knet_handle_compress.c
M libknet/tests/api_knet_handle_crypto.c
M libknet/tests/api_knet_handle_enable_filter.c
M libknet/tests/api_knet_handle_enable_pmtud_notify.c
M libknet/tests/api_knet_handle_enable_sock_notify.c
M libknet/tests/api_knet_handle_free.c
M libknet/tests/api_knet_handle_get_channel.c
M libknet/tests/api_knet_handle_get_datafd.c
M libknet/tests/api_knet_handle_get_stats.c
M libknet/tests/api_knet_handle_get_transport_reconnect_interval.c
M libknet/tests/api_knet_handle_new.c
M libknet/tests/api_knet_handle_pmtud_get.c
M libknet/tests/api_knet_handle_pmtud_getfreq.c
M libknet/tests/api_knet_handle_pmtud_setfreq.c
M libknet/tests/api_knet_handle_remove_datafd.c
M libknet/tests/api_knet_handle_set_transport_reconnect_interval.c
M libknet/tests/api_knet_handle_setfwd.c
M libknet/tests/api_knet_host_add.c
M libknet/tests/api_knet_host_enable_status_change_notify.c
M libknet/tests/api_knet_host_get_host_list.c
M libknet/tests/api_knet_host_get_id_by_host_name.c
M libknet/tests/api_knet_host_get_name_by_host_id.c
M libknet/tests/api_knet_host_get_policy.c
M libknet/tests/api_knet_host_get_status.c
M libknet/tests/api_knet_host_remove.c
M libknet/tests/api_knet_host_set_name.c
M libknet/tests/api_knet_host_set_policy.c
M libknet/tests/api_knet_link_clear_config.c
M libknet/tests/api_knet_link_get_config.c
M libknet/tests/api_knet_link_get_enable.c
M libknet/tests/api_knet_link_get_link_list.c
M libknet/tests/api_knet_link_get_ping_timers.c
M libknet/tests/api_knet_link_get_pong_count.c
M libknet/tests/api_knet_link_get_priority.c
M libknet/tests/api_knet_link_get_status.c
M libknet/tests/api_knet_link_set_config.c
M libknet/tests/api_knet_link_set_enable.c
M libknet/tests/api_knet_link_set_ping_timers.c
M libknet/tests/api_knet_link_set_pong_count.c
M libknet/tests/api_knet_link_set_priority.c
M libknet/tests/api_knet_log_get_loglevel.c
M libknet/tests/api_knet_log_set_loglevel.c
M libknet/tests/api_knet_recv.c
M libknet/tests/api_knet_send.c
M libknet/tests/api_knet_send_compress.c
M libknet/tests/api_knet_send_crypto.c
M libknet/tests/api_knet_send_loopback.c
M libknet/tests/api_knet_send_sync.c
Log Message:
-----------
tests: replace open coded error handling with knet_handle_start() calls
Done by:
$ sed -i -e '1h;2,$H;$!d;g' -e 's/knet_h = knet_handle_new(1, logfds\[1\], \(KNET_LOG_[A-Z]*\));\n\n\tif (!knet_h) {\n\t\tprintf("knet_handle_new failed: %s\\n", strerror(errno));\n\t\tflush_logs(logfds\[0\], stdout);\n\t\tclose_logpipes(logfds);\n\t\texit(FAIL);\n\t}/knet_h = knet_handle_start(logfds, \1);/g' libknet/tests/*.c
Signed-off-by: Ferenc Wágner <wferi(a)debian.org>
Commit: ccc9b19e051d9bf4c59ca33c9c2fa4050e53c3ec
https://github.com/kronosnet/kronosnet/commit/ccc9b19e051d9bf4c59ca33c9c2fa…
Author: Ferenc Wágner <wferi(a)debian.org>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libknet/tests/api_knet_handle_new.c
M libknet/tests/test-common.c
Log Message:
-----------
tests: skip if socket buffers are too small
Signed-off-by: Ferenc Wágner <wferi(a)debian.org>
Compare: https://github.com/kronosnet/kronosnet/compare/88dda6d2c0a3...ccc9b19e051d
Branch: refs/heads/libtap-fixes
Home: https://github.com/kronosnet/kronosnet
Commit: 81d114b0dc28be78cb6d0d6100e445f791e6baf2
https://github.com/kronosnet/kronosnet/commit/81d114b0dc28be78cb6d0d6100e44…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libtap/libtap.c
Log Message:
-----------
[libtap] tests: allow random localhost IPs for testing
- avoids clashing with machine routing
- allows parallel testing
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: eca57d1bcd78cf0aa85e87c09b3125147e75cc97
https://github.com/kronosnet/kronosnet/commit/eca57d1bcd78cf0aa85e87c09b312…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libtap/libtap.c
Log Message:
-----------
[libtap] tests: add better IPv6 private address space randomization
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: c2bb5db9a1faf825c7efe6c325e6bed71c6aef82
https://github.com/kronosnet/kronosnet/commit/c2bb5db9a1faf825c7efe6c325e6b…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M configure.ac
M libtap/libtap.c
Log Message:
-----------
[libtap] port to freebsd and fix a bunch of small bugs
- tap_open: do mutex lock only after malloc to avoid deadlock
- fix test suite to increase randomness when testing named tap devices
- remove hardcoded paths to /bin/true /bin/false and /bin/grep
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 75f397afb366207b1f69457bec1f426a9a794a8b
https://github.com/kronosnet/kronosnet/commit/75f397afb366207b1f69457bec1f4…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M README
Log Message:
-----------
[libtap] update README for BSD
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 54f829f60cbfe24a67ae47f5b88af98a57680c65
https://github.com/kronosnet/kronosnet/commit/54f829f60cbfe24a67ae47f5b88af…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libtap/libtap.h
Log Message:
-----------
[libtap] define IFNAMSIZ for applications that don't need/want to include net/if.h
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 393aad265a6f321ee710ea0cb83fd23c000f7d33
https://github.com/kronosnet/kronosnet/commit/393aad265a6f321ee710ea0cb83fd…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libtap/libtap.c
Log Message:
-----------
[libtap] BSD: switch to ioctl to destroy tap devices
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 4de302c61ee264ee495f9c41b947661312a90d36
https://github.com/kronosnet/kronosnet/commit/4de302c61ee264ee495f9c41b9476…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M Makefile.am
M NOTES_TO_PACKAGE_MAINTAINERS
M README
M configure.ac
M kronosnet.spec.in
M kronosnetd/Makefile.am
M kronosnetd/cfg.c
M kronosnetd/cfg.h
M kronosnetd/vty_cli_cmds.c
A libnozzle/Makefile.am
A libnozzle/api-test-coverage
A libnozzle/libnozzle.c
A libnozzle/libnozzle.h
A libnozzle/libnozzle.pc.in
A libnozzle/libnozzle_exported_syms
A libnozzle/tap_updown_bad/down.d/kronostest
A libnozzle/tap_updown_bad/post-down.d/kronostest
A libnozzle/tap_updown_bad/pre-up.d/kronostest
A libnozzle/tap_updown_bad/up.d/kronostest
A libnozzle/tap_updown_good/down.d/kronostest
A libnozzle/tap_updown_good/post-down.d/kronostest
A libnozzle/tap_updown_good/pre-up.d/kronostest
A libnozzle/tap_updown_good/up.d/kronostest
R libtap/Makefile.am
R libtap/api-test-coverage
R libtap/libtap.c
R libtap/libtap.h
R libtap/libtap.pc.in
R libtap/libtap_exported_syms
R libtap/tap_updown_bad/down.d/kronostest
R libtap/tap_updown_bad/post-down.d/kronostest
R libtap/tap_updown_bad/pre-up.d/kronostest
R libtap/tap_updown_bad/up.d/kronostest
R libtap/tap_updown_good/down.d/kronostest
R libtap/tap_updown_good/post-down.d/kronostest
R libtap/tap_updown_good/pre-up.d/kronostest
R libtap/tap_updown_good/up.d/kronostest
Log Message:
-----------
[libnozzle] rename libtap to libnozzle (part 1)
Our fearless Debian maintainer wferi made us aware that TAP is an overloaded
term already and it would be very confusing to add yet another one.
nozzle is a good pick from http://www.thesaurus.com/browse/tap
I am sure lib*cock* would have cause havoc :-)
This commit only rename files and allow builds. The API needs to be renamed too,
but that will come over time with major code cleanup as documented here:
https://trello.com/c/pyEKd4UH/396-libnozzle-make-it-production-ga-ready
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 3ef4e59cbcacef95cb71d849a3331db940b0e06d
https://github.com/kronosnet/kronosnet/commit/3ef4e59cbcacef95cb71d849a3331…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] add Doxygen header
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 7bf9d9d39785cbaf1b020e3f1b99d851a7545309
https://github.com/kronosnet/kronosnet/commit/7bf9d9d39785cbaf1b020e3f1b99d…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] include net/if.h to define IFNAMSIZ instead of redefine
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 3d4925b75250d317afaa8606415b4f69c11597cc
https://github.com/kronosnet/kronosnet/commit/3d4925b75250d317afaa8606415b4…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] rename tap_t to nozzle_t
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 5bb767acad2a574b94406fd095c9bfe71599d5a6
https://github.com/kronosnet/kronosnet/commit/5bb767acad2a574b94406fd095c9b…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] rename struct _iface to nozzle_iface (looks better on public headers)
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: d2f1031ab5ee7a82254c08864a93d9c8b8ffc0db
https://github.com/kronosnet/kronosnet/commit/d2f1031ab5ee7a82254c08864a93d…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libnozzle/libnozzle.pc.in
Log Message:
-----------
[nozzle] fix pkg-config to point to nozzle
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: ee1ad2857c185322758ac61c7da2641c293fb6d3
https://github.com/kronosnet/kronosnet/commit/ee1ad2857c185322758ac61c7da26…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libnozzle/api-test-coverage
M libnozzle/libnozzle.c
M libnozzle/libnozzle.h
M libnozzle/libnozzle_exported_syms
Log Message:
-----------
[nozzle] rename API from tap_ to nozzle_
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 08894fa78d649169d7c68c9d7f4523c1e5e83f57
https://github.com/kronosnet/kronosnet/commit/08894fa78d649169d7c68c9d7f452…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] rename last tap bits to nozzle
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 5d01353139e798bdc9d3218360b7d2e2681646b6
https://github.com/kronosnet/kronosnet/commit/5d01353139e798bdc9d3218360b7d…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] cleanup nozzle_open coding style and return codes
also update the header file for Doxygen man pages
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 5010f90bdf185e4141e88e108f51d360da2b971f
https://github.com/kronosnet/kronosnet/commit/5010f90bdf185e4141e88e108f51d…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] start to cleanup nozzle_close to be more informative and effective
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 91fca98bc3909c8a7e63945504238b4c92c92ae2
https://github.com/kronosnet/kronosnet/commit/91fca98bc3909c8a7e63945504238…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] cleanup and document nozzle_set_up
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 3e6844086598390ceb5dca4a5997e54efe848fc6
https://github.com/kronosnet/kronosnet/commit/3e6844086598390ceb5dca4a5997e…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] cleanup and document nozzle_set_down
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 38120eacaec9d5d4bb58451d58cfcffcb1393aed
https://github.com/kronosnet/kronosnet/commit/38120eacaec9d5d4bb58451d58cfc…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] re-order functions in order of importance
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 455519f537a58d14f63e948c504c65c95ba4a1ed
https://github.com/kronosnet/kronosnet/commit/455519f537a58d14f63e948c504c6…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] cleanup and document nozzle_add_ip
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 2f827894d5973357d641969bd06ffbda26e9343b
https://github.com/kronosnet/kronosnet/commit/2f827894d5973357d641969bd06ff…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] cleanup and document nozzle_del_ip
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: c57a0328a670faf2be83cf26804da3905a759e16
https://github.com/kronosnet/kronosnet/commit/c57a0328a670faf2be83cf26804da…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] cleanup and document nozzle_get_ips (part 1)
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 664025e36213dc25be6cc55df4397a12e3627a68
https://github.com/kronosnet/kronosnet/commit/664025e36213dc25be6cc55df4397…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
Log Message:
-----------
[nozzle] fix test on BSD
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: fa54f1b336f261ad387b906b4d69639ee352e34c
https://github.com/kronosnet/kronosnet/commit/fa54f1b336f261ad387b906b4d696…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] cleanup and document nozzle_get_mtu
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 5f8d49fcd7a9d9a64c153341d5509901cccfd6c4
https://github.com/kronosnet/kronosnet/commit/5f8d49fcd7a9d9a64c153341d5509…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] cleanup and document nozzle_set_mtu and nozzle_reset_mtu
couldn't split those 2 because they are stricly related
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 1dd4bfdad22c8ec2809959fa5362af1625b9bf03
https://github.com/kronosnet/kronosnet/commit/1dd4bfdad22c8ec2809959fa5362a…
Author: Christine Caulfield <ccaulfie(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libnozzle/libnozzle.h
Log Message:
-----------
Tidy some English
Commit: f8ffeb8d6df5a445b21b439c7eced9a93a601639
https://github.com/kronosnet/kronosnet/commit/f8ffeb8d6df5a445b21b439c7eced…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] cleanup and document nozzle_get_mac
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: a934dc4ef6c14322f2e250638c1276fb02f47ffe
https://github.com/kronosnet/kronosnet/commit/a934dc4ef6c14322f2e250638c127…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] cleanup and document nozzle_(re)set_mac
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: be14eb86c8688a184758a7c6a616161d4c44eeb7
https://github.com/kronosnet/kronosnet/commit/be14eb86c8688a184758a7c6a6161…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] cleanup and document nozzle_get_handle_by_name
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 8229c472e8d471045e3fddf1449bd7a5f5bfb0fd
https://github.com/kronosnet/kronosnet/commit/8229c472e8d471045e3fddf1449bd…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] cleanup and document nozzle_get_name_by_handle
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 2fc112feaaeebee5cff71176e75af7645a7d50c4
https://github.com/kronosnet/kronosnet/commit/2fc112feaaeebee5cff71176e75af…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
M libnozzle/libnozzle.h
Log Message:
-----------
[nozzle] cleanup and document nozzle_get_fd
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 751a78efefa07a1147ccf878a1e50f9f79896e21
https://github.com/kronosnet/kronosnet/commit/751a78efefa07a1147ccf878a1e50…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libknet/Makefile.am
Log Message:
-----------
[man] drop redundant update-man-page code
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 612cb5770778ed14a1a440e963ec80f5631221b0
https://github.com/kronosnet/kronosnet/commit/612cb5770778ed14a1a440e963ec8…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libnozzle/Makefile.am
A libnozzle/internals.h
M libnozzle/libnozzle.c
Log Message:
-----------
[cleanup] start splitting the code across multiple files
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: bdeea2780b9c112ddfca3e23ee6a26db27d8a992
https://github.com/kronosnet/kronosnet/commit/bdeea2780b9c112ddfca3e23ee6a2…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libnozzle/internals.h
M libnozzle/libnozzle.c
Log Message:
-----------
[nozzle] rename _config to nozzle_lib_config
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: ad20c357f940f81b868258ed67a027d46e3d1e11
https://github.com/kronosnet/kronosnet/commit/ad20c357f940f81b868258ed67a02…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libnozzle/internals.h
M libnozzle/libnozzle.c
Log Message:
-----------
[cleanup] rename struct _ip to struct nozzle_ip and cleanup related defines
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 0f169760710c25458d58b4c0418c12add4f36aff
https://github.com/kronosnet/kronosnet/commit/0f169760710c25458d58b4c0418c1…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libnozzle/internals.h
M libnozzle/libnozzle.c
Log Message:
-----------
[cleanup] rename sockfd to ioctlfd
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: abaa80836033cafe2d3173851200bb7333461f48
https://github.com/kronosnet/kronosnet/commit/abaa80836033cafe2d3173851200b…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libnozzle/internals.h
M libnozzle/libnozzle.c
M libnozzle/libnozzle.h
Log Message:
-----------
[cleanup] rename ip_addr to ipaddr
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 08ef8d306599081618f352d384662c4d535aa6ff
https://github.com/kronosnet/kronosnet/commit/08ef8d306599081618f352d384662…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libnozzle/internals.h
M libnozzle/libnozzle.c
Log Message:
-----------
[cleanup] document nozzle_iface struct, drop unnecessary ifr struct and cleanup names
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 2f5936069f226d5996b272cc98505f4a438799e7
https://github.com/kronosnet/kronosnet/commit/2f5936069f226d5996b272cc98505…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
Log Message:
-----------
[build] fix build on BSD
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: ed773a58bfe403112e6b64fc056d02f6e6774700
https://github.com/kronosnet/kronosnet/commit/ed773a58bfe403112e6b64fc056d0…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libnozzle/libnozzle.c
Log Message:
-----------
[nozzle] rename lib_mutex to config_mutex
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: 3b2f22d0142831826383540d9390ac834f8c81ca
https://github.com/kronosnet/kronosnet/commit/3b2f22d0142831826383540d9390a…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M configure.ac
M libnozzle/Makefile.am
R libnozzle/api-test-coverage
A libnozzle/man/Doxyfile.in
A libnozzle/man/Makefile.am
R libnozzle/tap_updown_bad/down.d/kronostest
R libnozzle/tap_updown_bad/post-down.d/kronostest
R libnozzle/tap_updown_bad/pre-up.d/kronostest
R libnozzle/tap_updown_bad/up.d/kronostest
R libnozzle/tap_updown_good/down.d/kronostest
R libnozzle/tap_updown_good/post-down.d/kronostest
R libnozzle/tap_updown_good/pre-up.d/kronostest
R libnozzle/tap_updown_good/up.d/kronostest
A libnozzle/tests/Makefile.am
A libnozzle/tests/api-test-coverage
A libnozzle/tests/tap_updown_bad/down.d/kronostest
A libnozzle/tests/tap_updown_bad/post-down.d/kronostest
A libnozzle/tests/tap_updown_bad/pre-up.d/kronostest
A libnozzle/tests/tap_updown_bad/up.d/kronostest
A libnozzle/tests/tap_updown_good/down.d/kronostest
A libnozzle/tests/tap_updown_good/post-down.d/kronostest
A libnozzle/tests/tap_updown_good/pre-up.d/kronostest
A libnozzle/tests/tap_updown_good/up.d/kronostest
Log Message:
-----------
[build] split tests, man pages and build dirs
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Commit: ff17851e03fa5c5ce57c9a015aaede69b5488ae2
https://github.com/kronosnet/kronosnet/commit/ff17851e03fa5c5ce57c9a015aaed…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libnozzle/Makefile.am
A libnozzle/internals.c
M libnozzle/internals.h
M libnozzle/libnozzle.c
M libnozzle/tests/Makefile.am
A libnozzle/tests/nozzle_test.c
Log Message:
-----------
[nozzle] split code around to separate libnozzle and testsuite
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Compare: https://github.com/kronosnet/kronosnet/compare/7c06942f0fcc...ff17851e03fa
Branch: refs/heads/mtu-lock
Home: https://github.com/kronosnet/kronosnet
Commit: 1dfc8220a3f090e5ca6f8b922c63ae64e09260d1
https://github.com/kronosnet/kronosnet/commit/1dfc8220a3f090e5ca6f8b922c63a…
Author: Fabio M. Di Nitto <fdinitto(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M libknet/handle.c
M libknet/host.c
M libknet/internals.h
M libknet/links.c
M libknet/logging.c
M libknet/tests/Makefile.am
M libknet/threads_common.c
M libknet/threads_common.h
M libknet/threads_dsthandler.c
M libknet/threads_pmtud.c
M libknet/transport_sctp.c
M libknet/transports.c
Log Message:
-----------
[PMTUd] fix external API and PMTUd interaction
The problem:
PMTUd can take a long time to release the global read lock, mostly due
to the pthread_cond_timedwait required to ack/nack packets from the
other hosts. This delay could block any wrlock operation for several seconds
if not more.
The solution:
each call to the global pthread_rwlock_wrlock has been changed to a wrapper
that will notify the PMTUd to interrupt its operations (and restart) first,
then get a global write lock that is queued as soon as PMTUd is going out.
This solution also improves a lot shutdown speed.
How to test:
This is not super simple to test and verify. I used 2 VMs with known MTU of
1500. Start knet_bench on both (normal ping_data -C is more than enough).
Once they have established data exchange, change the MTU on one of the nodes
to 1600 (or higher). This should guarantee that the PMTUd process will take
a very long time to complete.
First verify that the PMTUd process takes several seconds.
Once the next PMTUd run starts, hit ctrl+c on the node that is executing
the PMTUd and the process should exit much faster than before this patch.
Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>