Commits September 2023

commits@lists.kronosnet.org

2 participants
931 discussions

[kronosnet/kronosnet] 887d23: links: fix ping interval and pong timeout value ch...

by Fabio M. Di Nitto

Branch: refs/heads/fast-link-up Home: https://github.com/kronosnet/kronosnet Commit: 887d238fdb98f7dbe9a0f508124d1e226a32dc94 https://github.com/kronosnet/kronosnet/commit/887d238fdb98f7dbe9a0f508124d1… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2023-09-25 (Mon, 25 Sep 2023) Changed paths: M libknet/links.c M libknet/tests/api_knet_link_set_ping_timers.c Log Message: ----------- links: fix ping interval and pong timeout value checking warn if ping interval is lower than thread timer resolution as it has no effects error if ping timeout is lower than thread timer resolution as it causes links to be highly unstable Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: e0de10070c6832c8203c5ec1e28c18a3c21347fc https://github.com/kronosnet/kronosnet/commit/e0de10070c6832c8203c5ec1e28c1… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2023-09-25 (Mon, 25 Sep 2023) Changed paths: M libknet/threads_rx.c Log Message: ----------- rx: allow links to be active faster scenario: node A and node B node A completes ping/pong link up process faster than B node A starts to send data to node B old behavior: node B would unconditionally discard data packets new behavior: node B will check internal link status to see if ping/pong link up process is in progress. if the link is sending pings and receiving pongs, it´s safe to assume that the link will go up (since we are also receiving data from the node A). node B will speed up link up and accept data immediately. This should address a overall init race condition when nodes startup are slighly off by enough milliseconds to cause 2 memeberships to form and see fencing fireworks. Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: c72d42e43ece4bbfe389bd622874681da087643e https://github.com/kronosnet/kronosnet/commit/c72d42e43ece4bbfe389bd6228746… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2023-09-25 (Mon, 25 Sep 2023) Changed paths: M libknet/tests/api_knet_handle_set_threads_timer_res.c M libknet/threads_common.c Log Message: ----------- threads: add config check to match min value with pong timeouts avoid network instability and dump full report of nodes/links that would have caused problems Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Compare: https://github.com/kronosnet/kronosnet/compare/03e36e80b2a3...c72d42e43ece

1 year, 2 months