Commits September 2023

commits@lists.kronosnet.org

2 participants
931 discussions

[kronosnet/kronosnet] 8e295d: links: fix conversion

by Fabio M. Di Nitto

Branch: refs/heads/fix-i686-build Home: https://github.com/kronosnet/kronosnet Commit: 8e295dddb7a3d256a156a136d56d2b2a35c79e22 https://github.com/kronosnet/kronosnet/commit/8e295dddb7a3d256a156a136d56d2… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2023-09-26 (Tue, 26 Sep 2023) Changed paths: M libknet/links.c Log Message: ----------- links: fix conversion Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>

1 year, 2 months

[jenkins] kronosnet stable1 (build 18) success

by jenkins＠kronosnet.org

total runtime: 24 min Coverity results: http://ci.kronosnet.org/coverity/kronosnet/rhel9-coverity-x86-64/origin/sta… Split logs: https://ci.kronosnet.org/job/kronosnet/job/kronosnet-pipeline/job/stable1/1… Full log: https://ci.kronosnet.org/job/kronosnet/job/kronosnet-pipeline/job/stable1/1…

1 year, 2 months

[kronosnet/kronosnet] f5d6e6: Merge pull request #413 from kronosnet/stable1-pro...

by Fabio M. Di Nitto

Branch: refs/heads/stable1-proposed Home: https://github.com/kronosnet/kronosnet Commit: f5d6e66a950d103559212f33759b245ca59e7805 https://github.com/kronosnet/kronosnet/commit/f5d6e66a950d103559212f33759b2… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2023-09-26 (Tue, 26 Sep 2023) Changed paths: M libknet/crypto.c M libknet/links.c M libknet/tests/api_knet_link_set_ping_timers.c M libknet/threads_rx.c M libnozzle/tests/test-common.c Log Message: ----------- Merge pull request #413 from kronosnet/stable1-proposed stable1 proposed

1 year, 2 months

[kronosnet/kronosnet]

by Fabio M. Di Nitto

Branch: refs/tags/v1.27 Home: https://github.com/kronosnet/kronosnet

1 year, 2 months

[kronosnet/kronosnet] 49ef95: [crypto] Try crypt and decrypt on crypto_init

by Fabio M. Di Nitto

Branch: refs/heads/stable1 Home: https://github.com/kronosnet/kronosnet Commit: 49ef95aea3bb5a223ec12c2e33e855c8948c0204 https://github.com/kronosnet/kronosnet/commit/49ef95aea3bb5a223ec12c2e33e85… Author: Jan Friesse <jfriesse(a)redhat.com> Date: 2023-08-14 (Mon, 14 Aug 2023) Changed paths: M libknet/crypto.c Log Message: ----------- [crypto] Try crypt and decrypt on crypto_init Crypt (or decrypt) operation might fail in some cases even when initialization succeeded. This problem is known to happen when FIPS mode is enabled and combination of openssl/aes192 and md5 is used. This was not caught during crypto_init so knet user (corosync) was not aware of non-working crypto so it couldn't handle it - and couldn't send/receive any packets. Solution is to try crypt, decrypt and compare of result buffer right after new crypto_instance is created. If any of these operation fails, whole crypto_init fails, crypto_instance is freed and knet user is notified by receiving non-zero return code. Signed-off-by: Jan Friesse <jfriesse(a)redhat.com> Commit: cae7cafa5f0301df53eb8510638531b5d2932b5f https://github.com/kronosnet/kronosnet/commit/cae7cafa5f0301df53eb851063853… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2023-09-18 (Mon, 18 Sep 2023) Changed paths: M libnozzle/tests/test-common.c Log Message: ----------- nozzle: don´t leak tun/tap interfaces in test suite the need_tun() test check to verify that the kernel module for tun/tap is loaded, was opening a generic /dev/tun (or /dev/tap) to verify the presence of the kernel module. On linux, closing the fd to the tap/tun device is enough to destroy the device. On BSD the device is set to DOWN on closing the fd, but it´s not destroyed. Stop leaking by gathering ifr ioctl info from the generic interface created by BSD and pass it to the ioctlfd to destroy. Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: fa63b127bac3c6169407dd0d4d15ba2f0d503ba5 https://github.com/kronosnet/kronosnet/commit/fa63b127bac3c6169407dd0d4d15b… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2023-09-25 (Mon, 25 Sep 2023) Changed paths: M libknet/links.c M libknet/tests/api_knet_link_set_ping_timers.c Log Message: ----------- links: fix ping interval and pong timeout value checking warn if ping interval is lower than thread timer resolution as it has no effects error if ping timeout is lower than thread timer resolution as it causes links to be highly unstable Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: cb96e3aa85799b6b2c74a645af6cc7e494f7f811 https://github.com/kronosnet/kronosnet/commit/cb96e3aa85799b6b2c74a645af6cc… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2023-09-25 (Mon, 25 Sep 2023) Changed paths: M libknet/threads_rx.c Log Message: ----------- rx: allow links to be active faster scenario: node A and node B node A completes ping/pong link up process faster than B node A starts to send data to node B old behavior: node B would unconditionally discard data packets new behavior: node B will check internal link status to see if ping/pong link up process is in progress. if the link is sending pings and receiving pongs, it´s safe to assume that the link will go up (since we are also receiving data from the node A). node B will speed up link up and accept data immediately. This should address a overall init race condition when nodes startup are slighly off by enough milliseconds to cause 2 memeberships to form and see fencing fireworks. Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: f5d6e66a950d103559212f33759b245ca59e7805 https://github.com/kronosnet/kronosnet/commit/f5d6e66a950d103559212f33759b2… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2023-09-26 (Tue, 26 Sep 2023) Changed paths: M libknet/crypto.c M libknet/links.c M libknet/tests/api_knet_link_set_ping_timers.c M libknet/threads_rx.c M libnozzle/tests/test-common.c Log Message: ----------- Merge pull request #413 from kronosnet/stable1-proposed stable1 proposed Compare: https://github.com/kronosnet/kronosnet/compare/a40c3549012f...f5d6e66a950d

1 year, 2 months