Commits October 2019

commits@lists.kronosnet.org

2 participants
174 discussions

[kronosnet/kronosnet] 7c470f: Merge pull request #263 from kronosnet/runtime-debug

by Fabio M. Di Nitto

Branch: refs/heads/coverity_scan Home: https://github.com/kronosnet/kronosnet Commit: 7c470fe6fe90d7a523ca0bfc238ed89e0948f940 https://github.com/kronosnet/kronosnet/commit/7c470fe6fe90d7a523ca0bfc238ed… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-09 (Wed, 09 Oct 2019) Changed paths: M configure.ac M man/Makefile.am Log Message: ----------- Merge pull request #263 from kronosnet/runtime-debug [build] add --with-sanitizers= option for sanitizer builds Commit: a081ff7fab6bb98f9ff2a88b1593776b0c27b6f1 https://github.com/kronosnet/kronosnet/commit/a081ff7fab6bb98f9ff2a88b15937… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-15 (Tue, 15 Oct 2019) Changed paths: M libknet/host.c Log Message: ----------- [host] rename variables to make it easier to read the code Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 1338058fa634b08eee7099c0614e8076267501ff https://github.com/kronosnet/kronosnet/commit/1338058fa634b08eee7099c0614e8… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-15 (Tue, 15 Oct 2019) Changed paths: M libknet/host.c Log Message: ----------- [host] fix defrag buffers reclaim logic The problem: - let's assume a 2 nodes (A and B) cluster setup - node A sends fragmented packets to node B and there is packet loss on the network. - node B receives all those fragments and attempts to reassemble them. - node A sends packet seq_num X in Y fragments. - node B receives only part of the fragments and stores them in a defrag buf. - packet loss stops. - node A continues to send packets and a seq_num roll-over takes place. - node A sends a new packet seq_num X in Y fragments. - node B gets confused here because the parts of the old packet seq_num X are still stored and the buffer has not been reclaimed. - node B continues to rebuild packet seq_num X with old stale data and new data from after the roll-over. - node B completes reassembling the packet and delivers junk to the application. The solution: Add a much stronger buffer reclaim logic that will apply on each received packet and not only when defrag buffers are needed, as there might be a mix of fragmented and not fragmented packets in-flight. The new logic creates a window of N packets that can be handled at the same time (based on the number of buffers) and clear everything else. Fixes https://github.com/kronosnet/kronosnet/issues/261 Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: aeaffc89bb71a2ab4e5b1f5cce49a20e3c0872e3 https://github.com/kronosnet/kronosnet/commit/aeaffc89bb71a2ab4e5b1f5cce49a… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-15 (Tue, 15 Oct 2019) Changed paths: M libknet/threads_rx.c Log Message: ----------- [rx] copy data into the defrag buffer only if we know the size of the frame Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 3ed7293c027cc0c5940dabd19f859bf22f00efae https://github.com/kronosnet/kronosnet/commit/3ed7293c027cc0c5940dabd19f859… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-15 (Tue, 15 Oct 2019) Changed paths: M libknet/tests/knet_bench.c Log Message: ----------- [test] add ability to knet_bench to specify a fixed packet size for perf test Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Compare: https://github.com/kronosnet/kronosnet/compare/38e40998ec6b...3ed7293c027c

5 years, 2 months

[kronosnet/kronosnet] a081ff: [host] rename variables to make it easier to read ...

by Fabio M. Di Nitto

Branch: refs/heads/netload-fixes Home: https://github.com/kronosnet/kronosnet Commit: a081ff7fab6bb98f9ff2a88b1593776b0c27b6f1 https://github.com/kronosnet/kronosnet/commit/a081ff7fab6bb98f9ff2a88b15937… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-15 (Tue, 15 Oct 2019) Changed paths: M libknet/host.c Log Message: ----------- [host] rename variables to make it easier to read the code Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 1338058fa634b08eee7099c0614e8076267501ff https://github.com/kronosnet/kronosnet/commit/1338058fa634b08eee7099c0614e8… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-15 (Tue, 15 Oct 2019) Changed paths: M libknet/host.c Log Message: ----------- [host] fix defrag buffers reclaim logic The problem: - let's assume a 2 nodes (A and B) cluster setup - node A sends fragmented packets to node B and there is packet loss on the network. - node B receives all those fragments and attempts to reassemble them. - node A sends packet seq_num X in Y fragments. - node B receives only part of the fragments and stores them in a defrag buf. - packet loss stops. - node A continues to send packets and a seq_num roll-over takes place. - node A sends a new packet seq_num X in Y fragments. - node B gets confused here because the parts of the old packet seq_num X are still stored and the buffer has not been reclaimed. - node B continues to rebuild packet seq_num X with old stale data and new data from after the roll-over. - node B completes reassembling the packet and delivers junk to the application. The solution: Add a much stronger buffer reclaim logic that will apply on each received packet and not only when defrag buffers are needed, as there might be a mix of fragmented and not fragmented packets in-flight. The new logic creates a window of N packets that can be handled at the same time (based on the number of buffers) and clear everything else. Fixes https://github.com/kronosnet/kronosnet/issues/261 Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: aeaffc89bb71a2ab4e5b1f5cce49a20e3c0872e3 https://github.com/kronosnet/kronosnet/commit/aeaffc89bb71a2ab4e5b1f5cce49a… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-15 (Tue, 15 Oct 2019) Changed paths: M libknet/threads_rx.c Log Message: ----------- [rx] copy data into the defrag buffer only if we know the size of the frame Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 3ed7293c027cc0c5940dabd19f859bf22f00efae https://github.com/kronosnet/kronosnet/commit/3ed7293c027cc0c5940dabd19f859… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-15 (Tue, 15 Oct 2019) Changed paths: M libknet/tests/knet_bench.c Log Message: ----------- [test] add ability to knet_bench to specify a fixed packet size for perf test Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Compare: https://github.com/kronosnet/kronosnet/compare/31a539284f66...3ed7293c027c

5 years, 2 months

[kronosnet/kronosnet] 31a539: [test] add ability to knet_bench to specify a fixe...

by Fabio M. Di Nitto

Branch: refs/heads/netload-fixes Home: https://github.com/kronosnet/kronosnet Commit: 31a539284f66d6e620bef39c0c9961a195921c7a https://github.com/kronosnet/kronosnet/commit/31a539284f66d6e620bef39c0c996… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-15 (Tue, 15 Oct 2019) Changed paths: M libknet/tests/knet_bench.c Log Message: ----------- [test] add ability to knet_bench to specify a fixed packet size for perf test Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>

5 years, 2 months

[kronosnet/kronosnet] 89213e: Merge pull request #257 from kronosnet/netload-fixes

by Fabio M. Di Nitto

Branch: refs/heads/netload-fixes Home: https://github.com/kronosnet/kronosnet Commit: 89213e429ef7eb8241606313b99ff413afdb8662 https://github.com/kronosnet/kronosnet/commit/89213e429ef7eb8241606313b99ff… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-09-19 (Thu, 19 Sep 2019) Changed paths: M libknet/links.c Log Message: ----------- Merge pull request #257 from kronosnet/netload-fixes [links] fix memory corryption of link structure Commit: eba47802dc84f096b0dca3c6963baa1d94bed6a2 https://github.com/kronosnet/kronosnet/commit/eba47802dc84f096b0dca3c6963ba… Author: Ferenc Wágner <wferi(a)debian.org> Date: 2019-09-25 (Wed, 25 Sep 2019) Changed paths: M libknet/tests/api_knet_send.c Log Message: ----------- tests: skip the SCTP test if SCTP is not supported by the kernel For example, module loading is disabled on Debian build daemons. (In the vein of c5aa1c3343703455b480cef5c173f471e1bb020f.) Signed-off-by: Ferenc Wágner <wferi(a)debian.org> Commit: 1c5d845851028e8e423095dab5a2d87c8eff1437 https://github.com/kronosnet/kronosnet/commit/1c5d845851028e8e423095dab5a2d… Author: Ferenc Wágner <wferi(a)debian.org> Date: 2019-09-25 (Wed, 25 Sep 2019) Changed paths: M libknet/transport_sctp.c Log Message: ----------- Fix typo: trasport -> transport Signed-off-by: Ferenc Wágner <wferi(a)debian.org> Commit: 9f10144d0274c89423d8422ef826a02459e602d8 https://github.com/kronosnet/kronosnet/commit/9f10144d0274c89423d8422ef826a… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-09-25 (Wed, 25 Sep 2019) Changed paths: M libknet/tests/api_knet_send.c M libknet/transport_sctp.c Log Message: ----------- Merge pull request #258 from kronosnet/wferi/fixes Assorted small fixups Commit: 728ca4fb953992be7100a33c5720496ae5fef5c1 https://github.com/kronosnet/kronosnet/commit/728ca4fb953992be7100a33c57204… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-09-26 (Thu, 26 Sep 2019) Changed paths: M libknet/tests/api_knet_handle_pmtud_set.c M libknet/tests/api_knet_link_set_enable.c M libknet/tests/test-common.c M libknet/tests/test-common.h Log Message: ----------- [tests] add common function to sleep based on how the test suite is running Address issue while waiting for host to be up and PMTUd first run. Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: a0128b93d4a6b5637cbc5885a0a64e333d93a414 https://github.com/kronosnet/kronosnet/commit/a0128b93d4a6b5637cbc5885a0a64… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-09-26 (Thu, 26 Sep 2019) Changed paths: M libknet/tests/api_knet_handle_pmtud_set.c M libknet/tests/api_knet_link_set_enable.c M libknet/tests/test-common.c M libknet/tests/test-common.h Log Message: ----------- Merge pull request #260 from kronosnet/test-suite [tests] add common function to sleep based on how the test suite is r… Commit: f2bb002911d669f1b8c07cba5f86c580d4e30bf3 https://github.com/kronosnet/kronosnet/commit/f2bb002911d669f1b8c07cba5f86c… Author: Thomas Lamprecht <t.lamprecht(a)proxmox.com> Date: 2019-10-08 (Tue, 08 Oct 2019) Changed paths: M man/doxyxml.c Log Message: ----------- doxyxml: print_param: fix heap-buffer-overflow on read in read_struct we can get the pi->paramtype assigned with: > pi->paramtype = type?strdup(type):strdup(""); And in print_param we then always check the last character by getting the strlen and subtracting one. But in the case where either type was NULL and we assigned an empty string, or type wasn't null but pointing to an empty string we ran into an read-heap-buffer-overflow as here strlen is zero, and so we the first if branch evaluated to > if (pi->paramtype[-1] == '*') { which isn't valid. Depending on the OS, protection of surrounding area due to said OS or the compiler, this can crash the program. Similar issue was the case for the next check for double pointers, here for all strings with strlen < 2. To solve this get the strlen early and check if we cannot underflow before doing the real read. Signed-off-by: Thomas Lamprecht <t.lamprecht(a)proxmox.com> Commit: f2f1fe9162ca82d45187ab0b26009207932686f0 https://github.com/kronosnet/kronosnet/commit/f2f1fe9162ca82d45187ab0b26009… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-09 (Wed, 09 Oct 2019) Changed paths: M man/doxyxml.c Log Message: ----------- Merge pull request #262 from ThomasLamprecht/fix-doxyxml-overflow doxyxml: print_param: fix heap-buffer-overflow on read Commit: 38e40998ec6b843218251a2b56cb056d5b9fbc6e https://github.com/kronosnet/kronosnet/commit/38e40998ec6b843218251a2b56cb0… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-09 (Wed, 09 Oct 2019) Changed paths: M configure.ac M man/Makefile.am Log Message: ----------- [build] add --with-sanitizers= option for sanitizer builds this option is stricly meant for runtime debugging purposes. do NOT use in production. check gcc/clang man pages on how to use ASAN/UBSAN/TSAN. Also allow users to specificy SANITIZERS_CFLAGS and SANITIZERS_LDFLAGS for advanced use. Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com> Commit: 7c470fe6fe90d7a523ca0bfc238ed89e0948f940 https://github.com/kronosnet/kronosnet/commit/7c470fe6fe90d7a523ca0bfc238ed… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-09 (Wed, 09 Oct 2019) Changed paths: M configure.ac M man/Makefile.am Log Message: ----------- Merge pull request #263 from kronosnet/runtime-debug [build] add --with-sanitizers= option for sanitizer builds Compare: https://github.com/kronosnet/kronosnet/compare/93f3df56ce10...7c470fe6fe90

5 years, 2 months

[kronosnet/kronosnet] b60fd2: [DEBUG] DO NOT MERGE: reclaim buffer on each lookup

by Fabio M. Di Nitto

Branch: refs/heads/memory-corrupt-debug Home: https://github.com/kronosnet/kronosnet Commit: b60fd29c75f8eb60a3f52832447ddc632d7fe83e https://github.com/kronosnet/kronosnet/commit/b60fd29c75f8eb60a3f52832447dd… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-15 (Tue, 15 Oct 2019) Changed paths: M libknet/host.c Log Message: ----------- [DEBUG] DO NOT MERGE: reclaim buffer on each lookup Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>

5 years, 2 months

[kronosnet/kronosnet] ad71d9: [DEBUG] DO NOT MERGE: fix reclaim logic to be more...

by Fabio M. Di Nitto

Branch: refs/heads/memory-corrupt-debug Home: https://github.com/kronosnet/kronosnet Commit: ad71d9d001044212e5d8fcb4acb12fe1ef2d507c https://github.com/kronosnet/kronosnet/commit/ad71d9d001044212e5d8fcb4acb12… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-15 (Tue, 15 Oct 2019) Changed paths: M libknet/host.c Log Message: ----------- [DEBUG] DO NOT MERGE: fix reclaim logic to be more aggressive Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>

5 years, 2 months

pacemaker-build-all-voting - Build # 1764 - Failure!

by jenkins＠kronosnet.org

pacemaker-build-all-voting - Build # 1764 - Failure: Check console output at https://ci.kronosnet.org/job/pacemaker-build-all-voting/1764/ to view the results.

5 years, 2 months

pacemaker1-build-all-voting - Build # 232 - Failure!

by jenkins＠kronosnet.org

pacemaker1-build-all-voting - Build # 232 - Failure: Check console output at https://ci.kronosnet.org/job/pacemaker1-build-all-voting/232/ to view the results.

5 years, 2 months

[kronosnet/kronosnet] 37913b: [DEBUG] DO NOT MERGE: more debug info

by Fabio M. Di Nitto

Branch: refs/heads/memory-corrupt-debug Home: https://github.com/kronosnet/kronosnet Commit: 37913bc5811c58f38e6e1f4e127db6006b9834f3 https://github.com/kronosnet/kronosnet/commit/37913bc5811c58f38e6e1f4e127db… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-14 (Mon, 14 Oct 2019) Changed paths: M libknet/threads_rx.c Log Message: ----------- [DEBUG] DO NOT MERGE: more debug info Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>

5 years, 2 months

[kronosnet/kronosnet] 370120: [DEBUG] DO NOT MERGE: tune reclaim

by Fabio M. Di Nitto

Branch: refs/heads/memory-corrupt-debug Home: https://github.com/kronosnet/kronosnet Commit: 3701204eeaa53ea53a37688579e4b36f47b4d5db https://github.com/kronosnet/kronosnet/commit/3701204eeaa53ea53a37688579e4b… Author: Fabio M. Di Nitto <fdinitto(a)redhat.com> Date: 2019-10-14 (Mon, 14 Oct 2019) Changed paths: M libknet/host.c Log Message: ----------- [DEBUG] DO NOT MERGE: tune reclaim Signed-off-by: Fabio M. Di Nitto <fdinitto(a)redhat.com>

5 years, 2 months

← Newer
1
...
10
11
12
13
14
15
16
17
18
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Commits October 2019