[fabbione/kronosnet] 735329: libtap: don't close pipe fd twice - Commits

21 Apr 2015

  Branch: refs/heads/master
  Home:   https://github.com/fabbione/kronosnet
  Commit: 7353292b0b81bc8bd485e1aea913a6ae9f1db780

https://github.com/fabbione/kronosnet/commit/7353292b0b81bc8bd485e1aea913a6…
  Author: Christine Caulfield &lt;ccaulfie(a)redhat.com&gt;
  Date:   2015-04-21 (Tue, 21 Apr 2015)

  Changed paths:
    M libtap/libtap.c

  Log Message:
  -----------
  libtap: don't close pipe fd twice

libtap was closing the parent's pipe() fd twice. Sometimes, between the
first and second close, that fd gets reopened by the logging thread as
PF_LOCAL, and used for logging.

Then libtap wakes up again after the fork and closes the fd thinking
it's its pipe fd. knet then opens it again as AF_INET for pinging.

libqb logging then errors on a sendto() and closes it AGAIN, and reopens
it as a PF_LOCAL logging fd. Ping then has a brain haemorrage next time
it comes round to calling sendto().

Signed-off-by: Christine Caulfield &lt;ccaulfie(a)redhat.com&gt;